[igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Dhinakaran Pandiyan]

We do not have PSR panels on shards machines, so this is the only way to
test PSR in CI.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index aa861d39..e262d024 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
 igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
 igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
 igt@kms_psr@basic
+igt@kms_psr@no_drrs
+igt@kms_psr@primary_page_flip
+igt@kms_psr@primary_mmap_gtt
+igt@kms_psr@primary_mmap_cpu
+igt@kms_psr@primary_blt
+igt@kms_psr@primary_render
+igt@kms_psr@sprite_mmap_gtt
+igt@kms_psr@sprite_mmap_cpu
+igt@kms_psr@sprite_blt
+igt@kms_psr@sprite_render
+igt@kms_psr@sprite_plane_move
+igt@kms_psr@sprite_plane_onoff
+igt@kms_psr@cursor_mmap_gtt
+igt@kms_psr@cursor_mmap_cpu
+igt@kms_psr@cursor_blt
+igt@kms_psr@cursor_render
+igt@kms_psr@cursor_plane_move
+igt@kms_psr@cursor_plane_onoff
+igt@kms_psr@dpms
+igt@kms_psr@suspend
 igt@kms_setmode@basic-clone-single-crtc
 igt@kms_sink_crc_basic
 igt@pm_backlight@basic-brightness
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/psr: Add PSR tests to fast-feedback list.

[Patchwork]

== Series Details ==

Series: tests/psr: Add PSR tests to fast-feedback list.
URL   : https://patchwork.freedesktop.org/series/46520/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4488 -> IGTPW_1586 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46520/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1586 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_chamelium@hdmi-hpd-fast:
      fi-kbl-7500u:       FAIL (fdo#102672, fdo#103841) -> SKIP

    
  fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841


== Participating hosts (46 -> 42) ==

  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4557 -> IGTPW_1586

  CI_DRM_4488: a3a527faf129e7901fdff5309a7e6df8abd72d13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1586: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1586/
  IGT_4557: 140a67c13aad2595ee6c72e41d14d35a793158b5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1586/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Rodrigo Vivi]

On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan wrote:
> We do not have PSR panels on shards machines, so this is the only way to
> test PSR in CI.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

fingers-crossing-acked-by: me ;)

but let's wait for CI results

> ---
>  tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index aa861d39..e262d024 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
>  igt@kms_psr@basic
> +igt@kms_psr@no_drrs
> +igt@kms_psr@primary_page_flip
> +igt@kms_psr@primary_mmap_gtt
> +igt@kms_psr@primary_mmap_cpu
> +igt@kms_psr@primary_blt
> +igt@kms_psr@primary_render
> +igt@kms_psr@sprite_mmap_gtt
> +igt@kms_psr@sprite_mmap_cpu
> +igt@kms_psr@sprite_blt
> +igt@kms_psr@sprite_render
> +igt@kms_psr@sprite_plane_move
> +igt@kms_psr@sprite_plane_onoff
> +igt@kms_psr@cursor_mmap_gtt
> +igt@kms_psr@cursor_mmap_cpu
> +igt@kms_psr@cursor_blt
> +igt@kms_psr@cursor_render
> +igt@kms_psr@cursor_plane_move
> +igt@kms_psr@cursor_plane_onoff
> +igt@kms_psr@dpms
> +igt@kms_psr@suspend
>  igt@kms_setmode@basic-clone-single-crtc
>  igt@kms_sink_crc_basic
>  igt@pm_backlight@basic-brightness
> -- 
> 2.17.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for tests/psr: Add PSR tests to fast-feedback list.

[Patchwork]

== Series Details ==

Series: tests/psr: Add PSR tests to fast-feedback list.
URL   : https://patchwork.freedesktop.org/series/46520/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4557_full -> IGTPW_1586_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1586_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1586_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46520/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1586_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_module_reload@basic-reload:
      shard-kbl:          PASS -> DMESG-WARN

    
    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-dirty-render:
      shard-kbl:          PASS -> SKIP

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1586_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_wait@invalid-buf:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411)

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105189)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-hsw:          PASS -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    {igt@gem_userptr_blits@readonly-mmap-unsync}:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4557 -> IGTPW_1586
    * Linux: CI_DRM_4487 -> CI_DRM_4488

  CI_DRM_4487: 627ed020cac6a73f0a014537dac7191efbb57084 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4488: a3a527faf129e7901fdff5309a7e6df8abd72d13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1586: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1586/
  IGT_4557: 140a67c13aad2595ee6c72e41d14d35a793158b5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1586/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Dhinakaran Pandiyan]

On Friday, July 13, 2018 5:28:59 PM PDT Rodrigo Vivi wrote:
> On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan wrote:
> > We do not have PSR panels on shards machines, so this is the only way to
> > test PSR in CI.
> > 
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> 
> fingers-crossing-acked-by: me ;)
> 
> but let's wait for CI results
> 
All the tests added to fastfeedback have passed. There is an unrelated failure 
in the full run, let's see what the rerun says.

-DK

> > ---
> > 
> >  tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/tests/intel-ci/fast-feedback.testlist
> > b/tests/intel-ci/fast-feedback.testlist index aa861d39..e262d024 100644
> > --- a/tests/intel-ci/fast-feedback.testlist
> > +++ b/tests/intel-ci/fast-feedback.testlist
> > @@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
> > 
> >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
> >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
> >  igt@kms_psr@basic
> > 
> > +igt@kms_psr@no_drrs
> > +igt@kms_psr@primary_page_flip
> > +igt@kms_psr@primary_mmap_gtt
> > +igt@kms_psr@primary_mmap_cpu
> > +igt@kms_psr@primary_blt
> > +igt@kms_psr@primary_render
> > +igt@kms_psr@sprite_mmap_gtt
> > +igt@kms_psr@sprite_mmap_cpu
> > +igt@kms_psr@sprite_blt
> > +igt@kms_psr@sprite_render
> > +igt@kms_psr@sprite_plane_move
> > +igt@kms_psr@sprite_plane_onoff
> > +igt@kms_psr@cursor_mmap_gtt
> > +igt@kms_psr@cursor_mmap_cpu
> > +igt@kms_psr@cursor_blt
> > +igt@kms_psr@cursor_render
> > +igt@kms_psr@cursor_plane_move
> > +igt@kms_psr@cursor_plane_onoff
> > +igt@kms_psr@dpms
> > +igt@kms_psr@suspend
> > 
> >  igt@kms_setmode@basic-clone-single-crtc
> >  igt@kms_sink_crc_basic
> >  igt@pm_backlight@basic-brightness
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev




_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/psr: Add PSR tests to fast-feedback list.

[Patchwork]

== Series Details ==

Series: tests/psr: Add PSR tests to fast-feedback list.
URL   : https://patchwork.freedesktop.org/series/46520/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4488 -> IGTPW_1588 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46520/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1588 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_chamelium@hdmi-hpd-fast:
      fi-kbl-7500u:       FAIL (fdo#102672, fdo#103841) -> SKIP

    
    ==== Warnings ====

    igt@gem_exec_suspend@basic-s4-devices:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#107139) -> DMESG-WARN (fdo#107222, fdo#107139)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
  fdo#107222 https://bugs.freedesktop.org/show_bug.cgi?id=107222


== Participating hosts (46 -> 42) ==

  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4557 -> IGTPW_1588

  CI_DRM_4488: a3a527faf129e7901fdff5309a7e6df8abd72d13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1588: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/
  IGT_4557: 140a67c13aad2595ee6c72e41d14d35a793158b5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/psr: Add PSR tests to fast-feedback list.

[Patchwork]

== Series Details ==

Series: tests/psr: Add PSR tests to fast-feedback list.
URL   : https://patchwork.freedesktop.org/series/46520/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4557_full -> IGTPW_1588_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1588_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1588_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46520/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1588_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1588_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    {igt@gem_userptr_blits@readonly-pwrite-unsync}:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-hsw:          PASS -> FAIL (fdo#102887)

    igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
      shard-glk:          PASS -> FAIL (fdo#103928)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@kms_vblank@pipe-c-accuracy-idle:
      shard-glk:          PASS -> FAIL (fdo#102583)

    
    ==== Possible fixes ====

    {igt@gem_userptr_blits@readonly-mmap-unsync}:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@testdisplay:
      shard-glk:          INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4557 -> IGTPW_1588
    * Linux: CI_DRM_4487 -> CI_DRM_4488

  CI_DRM_4487: 627ed020cac6a73f0a014537dac7191efbb57084 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4488: a3a527faf129e7901fdff5309a7e6df8abd72d13 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1588: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/
  IGT_4557: 140a67c13aad2595ee6c72e41d14d35a793158b5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Rodrigo Vivi]

On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan wrote:
> We do not have PSR panels on shards machines, so this is the only way to
> test PSR in CI.

We definitely need this...
but we need to ckeck the overall time and ff limits here as well...

ditto on the kms_frontbuffer_tracking one...

> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index aa861d39..e262d024 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
>  igt@kms_psr@basic
> +igt@kms_psr@no_drrs
> +igt@kms_psr@primary_page_flip
> +igt@kms_psr@primary_mmap_gtt
> +igt@kms_psr@primary_mmap_cpu
> +igt@kms_psr@primary_blt
> +igt@kms_psr@primary_render
> +igt@kms_psr@sprite_mmap_gtt
> +igt@kms_psr@sprite_mmap_cpu
> +igt@kms_psr@sprite_blt
> +igt@kms_psr@sprite_render
> +igt@kms_psr@sprite_plane_move
> +igt@kms_psr@sprite_plane_onoff
> +igt@kms_psr@cursor_mmap_gtt
> +igt@kms_psr@cursor_mmap_cpu
> +igt@kms_psr@cursor_blt
> +igt@kms_psr@cursor_render
> +igt@kms_psr@cursor_plane_move
> +igt@kms_psr@cursor_plane_onoff
> +igt@kms_psr@dpms
> +igt@kms_psr@suspend
>  igt@kms_setmode@basic-clone-single-crtc
>  igt@kms_sink_crc_basic
>  igt@pm_backlight@basic-brightness
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Dhinakaran Pandiyan]

On Mon, 2018-07-16 at 10:43 -0700, Rodrigo Vivi wrote:
> On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan wrote:
> > 
> > We do not have PSR panels on shards machines, so this is the only
> > way to
> > test PSR in CI.
> We definitely need this...
> but we need to ckeck the overall time and ff limits here as well...

 From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runt
imes0.log
 19.46 igt@kms_psr@suspend pass
  4.78 igt@kms_psr@dpms pass
  3.37 igt@kms_psr@sprite_blt pass
  3.35 igt@kms_psr@sprite_plane_onoff pass
  3.35 igt@kms_psr@sprite_plane_move pass
  3.35 igt@kms_psr@sprite_mmap_gtt pass
  3.35 igt@kms_psr@sprite_mmap_cpu pass
  3.34 igt@kms_psr@sprite_render pass
  3.34 igt@kms_psr@primary_render pass
  3.34 igt@kms_psr@primary_page_flip pass
  3.33 igt@kms_psr@primary_mmap_cpu pass
  3.31 igt@kms_psr@primary_mmap_gtt pass
  3.31 igt@kms_psr@primary_blt pass
  3.29 igt@kms_psr@cursor_render pass
  3.29 igt@kms_psr@cursor_plane_onoff pass
  3.29 igt@kms_psr@cursor_plane_move pass
  3.29 igt@kms_psr@cursor_mmap_gtt pass
  3.29 igt@kms_psr@cursor_mmap_cpu pass
  3.29 igt@kms_psr@cursor_blt pass
  3.14 igt@kms_psr@basic pass
  3.11 igt@kms_psr@no_drrs pass

Each test is under the 30s limit and kms_psr@suspend is the only that
gets closer to the limit.

Without kms_psr subtests 730.18s TOTAL
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4488/fi-kbl-r/runtimes0
.log
With kms_psr subtests 626.50s TOTAL
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runtimes0.
log

> ditto on the kms_frontbuffer_tracking one...

From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-whl-u/runti
mes0.log

  7.38 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwri
te pass
  6.23 igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack pass
  5.79 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap
-cpu pass
  5.71 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
-cpu pass
  5.69 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt
pass
  5.53 igt@kms_frontbuffer_tracking@psr-farfromfence pass
  5.51 igt@kms_frontbuffer_tracking@fbcpsr-farfromfence pass
  5.48 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-m
map-wc pass
5.20 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-g
tt pass
  5.19 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
-wc pass
  5.18 igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt pass
  5.18 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
-gtt pass
  5.16 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-m
map-gtt pass
  5.14 igt@gem_sync@basic-each pass
  5.10 igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt pass
  5.08 igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt pass
  4.96 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap
-gtt pass
  4.74 igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap
-gtt pass
  4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-m
map-gtt pass
  4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-m
map-gtt pass
  4.72 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
-gtt pass
  4.62 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-m
map-gtt skip
  4.61 igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack skip
  4.58 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-m
map-gtt skip
  4.57 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-r
ender skip
  3.63 igt@kms_frontbuffer_tracking@fbcpsr-stridechange skip

Same here, all are under the individual test limit.

I am not sure what the overall time limit is, this is what I see - 
Without PSR frontbuffer 742.12s
(https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4498/fi-skl-6600u/runt
imes0.log)
With PSR frontbuffer tests 693.63s
(https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-skl-6600u/runti
mes0.log)

Looks like there are others tests with a larger variance negating the
impact of new PSR tests.

-DK

> 
> > 
> > 
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> >  tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > ci/fast-feedback.testlist
> > index aa861d39..e262d024 100644
> > --- a/tests/intel-ci/fast-feedback.testlist
> > +++ b/tests/intel-ci/fast-feedback.testlist
> > @@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
> >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
> >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
> >  igt@kms_psr@basic
> > +igt@kms_psr@no_drrs
> > +igt@kms_psr@primary_page_flip
> > +igt@kms_psr@primary_mmap_gtt
> > +igt@kms_psr@primary_mmap_cpu
> > +igt@kms_psr@primary_blt
> > +igt@kms_psr@primary_render
> > +igt@kms_psr@sprite_mmap_gtt
> > +igt@kms_psr@sprite_mmap_cpu
> > +igt@kms_psr@sprite_blt
> > +igt@kms_psr@sprite_render
> > +igt@kms_psr@sprite_plane_move
> > +igt@kms_psr@sprite_plane_onoff
> > +igt@kms_psr@cursor_mmap_gtt
> > +igt@kms_psr@cursor_mmap_cpu
> > +igt@kms_psr@cursor_blt
> > +igt@kms_psr@cursor_render
> > +igt@kms_psr@cursor_plane_move
> > +igt@kms_psr@cursor_plane_onoff
> > +igt@kms_psr@dpms
> > +igt@kms_psr@suspend
> >  igt@kms_setmode@basic-clone-single-crtc
> >  igt@kms_sink_crc_basic
> >  igt@pm_backlight@basic-brightness
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Rodrigo Vivi]

On Mon, Jul 16, 2018 at 11:29:48AM -0700, Dhinakaran Pandiyan wrote:
> On Mon, 2018-07-16 at 10:43 -0700, Rodrigo Vivi wrote:
> > On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan wrote:
> > > 
> > > We do not have PSR panels on shards machines, so this is the only
> > > way to
> > > test PSR in CI.
> > We definitely need this...
> > but we need to ckeck the overall time and ff limits here as well...
> 
>  From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runt
> imes0.log
>  19.46 igt@kms_psr@suspend pass
>   4.78 igt@kms_psr@dpms pass
>   3.37 igt@kms_psr@sprite_blt pass
>   3.35 igt@kms_psr@sprite_plane_onoff pass
>   3.35 igt@kms_psr@sprite_plane_move pass
>   3.35 igt@kms_psr@sprite_mmap_gtt pass
>   3.35 igt@kms_psr@sprite_mmap_cpu pass
>   3.34 igt@kms_psr@sprite_render pass
>   3.34 igt@kms_psr@primary_render pass
>   3.34 igt@kms_psr@primary_page_flip pass
>   3.33 igt@kms_psr@primary_mmap_cpu pass
>   3.31 igt@kms_psr@primary_mmap_gtt pass
>   3.31 igt@kms_psr@primary_blt pass
>   3.29 igt@kms_psr@cursor_render pass
>   3.29 igt@kms_psr@cursor_plane_onoff pass
>   3.29 igt@kms_psr@cursor_plane_move pass
>   3.29 igt@kms_psr@cursor_mmap_gtt pass
>   3.29 igt@kms_psr@cursor_mmap_cpu pass
>   3.29 igt@kms_psr@cursor_blt pass
>   3.14 igt@kms_psr@basic pass
>   3.11 igt@kms_psr@no_drrs pass
> 
> Each test is under the 30s limit and kms_psr@suspend is the only that
> gets closer to the limit.
> 
> Without kms_psr subtests 730.18s TOTAL
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4488/fi-kbl-r/runtimes0
> .log
> With kms_psr subtests 626.50s TOTAL
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runtimes0.
> log
> 
> > ditto on the kms_frontbuffer_tracking one...
> 
> From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-whl-u/runti
> mes0.log
> 
>   7.38 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwri
> te pass
>   6.23 igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack pass
>   5.79 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap
> -cpu pass
>   5.71 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
> -cpu pass
>   5.69 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt
> pass
>   5.53 igt@kms_frontbuffer_tracking@psr-farfromfence pass
>   5.51 igt@kms_frontbuffer_tracking@fbcpsr-farfromfence pass
>   5.48 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-m
> map-wc pass
> 5.20 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-g
> tt pass
>   5.19 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
> -wc pass
>   5.18 igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt pass
>   5.18 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
> -gtt pass
>   5.16 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-m
> map-gtt pass
>   5.14 igt@gem_sync@basic-each pass
>   5.10 igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt pass
>   5.08 igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt pass
>   4.96 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap
> -gtt pass
>   4.74 igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap
> -gtt pass
>   4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-m
> map-gtt pass
>   4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-m
> map-gtt pass
>   4.72 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
> -gtt pass
>   4.62 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-m
> map-gtt skip
>   4.61 igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack skip
>   4.58 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-m
> map-gtt skip
>   4.57 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-r
> ender skip
>   3.63 igt@kms_frontbuffer_tracking@fbcpsr-stridechange skip
> 
> Same here, all are under the individual test limit.

both changes

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

unless CI folks nack it ;)

> 
> I am not sure what the overall time limit is, this is what I see - 
> Without PSR frontbuffer 742.12s
> (https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4498/fi-skl-6600u/runt
> imes0.log)
> With PSR frontbuffer tests 693.63s
> (https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-skl-6600u/runti
> mes0.log)
> 
> Looks like there are others tests with a larger variance negating the
> impact of new PSR tests.
> 
> -DK
> 
> > 
> > > 
> > > 
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: Petri Latvala <petri.latvala@intel.com>
> > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > ---
> > >  tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > > ci/fast-feedback.testlist
> > > index aa861d39..e262d024 100644
> > > --- a/tests/intel-ci/fast-feedback.testlist
> > > +++ b/tests/intel-ci/fast-feedback.testlist
> > > @@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
> > >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
> > >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
> > >  igt@kms_psr@basic
> > > +igt@kms_psr@no_drrs
> > > +igt@kms_psr@primary_page_flip
> > > +igt@kms_psr@primary_mmap_gtt
> > > +igt@kms_psr@primary_mmap_cpu
> > > +igt@kms_psr@primary_blt
> > > +igt@kms_psr@primary_render
> > > +igt@kms_psr@sprite_mmap_gtt
> > > +igt@kms_psr@sprite_mmap_cpu
> > > +igt@kms_psr@sprite_blt
> > > +igt@kms_psr@sprite_render
> > > +igt@kms_psr@sprite_plane_move
> > > +igt@kms_psr@sprite_plane_onoff
> > > +igt@kms_psr@cursor_mmap_gtt
> > > +igt@kms_psr@cursor_mmap_cpu
> > > +igt@kms_psr@cursor_blt
> > > +igt@kms_psr@cursor_render
> > > +igt@kms_psr@cursor_plane_move
> > > +igt@kms_psr@cursor_plane_onoff
> > > +igt@kms_psr@dpms
> > > +igt@kms_psr@suspend
> > >  igt@kms_setmode@basic-clone-single-crtc
> > >  igt@kms_sink_crc_basic
> > >  igt@pm_backlight@basic-brightness
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Martin Peres]

On 17/07/18 08:13, Rodrigo Vivi wrote:
> On Mon, Jul 16, 2018 at 11:29:48AM -0700, Dhinakaran Pandiyan wrote:
>> On Mon, 2018-07-16 at 10:43 -0700, Rodrigo Vivi wrote:
>>> On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan wrote:
>>>>
>>>> We do not have PSR panels on shards machines, so this is the only
>>>> way to
>>>> test PSR in CI.
>>> We definitely need this...
>>> but we need to ckeck the overall time and ff limits here as well...
>>
>>  From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runt
>> imes0.log
>>  19.46 igt@kms_psr@suspend pass
>>   4.78 igt@kms_psr@dpms pass
>>   3.37 igt@kms_psr@sprite_blt pass
>>   3.35 igt@kms_psr@sprite_plane_onoff pass
>>   3.35 igt@kms_psr@sprite_plane_move pass
>>   3.35 igt@kms_psr@sprite_mmap_gtt pass
>>   3.35 igt@kms_psr@sprite_mmap_cpu pass
>>   3.34 igt@kms_psr@sprite_render pass
>>   3.34 igt@kms_psr@primary_render pass
>>   3.34 igt@kms_psr@primary_page_flip pass
>>   3.33 igt@kms_psr@primary_mmap_cpu pass
>>   3.31 igt@kms_psr@primary_mmap_gtt pass
>>   3.31 igt@kms_psr@primary_blt pass
>>   3.29 igt@kms_psr@cursor_render pass
>>   3.29 igt@kms_psr@cursor_plane_onoff pass
>>   3.29 igt@kms_psr@cursor_plane_move pass
>>   3.29 igt@kms_psr@cursor_mmap_gtt pass
>>   3.29 igt@kms_psr@cursor_mmap_cpu pass
>>   3.29 igt@kms_psr@cursor_blt pass
>>   3.14 igt@kms_psr@basic pass
>>   3.11 igt@kms_psr@no_drrs pass
>>
>> Each test is under the 30s limit and kms_psr@suspend is the only that
>> gets closer to the limit.
>>
>> Without kms_psr subtests 730.18s TOTAL
>> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4488/fi-kbl-r/runtimes0
>> .log
>> With kms_psr subtests 626.50s TOTAL
>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runtimes0.
>> log
>>
>>> ditto on the kms_frontbuffer_tracking one...
>>
>> From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-whl-u/runti
>> mes0.log
>>
>>   7.38 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwri
>> te pass
>>   6.23 igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack pass
>>   5.79 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap
>> -cpu pass
>>   5.71 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
>> -cpu pass
>>   5.69 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt
>> pass
>>   5.53 igt@kms_frontbuffer_tracking@psr-farfromfence pass
>>   5.51 igt@kms_frontbuffer_tracking@fbcpsr-farfromfence pass
>>   5.48 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-m
>> map-wc pass
>> 5.20 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-g
>> tt pass
>>   5.19 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
>> -wc pass
>>   5.18 igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt pass
>>   5.18 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
>> -gtt pass
>>   5.16 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-m
>> map-gtt pass
>>   5.14 igt@gem_sync@basic-each pass
>>   5.10 igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt pass
>>   5.08 igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt pass
>>   4.96 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap
>> -gtt pass
>>   4.74 igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap
>> -gtt pass
>>   4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-m
>> map-gtt pass
>>   4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-m
>> map-gtt pass
>>   4.72 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
>> -gtt pass
>>   4.62 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-m
>> map-gtt skip
>>   4.61 igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack skip
>>   4.58 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-m
>> map-gtt skip
>>   4.57 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-r
>> ender skip
>>   3.63 igt@kms_frontbuffer_tracking@fbcpsr-stridechange skip
>>
>> Same here, all are under the individual test limit.
> 
> both changes
> 
> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> unless CI folks nack it ;)

Well, no, that's can't be accepted as such. The point is not for tests
to take less than 30s, it is to have the widest coverage in less than 10m...

As a general rule, we are OK with an increase by 15 to 20s in the
general case, and no more than 30s on the slowest machine, but we can't
allow anything more than that in *fast* feedback.

In my opinion, the basic test should be the only one executed, but of
course you know better and may want to add one or two extra tests. The
suspend test should however definitely not be there because it increases
the chances of the machine dying for unrelated reasons :s

I know you are trying to add all these tests because right now, this is
the only way to prevent PSR regressions (since we have no PSR panels in
shards), but we just received enough machines to add to the shards that
have PSR panels and will catch regressions.

The point of FF should remain to gate further testing, when a
patchseries is just too broken to warrant wasting time on it ;)

Martin
> 
>>
>> I am not sure what the overall time limit is, this is what I see - 
>> Without PSR frontbuffer 742.12s
>> (https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4498/fi-skl-6600u/runt
>> imes0.log)
>> With PSR frontbuffer tests 693.63s
>> (https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-skl-6600u/runti
>> mes0.log)
>>
>> Looks like there are others tests with a larger variance negating the
>> impact of new PSR tests.
>>
>> -DK
>>
>>>
>>>>
>>>>
>>>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>>> Cc: Petri Latvala <petri.latvala@intel.com>
>>>> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>>> ---
>>>>  tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
>>>>  1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
>>>> ci/fast-feedback.testlist
>>>> index aa861d39..e262d024 100644
>>>> --- a/tests/intel-ci/fast-feedback.testlist
>>>> +++ b/tests/intel-ci/fast-feedback.testlist
>>>> @@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
>>>>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
>>>>  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
>>>>  igt@kms_psr@basic
>>>> +igt@kms_psr@no_drrs
>>>> +igt@kms_psr@primary_page_flip
>>>> +igt@kms_psr@primary_mmap_gtt
>>>> +igt@kms_psr@primary_mmap_cpu
>>>> +igt@kms_psr@primary_blt
>>>> +igt@kms_psr@primary_render
>>>> +igt@kms_psr@sprite_mmap_gtt
>>>> +igt@kms_psr@sprite_mmap_cpu
>>>> +igt@kms_psr@sprite_blt
>>>> +igt@kms_psr@sprite_render
>>>> +igt@kms_psr@sprite_plane_move
>>>> +igt@kms_psr@sprite_plane_onoff
>>>> +igt@kms_psr@cursor_mmap_gtt
>>>> +igt@kms_psr@cursor_mmap_cpu
>>>> +igt@kms_psr@cursor_blt
>>>> +igt@kms_psr@cursor_render
>>>> +igt@kms_psr@cursor_plane_move
>>>> +igt@kms_psr@cursor_plane_onoff
>>>> +igt@kms_psr@dpms
>>>> +igt@kms_psr@suspend
>>>>  igt@kms_setmode@basic-clone-single-crtc
>>>>  igt@kms_sink_crc_basic
>>>>  igt@pm_backlight@basic-brightness
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.

[Dhinakaran Pandiyan]

On Tue, 2018-07-17 at 10:52 +0300, Martin Peres wrote:
> On 17/07/18 08:13, Rodrigo Vivi wrote:
> > 
> > On Mon, Jul 16, 2018 at 11:29:48AM -0700, Dhinakaran Pandiyan
> > wrote:
> > > 
> > > On Mon, 2018-07-16 at 10:43 -0700, Rodrigo Vivi wrote:
> > > > 
> > > > On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan
> > > > wrote:
> > > > > 
> > > > > 
> > > > > We do not have PSR panels on shards machines, so this is the
> > > > > only
> > > > > way to
> > > > > test PSR in CI.
> > > > We definitely need this...
> > > > but we need to ckeck the overall time and ff limits here as
> > > > well...
> > >  From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-
> > > r/runt
> > > imes0.log
> > >  19.46 igt@kms_psr@suspend pass
> > >   4.78 igt@kms_psr@dpms pass
> > >   3.37 igt@kms_psr@sprite_blt pass
> > >   3.35 igt@kms_psr@sprite_plane_onoff pass
> > >   3.35 igt@kms_psr@sprite_plane_move pass
> > >   3.35 igt@kms_psr@sprite_mmap_gtt pass
> > >   3.35 igt@kms_psr@sprite_mmap_cpu pass
> > >   3.34 igt@kms_psr@sprite_render pass
> > >   3.34 igt@kms_psr@primary_render pass
> > >   3.34 igt@kms_psr@primary_page_flip pass
> > >   3.33 igt@kms_psr@primary_mmap_cpu pass
> > >   3.31 igt@kms_psr@primary_mmap_gtt pass
> > >   3.31 igt@kms_psr@primary_blt pass
> > >   3.29 igt@kms_psr@cursor_render pass
> > >   3.29 igt@kms_psr@cursor_plane_onoff pass
> > >   3.29 igt@kms_psr@cursor_plane_move pass
> > >   3.29 igt@kms_psr@cursor_mmap_gtt pass
> > >   3.29 igt@kms_psr@cursor_mmap_cpu pass
> > >   3.29 igt@kms_psr@cursor_blt pass
> > >   3.14 igt@kms_psr@basic pass
> > >   3.11 igt@kms_psr@no_drrs pass
> > > 
> > > Each test is under the 30s limit and kms_psr@suspend is the only
> > > that
> > > gets closer to the limit.
> > > 
> > > Without kms_psr subtests 730.18s TOTAL
> > > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4488/fi-kbl-r/run
> > > times0
> > > .log
> > > With kms_psr subtests 626.50s TOTAL
> > > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runt
> > > imes0.
> > > log
> > > 
> > > > 
> > > > ditto on the kms_frontbuffer_tracking one...
> > > From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-whl-u
> > > /runti
> > > mes0.log
> > > 
> > >   7.38 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-dra
> > > w-pwri
> > > te pass
> > >   6.23 igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack
> > > pass
> > >   5.79 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-dra
> > > w-mmap
> > > -cpu pass
> > >   5.71 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-dra
> > > w-mmap
> > > -cpu pass
> > >   5.69 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-dra
> > > w-blt
> > > pass
> > >   5.53 igt@kms_frontbuffer_tracking@psr-farfromfence pass
> > >   5.51 igt@kms_frontbuffer_tracking@fbcpsr-farfromfence pass
> > >   5.48 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-
> > > draw-m
> > > map-wc pass
> > > 5.20 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-
> > > mmap-g
> > > tt pass
> > >   5.19 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-dra
> > > w-mmap
> > > -wc pass
> > >   5.18 igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt
> > > pass
> > >   5.18 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-dra
> > > w-mmap
> > > -gtt pass
> > >   5.16 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-
> > > draw-m
> > > map-gtt pass
> > >   5.14 igt@gem_sync@basic-each pass
> > >   5.10 igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt
> > > pass
> > >   5.08 igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt pass
> > >   4.96 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-dra
> > > w-mmap
> > > -gtt pass
> > >   4.74 igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-dra
> > > w-mmap
> > > -gtt pass
> > >   4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-
> > > draw-m
> > > map-gtt pass
> > >   4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-
> > > draw-m
> > > map-gtt pass
> > >   4.72 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-dra
> > > w-mmap
> > > -gtt pass
> > >   4.62 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-
> > > draw-m
> > > map-gtt skip
> > >   4.61 igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack
> > > skip
> > >   4.58 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-
> > > draw-m
> > > map-gtt skip
> > >   4.57 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-
> > > draw-r
> > > ender skip
> > >   3.63 igt@kms_frontbuffer_tracking@fbcpsr-stridechange skip
> > > 
> > > Same here, all are under the individual test limit.
> > both changes
> > 
> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > 
> > unless CI folks nack it ;)
> Well, no, that's can't be accepted as such. The point is not for
> tests
> to take less than 30s, it is to have the widest coverage in less than
> 10m...
> 
> As a general rule, we are OK with an increase by 15 to 20s in the
> general case, and no more than 30s on the slowest machine, but we
> can't
> allow anything more than that in *fast* feedback.
> 
> In my opinion, the basic test should be the only one executed, but of
> course you know better and may want to add one or two extra tests.
> The
> suspend test should however definitely not be there because it
> increases
> the chances of the machine dying for unrelated reasons :s
> 
> I know you are trying to add all these tests because right now, this
> is
> the only way to prevent PSR regressions (since we have no PSR panels
> in
> shards), but we just received enough machines to add to the shards
> that
> have PSR panels and will catch regressions.

Great, if this is already in progress, we can filter this list to a
smaller set.

Thanks
DK

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev