* [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed
@ 2018-07-12 7:31 Chris Wilson
2018-07-12 8:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2018-07-12 7:31 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
Before running a hang test, check if we can inject a hang and expect
recover to work. If we can't control a hang, skip the subtest.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/kms_vblank.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 2bee49de5..508c0fa03 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -442,10 +442,14 @@ static void run_subtests_for_pipe(data_t *data)
igt_subtest_f("pipe-%s-%s-%s-hang",
kmstest_pipe_name(data->pipe),
f->name, m->name) {
+ igt_hang_t hang;
+
+ hang = igt_allow_hang(data->display.drm_fd, 0, 0);
for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
data->flags = m->flags;
run_test(data, f->func);
}
+ igt_disallow_hang(data->display.drm_fd, hang);
}
}
}
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for igt/kms_vblank: Check if hangs are allowed
2018-07-12 7:31 [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed Chris Wilson
@ 2018-07-12 8:19 ` Patchwork
2018-07-12 10:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-07-17 11:51 ` [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-12 8:19 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/kms_vblank: Check if hangs are allowed
URL : https://patchwork.freedesktop.org/series/46357/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4469 -> IGTPW_1560 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1560 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1560, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46357/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1560:
=== IGT changes ===
==== Warnings ====
igt@pm_rpm@basic-rte:
fi-hsw-peppy: PASS -> SKIP +1
fi-hsw-4770r: PASS -> SKIP +1
fi-bdw-5557u: PASS -> SKIP +1
fi-hsw-4770: PASS -> SKIP +1
== Known issues ==
Here are the changes found in IGTPW_1560 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-dsi: PASS -> FAIL (fdo#100368)
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
== Participating hosts (46 -> 39) ==
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-elk-e7500
== Build changes ==
* IGT: IGT_4546 -> IGTPW_1560
CI_DRM_4469: 02e578b7aace48d33fa617dddb40621bd664c92c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1560: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1560/
IGT_4546: e8905e756cf3640c66541e963ff97f8af2d98936 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1560/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for igt/kms_vblank: Check if hangs are allowed
2018-07-12 7:31 [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed Chris Wilson
2018-07-12 8:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-12 10:37 ` Patchwork
2018-07-17 11:51 ` [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-12 10:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/kms_vblank: Check if hangs are allowed
URL : https://patchwork.freedesktop.org/series/46357/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4546_full -> IGTPW_1560_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1560_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1560_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46357/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1560_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-vebox:
shard-kbl: SKIP -> PASS
igt@gem_mocs_settings@mocs-rc6-dirty-render:
shard-kbl: PASS -> SKIP
igt@pm_rpm@cursor:
shard-hsw: PASS -> SKIP +34
== Known issues ==
Here are the changes found in IGTPW_1560_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-apl: PASS -> FAIL (fdo#106886)
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
igt@kms_flip@2x-plain-flip-ts-check:
shard-glk: PASS -> FAIL (fdo#100368) +1
igt@kms_flip_tiling@flip-to-x-tiled:
shard-glk: PASS -> FAIL (fdo#107161)
igt@kms_rotation_crc@sprite-rotation-270:
shard-apl: PASS -> FAIL (fdo#103925)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@perf@polling:
shard-hsw: PASS -> FAIL (fdo#102252)
==== Possible fixes ====
igt@drv_suspend@fence-restore-untiled:
shard-glk: FAIL (fdo#103375) -> PASS
igt@kms_busy@basic-flip-e:
shard-snb: INCOMPLETE (fdo#105411) -> SKIP
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-glk: INCOMPLETE (fdo#103359, k.org#198133) -> PASS +1
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105189) -> PASS
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-glk: FAIL (fdo#103928) -> PASS
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: FAIL (fdo#107161, fdo#103822) -> PASS +1
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
shard-hsw: FAIL (fdo#103925) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4546 -> IGTPW_1560
* Linux: CI_DRM_4466 -> CI_DRM_4469
CI_DRM_4466: 40ea4d696481930682c782e8dd7bd0cdbdfad574 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4469: 02e578b7aace48d33fa617dddb40621bd664c92c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1560: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1560/
IGT_4546: e8905e756cf3640c66541e963ff97f8af2d98936 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1560/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed
2018-07-12 7:31 [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed Chris Wilson
2018-07-12 8:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-12 10:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-07-17 11:51 ` Chris Wilson
2018-07-17 12:08 ` [Intel-gfx] [igt-dev] " Ville Syrjälä
2 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-07-17 11:51 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
Quoting Chris Wilson (2018-07-12 08:31:42)
> Before running a hang test, check if we can inject a hang and expect
> recover to work. If we can't control a hang, skip the subtest.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Any takers?
-Chris
> ---
> tests/kms_vblank.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 2bee49de5..508c0fa03 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -442,10 +442,14 @@ static void run_subtests_for_pipe(data_t *data)
> igt_subtest_f("pipe-%s-%s-%s-hang",
> kmstest_pipe_name(data->pipe),
> f->name, m->name) {
> + igt_hang_t hang;
> +
> + hang = igt_allow_hang(data->display.drm_fd, 0, 0);
> for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
> data->flags = m->flags;
> run_test(data, f->func);
> }
> + igt_disallow_hang(data->display.drm_fd, hang);
> }
> }
> }
> --
> 2.18.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed
2018-07-17 11:51 ` [Intel-gfx] [PATCH i-g-t] " Chris Wilson
@ 2018-07-17 12:08 ` Ville Syrjälä
2018-07-17 12:26 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2018-07-17 12:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Jul 17, 2018 at 12:51:55PM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-07-12 08:31:42)
> > Before running a hang test, check if we can inject a hang and expect
> > recover to work. If we can't control a hang, skip the subtest.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Any takers?
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> -Chris
>
> > ---
> > tests/kms_vblank.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> > index 2bee49de5..508c0fa03 100644
> > --- a/tests/kms_vblank.c
> > +++ b/tests/kms_vblank.c
> > @@ -442,10 +442,14 @@ static void run_subtests_for_pipe(data_t *data)
> > igt_subtest_f("pipe-%s-%s-%s-hang",
> > kmstest_pipe_name(data->pipe),
> > f->name, m->name) {
> > + igt_hang_t hang;
> > +
> > + hang = igt_allow_hang(data->display.drm_fd, 0, 0);
> > for_each_valid_output_on_pipe(&data->display, data->pipe, data->output) {
> > data->flags = m->flags;
> > run_test(data, f->func);
> > }
> > + igt_disallow_hang(data->display.drm_fd, hang);
> > }
> > }
> > }
> > --
> > 2.18.0
> >
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed
2018-07-17 12:08 ` [Intel-gfx] [igt-dev] " Ville Syrjälä
@ 2018-07-17 12:26 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-07-17 12:26 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: igt-dev, intel-gfx
Quoting Ville Syrjälä (2018-07-17 13:08:01)
> On Tue, Jul 17, 2018 at 12:51:55PM +0100, Chris Wilson wrote:
> > Quoting Chris Wilson (2018-07-12 08:31:42)
> > > Before running a hang test, check if we can inject a hang and expect
> > > recover to work. If we can't control a hang, skip the subtest.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Any takers?
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Ta. Gradually turning skl-iommu gray.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-17 12:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-12 7:31 [igt-dev] [PATCH i-g-t] igt/kms_vblank: Check if hangs are allowed Chris Wilson
2018-07-12 8:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-12 10:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-07-17 11:51 ` [Intel-gfx] [PATCH i-g-t] " Chris Wilson
2018-07-17 12:08 ` [Intel-gfx] [igt-dev] " Ville Syrjälä
2018-07-17 12:26 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).