* [igt-dev] [PATCH] igt: Markup more tests that require GEM
@ 2018-07-20 17:01 Gwan-gyeong Mun
2018-07-20 20:15 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Gwan-gyeong Mun @ 2018-07-20 17:01 UTC (permalink / raw)
To: igt-dev; +Cc: martin.peres
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
tests/kms_addfb_basic.c | 4 ++++
tests/kms_flip.c | 5 ++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 7d8852f0..cd075117 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -106,6 +106,7 @@ static void invalid_tests(int fd)
igt_subtest("clobberred-modifier") {
f.flags = 0;
f.modifier[0] = 0;
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) == 0);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
@@ -200,6 +201,7 @@ static void tiling_tests(int fd)
igt_subtest("framebuffer-vs-set-tiling") {
f.handles[0] = gem_bo;
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == 0);
igt_assert(__gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4) == -EBUSY);
@@ -318,6 +320,7 @@ static void size_tests(int fd)
}
igt_subtest("bo-too-small-due-to-tiling") {
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
errno == EINVAL);
@@ -369,6 +372,7 @@ static void addfb25_tests(int fd)
igt_subtest_group {
igt_fixture {
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
igt_require_fb_modifiers(fd);
}
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 393d690a..4dcb0691 100644
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -612,6 +612,7 @@ static void set_y_tiling(struct test_output *o, int fb_idx)
r = drmModeGetFB(drm_fd, fb_info->fb_id);
igt_assert(r);
/* Newer kernels don't allow such shenagians any more, so skip the test. */
+ igt_require_gem(drm_fd);
igt_require(__gem_set_tiling(drm_fd, r->handle, I915_TILING_Y, fb_info->stride) == 0);
gem_close(drm_fd, r->handle);
drmFree(r);
@@ -782,8 +783,10 @@ static unsigned int run_test_step(struct test_output *o)
if (do_flip)
do_or_die(do_page_flip(o, new_fb_id, !(o->flags & TEST_NOEVENT)));
- if (o->flags & TEST_FENCE_STRESS)
+ if (o->flags & TEST_FENCE_STRESS) {
+ igt_require_gem(drm_fd);
emit_fence_stress(o);
+ }
if (do_vblank) {
do_or_die(do_wait_for_vblank(o, o->pipe, target_seq,
--
2.18.0
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for igt: Markup more tests that require GEM
2018-07-20 17:01 [igt-dev] [PATCH] igt: Markup more tests that require GEM Gwan-gyeong Mun
@ 2018-07-20 20:15 ` Patchwork
2018-07-24 12:17 ` [igt-dev] [PATCH] " Gwan-gyeong Mun
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-20 20:15 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: igt-dev
== Series Details ==
Series: igt: Markup more tests that require GEM
URL : https://patchwork.freedesktop.org/series/46971/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4521 -> IGTPW_1618 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46971/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1618 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: PASS -> DMESG-WARN (fdo#105128, fdo#107139)
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
== Participating hosts (47 -> 42) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4570 -> IGTPW_1618
CI_DRM_4521: a4ebbd84c682fd30edbde6ac0e48d150d4c5c066 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1618: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1618/
IGT_4570: 65cdccdc7bcbb791d791aeeeecb784a382110a3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1618/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] [PATCH] igt: Markup more tests that require GEM
2018-07-20 17:01 [igt-dev] [PATCH] igt: Markup more tests that require GEM Gwan-gyeong Mun
2018-07-20 20:15 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-07-24 12:17 ` Gwan-gyeong Mun
2018-08-17 11:50 ` Chris Wilson
2018-07-24 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for igt: Markup more tests that require GEM (rev2) Patchwork
2018-07-24 14:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Gwan-gyeong Mun @ 2018-07-24 12:17 UTC (permalink / raw)
To: igt-dev; +Cc: martin.peres
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
tests/kms_addfb_basic.c | 4 ++++
tests/kms_flip.c | 5 ++++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 7d8852f0..cd075117 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -106,6 +106,7 @@ static void invalid_tests(int fd)
igt_subtest("clobberred-modifier") {
f.flags = 0;
f.modifier[0] = 0;
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) == 0);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
@@ -200,6 +201,7 @@ static void tiling_tests(int fd)
igt_subtest("framebuffer-vs-set-tiling") {
f.handles[0] = gem_bo;
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == 0);
igt_assert(__gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4) == -EBUSY);
@@ -318,6 +320,7 @@ static void size_tests(int fd)
}
igt_subtest("bo-too-small-due-to-tiling") {
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
errno == EINVAL);
@@ -369,6 +372,7 @@ static void addfb25_tests(int fd)
igt_subtest_group {
igt_fixture {
+ igt_require_gem(fd);
gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
igt_require_fb_modifiers(fd);
}
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 393d690a..4dcb0691 100644
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -612,6 +612,7 @@ static void set_y_tiling(struct test_output *o, int fb_idx)
r = drmModeGetFB(drm_fd, fb_info->fb_id);
igt_assert(r);
/* Newer kernels don't allow such shenagians any more, so skip the test. */
+ igt_require_gem(drm_fd);
igt_require(__gem_set_tiling(drm_fd, r->handle, I915_TILING_Y, fb_info->stride) == 0);
gem_close(drm_fd, r->handle);
drmFree(r);
@@ -782,8 +783,10 @@ static unsigned int run_test_step(struct test_output *o)
if (do_flip)
do_or_die(do_page_flip(o, new_fb_id, !(o->flags & TEST_NOEVENT)));
- if (o->flags & TEST_FENCE_STRESS)
+ if (o->flags & TEST_FENCE_STRESS) {
+ igt_require_gem(drm_fd);
emit_fence_stress(o);
+ }
if (do_vblank) {
do_or_die(do_wait_for_vblank(o, o->pipe, target_seq,
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH] igt: Markup more tests that require GEM
2018-07-24 12:17 ` [igt-dev] [PATCH] " Gwan-gyeong Mun
@ 2018-08-17 11:50 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-17 11:50 UTC (permalink / raw)
To: Gwan-gyeong Mun, igt-dev; +Cc: martin.peres
Quoting Gwan-gyeong Mun (2018-07-24 13:17:19)
igt_require_gem() is overkill for set-tiling. igt_require_gem() role is
to determine if we can execute; for a large part the memory management
aspect has to always work if the module is loaded, tiling included.
If you
$ echo 0 > /sys/modules/i915/parameters/reset
$ echo -1 > /sys/kernel/debug/dri/0/i915_wedged
you will end with an wedged driver. Any test that fails in that state is
missing the igt_require_gem(). Of course, some that fail may be a kernel
bug in not providing enough working interfaces after being wedged...
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt: Markup more tests that require GEM (rev2)
2018-07-20 17:01 [igt-dev] [PATCH] igt: Markup more tests that require GEM Gwan-gyeong Mun
2018-07-20 20:15 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-24 12:17 ` [igt-dev] [PATCH] " Gwan-gyeong Mun
@ 2018-07-24 12:59 ` Patchwork
2018-07-24 14:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-24 12:59 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: igt-dev
== Series Details ==
Series: igt: Markup more tests that require GEM (rev2)
URL : https://patchwork.freedesktop.org/series/46971/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4534 -> IGTPW_1636 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46971/revisions/2/mbox/
== Known issues ==
Here are the changes found in IGTPW_1636 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_busy@basic-flip-a:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097)
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#102614, fdo#106103)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@gem_exec_flush@basic-wb-ro-default:
fi-glk-j4005: DMESG-WARN (fdo#105719) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#100368) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
== Participating hosts (52 -> 44) ==
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-caroline fi-byt-clapper fi-bdw-samus
== Build changes ==
* IGT: IGT_4572 -> IGTPW_1636
CI_DRM_4534: a59bbda34ede6f5685fdc86b58f143bada751617 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1636: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1636/
IGT_4572: 9b064015df14506b23cd2d7245a73e1b1d16ee1f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1636/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for igt: Markup more tests that require GEM (rev2)
2018-07-20 17:01 [igt-dev] [PATCH] igt: Markup more tests that require GEM Gwan-gyeong Mun
` (2 preceding siblings ...)
2018-07-24 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for igt: Markup more tests that require GEM (rev2) Patchwork
@ 2018-07-24 14:54 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-24 14:54 UTC (permalink / raw)
To: Gwan-gyeong Mun; +Cc: igt-dev
== Series Details ==
Series: igt: Markup more tests that require GEM (rev2)
URL : https://patchwork.freedesktop.org/series/46971/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4572_full -> IGTPW_1636_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1636_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1636_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/46971/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1636_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-blt:
shard-apl: SKIP -> PASS +3
igt@gem_exec_schedule@deep-bsd:
shard-glk: SKIP -> PASS +3
igt@gem_exec_schedule@deep-bsd1:
shard-kbl: SKIP -> PASS +2
igt@gem_mocs_settings@mocs-rc6-vebox:
shard-kbl: PASS -> SKIP +1
igt@kms_atomic_interruptible@legacy-dpms:
shard-snb: PASS -> SKIP +1
== Known issues ==
Here are the changes found in IGTPW_1636_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
shard-kbl: PASS -> DMESG-FAIL (fdo#106560, fdo#106947)
igt@gem_sync@basic-many-each:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: PASS -> FAIL (fdo#106641)
igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
shard-kbl: PASS -> DMESG-WARN (fdo#106247)
igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
shard-glk: NOTRUN -> FAIL (fdo#106509, fdo#105454)
igt@kms_cursor_legacy@pipe-c-torture-bo:
shard-apl: PASS -> DMESG-WARN (fdo#107122)
shard-glk: PASS -> DMESG-WARN (fdo#107122)
igt@kms_flip@2x-plain-flip-fb-recreate:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
igt@kms_flip@plain-flip-ts-check:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
igt@kms_universal_plane@cursor-fb-leak-pipe-a:
shard-apl: FAIL (fdo#107241) -> PASS
igt@perf_pmu@rc6-runtime-pm-long:
shard-kbl: FAIL (fdo#105010) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107122 https://bugs.freedesktop.org/show_bug.cgi?id=107122
fdo#107241 https://bugs.freedesktop.org/show_bug.cgi?id=107241
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4572 -> IGTPW_1636
* Linux: CI_DRM_4533 -> CI_DRM_4534
CI_DRM_4533: 712e7047cfc7a129df6d324f59cc5d4eb2879285 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4534: a59bbda34ede6f5685fdc86b58f143bada751617 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1636: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1636/
IGT_4572: 9b064015df14506b23cd2d7245a73e1b1d16ee1f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1636/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-17 11:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-20 17:01 [igt-dev] [PATCH] igt: Markup more tests that require GEM Gwan-gyeong Mun
2018-07-20 20:15 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-24 12:17 ` [igt-dev] [PATCH] " Gwan-gyeong Mun
2018-08-17 11:50 ` Chris Wilson
2018-07-24 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for igt: Markup more tests that require GEM (rev2) Patchwork
2018-07-24 14:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).