igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: martin.peres@linux.intel.com
Subject: [igt-dev] [i-g-t,v2] igt: Markup more tests that require INTEL
Date: Tue, 24 Jul 2018 17:31:19 +0300	[thread overview]
Message-ID: <20180724143119.5280-1-gwan-gyeong.mun@intel.com> (raw)
In-Reply-To: <20180724122653.26429-1-gwan-gyeong.mun@intel.com>

v2: Drop igt_require_intel() on drv_module_reload (Chris Wilson)
    drv_module_reload on the whole should not require intel.
    Some particular tests should skip if the module doesn't have the right
    modparam, but if it does it should conform.

Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
---
 tests/kms_atomic.c       | 4 ++++
 tests/kms_flip.c         | 4 +++-
 tests/kms_plane_lowres.c | 1 +
 tests/kms_vblank.c       | 4 +++-
 4 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index ac02baf0..b1aa8a0c 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -895,18 +895,21 @@ igt_main
 			igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_OVERLAY);
 
 		igt_require(overlay);
+		igt_require_intel(display.drm_fd);
 
 		atomic_setup(&display, pipe, output, primary, &fb);
 		plane_overlay(pipe_obj, output, overlay);
 	}
 
 	igt_subtest("plane_primary_legacy") {
+		igt_require_intel(display.drm_fd);
 		atomic_setup(&display, pipe, output, primary, &fb);
 
 		plane_primary(pipe_obj, primary, &fb);
 	}
 
 	igt_subtest("test_only") {
+		igt_require_intel(display.drm_fd);
 		atomic_clear(&display, pipe, primary, output);
 
 		test_only(pipe_obj, primary, output);
@@ -922,6 +925,7 @@ igt_main
 	}
 
 	igt_subtest("plane_invalid_params") {
+		igt_require_intel(display.drm_fd);
 		atomic_setup(&display, pipe, output, primary, &fb);
 
 		plane_invalid_params(pipe_obj, output, primary, &fb);
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 4dcb0691..03173173 100644
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -771,8 +771,10 @@ static unsigned int run_test_step(struct test_output *o)
 	igt_print_activity();
 
 	memset(&hang, 0, sizeof(hang));
-	if (do_flip && (o->flags & TEST_HANG))
+	if (do_flip && (o->flags & TEST_HANG)) {
+		igt_require_intel(drm_fd);
 		hang = hang_gpu(drm_fd);
+	}
 
 	/* try to make sure we can issue two flips during the same frame */
 	if (do_flip && (o->flags & TEST_EBUSY)) {
diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
index d1e4b3ca..d2c0b0b2 100644
--- a/tests/kms_plane_lowres.c
+++ b/tests/kms_plane_lowres.c
@@ -270,6 +270,7 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
 		igt_skip_on(pipe >= data->display.n_pipes);
 
 		igt_display_require_output_on_pipe(&data->display, pipe);
+		igt_require_intel(data->drm_fd);
 	}
 
 	igt_subtest_f("pipe-%s-tiling-none",
diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 508c0fa0..46072e85 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -127,8 +127,10 @@ static void run_test(data_t *data, void (*testfunc)(data_t *, int, int))
 		 igt_subtest_name(), kmstest_pipe_name(data->pipe),
 		 igt_output_name(output));
 
-	if (!(data->flags & NOHANG))
+	if (!(data->flags & NOHANG)) {
+		igt_require_intel(fd);
 		hang = igt_hang_ring(fd, I915_EXEC_DEFAULT);
+	}
 
 	if (data->flags & BUSY) {
 		union drm_wait_vblank vbl;
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-07-24 14:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 17:02 [igt-dev] [PATCH] igt: Markup more tests that require INTEL Gwan-gyeong Mun
2018-07-20 19:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-24 12:26 ` [igt-dev] [PATCH] " Gwan-gyeong Mun
2018-07-24 12:33   ` Chris Wilson
2018-07-24 14:31   ` Gwan-gyeong Mun [this message]
2018-07-24 13:15 ` [igt-dev] ✓ Fi.CI.BAT: success for igt: Markup more tests that require INTEL (rev2) Patchwork
2018-07-24 15:34 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-07-24 15:36 ` [igt-dev] ✓ Fi.CI.BAT: success for igt: Markup more tests that require INTEL (rev3) Patchwork
2018-07-24 19:01 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-08-09 12:50 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-08-09 13:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724143119.5280-1-gwan-gyeong.mun@intel.com \
    --to=gwan-gyeong.mun@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=martin.peres@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).