igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
@ 2018-08-06 12:43 Chris Wilson
  2018-08-06 13:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Chris Wilson @ 2018-08-06 12:43 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

Since amdgpu is synchronous for exporting a dmabuf, exercise both paths
to highlight the issue.

References: https://bugs.freedesktop.org/show_bug.cgi?id=107341
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/amdgpu/amd_prime.c | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
index 9bf298a41..7be7a04ac 100644
--- a/tests/amdgpu/amd_prime.c
+++ b/tests/amdgpu/amd_prime.c
@@ -286,7 +286,9 @@ static void i915_to_amd(int i915, int amd, amdgpu_device_handle device)
 	gem_close(i915, obj[1].handle);
 }
 
-static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
+static void amd_to_i915(int i915, int amd, amdgpu_device_handle device,
+			unsigned int flags)
+#define EXPORT_BEFORE 0x1
 {
 	const uint32_t bbe = MI_BATCH_BUFFER_END;
 	struct drm_i915_gem_exec_object2 obj[2];
@@ -300,7 +302,7 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 	struct amdgpu_cs_ib_info ib_info;
 	uint32_t *ptr;
 	amdgpu_context_handle *contexts;
-	int i, r, dmabuf;
+	int i, r, dmabuf = -1;
 	amdgpu_bo_list_handle bo_list;
 	amdgpu_va_handle va_handle;
 	unsigned long count, size;
@@ -320,6 +322,13 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 				    &ib_result_mc_address, &va_handle);
 	igt_assert_eq(r, 0);
 
+	if (flags & EXPORT_BEFORE) {
+		amdgpu_bo_export(ib_result_handle,
+				 amdgpu_bo_handle_type_dma_buf_fd,
+				 (uint32_t *)&dmabuf);
+		igt_assert(dmabuf != -1);
+	}
+
 	ptr = ib_result_cpu;
 	for (i = 0; i < 16; ++i)
 		ptr[i] = GFX_COMPUTE_NOP;
@@ -365,9 +374,12 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 
 	igt_info("Reservation width = %ld\n", count);
 
-	amdgpu_bo_export(ib_result_handle,
-			 amdgpu_bo_handle_type_dma_buf_fd,
-			 (uint32_t *)&dmabuf);
+	if (dmabuf == -1) {
+		amdgpu_bo_export(ib_result_handle,
+				 amdgpu_bo_handle_type_dma_buf_fd,
+				 (uint32_t *)&dmabuf);
+		igt_assert(dmabuf != -1);
+	}
 	igt_assert_eq(poll(&(struct pollfd){dmabuf, POLLOUT}, 1, 0), 0);
 	obj[0].handle = prime_fd_to_handle(i915, dmabuf);
 	obj[0].flags = EXEC_OBJECT_WRITE;
@@ -418,7 +430,10 @@ igt_main
 	}
 
 	igt_subtest("amd-to-i915")
-		amd_to_i915(i915, amd, device);
+		amd_to_i915(i915, amd, device, EXPORT_BEFORE);
+
+	igt_subtest("inflight-amd-to-i915")
+		amd_to_i915(i915, amd, device, 0);
 
 	igt_fixture {
 		amdgpu_device_deinitialize(device);
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
  2018-08-06 12:43 [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Chris Wilson
@ 2018-08-06 13:41 ` Patchwork
  2018-08-06 14:01 ` Patchwork
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-08-06 13:41 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
URL   : https://patchwork.freedesktop.org/series/47759/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4612 -> IGTPW_1681 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47759/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1681 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    {igt@amdgpu/amd_basic@userptr}:
      {fi-kbl-8809g}:     PASS -> INCOMPLETE (fdo#107402)

    igt@drv_selftest@live_workarounds:
      fi-cnl-psr:         PASS -> DMESG-FAIL (fdo#107292)

    igt@kms_chamelium@dp-crc-fast:
      fi-kbl-7500u:       PASS -> DMESG-FAIL (fdo#103841)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-skl-6260u:       PASS -> INCOMPLETE (fdo#104108)

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_workarounds:
      {fi-bsw-kefka}:     DMESG-FAIL (fdo#107292) -> PASS

    igt@kms_chamelium@common-hpd-after-suspend:
      fi-skl-6700k2:      INCOMPLETE (fdo#105524, k.org#199541, fdo#104108) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#106103, fdo#102614) -> PASS
      {fi-byt-clapper}:   FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
  fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
  k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541


== Participating hosts (53 -> 47) ==

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-glk-dsi fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4586 -> IGTPW_1681

  CI_DRM_4612: 54b418b10dad143d1bbe7708de5bbf3344164303 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1681: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1681/
  IGT_4586: 57caaf440520e397403d898e1d3f1d65ef7b79e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@amdgpu/amd_prime@inflight-amd-to-i915

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1681/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
  2018-08-06 12:43 [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Chris Wilson
  2018-08-06 13:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-08-06 14:01 ` Patchwork
  2018-08-06 14:08 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-08-06 14:01 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
URL   : https://patchwork.freedesktop.org/series/47759/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4612 -> IGTPW_1682 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47759/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1682 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_workarounds:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL (fdo#107292)
      {fi-bdw-samus}:     PASS -> DMESG-FAIL (fdo#107292)
      fi-cnl-psr:         PASS -> DMESG-FAIL (fdo#107292)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      {fi-byt-clapper}:   PASS -> INCOMPLETE (fdo#102657)
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    {igt@kms_psr@primary_page_flip}:
      fi-cfl-s3:          PASS -> FAIL (fdo#107336)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_workarounds:
      {fi-bsw-kefka}:     DMESG-FAIL (fdo#107292) -> PASS

    igt@kms_chamelium@common-hpd-after-suspend:
      fi-skl-6700k2:      INCOMPLETE (fdo#104108, k.org#199541, fdo#105524) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#102614, fdo#106103) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541


== Participating hosts (53 -> 46) ==

  Missing    (7): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-caroline 


== Build changes ==

    * IGT: IGT_4586 -> IGTPW_1682

  CI_DRM_4612: 54b418b10dad143d1bbe7708de5bbf3344164303 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1682: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1682/
  IGT_4586: 57caaf440520e397403d898e1d3f1d65ef7b79e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@amdgpu/amd_prime@inflight-amd-to-i915

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1682/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
  2018-08-06 12:43 [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Chris Wilson
  2018-08-06 13:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-08-06 14:01 ` Patchwork
@ 2018-08-06 14:08 ` Chris Wilson
  2018-08-07  7:35   ` Chris Wilson
  2018-08-06 14:27 ` [igt-dev] ✓ Fi.CI.BAT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2) Patchwork
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 8+ messages in thread
From: Chris Wilson @ 2018-08-06 14:08 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

Since amdgpu is synchronous for exporting a dmabuf, exercise both paths
to highlight the issue.

v2: More action required to trigger the dmabuf-mapping

References: https://bugs.freedesktop.org/show_bug.cgi?id=107341
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/amdgpu/amd_prime.c | 47 +++++++++++++++++++++++++++++++---------
 1 file changed, 37 insertions(+), 10 deletions(-)

diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
index 9bf298a41..4cd981114 100644
--- a/tests/amdgpu/amd_prime.c
+++ b/tests/amdgpu/amd_prime.c
@@ -286,7 +286,9 @@ static void i915_to_amd(int i915, int amd, amdgpu_device_handle device)
 	gem_close(i915, obj[1].handle);
 }
 
-static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
+static void amd_to_i915(int i915, int amd, amdgpu_device_handle device,
+			unsigned int flags)
+#define EXPORT_BEFORE 0x1
 {
 	const uint32_t bbe = MI_BATCH_BUFFER_END;
 	struct drm_i915_gem_exec_object2 obj[2];
@@ -300,11 +302,11 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 	struct amdgpu_cs_ib_info ib_info;
 	uint32_t *ptr;
 	amdgpu_context_handle *contexts;
-	int i, r, dmabuf;
 	amdgpu_bo_list_handle bo_list;
 	amdgpu_va_handle va_handle;
 	unsigned long count, size;
 	struct cork c;
+	int i, r;
 
 	memset(obj, 0, sizeof(obj));
 	obj[1].handle = gem_create(i915, 4096);
@@ -320,6 +322,21 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 				    &ib_result_mc_address, &va_handle);
 	igt_assert_eq(r, 0);
 
+	if (flags & EXPORT_BEFORE) {
+		int dmabuf;
+
+		amdgpu_bo_export(ib_result_handle,
+				 amdgpu_bo_handle_type_dma_buf_fd,
+				 (uint32_t *)&dmabuf);
+		igt_assert(dmabuf != -1);
+
+		obj[0].handle = prime_fd_to_handle(i915, dmabuf);
+		obj[0].flags = EXEC_OBJECT_WRITE;
+		close(dmabuf);
+
+		gem_set_domain(i915, obj[0].handle, I915_GEM_DOMAIN_GTT, 0);
+	}
+
 	ptr = ib_result_cpu;
 	for (i = 0; i < 16; ++i)
 		ptr[i] = GFX_COMPUTE_NOP;
@@ -365,13 +382,20 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
 
 	igt_info("Reservation width = %ld\n", count);
 
-	amdgpu_bo_export(ib_result_handle,
-			 amdgpu_bo_handle_type_dma_buf_fd,
-			 (uint32_t *)&dmabuf);
-	igt_assert_eq(poll(&(struct pollfd){dmabuf, POLLOUT}, 1, 0), 0);
-	obj[0].handle = prime_fd_to_handle(i915, dmabuf);
-	obj[0].flags = EXEC_OBJECT_WRITE;
-	close(dmabuf);
+	if (!obj[0].handle) {
+		int dmabuf;
+
+		amdgpu_bo_export(ib_result_handle,
+				 amdgpu_bo_handle_type_dma_buf_fd,
+				 (uint32_t *)&dmabuf);
+		igt_assert(dmabuf != -1);
+
+		obj[0].handle = prime_fd_to_handle(i915, dmabuf);
+		obj[0].flags = EXEC_OBJECT_WRITE;
+
+		igt_assert_eq(poll(&(struct pollfd){dmabuf, POLLOUT}, 1, 0), 0);
+		close(dmabuf);
+	}
 
 	gem_execbuf(i915, &execbuf);
 	igt_assert(gem_bo_busy(i915, obj[1].handle));
@@ -418,7 +442,10 @@ igt_main
 	}
 
 	igt_subtest("amd-to-i915")
-		amd_to_i915(i915, amd, device);
+		amd_to_i915(i915, amd, device, EXPORT_BEFORE);
+
+	igt_subtest("inflight-amd-to-i915")
+		amd_to_i915(i915, amd, device, 0);
 
 	igt_fixture {
 		amdgpu_device_deinitialize(device);
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2)
  2018-08-06 12:43 [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Chris Wilson
                   ` (2 preceding siblings ...)
  2018-08-06 14:08 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2018-08-06 14:27 ` Patchwork
  2018-08-06 16:00 ` [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Patchwork
  2018-08-06 17:25 ` [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2) Patchwork
  5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-08-06 14:27 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2)
URL   : https://patchwork.freedesktop.org/series/47759/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4612 -> IGTPW_1683 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47759/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1683 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_workarounds:
      fi-cnl-psr:         PASS -> DMESG-FAIL (fdo#107292)

    
    ==== Possible fixes ====

    {igt@amdgpu/amd_prime@amd-to-i915}:
      {fi-kbl-8809g}:     FAIL (fdo#107341) -> PASS

    igt@drv_selftest@live_workarounds:
      {fi-bsw-kefka}:     DMESG-FAIL (fdo#107292) -> PASS

    igt@kms_chamelium@common-hpd-after-suspend:
      fi-skl-6700k2:      INCOMPLETE (fdo#105524, k.org#199541, fdo#104108) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#102614, fdo#106103) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541


== Participating hosts (53 -> 48) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4586 -> IGTPW_1683

  CI_DRM_4612: 54b418b10dad143d1bbe7708de5bbf3344164303 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1683: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1683/
  IGT_4586: 57caaf440520e397403d898e1d3f1d65ef7b79e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@amdgpu/amd_prime@inflight-amd-to-i915

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1683/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
  2018-08-06 12:43 [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Chris Wilson
                   ` (3 preceding siblings ...)
  2018-08-06 14:27 ` [igt-dev] ✓ Fi.CI.BAT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2) Patchwork
@ 2018-08-06 16:00 ` Patchwork
  2018-08-06 17:25 ` [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2) Patchwork
  5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-08-06 16:00 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
URL   : https://patchwork.freedesktop.org/series/47759/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4586_full -> IGTPW_1681_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1681_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1681_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47759/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1681_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1681_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-snb:          PASS -> INCOMPLETE (fdo#106886, fdo#105411)

    igt@gem_eio@reset-stress:
      shard-hsw:          PASS -> FAIL (fdo#107500)

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@gem_render_copy_redux@flink:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@prime_vgem@basic-fence-flip:
      shard-kbl:          PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@gem_softpin@noreloc-s3:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          FAIL (fdo#106641) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@perf_pmu@init-wait-rcs0:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@pm_rpm@dpms-mode-unset-lpsp:
      shard-glk:          FAIL (fdo#106539) -> SKIP +1
      shard-apl:          FAIL (fdo#106539) -> SKIP +1
      shard-kbl:          FAIL (fdo#106539) -> SKIP +1

    igt@pm_rpm@modeset-lpsp-stress:
      shard-hsw:          FAIL (fdo#106539) -> SKIP +1

    igt@pm_rps@min-max-config-loaded:
      shard-glk:          FAIL (fdo#107466) -> PASS

    
    ==== Warnings ====

    igt@testdisplay:
      shard-glk:          DMESG-WARN (fdo#105763) -> INCOMPLETE (fdo#107093, fdo#103359, k.org#198133)

    
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106539 https://bugs.freedesktop.org/show_bug.cgi?id=106539
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107466 https://bugs.freedesktop.org/show_bug.cgi?id=107466
  fdo#107500 https://bugs.freedesktop.org/show_bug.cgi?id=107500
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4586 -> IGTPW_1681
    * Linux: CI_DRM_4606 -> CI_DRM_4612

  CI_DRM_4606: 603c0696f3c56d3f1e47c283de897448473c9041 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4612: 54b418b10dad143d1bbe7708de5bbf3344164303 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1681: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1681/
  IGT_4586: 57caaf440520e397403d898e1d3f1d65ef7b79e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1681/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2)
  2018-08-06 12:43 [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Chris Wilson
                   ` (4 preceding siblings ...)
  2018-08-06 16:00 ` [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Patchwork
@ 2018-08-06 17:25 ` Patchwork
  5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-08-06 17:25 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2)
URL   : https://patchwork.freedesktop.org/series/47759/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4586_full -> IGTPW_1683_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1683_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1683_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47759/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1683_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1683_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_schedule@preempt-queue-chain-bsd:
      shard-apl:          PASS -> FAIL (fdo#105900)

    igt@gem_pwrite_pread@display-pwrite-blt-gtt_mmap-performance:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@gem_workarounds@suspend-resume-fd:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-kbl:          PASS -> DMESG-WARN (fdo#103313)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@pm_rpm@debugfs-forcewake-user:
      shard-glk:          PASS -> FAIL (fdo#106539)
      shard-hsw:          PASS -> FAIL (fdo#106539) +5
      shard-kbl:          PASS -> FAIL (fdo#106539)
      shard-apl:          PASS -> FAIL (fdo#106539)

    igt@pm_rpm@dpms-lpsp:
      shard-hsw:          SKIP -> FAIL (fdo#106539)

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@gem_softpin@noreloc-s3:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          FAIL (fdo#106641) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@perf_pmu@init-wait-rcs0:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@pm_rpm@dpms-mode-unset-lpsp:
      shard-glk:          FAIL (fdo#106539) -> SKIP +1
      shard-apl:          FAIL (fdo#106539) -> SKIP +1
      shard-kbl:          FAIL (fdo#106539) -> SKIP +1

    igt@pm_rpm@modeset-lpsp-stress:
      shard-hsw:          FAIL (fdo#106539) -> SKIP +1

    igt@pm_rps@min-max-config-loaded:
      shard-glk:          FAIL (fdo#107466) -> PASS

    
    ==== Warnings ====

    igt@testdisplay:
      shard-glk:          DMESG-WARN (fdo#105763) -> INCOMPLETE (k.org#198133, fdo#103359, fdo#107093)

    
  fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106539 https://bugs.freedesktop.org/show_bug.cgi?id=106539
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107466 https://bugs.freedesktop.org/show_bug.cgi?id=107466
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4586 -> IGTPW_1683
    * Linux: CI_DRM_4606 -> CI_DRM_4612

  CI_DRM_4606: 603c0696f3c56d3f1e47c283de897448473c9041 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4612: 54b418b10dad143d1bbe7708de5bbf3344164303 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1683: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1683/
  IGT_4586: 57caaf440520e397403d898e1d3f1d65ef7b79e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1683/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences
  2018-08-06 14:08 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2018-08-07  7:35   ` Chris Wilson
  0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-08-07  7:35 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

Quoting Chris Wilson (2018-08-06 15:08:17)
> Since amdgpu is synchronous for exporting a dmabuf, exercise both paths
> to highlight the issue.
> 
> v2: More action required to trigger the dmabuf-mapping
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=107341
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Poke

> ---
>  tests/amdgpu/amd_prime.c | 47 +++++++++++++++++++++++++++++++---------
>  1 file changed, 37 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/amdgpu/amd_prime.c b/tests/amdgpu/amd_prime.c
> index 9bf298a41..4cd981114 100644
> --- a/tests/amdgpu/amd_prime.c
> +++ b/tests/amdgpu/amd_prime.c
> @@ -286,7 +286,9 @@ static void i915_to_amd(int i915, int amd, amdgpu_device_handle device)
>         gem_close(i915, obj[1].handle);
>  }
>  
> -static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
> +static void amd_to_i915(int i915, int amd, amdgpu_device_handle device,
> +                       unsigned int flags)
> +#define EXPORT_BEFORE 0x1
>  {
>         const uint32_t bbe = MI_BATCH_BUFFER_END;
>         struct drm_i915_gem_exec_object2 obj[2];
> @@ -300,11 +302,11 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
>         struct amdgpu_cs_ib_info ib_info;
>         uint32_t *ptr;
>         amdgpu_context_handle *contexts;
> -       int i, r, dmabuf;
>         amdgpu_bo_list_handle bo_list;
>         amdgpu_va_handle va_handle;
>         unsigned long count, size;
>         struct cork c;
> +       int i, r;
>  
>         memset(obj, 0, sizeof(obj));
>         obj[1].handle = gem_create(i915, 4096);
> @@ -320,6 +322,21 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
>                                     &ib_result_mc_address, &va_handle);
>         igt_assert_eq(r, 0);
>  
> +       if (flags & EXPORT_BEFORE) {
> +               int dmabuf;
> +
> +               amdgpu_bo_export(ib_result_handle,
> +                                amdgpu_bo_handle_type_dma_buf_fd,
> +                                (uint32_t *)&dmabuf);
> +               igt_assert(dmabuf != -1);
> +
> +               obj[0].handle = prime_fd_to_handle(i915, dmabuf);
> +               obj[0].flags = EXEC_OBJECT_WRITE;
> +               close(dmabuf);
> +
> +               gem_set_domain(i915, obj[0].handle, I915_GEM_DOMAIN_GTT, 0);
> +       }
> +
>         ptr = ib_result_cpu;
>         for (i = 0; i < 16; ++i)
>                 ptr[i] = GFX_COMPUTE_NOP;
> @@ -365,13 +382,20 @@ static void amd_to_i915(int i915, int amd, amdgpu_device_handle device)
>  
>         igt_info("Reservation width = %ld\n", count);
>  
> -       amdgpu_bo_export(ib_result_handle,
> -                        amdgpu_bo_handle_type_dma_buf_fd,
> -                        (uint32_t *)&dmabuf);
> -       igt_assert_eq(poll(&(struct pollfd){dmabuf, POLLOUT}, 1, 0), 0);
> -       obj[0].handle = prime_fd_to_handle(i915, dmabuf);
> -       obj[0].flags = EXEC_OBJECT_WRITE;
> -       close(dmabuf);
> +       if (!obj[0].handle) {
> +               int dmabuf;
> +
> +               amdgpu_bo_export(ib_result_handle,
> +                                amdgpu_bo_handle_type_dma_buf_fd,
> +                                (uint32_t *)&dmabuf);
> +               igt_assert(dmabuf != -1);
> +
> +               obj[0].handle = prime_fd_to_handle(i915, dmabuf);
> +               obj[0].flags = EXEC_OBJECT_WRITE;
> +
> +               igt_assert_eq(poll(&(struct pollfd){dmabuf, POLLOUT}, 1, 0), 0);
> +               close(dmabuf);
> +       }
>  
>         gem_execbuf(i915, &execbuf);
>         igt_assert(gem_bo_busy(i915, obj[1].handle));
> @@ -418,7 +442,10 @@ igt_main
>         }
>  
>         igt_subtest("amd-to-i915")
> -               amd_to_i915(i915, amd, device);
> +               amd_to_i915(i915, amd, device, EXPORT_BEFORE);
> +
> +       igt_subtest("inflight-amd-to-i915")
> +               amd_to_i915(i915, amd, device, 0);
>  
>         igt_fixture {
>                 amdgpu_device_deinitialize(device);
> -- 
> 2.18.0
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-08-07  7:35 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-06 12:43 [Intel-gfx] [PATCH i-g-t] amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Chris Wilson
2018-08-06 13:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-06 14:01 ` Patchwork
2018-08-06 14:08 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-08-07  7:35   ` Chris Wilson
2018-08-06 14:27 ` [igt-dev] ✓ Fi.CI.BAT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2) Patchwork
2018-08-06 16:00 ` [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences Patchwork
2018-08-06 17:25 ` [igt-dev] ✓ Fi.CI.IGT: success for amdgpu: Exporting a dmabuf from amdgpu waits for outstanding fences (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).