* [igt-dev] [PATCH i-g-t] intel-ci: Skip module reloads
@ 2018-08-10 9:02 Chris Wilson
2018-08-10 9:11 ` [igt-dev] [Intel-gfx] " Petri Latvala
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-10 9:02 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev, Tomi Sarvela
Reloading the module may impact subsequent tests by destabilising the
system. As we do for BAT, if we want to test reloads, it should be
handled explicitly at the end of the run, rather than placed at random
in the middle of the test list.
References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
tests/intel-ci/blacklist.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 1d1652964..066a5c014 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -2,6 +2,7 @@ igt@meta_test(@.*)?
###############################################
# GEM
###############################################
+igt@drv_module_reload(@.*)?
igt@drv_selftest(@.*)?
igt@drm_mm(@.*)?
igt@gem_busy@(?!.*basic).*hang.*
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel-ci: Skip module reloads
2018-08-10 9:02 [igt-dev] [PATCH i-g-t] intel-ci: Skip module reloads Chris Wilson
@ 2018-08-10 9:11 ` Petri Latvala
2018-08-10 9:21 ` Chris Wilson
2018-08-10 12:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-10 16:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Petri Latvala @ 2018-08-10 9:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, Tomi Sarvela, intel-gfx
On Fri, Aug 10, 2018 at 10:02:46AM +0100, Chris Wilson wrote:
> Reloading the module may impact subsequent tests by destabilising the
> system. As we do for BAT, if we want to test reloads, it should be
> handled explicitly at the end of the run, rather than placed at random
> in the middle of the test list.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> ---
> tests/intel-ci/blacklist.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index 1d1652964..066a5c014 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -2,6 +2,7 @@ igt@meta_test(@.*)?
> ###############################################
> # GEM
> ###############################################
> +igt@drv_module_reload(@.*)?
"GEM"?
Comment the line with the explanation from the commit message.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel-ci: Skip module reloads
2018-08-10 9:11 ` [igt-dev] [Intel-gfx] " Petri Latvala
@ 2018-08-10 9:21 ` Chris Wilson
2018-08-10 9:33 ` Petri Latvala
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-08-10 9:21 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev, Tomi Sarvela, intel-gfx
Quoting Petri Latvala (2018-08-10 10:11:29)
> On Fri, Aug 10, 2018 at 10:02:46AM +0100, Chris Wilson wrote:
> > Reloading the module may impact subsequent tests by destabilising the
> > system. As we do for BAT, if we want to test reloads, it should be
> > handled explicitly at the end of the run, rather than placed at random
> > in the middle of the test list.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > ---
> > tests/intel-ci/blacklist.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > index 1d1652964..066a5c014 100644
> > --- a/tests/intel-ci/blacklist.txt
> > +++ b/tests/intel-ci/blacklist.txt
> > @@ -2,6 +2,7 @@ igt@meta_test(@.*)?
> > ###############################################
> > # GEM
> > ###############################################
> > +igt@drv_module_reload(@.*)?
>
> "GEM"?
That didn't apply to the selftests or drm_mm, so I thought it was the
usual misleading comment.
> Comment the line with the explanation from the commit message.
Where are comments allowed?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] intel-ci: Skip module reloads
2018-08-10 9:21 ` Chris Wilson
@ 2018-08-10 9:33 ` Petri Latvala
0 siblings, 0 replies; 6+ messages in thread
From: Petri Latvala @ 2018-08-10 9:33 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, Tomi Sarvela, intel-gfx
On Fri, Aug 10, 2018 at 10:21:59AM +0100, Chris Wilson wrote:
> Quoting Petri Latvala (2018-08-10 10:11:29)
> > On Fri, Aug 10, 2018 at 10:02:46AM +0100, Chris Wilson wrote:
> > > Reloading the module may impact subsequent tests by destabilising the
> > > system. As we do for BAT, if we want to test reloads, it should be
> > > handled explicitly at the end of the run, rather than placed at random
> > > in the middle of the test list.
> > >
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > > ---
> > > tests/intel-ci/blacklist.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > > index 1d1652964..066a5c014 100644
> > > --- a/tests/intel-ci/blacklist.txt
> > > +++ b/tests/intel-ci/blacklist.txt
> > > @@ -2,6 +2,7 @@ igt@meta_test(@.*)?
> > > ###############################################
> > > # GEM
> > > ###############################################
> > > +igt@drv_module_reload(@.*)?
> >
> > "GEM"?
>
> That didn't apply to the selftests or drm_mm, so I thought it was the
> usual misleading comment.
>
> > Comment the line with the explanation from the commit message.
>
> Where are comments allowed?
I believe Tomi's handling of blacklist.txt considers anything
beginning with # a comment.
--
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for intel-ci: Skip module reloads
2018-08-10 9:02 [igt-dev] [PATCH i-g-t] intel-ci: Skip module reloads Chris Wilson
2018-08-10 9:11 ` [igt-dev] [Intel-gfx] " Petri Latvala
@ 2018-08-10 12:56 ` Patchwork
2018-08-10 16:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-10 12:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: intel-ci: Skip module reloads
URL : https://patchwork.freedesktop.org/series/47992/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4642 -> IGTPW_1700 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47992/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1700 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_coherency:
fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164)
igt@drv_selftest@live_hangcheck:
fi-bxt-dsi: PASS -> DMESG-FAIL (fdo#106560)
igt@drv_selftest@live_workarounds:
fi-kbl-7560u: PASS -> DMESG-FAIL (fdo#107292)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
{fi-byt-clapper}: PASS -> FAIL (fdo#103191, fdo#107362)
{igt@kms_psr@sprite_plane_onoff}:
{fi-bdw-samus}: NOTRUN -> FAIL (fdo#107360)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: DMESG-WARN (fdo#106725, fdo#106248) -> PASS
igt@drv_selftest@live_workarounds:
{fi-bsw-kefka}: DMESG-FAIL (fdo#107292) -> PASS
fi-bdw-5557u: DMESG-FAIL (fdo#107292) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#100368) -> PASS
==== Warnings ====
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: DMESG-WARN (fdo#107372) -> DMESG-FAIL (fdo#107372)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
== Participating hosts (53 -> 49) ==
Additional (1): fi-bdw-samus
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4591 -> IGTPW_1700
CI_DRM_4642: 0de4e9a02a422ebe523f59c3b462c949673746b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1700: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1700/
IGT_4591: 6cb3d7dbe5831a7b2b5b7a4638d8a8b7ac624f5f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1700/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.IGT: success for intel-ci: Skip module reloads
2018-08-10 9:02 [igt-dev] [PATCH i-g-t] intel-ci: Skip module reloads Chris Wilson
2018-08-10 9:11 ` [igt-dev] [Intel-gfx] " Petri Latvala
2018-08-10 12:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-08-10 16:22 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-10 16:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: intel-ci: Skip module reloads
URL : https://patchwork.freedesktop.org/series/47992/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4591_full -> IGTPW_1700_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1700_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1700_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47992/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1700_full:
=== IGT changes ===
==== Warnings ====
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1700_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_workarounds:
shard-kbl: PASS -> DMESG-FAIL (fdo#107292)
igt@drv_suspend@shrink:
shard-kbl: PASS -> FAIL (fdo#106886)
igt@gem_eio@wait-wedge-immediate:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@gem_exec_schedule@pi-ringfull-render:
shard-glk: NOTRUN -> FAIL (fdo#103158)
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
shard-glk: NOTRUN -> FAIL (fdo#99912)
==== Possible fixes ====
igt@gem_exec_store@basic-blt:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
igt@pm_rpm@i2c:
shard-apl: FAIL (fdo#106539) -> PASS
shard-glk: FAIL (fdo#106539) -> PASS
shard-hsw: FAIL (fdo#106539) -> PASS
shard-kbl: FAIL (fdo#106539) -> PASS
igt@testdisplay:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359, fdo#107093) -> PASS
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106539 https://bugs.freedesktop.org/show_bug.cgi?id=106539
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4591 -> IGTPW_1700
* Linux: CI_DRM_4636 -> CI_DRM_4642
CI_DRM_4636: 084bb2fb549650b6da80976c9bc594779ce342b4 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4642: 0de4e9a02a422ebe523f59c3b462c949673746b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1700: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1700/
IGT_4591: 6cb3d7dbe5831a7b2b5b7a4638d8a8b7ac624f5f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1700/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-10 16:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-10 9:02 [igt-dev] [PATCH i-g-t] intel-ci: Skip module reloads Chris Wilson
2018-08-10 9:11 ` [igt-dev] [Intel-gfx] " Petri Latvala
2018-08-10 9:21 ` Chris Wilson
2018-08-10 9:33 ` Petri Latvala
2018-08-10 12:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-10 16:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).