From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org, Tomi Sarvela <tomi.p.sarvela@intel.com>
Subject: [Intel-gfx] [PATCH i-g-t 2/2] intel-ci: Skip module reloads
Date: Fri, 10 Aug 2018 10:41:45 +0100 [thread overview]
Message-ID: <20180810094145.10182-2-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20180810094145.10182-1-chris@chris-wilson.co.uk>
Reloading the module may impact subsequent tests by destabilising the
system. As we do for BAT, if we want to test reloads, it should be
handled explicitly at the end of the run, rather than placed at random
in the middle of the test list.
v2: Commentary
References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
tests/intel-ci/blacklist.txt | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 7700a60b7..c93554a37 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -5,6 +5,15 @@ igt@meta_test(@.*)?
igt@drv_selftest(@.*)?
igt@drm_mm(@.*)?
###############################################
+# Handle module reloads with great care!
+#
+# Reloading a module is more likely to leave
+# the machine in an unexpected state than other
+# self-contained tests, leading to random
+# failures in tests run afterwards.
+###############################################
+igt@drv_module_reload(@.*)?
+###############################################
# GEM
###############################################
igt@gem_busy@(?!.*basic).*hang.*
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-08-10 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 9:41 [igt-dev] [PATCH i-g-t 1/2] intel-ci: Comment on kernel selftest exclusion Chris Wilson
2018-08-10 9:41 ` Chris Wilson [this message]
2018-08-10 9:55 ` [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] intel-ci: Skip module reloads Petri Latvala
2018-08-10 10:05 ` Chris Wilson
2018-08-10 12:56 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] intel-ci: Comment on kernel selftest exclusion Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810094145.10182-2-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).