[igt-dev] [PATCH i-g-t 1/2] intel-ci: Comment on kernel selftest exclusion

[igt-dev] [PATCH i-g-t 1/2] intel-ci: Comment on kernel selftest exclusion

[Chris Wilson]

The kernel selftests are excluded from the shard lists as those lists
are compiled separately.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/intel-ci/blacklist.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 1d1652964..7700a60b7 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -1,9 +1,12 @@
 igt@meta_test(@.*)?
 ###############################################
-# GEM
+# Kernel selftests (run separately)
 ###############################################
 igt@drv_selftest(@.*)?
 igt@drm_mm(@.*)?
+###############################################
+# GEM
+###############################################
 igt@gem_busy@(?!.*basic).*hang.*
 igt@gem_close_race@(?!.*basic).*
 igt@gem_concurrent_blit(@.*)?
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[Intel-gfx] [PATCH i-g-t 2/2] intel-ci: Skip module reloads

[Chris Wilson]

Reloading the module may impact subsequent tests by destabilising the
system. As we do for BAT, if we want to test reloads, it should be
handled explicitly at the end of the run, rather than placed at random
in the middle of the test list.

v2: Commentary

References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
 tests/intel-ci/blacklist.txt | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index 7700a60b7..c93554a37 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -5,6 +5,15 @@ igt@meta_test(@.*)?
 igt@drv_selftest(@.*)?
 igt@drm_mm(@.*)?
 ###############################################
+# Handle module reloads with great care!
+#
+# Reloading a module is more likely to leave
+# the machine in an unexpected state than other
+# self-contained tests, leading to random
+# failures in tests run afterwards.
+###############################################
+igt@drv_module_reload(@.*)?
+###############################################
 # GEM
 ###############################################
 igt@gem_busy@(?!.*basic).*hang.*
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] intel-ci: Skip module reloads

[Petri Latvala]

On Fri, Aug 10, 2018 at 10:41:45AM +0100, Chris Wilson wrote:
> Reloading the module may impact subsequent tests by destabilising the
> system. As we do for BAT, if we want to test reloads, it should be
> handled explicitly at the end of the run, rather than placed at random
> in the middle of the test list.
> 
> v2: Commentary
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>


The series is

Acked-by: Petri Latvala <petri.latvala@intel.com>



> ---
>  tests/intel-ci/blacklist.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index 7700a60b7..c93554a37 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -5,6 +5,15 @@ igt@meta_test(@.*)?
>  igt@drv_selftest(@.*)?
>  igt@drm_mm(@.*)?
>  ###############################################
> +# Handle module reloads with great care!
> +#
> +# Reloading a module is more likely to leave
> +# the machine in an unexpected state than other
> +# self-contained tests, leading to random
> +# failures in tests run afterwards.
> +###############################################
> +igt@drv_module_reload(@.*)?
> +###############################################
>  # GEM
>  ###############################################
>  igt@gem_busy@(?!.*basic).*hang.*
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] intel-ci: Skip module reloads

[Chris Wilson]

Quoting Petri Latvala (2018-08-10 10:55:06)
> On Fri, Aug 10, 2018 at 10:41:45AM +0100, Chris Wilson wrote:
> > Reloading the module may impact subsequent tests by destabilising the
> > system. As we do for BAT, if we want to test reloads, it should be
> > handled explicitly at the end of the run, rather than placed at random
> > in the middle of the test list.
> > 
> > v2: Commentary
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> 
> 
> The series is
> 
> Acked-by: Petri Latvala <petri.latvala@intel.com>

I've pushed this to see if this does indeed stabilise our test results
as currently we have random failures that change on every shardlist
rebuild.

I think we need an explicit test list to check after reload. I think
BAT?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] intel-ci: Comment on kernel selftest exclusion

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] intel-ci: Comment on kernel selftest exclusion
URL   : https://patchwork.freedesktop.org/series/47994/
State : failure

== Summary ==

Applying: intel-ci: Comment on kernel selftest exclusion
Using index info to reconstruct a base tree...
M	tests/intel-ci/blacklist.txt
Falling back to patching base and 3-way merge...
Auto-merging tests/intel-ci/blacklist.txt
CONFLICT (content): Merge conflict in tests/intel-ci/blacklist.txt
Patch failed at 0001 intel-ci: Comment on kernel selftest exclusion
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev