igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing
@ 2018-08-16  6:06 Chris Wilson
  2018-08-16  6:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Chris Wilson @ 2018-08-16  6:06 UTC (permalink / raw)
  To: igt-dev; +Cc: intel-gfx

The pm_rpm module-reload exists to exercise a rpm wakeref leak, and
affects the random selection of tests run after it. Similar to the
normal module-reload tests, care must be taken in its execution to avoid
causing spurious failures elsewhere.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/intel-ci/blacklist.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
index c93554a37..88b2fe313 100644
--- a/tests/intel-ci/blacklist.txt
+++ b/tests/intel-ci/blacklist.txt
@@ -13,6 +13,7 @@ igt@drm_mm(@.*)?
 # failures in tests run afterwards.
 ###############################################
 igt@drv_module_reload(@.*)?
+igt@pm_rpm@module-reload
 ###############################################
 # GEM
 ###############################################
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for intel-ci: Exclude pm_rpm module-reload from full testing
  2018-08-16  6:06 [igt-dev] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing Chris Wilson
@ 2018-08-16  6:26 ` Patchwork
  2018-08-16  7:56 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Petri Latvala
  2018-08-16  8:09 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-08-16  6:26 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: intel-ci: Exclude pm_rpm module-reload from full testing
URL   : https://patchwork.freedesktop.org/series/48295/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4672 -> IGTPW_1720 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48295/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1720 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    {igt@amdgpu/amd_prime@amd-to-i915}:
      {fi-kbl-8809g}:     NOTRUN -> FAIL (fdo#107341)

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7500u:       PASS -> DMESG-FAIL (fdo#106947, fdo#106560)

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    {igt@amdgpu/amd_basic@userptr}:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#107402) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#102614) -> PASS
      {fi-byt-clapper}:   FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      {fi-cfl-8109u}:     INCOMPLETE (fdo#106070) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402


== Participating hosts (53 -> 47) ==

  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4598 -> IGTPW_1720

  CI_DRM_4672: 2a55ea192b780b798b8c5bf2e458694ba54a312d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1720: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1720/
  IGT_4598: 9c0f04355107a8693650b16756b6343a78501138 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1720/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing
  2018-08-16  6:06 [igt-dev] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing Chris Wilson
  2018-08-16  6:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-08-16  7:56 ` Petri Latvala
  2018-08-16  8:00   ` Chris Wilson
  2018-08-16  8:09 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
  2 siblings, 1 reply; 7+ messages in thread
From: Petri Latvala @ 2018-08-16  7:56 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx

On Thu, Aug 16, 2018 at 07:06:46AM +0100, Chris Wilson wrote:
> The pm_rpm module-reload exists to exercise a rpm wakeref leak, and
> affects the random selection of tests run after it. Similar to the
> normal module-reload tests, care must be taken in its execution to avoid
> causing spurious failures elsewhere.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/intel-ci/blacklist.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index c93554a37..88b2fe313 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -13,6 +13,7 @@ igt@drm_mm(@.*)?
>  # failures in tests run afterwards.
>  ###############################################
>  igt@drv_module_reload(@.*)?
> +igt@pm_rpm@module-reload


As we don't have machinery in place yet to run these reloading tests
in shards in a controlled manner, should this be added to
fast-feedback to not lose the coverage entirely?


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing
  2018-08-16  7:56 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Petri Latvala
@ 2018-08-16  8:00   ` Chris Wilson
  2018-08-16  8:43     ` Petri Latvala
  0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2018-08-16  8:00 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev, intel-gfx

Quoting Petri Latvala (2018-08-16 08:56:27)
> On Thu, Aug 16, 2018 at 07:06:46AM +0100, Chris Wilson wrote:
> > The pm_rpm module-reload exists to exercise a rpm wakeref leak, and
> > affects the random selection of tests run after it. Similar to the
> > normal module-reload tests, care must be taken in its execution to avoid
> > causing spurious failures elsewhere.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  tests/intel-ci/blacklist.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > index c93554a37..88b2fe313 100644
> > --- a/tests/intel-ci/blacklist.txt
> > +++ b/tests/intel-ci/blacklist.txt
> > @@ -13,6 +13,7 @@ igt@drm_mm(@.*)?
> >  # failures in tests run afterwards.
> >  ###############################################
> >  igt@drv_module_reload(@.*)?
> > +igt@pm_rpm@module-reload
> 
> 
> As we don't have machinery in place yet to run these reloading tests
> in shards in a controlled manner, should this be added to
> fast-feedback to not lose the coverage entirely?

It already is in fast-feedback awaiting us landing the wakeref fix. :-p
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for intel-ci: Exclude pm_rpm module-reload from full testing
  2018-08-16  6:06 [igt-dev] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing Chris Wilson
  2018-08-16  6:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-08-16  7:56 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Petri Latvala
@ 2018-08-16  8:09 ` Patchwork
  2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-08-16  8:09 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: intel-ci: Exclude pm_rpm module-reload from full testing
URL   : https://patchwork.freedesktop.org/series/48295/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4598_full -> IGTPW_1720_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1720_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1720_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48295/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1720_full:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render:
      shard-hsw:          PASS -> SKIP

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1720_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          NOTRUN -> FAIL (fdo#105363, fdo#102887)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          PASS -> FAIL (fdo#103166)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_wait@await-default:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#107161) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@perf@polling:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    igt@testdisplay:
      shard-glk:          INCOMPLETE (fdo#103359, k.org#198133, fdo#107093) -> PASS

    
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4598 -> IGTPW_1720
    * Linux: CI_DRM_4669 -> CI_DRM_4672

  CI_DRM_4669: aea12ded40860145c23f1c1a28a386fb97ae6e4e @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4672: 2a55ea192b780b798b8c5bf2e458694ba54a312d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1720: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1720/
  IGT_4598: 9c0f04355107a8693650b16756b6343a78501138 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1720/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Intel-gfx] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing
  2018-08-16  8:00   ` Chris Wilson
@ 2018-08-16  8:43     ` Petri Latvala
  2018-08-16  9:03       ` Chris Wilson
  0 siblings, 1 reply; 7+ messages in thread
From: Petri Latvala @ 2018-08-16  8:43 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx

On Thu, Aug 16, 2018 at 09:00:37AM +0100, Chris Wilson wrote:
> Quoting Petri Latvala (2018-08-16 08:56:27)
> > On Thu, Aug 16, 2018 at 07:06:46AM +0100, Chris Wilson wrote:
> > > The pm_rpm module-reload exists to exercise a rpm wakeref leak, and
> > > affects the random selection of tests run after it. Similar to the
> > > normal module-reload tests, care must be taken in its execution to avoid
> > > causing spurious failures elsewhere.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > >  tests/intel-ci/blacklist.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > > index c93554a37..88b2fe313 100644
> > > --- a/tests/intel-ci/blacklist.txt
> > > +++ b/tests/intel-ci/blacklist.txt
> > > @@ -13,6 +13,7 @@ igt@drm_mm(@.*)?
> > >  # failures in tests run afterwards.
> > >  ###############################################
> > >  igt@drv_module_reload(@.*)?
> > > +igt@pm_rpm@module-reload
> > 
> > 
> > As we don't have machinery in place yet to run these reloading tests
> > in shards in a controlled manner, should this be added to
> > fast-feedback to not lose the coverage entirely?
> 
> It already is in fast-feedback awaiting us landing the wakeref fix. :-p


Blindness is bad, kids.


Acked-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Intel-gfx] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing
  2018-08-16  8:43     ` Petri Latvala
@ 2018-08-16  9:03       ` Chris Wilson
  0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2018-08-16  9:03 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev, intel-gfx

Quoting Petri Latvala (2018-08-16 09:43:10)
> On Thu, Aug 16, 2018 at 09:00:37AM +0100, Chris Wilson wrote:
> > Quoting Petri Latvala (2018-08-16 08:56:27)
> > > On Thu, Aug 16, 2018 at 07:06:46AM +0100, Chris Wilson wrote:
> > > > The pm_rpm module-reload exists to exercise a rpm wakeref leak, and
> > > > affects the random selection of tests run after it. Similar to the
> > > > normal module-reload tests, care must be taken in its execution to avoid
> > > > causing spurious failures elsewhere.
> > > > 
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > ---
> > > >  tests/intel-ci/blacklist.txt | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> > > > index c93554a37..88b2fe313 100644
> > > > --- a/tests/intel-ci/blacklist.txt
> > > > +++ b/tests/intel-ci/blacklist.txt
> > > > @@ -13,6 +13,7 @@ igt@drm_mm(@.*)?
> > > >  # failures in tests run afterwards.
> > > >  ###############################################
> > > >  igt@drv_module_reload(@.*)?
> > > > +igt@pm_rpm@module-reload
> > > 
> > > 
> > > As we don't have machinery in place yet to run these reloading tests
> > > in shards in a controlled manner, should this be added to
> > > fast-feedback to not lose the coverage entirely?
> > 
> > It already is in fast-feedback awaiting us landing the wakeref fix. :-p
> 
> 
> Blindness is bad, kids.
> 
> 
> Acked-by: Petri Latvala <petri.latvala@intel.com>

Got an irc r-b from Imre for the pm_rpm/module-reload fix, so pushed all
3. All that we have to do now is to fix the wakeref and rejoice in a
green BAT.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-08-16  9:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-16  6:06 [igt-dev] [PATCH i-g-t] intel-ci: Exclude pm_rpm module-reload from full testing Chris Wilson
2018-08-16  6:26 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-16  7:56 ` [igt-dev] [Intel-gfx] [PATCH i-g-t] " Petri Latvala
2018-08-16  8:00   ` Chris Wilson
2018-08-16  8:43     ` Petri Latvala
2018-08-16  9:03       ` Chris Wilson
2018-08-16  8:09 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).