* [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display
@ 2018-08-16 14:17 Chris Wilson
2018-08-16 14:38 ` [igt-dev] " Chris Wilson
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-16 14:17 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
If we've explicitly disabled the display, we will never find any
connected outputs or modes. Checking for them will fail and report the
missing requirement instead.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
tests/pm_rpm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index fefcb1beb..2c4bf529c 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2046,7 +2046,6 @@ int main(int argc, char *argv[])
igt_assert(setup_environment());
basic_subtest();
- drm_resources_equal_subtest();
pci_d3_state_subtest();
teardown_environment();
@@ -2056,7 +2055,8 @@ int main(int argc, char *argv[])
igt_assert(setup_environment());
basic_subtest();
- drm_resources_equal_subtest();
+ if (enable_one_screen_with_type(data, SCREEN_TYPE_ANY))
+ drm_resources_equal_subtest();
pci_d3_state_subtest();
teardown_environment();
}
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display
2018-08-16 14:17 [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
@ 2018-08-16 14:38 ` Chris Wilson
2018-08-16 14:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev2) Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-16 14:38 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
If we've explicitly disabled the display, we will never find any
connected outputs or modes. Checking for them will fail and report the
missing requirement instead.
v2: Sigh, avoid more comparisons against enabled displays
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
tests/pm_rpm.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index fefcb1beb..7bde26972 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2045,9 +2045,7 @@ int main(int argc, char *argv[])
igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
igt_assert(setup_environment());
- basic_subtest();
- drm_resources_equal_subtest();
- pci_d3_state_subtest();
+ igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
teardown_environment();
igt_debug("Reload as normal\n");
@@ -2055,9 +2053,9 @@ int main(int argc, char *argv[])
igt_assert_eq(igt_i915_driver_load(NULL), 0);
igt_assert(setup_environment());
- basic_subtest();
- drm_resources_equal_subtest();
- pci_d3_state_subtest();
+ igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
+ if (enable_one_screen_with_type(data, SCREEN_TYPE_ANY))
+ drm_resources_equal_subtest();
teardown_environment();
}
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev2)
2018-08-16 14:17 [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
2018-08-16 14:38 ` [igt-dev] " Chris Wilson
@ 2018-08-16 14:52 ` Patchwork
2018-08-16 15:46 ` [igt-dev] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-16 14:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev2)
URL : https://patchwork.freedesktop.org/series/48323/
State : failure
== Summary ==
IGT patchset build failed on latest successful build
1598fdb717546e25e8077935daa8e97768ad245d runner: Match the piglit name with -t and -x options
[277/447] Linking target tests/kms_available_modes_crc.
[278/447] Linking target tests/kms_busy.
[279/447] Linking target tests/kms_ccs.
[280/447] Linking target tests/kms_chv_cursor_fail.
[281/447] Linking target tests/kms_color.
[282/447] Linking target tests/kms_concurrent.
[283/447] Linking target tests/kms_crtc_background_color.
[284/447] Linking target tests/kms_cursor_crc.
[285/447] Linking target tests/kms_cursor_legacy.
[286/447] Linking target tests/kms_draw_crc.
[287/447] Linking target tests/kms_fbcon_fbt.
[288/447] Linking target tests/kms_fence_pin_leak.
[289/447] Linking target tests/kms_flip.
[290/447] Linking target tests/kms_flip_event_leak.
[291/447] Linking target tests/kms_flip_tiling.
[292/447] Linking target tests/kms_force_connector_basic.
[293/447] Linking target tests/kms_frontbuffer_tracking.
[294/447] Linking target tests/kms_invalid_dotclock.
[295/447] Linking target tests/kms_legacy_colorkey.
[296/447] Linking target tests/kms_mmap_write_crc.
[297/447] Linking target tests/kms_panel_fitting.
[298/447] Linking target tests/kms_pipe_b_c_ivb.
[299/447] Linking target tests/kms_pipe_crc_basic.
[300/447] Linking target tests/kms_plane.
[301/447] Linking target tests/kms_plane_lowres.
[302/447] Linking target tests/kms_plane_multiple.
[303/447] Linking target tests/kms_plane_scaling.
[304/447] Linking target tests/kms_properties.
[305/447] Linking target tests/kms_psr.
[306/447] Linking target tests/kms_pwrite_crc.
[307/447] Linking target tests/kms_rmfb.
[308/447] Linking target tests/kms_rotation_crc.
[309/447] Linking target tests/kms_setmode.
[310/447] Linking target tests/kms_sysfs_edid_timing.
[311/447] Linking target tests/kms_vblank.
[312/447] Linking target tests/meta_test.
[313/447] Linking target tests/perf.
[314/447] Linking target tests/pm_backlight.
[315/447] Linking target tests/pm_lpsp.
[316/447] Linking target tests/pm_rc6_residency.
[317/447] Compiling C object 'tests/pm_rpm@exe/pm_rpm.c.o'.
FAILED: tests/pm_rpm@exe/pm_rpm.c.o
ccache cc -Itests/pm_rpm@exe -Itests -I../tests -I. -I../ -I../lib/stubs/syscalls -Ilib -I../lib -I../include/drm-uapi -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/opt/igt/include -I/opt/igt/include/libdrm -I/usr/include/x86_64-linux-gnu -I/usr/include -I/usr/include/libdrm -I/usr/include/libdrm/nouveau -I/home/cidrm/kernel_headers/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -D_GNU_SOURCE -include config.h -Wno-unused-parameter -Wno-sign-compare -Wno-missing-field-initializers -Wno-clobbered -Wno-type-limits -Wimplicit-fallthrough=0 -pthread -MD -MQ 'tests/pm_rpm@exe/pm_rpm.c.o' -MF 'tests/pm_rpm@exe/pm_rpm.c.o.d' -o 'tests/pm_rpm@exe/pm_rpm.c.o' -c ../tests/pm_rpm.c
../tests/pm_rpm.c: In function ‘main’:
../tests/pm_rpm.c:2057:35: error: ‘data’ undeclared (first use in this function); did you mean ‘atan’?
if (enable_one_screen_with_type(data, SCREEN_TYPE_ANY))
^~~~
atan
../tests/pm_rpm.c:2057:35: note: each undeclared identifier is reported only once for each function it appears in
ninja: build stopped: subcommand failed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display
2018-08-16 14:17 [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
2018-08-16 14:38 ` [igt-dev] " Chris Wilson
2018-08-16 14:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev2) Patchwork
@ 2018-08-16 15:46 ` Chris Wilson
2018-08-16 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev3) Patchwork
2018-08-16 20:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-16 15:46 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
If we've explicitly disabled the display, we will never find any
connected outputs or modes. Checking for them will fail and report the
missing requirement instead.
v2: Sigh, avoid more comparisons against enabled displays
v3: Try occasionally compiling patches
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
---
tests/pm_rpm.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index fefcb1beb..bbe36e59e 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2045,9 +2045,7 @@ int main(int argc, char *argv[])
igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
igt_assert(setup_environment());
- basic_subtest();
- drm_resources_equal_subtest();
- pci_d3_state_subtest();
+ igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
teardown_environment();
igt_debug("Reload as normal\n");
@@ -2055,9 +2053,9 @@ int main(int argc, char *argv[])
igt_assert_eq(igt_i915_driver_load(NULL), 0);
igt_assert(setup_environment());
- basic_subtest();
- drm_resources_equal_subtest();
- pci_d3_state_subtest();
+ igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
+ if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
+ drm_resources_equal_subtest();
teardown_environment();
}
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev3)
2018-08-16 14:17 [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
` (2 preceding siblings ...)
2018-08-16 15:46 ` [igt-dev] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
@ 2018-08-16 17:00 ` Patchwork
2018-08-16 20:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-16 17:00 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev3)
URL : https://patchwork.freedesktop.org/series/48323/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4677 -> IGTPW_1723 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1723 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1723, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48323/revisions/3/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1723:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: SKIP -> PASS
== Known issues ==
Here are the changes found in IGTPW_1723 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-skl-guc: PASS -> DMESG-FAIL (fdo#107174)
igt@kms_chamelium@hdmi-hpd-fast:
fi-kbl-7500u: SKIP -> FAIL (fdo#103841, fdo#102672)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cnl-psr: PASS -> DMESG-WARN (fdo#104951)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@basic:
{fi-byt-clapper}: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
== Participating hosts (54 -> 47) ==
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u fi-bdw-samus
== Build changes ==
* IGT: IGT_4601 -> IGTPW_1723
CI_DRM_4677: 1af9e170b6469a64c82f5a4961a2be2f0fc1ff0a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1723: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1723/
IGT_4601: 0b5235db8d4c647a23cafe344c099d3699c8927e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1723/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev3)
2018-08-16 14:17 [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
` (3 preceding siblings ...)
2018-08-16 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev3) Patchwork
@ 2018-08-16 20:52 ` Patchwork
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-16 20:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev3)
URL : https://patchwork.freedesktop.org/series/48323/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4601_full -> IGTPW_1723_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1723_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1723_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48323/revisions/3/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1723_full:
=== IGT changes ===
==== Warnings ====
igt@gem_tiled_blits@interruptible:
shard-glk: SKIP -> PASS +4
== Known issues ==
Here are the changes found in IGTPW_1723_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_schedule@pi-ringfull-bsd1:
shard-kbl: NOTRUN -> FAIL (fdo#103158)
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: PASS -> INCOMPLETE (fdo#103665, fdo#106023)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-kbl: NOTRUN -> FAIL (fdo#106641)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-snb: PASS -> FAIL (fdo#105363)
igt@perf_pmu@rc6-runtime-pm:
shard-glk: PASS -> FAIL (fdo#105010)
igt@testdisplay:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133, fdo#107093)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106886) -> PASS
igt@gem_partial_pwrite_pread@write:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106023) -> PASS
igt@gem_render_linear_blits@basic:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: FAIL (fdo#106641) -> PASS
igt@kms_rotation_crc@primary-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4601 -> IGTPW_1723
* Linux: CI_DRM_4676 -> CI_DRM_4677
CI_DRM_4676: 8171ee8227a2633ffb5808841f08cc1a3bfaffbb @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4677: 1af9e170b6469a64c82f5a4961a2be2f0fc1ff0a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1723: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1723/
IGT_4601: 0b5235db8d4c647a23cafe344c099d3699c8927e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1723/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-16 20:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-16 14:17 [Intel-gfx] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
2018-08-16 14:38 ` [igt-dev] " Chris Wilson
2018-08-16 14:52 ` [igt-dev] ✗ Fi.CI.BAT: failure for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev2) Patchwork
2018-08-16 15:46 ` [igt-dev] [PATCH i-g-t] igt/pm_rpm: Skip counting modes if modprobed with disable_display Chris Wilson
2018-08-16 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Skip counting modes if modprobed with disable_display (rev3) Patchwork
2018-08-16 20:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).