igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v5 4/4] tests/kms_frontbuffer_tracking: Don't unset mode after reading CRC
Date: Fri, 17 Aug 2018 10:56:42 +0200	[thread overview]
Message-ID: <20180817085642.19501-4-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <20180817085642.19501-1-maarten.lankhorst@linux.intel.com>

Until the previous commit we had to disable the mode after reading CRC
because otherwise we might not have been enable features correctly.

Now we can just stage the disable without applying it, so each subtest
can set its desired mode and igt_display will update the state as
required.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_frontbuffer_tracking.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index a570f93a33a8..921aaffcb52c 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1220,7 +1220,7 @@ static void init_blue_crc(enum pixel_format format)
 
 	print_crc("Blue CRC:  ", &blue_crcs[format].crc);
 
-	unset_all_crtcs();
+	igt_display_reset(&drm.display);
 
 	igt_remove_fb(drm.fd, &blue);
 
@@ -1272,7 +1272,7 @@ static void init_crcs(enum pixel_format format,
 		print_crc("", &pattern->crcs[format][r]);
 	}
 
-	unset_all_crtcs();
+	igt_display_reset(&drm.display);
 
 	for (r = 0; r < pattern->n_rects; r++)
 		igt_remove_fb(drm.fd, &tmp_fbs[r]);
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-08-17  8:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17  8:56 [igt-dev] [PATCH i-g-t v5 1/4] lib/psr: Add support for toggling edp psr through debugfs, v5 Maarten Lankhorst
2018-08-17  8:56 ` [igt-dev] [PATCH i-g-t v5 2/4] tests/kms_frontbuffer_tracking: Attempt to enable both screens simultaneously Maarten Lankhorst
2018-08-17  8:56 ` [igt-dev] [PATCH i-g-t v5 3/4] tests/kms_frontbuffer_tracking: Remove redundant modesets for toggling features, v5 Maarten Lankhorst
2018-08-17  8:56 ` Maarten Lankhorst [this message]
2018-08-18  0:04   ` [igt-dev] [PATCH i-g-t v5 4/4] tests/kms_frontbuffer_tracking: Don't unset mode after reading CRC Dhinakaran Pandiyan
2018-08-22 10:17     ` Maarten Lankhorst
2018-08-30  2:02       ` Dhinakaran Pandiyan
2018-08-30  9:12         ` Maarten Lankhorst
2018-08-17 11:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v5,1/4] lib/psr: Add support for toggling edp psr through debugfs, v5 Patchwork
2018-08-17 14:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-08-18  0:02 ` [igt-dev] [PATCH i-g-t v5 1/4] " Dhinakaran Pandiyan
2018-09-04 21:41 ` Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817085642.19501-4-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).