[igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
 tests/pm_rpm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index bbe36e59e..249530691 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2042,7 +2042,7 @@ int main(int argc, char *argv[])
 	igt_subtest("module-reload") {
 		igt_debug("Reload w/o display\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2050,13 +2050,16 @@ int main(int argc, char *argv[])
 
 		igt_debug("Reload as normal\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load(NULL), 0);
+		igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
 		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
 			drm_resources_equal_subtest();
 		teardown_environment();
+
+		/* Remove our mmio_debugging module */
+		igt_i915_driver_unload();
 	}
 
 	igt_exit();
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/pm_rpm: Reload the module with full mmio debugging

[Patchwork]

== Series Details ==

Series: lib/pm_rpm: Reload the module with full mmio debugging
URL   : https://patchwork.freedesktop.org/series/48390/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4684 -> IGTPW_1727 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48390/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1727 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    {igt@kms_psr@primary_page_flip}:
      {fi-icl-u}:         NOTRUN -> FAIL (fdo#107383) +3

    {igt@kms_psr@sprite_plane_onoff}:
      {fi-bdw-samus}:     NOTRUN -> FAIL (fdo#107360)

    {igt@pm_rpm@module-reload}:
      fi-bxt-dsi:         NOTRUN -> WARN (fdo#107602)
      {fi-icl-u}:         NOTRUN -> WARN (fdo#107602)
      {fi-bdw-samus}:     NOTRUN -> DMESG-FAIL (fdo#107603)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         DMESG-FAIL (fdo#106685, fdo#107174) -> PASS
      fi-kbl-guc:         DMESG-FAIL (fdo#106560, fdo#106947) -> PASS
      fi-bxt-j4205:       DMESG-FAIL (fdo#106560) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    
    ==== Warnings ====

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> DMESG-FAIL (fdo#107372)

    {igt@pm_rpm@module-reload}:
      fi-skl-6700k2:      FAIL -> WARN (fdo#107602)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106685 https://bugs.freedesktop.org/show_bug.cgi?id=106685
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
  fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603


== Participating hosts (52 -> 49) ==

  Additional (2): fi-icl-u fi-bdw-samus 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1727

  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1727: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1727/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1727/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib/pm_rpm: Reload the module with full mmio debugging

[Patchwork]

== Series Details ==

Series: lib/pm_rpm: Reload the module with full mmio debugging
URL   : https://patchwork.freedesktop.org/series/48390/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4604_full -> IGTPW_1727_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48390/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1727_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@debugfs-reader:
      shard-snb:          PASS -> DMESG-WARN (fdo#102365)

    igt@gem_mocs_settings@mocs-settings-bsd1:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)
      shard-glk:          PASS -> FAIL (fdo#103375)

    
    ==== Possible fixes ====

    igt@gem_mocs_settings@mocs-rc6-bsd1:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1727
    * Linux: CI_DRM_4680 -> CI_DRM_4684

  CI_DRM_4680: c0adc75a6340ba5a3f9cf07c5064627ee73b9ba9 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1727: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1727/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1727/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
 tests/pm_rpm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index e3bb6227a..91aef0889 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
 	igt_subtest("module-reload") {
 		igt_debug("Reload w/o display\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
 
 		igt_debug("Reload as normal\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load(NULL), 0);
+		igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
 		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
 			drm_resources_equal_subtest();
 		teardown_environment();
+
+		/* Remove our mmio_debugging module */
+		igt_i915_driver_unload();
 	}
 
 	igt_exit();
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Chris Wilson]

Quoting Imre Deak (2018-09-04 15:14:06)
> On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > periodically and only if they fail do a full check around every mmio
> > access. When testing for runtime pm, enable the full mmio debugging from
> > the initial load.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@intel.com>
> > ---
> >  tests/pm_rpm.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index e3bb6227a..91aef0889 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> >       igt_subtest("module-reload") {
> >               igt_debug("Reload w/o display\n");
> >               igt_i915_driver_unload();
> > -             igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > +             igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> >  
> >               igt_assert(setup_environment());
> >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> >  
> >               igt_debug("Reload as normal\n");
> >               igt_i915_driver_unload();
> > -             igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > +             igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
> 
> Could've been in hex.
-1 should work as well as INT_MAX, I was just a bit dubious about that
claim at the time. But the kernel looks to be happy enough to start
counting down from -1.

> >               igt_assert(setup_environment());
> >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> >               if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> >                       drm_resources_equal_subtest();
> >               teardown_environment();
> > +
> > +             /* Remove our mmio_debugging module */
> > +             igt_i915_driver_unload();
> 
> What loads it again?

We automatically load it upon a failed drm_driver_open(). We have a list
of modules to try and modprobe if we find no matching /dev/dri/* fd.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging

[Imre Deak]

On Tue, Sep 04, 2018 at 03:21:09PM +0100, Chris Wilson wrote:
> Quoting Imre Deak (2018-09-04 15:14:06)
> > On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > > periodically and only if they fail do a full check around every mmio
> > > access. When testing for runtime pm, enable the full mmio debugging from
> > > the initial load.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > ---
> > >  tests/pm_rpm.c | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > > index e3bb6227a..91aef0889 100644
> > > --- a/tests/pm_rpm.c
> > > +++ b/tests/pm_rpm.c
> > > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> > >       igt_subtest("module-reload") {
> > >               igt_debug("Reload w/o display\n");
> > >               igt_i915_driver_unload();
> > > -             igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > > +             igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> > >  
> > >               igt_assert(setup_environment());
> > >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> > >  
> > >               igt_debug("Reload as normal\n");
> > >               igt_i915_driver_unload();
> > > -             igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > > +             igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
> > 
> > Could've been in hex.
> -1 should work as well as INT_MAX, I was just a bit dubious about that
> claim at the time. But the kernel looks to be happy enough to start
> counting down from -1.
> 
> > >               igt_assert(setup_environment());
> > >               igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > >               if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> > >                       drm_resources_equal_subtest();
> > >               teardown_environment();
> > > +
> > > +             /* Remove our mmio_debugging module */
> > > +             igt_i915_driver_unload();
> > 
> > What loads it again?
> 
> We automatically load it upon a failed drm_driver_open(). We have a list
> of modules to try and modprobe if we find no matching /dev/dri/* fd.

Ok, missed that. Looks ok:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev