* [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging
@ 2018-08-17 10:58 Chris Wilson
2018-08-17 11:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-17 15:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-17 10:58 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
tests/pm_rpm.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index bbe36e59e..249530691 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2042,7 +2042,7 @@ int main(int argc, char *argv[])
igt_subtest("module-reload") {
igt_debug("Reload w/o display\n");
igt_i915_driver_unload();
- igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+ igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
igt_assert(setup_environment());
igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2050,13 +2050,16 @@ int main(int argc, char *argv[])
igt_debug("Reload as normal\n");
igt_i915_driver_unload();
- igt_assert_eq(igt_i915_driver_load(NULL), 0);
+ igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
igt_assert(setup_environment());
igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
drm_resources_equal_subtest();
teardown_environment();
+
+ /* Remove our mmio_debugging module */
+ igt_i915_driver_unload();
}
igt_exit();
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging
@ 2018-09-04 10:20 Chris Wilson
2018-09-04 14:14 ` [Intel-gfx] " Imre Deak
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-09-04 10:20 UTC (permalink / raw)
To: igt-dev; +Cc: intel-gfx
Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
tests/pm_rpm.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index e3bb6227a..91aef0889 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
igt_subtest("module-reload") {
igt_debug("Reload w/o display\n");
igt_i915_driver_unload();
- igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+ igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
igt_assert(setup_environment());
igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
igt_debug("Reload as normal\n");
igt_i915_driver_unload();
- igt_assert_eq(igt_i915_driver_load(NULL), 0);
+ igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
igt_assert(setup_environment());
igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
drm_resources_equal_subtest();
teardown_environment();
+
+ /* Remove our mmio_debugging module */
+ igt_i915_driver_unload();
}
igt_exit();
--
2.19.0.rc1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Intel-gfx] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging
2018-09-04 10:20 [igt-dev] [PATCH i-g-t] " Chris Wilson
@ 2018-09-04 14:14 ` Imre Deak
2018-09-04 14:21 ` [igt-dev] " Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Imre Deak @ 2018-09-04 14:14 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> Our unclaimed mmio access debugging is lazy, doing cheap checks
> periodically and only if they fail do a full check around every mmio
> access. When testing for runtime pm, enable the full mmio debugging from
> the initial load.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> ---
> tests/pm_rpm.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index e3bb6227a..91aef0889 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> igt_subtest("module-reload") {
> igt_debug("Reload w/o display\n");
> igt_i915_driver_unload();
> - igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> + igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
>
> igt_assert(setup_environment());
> igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
>
> igt_debug("Reload as normal\n");
> igt_i915_driver_unload();
> - igt_assert_eq(igt_i915_driver_load(NULL), 0);
> + igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
Could've been in hex.
>
> igt_assert(setup_environment());
> igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> drm_resources_equal_subtest();
> teardown_environment();
> +
> + /* Remove our mmio_debugging module */
> + igt_i915_driver_unload();
What loads it again?
> }
>
> igt_exit();
> --
> 2.19.0.rc1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging
2018-09-04 14:14 ` [Intel-gfx] " Imre Deak
@ 2018-09-04 14:21 ` Chris Wilson
2018-09-04 14:50 ` Imre Deak
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-09-04 14:21 UTC (permalink / raw)
To: Imre Deak; +Cc: igt-dev, intel-gfx
Quoting Imre Deak (2018-09-04 15:14:06)
> On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > periodically and only if they fail do a full check around every mmio
> > access. When testing for runtime pm, enable the full mmio debugging from
> > the initial load.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@intel.com>
> > ---
> > tests/pm_rpm.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index e3bb6227a..91aef0889 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> > igt_subtest("module-reload") {
> > igt_debug("Reload w/o display\n");
> > igt_i915_driver_unload();
> > - igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > + igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> >
> > igt_assert(setup_environment());
> > igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> >
> > igt_debug("Reload as normal\n");
> > igt_i915_driver_unload();
> > - igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > + igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
>
> Could've been in hex.
-1 should work as well as INT_MAX, I was just a bit dubious about that
claim at the time. But the kernel looks to be happy enough to start
counting down from -1.
> > igt_assert(setup_environment());
> > igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> > drm_resources_equal_subtest();
> > teardown_environment();
> > +
> > + /* Remove our mmio_debugging module */
> > + igt_i915_driver_unload();
>
> What loads it again?
We automatically load it upon a failed drm_driver_open(). We have a list
of modules to try and modprobe if we find no matching /dev/dri/* fd.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging
2018-09-04 14:21 ` [igt-dev] " Chris Wilson
@ 2018-09-04 14:50 ` Imre Deak
0 siblings, 0 replies; 6+ messages in thread
From: Imre Deak @ 2018-09-04 14:50 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Tue, Sep 04, 2018 at 03:21:09PM +0100, Chris Wilson wrote:
> Quoting Imre Deak (2018-09-04 15:14:06)
> > On Tue, Sep 04, 2018 at 11:20:04AM +0100, Chris Wilson wrote:
> > > Our unclaimed mmio access debugging is lazy, doing cheap checks
> > > periodically and only if they fail do a full check around every mmio
> > > access. When testing for runtime pm, enable the full mmio debugging from
> > > the initial load.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > ---
> > > tests/pm_rpm.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > > index e3bb6227a..91aef0889 100644
> > > --- a/tests/pm_rpm.c
> > > +++ b/tests/pm_rpm.c
> > > @@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
> > > igt_subtest("module-reload") {
> > > igt_debug("Reload w/o display\n");
> > > igt_i915_driver_unload();
> > > - igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> > > + igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=2147483647"), 0);
> > >
> > > igt_assert(setup_environment());
> > > igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > > @@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
> > >
> > > igt_debug("Reload as normal\n");
> > > igt_i915_driver_unload();
> > > - igt_assert_eq(igt_i915_driver_load(NULL), 0);
> > > + igt_assert_eq(igt_i915_driver_load("mmio_debug=2147483647"), 0);
> >
> > Could've been in hex.
> -1 should work as well as INT_MAX, I was just a bit dubious about that
> claim at the time. But the kernel looks to be happy enough to start
> counting down from -1.
>
> > > igt_assert(setup_environment());
> > > igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
> > > if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
> > > drm_resources_equal_subtest();
> > > teardown_environment();
> > > +
> > > + /* Remove our mmio_debugging module */
> > > + igt_i915_driver_unload();
> >
> > What loads it again?
>
> We automatically load it upon a failed drm_driver_open(). We have a list
> of modules to try and modprobe if we find no matching /dev/dri/* fd.
Ok, missed that. Looks ok:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-04 14:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 10:58 [igt-dev] [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging Chris Wilson
2018-08-17 11:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-17 15:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-09-04 10:20 [igt-dev] [PATCH i-g-t] " Chris Wilson
2018-09-04 14:14 ` [Intel-gfx] " Imre Deak
2018-09-04 14:21 ` [igt-dev] " Chris Wilson
2018-09-04 14:50 ` Imre Deak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).