[igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Rodrigo Vivi]

Since we block runtime PM if DMC is not loaded, let's skip
the test.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/pm_rpm.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index bbe36e59..f8442e4a 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -693,6 +693,16 @@ static void setup_pc8(void)
 	has_pc8 = true;
 }
 
+static bool dmc_loaded(void)
+{
+	char buf[15];
+
+	igt_debugfs_read(drm_fd, "i915_dmc_info", buf);
+
+	igt_info("DMC: %s\n", buf);
+	return strstr(buf, "fw loaded: yes");
+}
+
 static bool setup_environment(void)
 {
 	if (has_runtime_pm)
@@ -716,6 +726,9 @@ static bool setup_environment(void)
 	igt_info("PC8 residency support: %d\n", has_pc8);
 	igt_require(has_runtime_pm);
 
+	if (intel_gen(ms_data.devid) >= 9)
+		igt_require(dmc_loaded());
+
 out:
 	disable_all_screens(&ms_data);
 	return wait_for_suspended();
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Chris Wilson]

Quoting Rodrigo Vivi (2018-08-17 21:51:25)
> Since we block runtime PM if DMC is not loaded, let's skip
> the test.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/pm_rpm.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index bbe36e59..f8442e4a 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -693,6 +693,16 @@ static void setup_pc8(void)
>         has_pc8 = true;
>  }
>  
> +static bool dmc_loaded(void)
> +{
> +       char buf[15];
> +
> +       igt_debugfs_read(drm_fd, "i915_dmc_info", buf);

There's already a debugfs fd, so you can use

if (igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) < 0)
	return true; /* no CSR support, no DMC requirement */

You can skip the gen test as i915_dmc_info reports ENODEV for platforms
without CSR.

> +
> +       igt_info("DMC: %s\n", buf);
> +       return strstr(buf, "fw loaded: yes");
> +}
> +
>  static bool setup_environment(void)
>  {
>         if (has_runtime_pm)
> @@ -716,6 +726,9 @@ static bool setup_environment(void)
>         igt_info("PC8 residency support: %d\n", has_pc8);
>         igt_require(has_runtime_pm);
>  
> +       if (intel_gen(ms_data.devid) >= 9)
> +               igt_require(dmc_loaded());
> +
>  out:
>         disable_all_screens(&ms_data);
>         return wait_for_suspended();
> -- 
> 2.17.1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Patchwork]

== Series Details ==

Series: pm_rpm: Require DMC loaded before testing runtime_pm for gen9+
URL   : https://patchwork.freedesktop.org/series/48415/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4684 -> IGTPW_1728 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48415/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1728:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@basic-rte:
      {fi-icl-u}:         NOTRUN -> INCOMPLETE

    
== Known issues ==

  Here are the changes found in IGTPW_1728 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL (fdo#106560)
      fi-cfl-s3:          PASS -> DMESG-FAIL (fdo#106560)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    {igt@kms_psr@primary_page_flip}:
      {fi-icl-u}:         NOTRUN -> FAIL (fdo#107383) +3

    {igt@kms_psr@sprite_plane_onoff}:
      {fi-bdw-samus}:     NOTRUN -> FAIL (fdo#107360)

    {igt@pm_rpm@module-reload}:
      fi-bxt-dsi:         NOTRUN -> WARN (fdo#107602)
      {fi-bdw-samus}:     NOTRUN -> DMESG-FAIL (fdo#107603)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-guc:         DMESG-FAIL (fdo#106560, fdo#106947) -> PASS
      fi-bxt-j4205:       DMESG-FAIL (fdo#106560) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> PASS

    
    ==== Warnings ====

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> DMESG-FAIL (fdo#107372)

    {igt@pm_rpm@module-reload}:
      fi-skl-6700k2:      FAIL -> WARN (fdo#107602)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603


== Participating hosts (52 -> 49) ==

  Additional (2): fi-icl-u fi-bdw-samus 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1728

  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1728: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1728/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1728/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Rodrigo Vivi]

Since we block runtime PM if DMC is not loaded, let's skip
the test.

v2: Use i915_dmc_info presence to detect dmc requirement
    instead of gen check as Chris suggested.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/pm_rpm.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index bbe36e59..24325feb 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -693,6 +693,17 @@ static void setup_pc8(void)
 	has_pc8 = true;
 }
 
+static bool dmc_loaded(void)
+{
+	char buf[15];
+
+	if (igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf)) < 0)
+	    return true; /* no CSR support, no DMC requirement */
+
+	igt_info("DMC: %s\n", buf);
+	return strstr(buf, "fw loaded: yes");
+}
+
 static bool setup_environment(void)
 {
 	if (has_runtime_pm)
@@ -715,6 +726,7 @@ static bool setup_environment(void)
 	igt_info("Runtime PM support: %d\n", has_runtime_pm);
 	igt_info("PC8 residency support: %d\n", has_pc8);
 	igt_require(has_runtime_pm);
+	igt_require(dmc_loaded());
 
 out:
 	disable_all_screens(&ms_data);
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Chris Wilson]

Quoting Rodrigo Vivi (2018-08-17 22:13:32)
> Since we block runtime PM if DMC is not loaded, let's skip
> the test.
> 
> v2: Use i915_dmc_info presence to detect dmc requirement
>     instead of gen check as Chris suggested.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/pm_rpm.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index bbe36e59..24325feb 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -693,6 +693,17 @@ static void setup_pc8(void)
>         has_pc8 = true;
>  }
>  
> +static bool dmc_loaded(void)
> +{
> +       char buf[15];
> +
> +       if (igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf)) < 0)
> +           return true; /* no CSR support, no DMC requirement */

Hmm, I didn't mention the issue with the missing NUL byte...

char buf[16];
int len;

len = ...read(... sizeof(buf) - 1);
if (len < 0)
	return true; /*...*/

buf[len] = '\0';

Sorry,
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Rodrigo Vivi]

Since we block runtime PM if DMC is not loaded, let's skip
the test.

v2: Use i915_dmc_info presence to detect dmc requirement
    instead of gen check as Chris suggested.
v3: Add missing \0 before using buf. (Chris)

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/pm_rpm.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index bbe36e59..fa0d98dc 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -693,6 +693,21 @@ static void setup_pc8(void)
 	has_pc8 = true;
 }
 
+static bool dmc_loaded(void)
+{
+	char buf[15];
+	int len;
+
+	len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf));
+	if (len < 0)
+	    return true; /* no CSR support, no DMC requirement */
+
+	buf[len] = '\0';
+
+	igt_info("DMC: %s\n", buf);
+	return strstr(buf, "fw loaded: yes");
+}
+
 static bool setup_environment(void)
 {
 	if (has_runtime_pm)
@@ -715,6 +730,7 @@ static bool setup_environment(void)
 	igt_info("Runtime PM support: %d\n", has_runtime_pm);
 	igt_info("PC8 residency support: %d\n", has_pc8);
 	igt_require(has_runtime_pm);
+	igt_require(dmc_loaded());
 
 out:
 	disable_all_screens(&ms_data);
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Chris Wilson]

Quoting Rodrigo Vivi (2018-08-17 22:35:53)
> Since we block runtime PM if DMC is not loaded, let's skip
> the test.
> 
> v2: Use i915_dmc_info presence to detect dmc requirement
>     instead of gen check as Chris suggested.
> v3: Add missing \0 before using buf. (Chris)
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/pm_rpm.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index bbe36e59..fa0d98dc 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -693,6 +693,21 @@ static void setup_pc8(void)
>         has_pc8 = true;
>  }
>  
> +static bool dmc_loaded(void)
> +{
> +       char buf[15];
> +       int len;
> +
> +       len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf));

sizeof(buf) - 1 :)

or else len will be sizeof(buf) and buf[len] not where it belongs.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Patchwork]

== Series Details ==

Series: pm_rpm: Require DMC loaded before testing runtime_pm for gen9+
URL   : https://patchwork.freedesktop.org/series/48415/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4604_full -> IGTPW_1728_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1728_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1728_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48415/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1728_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1728_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-hsw:          PASS -> INCOMPLETE (fdo#106886, fdo#103540)
      shard-kbl:          PASS -> FAIL (fdo#106886)

    igt@gem_exec_schedule@pi-ringfull-bsd1:
      shard-kbl:          NOTRUN -> FAIL (fdo#103158)

    
    ==== Possible fixes ====

    igt@gem_mocs_settings@mocs-rc6-bsd1:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1728
    * Linux: CI_DRM_4680 -> CI_DRM_4684

  CI_DRM_4680: c0adc75a6340ba5a3f9cf07c5064627ee73b9ba9 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1728: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1728/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1728/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Chris Wilson]

Quoting Chris Wilson (2018-08-17 22:43:03)
> Quoting Rodrigo Vivi (2018-08-17 22:35:53)
> > Since we block runtime PM if DMC is not loaded, let's skip
> > the test.
> > 
> > v2: Use i915_dmc_info presence to detect dmc requirement
> >     instead of gen check as Chris suggested.
> > v3: Add missing \0 before using buf. (Chris)
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> >  tests/pm_rpm.c | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > index bbe36e59..fa0d98dc 100644
> > --- a/tests/pm_rpm.c
> > +++ b/tests/pm_rpm.c
> > @@ -693,6 +693,21 @@ static void setup_pc8(void)
> >         has_pc8 = true;
> >  }
> >  
> > +static bool dmc_loaded(void)
> > +{
> > +       char buf[15];
> > +       int len;
> > +
> > +       len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf));
> 
> sizeof(buf) - 1 :)
> 
> or else len will be sizeof(buf) and buf[len] not where it belongs.

I was debating whether or not having a big red fail was a good idea or
not, but at the end of the day it is an external failure (e.g. the user
may purposely not provide the dmc firmware).

With the final fix,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev3)

[Patchwork]

== Series Details ==

Series: pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev3)
URL   : https://patchwork.freedesktop.org/series/48415/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4684 -> IGTPW_1729 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48415/revisions/3/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1729 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_coherency:
      fi-gdg-551:         PASS -> DMESG-FAIL (fdo#107164)

    igt@drv_selftest@live_hangcheck:
      fi-cfl-s3:          PASS -> DMESG-FAIL (fdo#106560)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103191, fdo#107362)

    {igt@kms_psr@sprite_plane_onoff}:
      {fi-bdw-samus}:     NOTRUN -> FAIL (fdo#107360)

    {igt@pm_rpm@module-reload}:
      fi-bxt-dsi:         NOTRUN -> WARN (fdo#107602)
      {fi-bdw-samus}:     NOTRUN -> DMESG-FAIL (fdo#107603)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         DMESG-FAIL (fdo#106685, fdo#107174) -> PASS
      fi-kbl-guc:         DMESG-FAIL (fdo#106947, fdo#106560) -> PASS
      fi-bxt-j4205:       DMESG-FAIL (fdo#106560) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    
    ==== Warnings ====

    {igt@pm_rpm@module-reload}:
      fi-skl-6700k2:      FAIL -> WARN (fdo#107602)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106685 https://bugs.freedesktop.org/show_bug.cgi?id=106685
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
  fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603


== Participating hosts (52 -> 48) ==

  Additional (1): fi-bdw-samus 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1729

  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1729: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1729/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1729/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Rodrigo Vivi]

On Fri, Aug 17, 2018 at 11:11:54PM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-08-17 22:43:03)
> > Quoting Rodrigo Vivi (2018-08-17 22:35:53)
> > > Since we block runtime PM if DMC is not loaded, let's skip
> > > the test.
> > > 
> > > v2: Use i915_dmc_info presence to detect dmc requirement
> > >     instead of gen check as Chris suggested.
> > > v3: Add missing \0 before using buf. (Chris)
> > > 
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Imre Deak <imre.deak@intel.com>
> > > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > ---
> > >  tests/pm_rpm.c | 16 ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > > 
> > > diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> > > index bbe36e59..fa0d98dc 100644
> > > --- a/tests/pm_rpm.c
> > > +++ b/tests/pm_rpm.c
> > > @@ -693,6 +693,21 @@ static void setup_pc8(void)
> > >         has_pc8 = true;
> > >  }
> > >  
> > > +static bool dmc_loaded(void)
> > > +{
> > > +       char buf[15];
> > > +       int len;
> > > +
> > > +       len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf));
> > 
> > sizeof(buf) - 1 :)
> > 
> > or else len will be sizeof(buf) and buf[len] not where it belongs.

ops... indeed

> I was debating whether or not having a big red fail was a good idea or
> not, but at the end of the day it is an external failure (e.g. the user
> may purposely not provide the dmc firmware).

yeap... I had same line of thought myself before trying this...

> 
> With the final fix,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks for all the fixes

> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Rodrigo Vivi]

Since we block runtime PM if DMC is not loaded, let's skip
the test.

v2: Use i915_dmc_info presence to detect dmc requirement
    instead of gen check as Chris suggested.
v3: Add missing \0 before using buf. (Chris)
v4: read only 14 bytes [0:13] so buf[len] is the 15th position.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/pm_rpm.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index bbe36e59..e3bb6227 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -693,6 +693,21 @@ static void setup_pc8(void)
 	has_pc8 = true;
 }
 
+static bool dmc_loaded(void)
+{
+	char buf[15];
+	int len;
+
+	len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
+	if (len < 0)
+	    return true; /* no CSR support, no DMC requirement */
+
+	buf[len] = '\0';
+
+	igt_info("DMC: %s\n", buf);
+	return strstr(buf, "fw loaded: yes");
+}
+
 static bool setup_environment(void)
 {
 	if (has_runtime_pm)
@@ -715,6 +730,7 @@ static bool setup_environment(void)
 	igt_info("Runtime PM support: %d\n", has_runtime_pm);
 	igt_info("PC8 residency support: %d\n", has_pc8);
 	igt_require(has_runtime_pm);
+	igt_require(dmc_loaded());
 
 out:
 	disable_all_screens(&ms_data);
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev4)

[Patchwork]

== Series Details ==

Series: pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev4)
URL   : https://patchwork.freedesktop.org/series/48415/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4684 -> IGTPW_1730 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48415/revisions/4/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1730 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      {fi-cfl-8109u}:     PASS -> FAIL (fdo#103375)

    {igt@kms_psr@sprite_plane_onoff}:
      {fi-bdw-samus}:     NOTRUN -> FAIL (fdo#107360)

    {igt@pm_rpm@module-reload}:
      fi-bxt-dsi:         NOTRUN -> WARN (fdo#107602)
      {fi-bdw-samus}:     NOTRUN -> DMESG-FAIL (fdo#107603)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         DMESG-FAIL (fdo#106685, fdo#107174) -> PASS
      fi-kbl-guc:         DMESG-FAIL (fdo#106560, fdo#106947) -> PASS
      fi-bxt-j4205:       DMESG-FAIL (fdo#106560) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    
    ==== Warnings ====

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> DMESG-FAIL (fdo#107372)

    {igt@pm_rpm@module-reload}:
      fi-skl-6700k2:      FAIL -> WARN (fdo#107602)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106685 https://bugs.freedesktop.org/show_bug.cgi?id=106685
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
  fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603


== Participating hosts (52 -> 48) ==

  Additional (1): fi-bdw-samus 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1730

  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1730: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1730/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1730/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev3)

[Patchwork]

== Series Details ==

Series: pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev3)
URL   : https://patchwork.freedesktop.org/series/48415/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4604_full -> IGTPW_1729_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48415/revisions/3/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1729_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_schedule@pi-ringfull-bsd1:
      shard-kbl:          NOTRUN -> FAIL (fdo#103158)

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          NOTRUN -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@gem_wait@wait-vebox:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@gem_mocs_settings@mocs-rc6-bsd1:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#106509, fdo#105454) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1729
    * Linux: CI_DRM_4680 -> CI_DRM_4684

  CI_DRM_4680: c0adc75a6340ba5a3f9cf07c5064627ee73b9ba9 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1729: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1729/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1729/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev4)

[Patchwork]

== Series Details ==

Series: pm_rpm: Require DMC loaded before testing runtime_pm for gen9+ (rev4)
URL   : https://patchwork.freedesktop.org/series/48415/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4604_full -> IGTPW_1730_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48415/revisions/4/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1730_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_schedule@pi-ringfull-bsd1:
      shard-kbl:          NOTRUN -> FAIL (fdo#103158)

    igt@gem_sync@basic-each:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#107556, fdo#103665)

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          PASS -> FAIL (fdo#107161)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    
    ==== Possible fixes ====

    igt@gem_mocs_settings@mocs-rc6-bsd1:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107161 https://bugs.freedesktop.org/show_bug.cgi?id=107161
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4604 -> IGTPW_1730
    * Linux: CI_DRM_4680 -> CI_DRM_4684

  CI_DRM_4680: c0adc75a6340ba5a3f9cf07c5064627ee73b9ba9 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4684: bb1a6d0044581c5d8867afde39111ea4605c644d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1730: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1730/
  IGT_4604: 2a5777f8a694f1f8edcf021afb1ef36192c6762d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1730/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] pm_rpm: Require DMC loaded before testing runtime_pm for gen9+

[Rodrigo Vivi]

On Fri, Aug 17, 2018 at 04:02:14PM -0700, Rodrigo Vivi wrote:
> Since we block runtime PM if DMC is not loaded, let's skip
> the test.
> 
> v2: Use i915_dmc_info presence to detect dmc requirement
>     instead of gen check as Chris suggested.
> v3: Add missing \0 before using buf. (Chris)
> v4: read only 14 bytes [0:13] so buf[len] is the 15th position.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

pushed (without double sob). Thanks for everything.

> ---
>  tests/pm_rpm.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index bbe36e59..e3bb6227 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -693,6 +693,21 @@ static void setup_pc8(void)
>  	has_pc8 = true;
>  }
>  
> +static bool dmc_loaded(void)
> +{
> +	char buf[15];
> +	int len;
> +
> +	len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
> +	if (len < 0)
> +	    return true; /* no CSR support, no DMC requirement */
> +
> +	buf[len] = '\0';
> +
> +	igt_info("DMC: %s\n", buf);
> +	return strstr(buf, "fw loaded: yes");
> +}
> +
>  static bool setup_environment(void)
>  {
>  	if (has_runtime_pm)
> @@ -715,6 +730,7 @@ static bool setup_environment(void)
>  	igt_info("Runtime PM support: %d\n", has_runtime_pm);
>  	igt_info("PC8 residency support: %d\n", has_pc8);
>  	igt_require(has_runtime_pm);
> +	igt_require(dmc_loaded());
>  
>  out:
>  	disable_all_screens(&ms_data);
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev