Re: [igt-dev] [PATCH v4 10/13] chamelium: Change our pattern for a custom one

Maxime Ripard
2018-08-24T08:00:17Z

[-- Attachment #1.1: Type: text/plain, Size: 1399 bytes --]

Hi Eric,

On Thu, Aug 09, 2018 at 02:31:50PM -0700, Eric Anholt wrote:
> Maxime Ripard <maxime.ripard@bootlin.com> writes:
>
> > The current pattern being used is the one generated through the
> > igt_create_color_pattern_fb.
> >
> > However, in order to deal with multiple formats and the upsampling /
> > downsampling issues that might arise from converting back and forth between
> > formats, we will need to have a pattern with quite precise color values,
> > and without any shades or gradient of colors.
>
> 64x64 blocks of color seem pretty limited, and might miss tiling issues
> for people -- would the previous pattern be worth using for 1:1,
> possibly non-format-converted cases?

I've changed it to use the previous pattern if we have the same depth
(and therefore won't have any up/down sampling issues).

> > The easiest way to do that will be to only use values that would have the
> > same part on the common most significant bits (5, to deal with the most
> > formats) and have the same bit repeated on the least significant bits that
> > are going to be dropped and / or padded when converting between formats.
> >
> > Pixman will fill the lowest bits with 1, and our hardware is able to
>
> Let's specify which hardware here :)

ACK :)

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]