* [igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware
@ 2018-08-30 7:19 Dhinakaran Pandiyan
2018-08-30 16:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-30 7:19 UTC (permalink / raw)
To: igt-dev; +Cc: Dhinakaran Pandiyan
CI runs show PSR tests failing on the recently added BDW (fi-bdw-samus), it
makes sense to enable these tests when we know they are expected to pass.
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
tests/kms_psr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/kms_psr.c b/tests/kms_psr.c
index 218b3960..52b71826 100644
--- a/tests/kms_psr.c
+++ b/tests/kms_psr.c
@@ -411,6 +411,7 @@ int main(int argc, char *argv[])
data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
kmstest_set_vt_graphics_mode();
data.devid = intel_get_drm_devid(data.drm_fd);
+ igt_require(AT_LEAST_GEN(data.devid, 9));
igt_set_module_param_int("enable_psr", data.with_psr_disabled ?
0 : 1);
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/psr: Skip kms_psr on pre-Gen9 hardware
2018-08-30 7:19 [igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware Dhinakaran Pandiyan
@ 2018-08-30 16:27 ` Patchwork
2018-08-30 18:30 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
2018-08-30 22:06 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-08-30 16:27 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: igt-dev
== Series Details ==
Series: tests/psr: Skip kms_psr on pre-Gen9 hardware
URL : https://patchwork.freedesktop.org/series/48920/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4737 -> IGTPW_1757 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48920/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1757:
=== IGT changes ===
==== Warnings ====
{igt@kms_psr@cursor_plane_move}:
{fi-bdw-samus}: PASS -> SKIP +2
== Known issues ==
Here are the changes found in IGTPW_1757 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
{fi-byt-clapper}: PASS -> FAIL (fdo#103191, fdo#107362)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@kms_pipe_crc_basic@read-crc-pipe-a:
{fi-byt-clapper}: FAIL (fdo#107362) -> PASS
{igt@kms_psr@sprite_plane_onoff}:
{fi-bdw-samus}: FAIL (fdo#107360) -> SKIP
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (53 -> 49) ==
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
== Build changes ==
* IGT: IGT_4611 -> IGTPW_1757
CI_DRM_4737: c8fe77635992b1f6b32102657faced7c9165c942 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1757: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1757/
IGT_4611: b966dd93a30f41581fe1dbf9bc1c4a29b552ca05 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1757/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware
2018-08-30 7:19 [igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware Dhinakaran Pandiyan
2018-08-30 16:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-08-30 18:30 ` Rodrigo Vivi
2018-08-30 19:50 ` Dhinakaran Pandiyan
2018-08-30 22:06 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Rodrigo Vivi @ 2018-08-30 18:30 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: igt-dev, Dhinakaran Pandiyan
On Thu, Aug 30, 2018 at 12:19:56AM -0700, Dhinakaran Pandiyan wrote:
> CI runs show PSR tests failing on the recently added BDW (fi-bdw-samus), it
> makes sense to enable these tests when we know they are expected to pass.
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> tests/kms_psr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> index 218b3960..52b71826 100644
> --- a/tests/kms_psr.c
> +++ b/tests/kms_psr.c
> @@ -411,6 +411,7 @@ int main(int argc, char *argv[])
> data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
> kmstest_set_vt_graphics_mode();
> data.devid = intel_get_drm_devid(data.drm_fd);
> + igt_require(AT_LEAST_GEN(data.devid, 9));
oh! I liked this macro... why don't we have the same on kernel side? :)
but as we talked in pvt I don't like the approach. I prefer that
we keep honest and transparent of the issues that we have on previous
gens.
Also we have the visibility if any change we make targeting gen9
is not possibly fixing or causing even more troubles on older gens.
Thanks,
Rodrigo.
>
> igt_set_module_param_int("enable_psr", data.with_psr_disabled ?
> 0 : 1);
> --
> 2.17.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware
2018-08-30 18:30 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
@ 2018-08-30 19:50 ` Dhinakaran Pandiyan
0 siblings, 0 replies; 5+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-30 19:50 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: igt-dev
On Thu, 2018-08-30 at 11:30 -0700, Rodrigo Vivi wrote:
> On Thu, Aug 30, 2018 at 12:19:56AM -0700, Dhinakaran Pandiyan wrote:
> > CI runs show PSR tests failing on the recently added BDW (fi-bdw-
> > samus), it
> > makes sense to enable these tests when we know they are expected to
> > pass.
> >
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> > tests/kms_psr.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> > index 218b3960..52b71826 100644
> > --- a/tests/kms_psr.c
> > +++ b/tests/kms_psr.c
> > @@ -411,6 +411,7 @@ int main(int argc, char *argv[])
> > data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
> > kmstest_set_vt_graphics_mode();
> > data.devid = intel_get_drm_devid(data.drm_fd);
> > + igt_require(AT_LEAST_GEN(data.devid, 9));
>
> oh! I liked this macro... why don't we have the same on kernel side?
> :)
>
> but as we talked in pvt I don't like the approach. I prefer that
> we keep honest and transparent of the issues that we have on previous
> gens.
>
> Also we have the visibility if any change we make targeting gen9
> is not possibly fixing or causing even more troubles on older gens.
>
Fair enough, dropping this patch.
Thanks
DK
> Thanks,
> Rodrigo.
>
> >
> > igt_set_module_param_int("enable_psr",
> > data.with_psr_disabled ?
> > 0 : 1);
> > --
> > 2.17.1
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/psr: Skip kms_psr on pre-Gen9 hardware
2018-08-30 7:19 [igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware Dhinakaran Pandiyan
2018-08-30 16:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-30 18:30 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
@ 2018-08-30 22:06 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-08-30 22:06 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: igt-dev
== Series Details ==
Series: tests/psr: Skip kms_psr on pre-Gen9 hardware
URL : https://patchwork.freedesktop.org/series/48920/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4611_full -> IGTPW_1757_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1757_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1757_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48920/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1757_full:
=== IGT changes ===
==== Warnings ====
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in IGTPW_1757_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: PASS -> INCOMPLETE (fdo#106023, fdo#103665)
igt@kms_frontbuffer_tracking@basic:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@perf@blocking:
shard-hsw: PASS -> FAIL (fdo#102252)
igt@testdisplay:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359, fdo#107093)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
shard-kbl: DMESG-FAIL (fdo#106947, fdo#106560) -> PASS
igt@gem_render_copy_redux@normal:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106650) -> PASS
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-kbl: INCOMPLETE (fdo#103665, fdo#107556) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#103925) -> PASS
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106650 https://bugs.freedesktop.org/show_bug.cgi?id=106650
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4611 -> IGTPW_1757
* Linux: CI_DRM_4715 -> CI_DRM_4737
CI_DRM_4715: 1b73a69651beab39192502181c83e77a1022014a @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4737: c8fe77635992b1f6b32102657faced7c9165c942 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1757: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1757/
IGT_4611: b966dd93a30f41581fe1dbf9bc1c4a29b552ca05 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1757/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-30 22:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-30 7:19 [igt-dev] [PATCH i-g-t] tests/psr: Skip kms_psr on pre-Gen9 hardware Dhinakaran Pandiyan
2018-08-30 16:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-30 18:30 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
2018-08-30 19:50 ` Dhinakaran Pandiyan
2018-08-30 22:06 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).