[igt-dev] [PATCH i-g-t v2] lib/drmtest: Move open device to separate function

[igt-dev] [PATCH i-g-t v2] lib/drmtest: Move open device to separate function

[Katarzyna Dec]

While working on IGT code and during reviewes I've noticed that
it could be nice to have function that is opening particular device.
Let's move out conditions for opening device and rename __open_device
to __search_and_open() function.

v2: Refactored open_device even more by getting device name once and
returning fd for it. (Chris)

Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/drmtest.c | 82 ++++++++++++++++++++++++++++-----------------------
 1 file changed, 45 insertions(+), 37 deletions(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index fae6f86f..ca1669a1 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -218,38 +218,58 @@ static void modprobe_i915(const char *name)
 	igt_i915_driver_load(NULL);
 }
 
-static int __open_device(const char *base, int offset, unsigned int chipset)
+static const struct module {
+		unsigned int bit;
+		const char *module;
+		void (*modprobe)(const char *name);
+	} modules[] = {
+		{ DRIVER_AMDGPU, "amdgpu" },
+		{ DRIVER_INTEL, "i915", modprobe_i915 },
+		{ DRIVER_VC4, "vc4" },
+		{ DRIVER_VGEM, "vgem" },
+		{ DRIVER_VIRTIO, "virtio-gpu" },
+		{}
+	};
+
+static int open_device(const char *name, unsigned int chipset)
 {
-	for (int i = 0; i < 16; i++) {
-		char name[80];
-		int fd;
+	int fd;
+	char dev_name[16] = "";
+	int chip = DRIVER_ANY;
 
-		sprintf(name, "%s%u", base, i + offset);
-		fd = open(name, O_RDWR);
-		if (fd == -1)
-			continue;
+	fd = open(name, O_RDWR);
+	if (fd == -1)
+		return -1;
 
-		if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
-		    has_known_intel_chipset(fd))
-			return fd;
+	if (__get_drm_device_name(fd, dev_name) == -1)
+		return -1;
 
-		if (chipset & DRIVER_VC4 && is_vc4_device(fd))
-			return fd;
+	for (const struct module *m = modules; m->module; m++) {
+		if (strcmp(m->module, dev_name) == 0) {
+			chip = m->bit;
+			break;
+		}
+	}
+	if (chipset & chip)
+		return fd;
 
-		if (chipset & DRIVER_VGEM && is_vgem_device(fd))
-			return fd;
+	close(fd);
 
-		if (chipset & DRIVER_VIRTIO && is_virtio_device(fd))
-			return fd;
+	return -1;
+}
 
-		if (chipset & DRIVER_AMDGPU && is_amd_device(fd))
-			return fd;
+static int __search_and_open(const char *base, int offset, unsigned int chipset)
+{
+	for (int i = 0; i < 16; i++) {
+		char name[80];
+		int fd;
 
-		/* Only VGEM-specific tests should be run on VGEM */
-		if (chipset == DRIVER_ANY && !is_vgem_device(fd))
+		sprintf(name, "%s%u", base, i + offset);
+		fd = open_device(name, chipset);
+		if (fd == -1)
+			continue;
+		else
 			return fd;
-
-		close(fd);
 	}
 
 	return -1;
@@ -258,21 +278,9 @@ static int __open_device(const char *base, int offset, unsigned int chipset)
 static int __open_driver(const char *base, int offset, unsigned int chipset)
 {
 	static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
-	static const struct module {
-		unsigned int bit;
-		const char *module;
-		void (*modprobe)(const char *name);
-	} modules[] = {
-		{ DRIVER_AMDGPU, "amdgpu" },
-		{ DRIVER_INTEL, "i915", modprobe_i915 },
-		{ DRIVER_VC4, "vc4" },
-		{ DRIVER_VGEM, "vgem" },
-		{ DRIVER_VIRTIO, "virtio-gpu" },
-		{}
-	};
 	int fd;
 
-	fd = __open_device(base, offset, chipset);
+	fd = __search_and_open(base, offset, chipset);
 	if (fd != -1)
 		return fd;
 
@@ -287,7 +295,7 @@ static int __open_driver(const char *base, int offset, unsigned int chipset)
 	}
 	pthread_mutex_unlock(&mutex);
 
-	return __open_device(base, offset, chipset);
+	return __search_and_open(base, offset, chipset);
 }
 
 /**
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/drmtest: Move open device to separate function

[Chris Wilson]

Quoting Katarzyna Dec (2018-08-31 11:41:15)
> While working on IGT code and during reviewes I've noticed that
> it could be nice to have function that is opening particular device.
> Let's move out conditions for opening device and rename __open_device
> to __search_and_open() function.
> 
> v2: Refactored open_device even more by getting device name once and
> returning fd for it. (Chris)

You get to remove all the unused is_X_device() as well.
Pass sizeof(name)-1 into __get_drm_device_name();
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/drmtest: Move open device to separate function

[Katarzyna Dec]

On Fri, Aug 31, 2018 at 11:47:19AM +0100, Chris Wilson wrote:
> Quoting Katarzyna Dec (2018-08-31 11:41:15)
> > While working on IGT code and during reviewes I've noticed that
> > it could be nice to have function that is opening particular device.
> > Let's move out conditions for opening device and rename __open_device
> > to __search_and_open() function.
> > 
> > v2: Refactored open_device even more by getting device name once and
> > returning fd for it. (Chris)
> 
> You get to remove all the unused is_X_device() as well.
> Pass sizeof(name)-1 into __get_drm_device_name();
> -Chris

Good point! Fixed that.
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v3] lib/drmtest: Move open device to separate function

[Katarzyna Dec]

While working on IGT code and during reviewes I've noticed that
it could be nice to have function that is opening particular device.
Let's move out conditions for opening device and rename __open_device
to __search_and_open() function.

v2: Refactored open_device even more by getting device name once and
returning fd for it. (Chris)
v3: Added name_size to __get_drm_device_name.

Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/drmtest.c | 108 ++++++++++++++++++++++----------------------------
 1 file changed, 48 insertions(+), 60 deletions(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index fae6f86f..d2c7a332 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -77,12 +77,12 @@
 
 uint16_t __drm_device_id;
 
-static int __get_drm_device_name(int fd, char *name)
+static int __get_drm_device_name(int fd, char *name, int name_size)
 {
 	drm_version_t version;
 
 	memset(&version, 0, sizeof(version));
-	version.name_len = 4;
+	version.name_len = name_size;
 	version.name = name;
 
 	if (!drmIoctl(fd, DRM_IOCTL_VERSION, &version)){
@@ -96,7 +96,7 @@ static bool __is_device(int fd, const char *expect)
 {
 	char name[5] = "";
 
-	if (__get_drm_device_name(fd, name))
+	if (__get_drm_device_name(fd, name, 4))
 		return false;
 
 	return strcmp(expect, name) == 0;
@@ -107,26 +107,6 @@ bool is_i915_device(int fd)
 	return __is_device(fd, "i915");
 }
 
-static bool is_vc4_device(int fd)
-{
-	return __is_device(fd, "vc4");
-}
-
-static bool is_vgem_device(int fd)
-{
-	return __is_device(fd, "vgem");
-}
-
-static bool is_virtio_device(int fd)
-{
-	return __is_device(fd, "virt");
-}
-
-static bool is_amd_device(int fd)
-{
-	return __is_device(fd, "amdg");
-}
-
 static bool has_known_intel_chipset(int fd)
 {
 	struct drm_i915_getparam gp;
@@ -218,38 +198,58 @@ static void modprobe_i915(const char *name)
 	igt_i915_driver_load(NULL);
 }
 
-static int __open_device(const char *base, int offset, unsigned int chipset)
+static const struct module {
+		unsigned int bit;
+		const char *module;
+		void (*modprobe)(const char *name);
+	} modules[] = {
+		{ DRIVER_AMDGPU, "amdgpu" },
+		{ DRIVER_INTEL, "i915", modprobe_i915 },
+		{ DRIVER_VC4, "vc4" },
+		{ DRIVER_VGEM, "vgem" },
+		{ DRIVER_VIRTIO, "virtio-gpu" },
+		{}
+	};
+
+static int open_device(const char *name, unsigned int chipset)
 {
-	for (int i = 0; i < 16; i++) {
-		char name[80];
-		int fd;
+	int fd;
+	char dev_name[16] = "";
+	int chip = DRIVER_ANY;
 
-		sprintf(name, "%s%u", base, i + offset);
-		fd = open(name, O_RDWR);
-		if (fd == -1)
-			continue;
+	fd = open(name, O_RDWR);
+	if (fd == -1)
+		return -1;
 
-		if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
-		    has_known_intel_chipset(fd))
-			return fd;
+	if (__get_drm_device_name(fd, dev_name, (sizeof(dev_name) - 1)) == -1)
+		return -1;
 
-		if (chipset & DRIVER_VC4 && is_vc4_device(fd))
-			return fd;
+	for (const struct module *m = modules; m->module; m++) {
+		if (strcmp(m->module, dev_name) == 0) {
+			chip = m->bit;
+			break;
+		}
+	}
+	if (chipset & chip)
+		return fd;
 
-		if (chipset & DRIVER_VGEM && is_vgem_device(fd))
-			return fd;
+	close(fd);
 
-		if (chipset & DRIVER_VIRTIO && is_virtio_device(fd))
-			return fd;
+	return -1;
+}
 
-		if (chipset & DRIVER_AMDGPU && is_amd_device(fd))
-			return fd;
+static int __search_and_open(const char *base, int offset, unsigned int chipset)
+{
+	for (int i = 0; i < 16; i++) {
+		char name[80];
+		int fd;
 
-		/* Only VGEM-specific tests should be run on VGEM */
-		if (chipset == DRIVER_ANY && !is_vgem_device(fd))
+		sprintf(name, "%s%u", base, i + offset);
+		fd = open_device(name, chipset);
+		if (fd == -1)
+			continue;
+		else
 			return fd;
-
-		close(fd);
 	}
 
 	return -1;
@@ -258,21 +258,9 @@ static int __open_device(const char *base, int offset, unsigned int chipset)
 static int __open_driver(const char *base, int offset, unsigned int chipset)
 {
 	static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
-	static const struct module {
-		unsigned int bit;
-		const char *module;
-		void (*modprobe)(const char *name);
-	} modules[] = {
-		{ DRIVER_AMDGPU, "amdgpu" },
-		{ DRIVER_INTEL, "i915", modprobe_i915 },
-		{ DRIVER_VC4, "vc4" },
-		{ DRIVER_VGEM, "vgem" },
-		{ DRIVER_VIRTIO, "virtio-gpu" },
-		{}
-	};
 	int fd;
 
-	fd = __open_device(base, offset, chipset);
+	fd = __search_and_open(base, offset, chipset);
 	if (fd != -1)
 		return fd;
 
@@ -287,7 +275,7 @@ static int __open_driver(const char *base, int offset, unsigned int chipset)
 	}
 	pthread_mutex_unlock(&mutex);
 
-	return __open_device(base, offset, chipset);
+	return __search_and_open(base, offset, chipset);
 }
 
 /**
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3] lib/drmtest: Move open device to separate function

[Petri Latvala]

On Fri, Aug 31, 2018 at 01:00:49PM +0200, Katarzyna Dec wrote:
> While working on IGT code and during reviewes I've noticed that
> it could be nice to have function that is opening particular device.
> Let's move out conditions for opening device and rename __open_device
> to __search_and_open() function.
> 
> v2: Refactored open_device even more by getting device name once and
> returning fd for it. (Chris)
> v3: Added name_size to __get_drm_device_name.
> 
> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---



This breaks opening virtio_gpu.


-- 
Petri Latvala






>  lib/drmtest.c | 108 ++++++++++++++++++++++----------------------------
>  1 file changed, 48 insertions(+), 60 deletions(-)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index fae6f86f..d2c7a332 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -77,12 +77,12 @@
>  
>  uint16_t __drm_device_id;
>  
> -static int __get_drm_device_name(int fd, char *name)
> +static int __get_drm_device_name(int fd, char *name, int name_size)
>  {
>  	drm_version_t version;
>  
>  	memset(&version, 0, sizeof(version));
> -	version.name_len = 4;
> +	version.name_len = name_size;
>  	version.name = name;
>  
>  	if (!drmIoctl(fd, DRM_IOCTL_VERSION, &version)){
> @@ -96,7 +96,7 @@ static bool __is_device(int fd, const char *expect)
>  {
>  	char name[5] = "";
>  
> -	if (__get_drm_device_name(fd, name))
> +	if (__get_drm_device_name(fd, name, 4))
>  		return false;
>  
>  	return strcmp(expect, name) == 0;
> @@ -107,26 +107,6 @@ bool is_i915_device(int fd)
>  	return __is_device(fd, "i915");
>  }
>  
> -static bool is_vc4_device(int fd)
> -{
> -	return __is_device(fd, "vc4");
> -}
> -
> -static bool is_vgem_device(int fd)
> -{
> -	return __is_device(fd, "vgem");
> -}
> -
> -static bool is_virtio_device(int fd)
> -{
> -	return __is_device(fd, "virt");
> -}
> -
> -static bool is_amd_device(int fd)
> -{
> -	return __is_device(fd, "amdg");
> -}
> -
>  static bool has_known_intel_chipset(int fd)
>  {
>  	struct drm_i915_getparam gp;
> @@ -218,38 +198,58 @@ static void modprobe_i915(const char *name)
>  	igt_i915_driver_load(NULL);
>  }
>  
> -static int __open_device(const char *base, int offset, unsigned int chipset)
> +static const struct module {
> +		unsigned int bit;
> +		const char *module;
> +		void (*modprobe)(const char *name);
> +	} modules[] = {
> +		{ DRIVER_AMDGPU, "amdgpu" },
> +		{ DRIVER_INTEL, "i915", modprobe_i915 },
> +		{ DRIVER_VC4, "vc4" },
> +		{ DRIVER_VGEM, "vgem" },
> +		{ DRIVER_VIRTIO, "virtio-gpu" },
> +		{}
> +	};
> +
> +static int open_device(const char *name, unsigned int chipset)
>  {
> -	for (int i = 0; i < 16; i++) {
> -		char name[80];
> -		int fd;
> +	int fd;
> +	char dev_name[16] = "";
> +	int chip = DRIVER_ANY;
>  
> -		sprintf(name, "%s%u", base, i + offset);
> -		fd = open(name, O_RDWR);
> -		if (fd == -1)
> -			continue;
> +	fd = open(name, O_RDWR);
> +	if (fd == -1)
> +		return -1;
>  
> -		if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
> -		    has_known_intel_chipset(fd))
> -			return fd;
> +	if (__get_drm_device_name(fd, dev_name, (sizeof(dev_name) - 1)) == -1)
> +		return -1;
>  
> -		if (chipset & DRIVER_VC4 && is_vc4_device(fd))
> -			return fd;
> +	for (const struct module *m = modules; m->module; m++) {
> +		if (strcmp(m->module, dev_name) == 0) {
> +			chip = m->bit;
> +			break;
> +		}
> +	}
> +	if (chipset & chip)
> +		return fd;
>  
> -		if (chipset & DRIVER_VGEM && is_vgem_device(fd))
> -			return fd;
> +	close(fd);
>  
> -		if (chipset & DRIVER_VIRTIO && is_virtio_device(fd))
> -			return fd;
> +	return -1;
> +}
>  
> -		if (chipset & DRIVER_AMDGPU && is_amd_device(fd))
> -			return fd;
> +static int __search_and_open(const char *base, int offset, unsigned int chipset)
> +{
> +	for (int i = 0; i < 16; i++) {
> +		char name[80];
> +		int fd;
>  
> -		/* Only VGEM-specific tests should be run on VGEM */
> -		if (chipset == DRIVER_ANY && !is_vgem_device(fd))
> +		sprintf(name, "%s%u", base, i + offset);
> +		fd = open_device(name, chipset);
> +		if (fd == -1)
> +			continue;
> +		else
>  			return fd;
> -
> -		close(fd);
>  	}
>  
>  	return -1;
> @@ -258,21 +258,9 @@ static int __open_device(const char *base, int offset, unsigned int chipset)
>  static int __open_driver(const char *base, int offset, unsigned int chipset)
>  {
>  	static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
> -	static const struct module {
> -		unsigned int bit;
> -		const char *module;
> -		void (*modprobe)(const char *name);
> -	} modules[] = {
> -		{ DRIVER_AMDGPU, "amdgpu" },
> -		{ DRIVER_INTEL, "i915", modprobe_i915 },
> -		{ DRIVER_VC4, "vc4" },
> -		{ DRIVER_VGEM, "vgem" },
> -		{ DRIVER_VIRTIO, "virtio-gpu" },
> -		{}
> -	};
>  	int fd;
>  
> -	fd = __open_device(base, offset, chipset);
> +	fd = __search_and_open(base, offset, chipset);
>  	if (fd != -1)
>  		return fd;
>  
> @@ -287,7 +275,7 @@ static int __open_driver(const char *base, int offset, unsigned int chipset)
>  	}
>  	pthread_mutex_unlock(&mutex);
>  
> -	return __open_device(base, offset, chipset);
> +	return __search_and_open(base, offset, chipset);
>  }
>  
>  /**
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3] lib/drmtest: Move open device to separate function

[Katarzyna Dec]

On Fri, Aug 31, 2018 at 02:51:08PM +0300, Petri Latvala wrote:
> On Fri, Aug 31, 2018 at 01:00:49PM +0200, Katarzyna Dec wrote:
> > While working on IGT code and during reviewes I've noticed that
> > it could be nice to have function that is opening particular device.
> > Let's move out conditions for opening device and rename __open_device
> > to __search_and_open() function.
> > 
> > v2: Refactored open_device even more by getting device name once and
> > returning fd for it. (Chris)
> > v3: Added name_size to __get_drm_device_name.
> > 
> > Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> 
> 
> 
> This breaks opening virtio_gpu.
> 
> 
> -- 
> Petri Latvala
> 
I will look at that.
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v3] lib/drmtest: Move open device to separate function

[Chris Wilson]

Quoting Petri Latvala (2018-08-31 12:51:08)
> On Fri, Aug 31, 2018 at 01:00:49PM +0200, Katarzyna Dec wrote:
> > While working on IGT code and during reviewes I've noticed that
> > it could be nice to have function that is opening particular device.
> > Let's move out conditions for opening device and rename __open_device
> > to __search_and_open() function.
> > 
> > v2: Refactored open_device even more by getting device name once and
> > returning fd for it. (Chris)
> > v3: Added name_size to __get_drm_device_name.
> > 
> > Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> 
> 
> 
> This breaks opening virtio_gpu.

Of course they needed to be different and have distinct names for their
module and driver.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t v4] lib/drmtest: Move open device to separate function

[Katarzyna Dec]

While working on IGT code and during reviewes I've noticed that
it could be nice to have function that is opening particular device.
Let's move out conditions for opening device and rename __open_device
to __search_and_open() function.

v2: Refactored open_device even more by getting device name once and
returning fd for it. (Chris)
v3: Added name_size to __get_drm_device_name, removed unused is_X_device.
v4: Fixed cases with failing virtio_gpu

Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 lib/drmtest.c | 109 +++++++++++++++++++++++---------------------------
 1 file changed, 49 insertions(+), 60 deletions(-)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index fae6f86f..dda629ed 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -77,12 +77,12 @@
 
 uint16_t __drm_device_id;
 
-static int __get_drm_device_name(int fd, char *name)
+static int __get_drm_device_name(int fd, char *name, int name_size)
 {
 	drm_version_t version;
 
 	memset(&version, 0, sizeof(version));
-	version.name_len = 4;
+	version.name_len = name_size;
 	version.name = name;
 
 	if (!drmIoctl(fd, DRM_IOCTL_VERSION, &version)){
@@ -96,7 +96,7 @@ static bool __is_device(int fd, const char *expect)
 {
 	char name[5] = "";
 
-	if (__get_drm_device_name(fd, name))
+	if (__get_drm_device_name(fd, name, 4))
 		return false;
 
 	return strcmp(expect, name) == 0;
@@ -107,26 +107,6 @@ bool is_i915_device(int fd)
 	return __is_device(fd, "i915");
 }
 
-static bool is_vc4_device(int fd)
-{
-	return __is_device(fd, "vc4");
-}
-
-static bool is_vgem_device(int fd)
-{
-	return __is_device(fd, "vgem");
-}
-
-static bool is_virtio_device(int fd)
-{
-	return __is_device(fd, "virt");
-}
-
-static bool is_amd_device(int fd)
-{
-	return __is_device(fd, "amdg");
-}
-
 static bool has_known_intel_chipset(int fd)
 {
 	struct drm_i915_getparam gp;
@@ -218,38 +198,59 @@ static void modprobe_i915(const char *name)
 	igt_i915_driver_load(NULL);
 }
 
-static int __open_device(const char *base, int offset, unsigned int chipset)
+static const struct module {
+		unsigned int bit;
+		const char *module;
+		void (*modprobe)(const char *name);
+	} modules[] = {
+		{ DRIVER_AMDGPU, "amdgpu" },
+		{ DRIVER_INTEL, "i915", modprobe_i915 },
+		{ DRIVER_VC4, "vc4" },
+		{ DRIVER_VGEM, "vgem" },
+		{ DRIVER_VIRTIO, "virtio-gpu" },
+		{ DRIVER_VIRTIO, "virtio_gpu" },
+		{}
+	};
+
+static int open_device(const char *name, unsigned int chipset)
 {
-	for (int i = 0; i < 16; i++) {
-		char name[80];
-		int fd;
+	int fd;
+	char dev_name[16] = "";
+	int chip = DRIVER_ANY;
 
-		sprintf(name, "%s%u", base, i + offset);
-		fd = open(name, O_RDWR);
-		if (fd == -1)
-			continue;
+	fd = open(name, O_RDWR);
+	if (fd == -1)
+		return -1;
 
-		if (chipset & DRIVER_INTEL && is_i915_device(fd) &&
-		    has_known_intel_chipset(fd))
-			return fd;
+	if (__get_drm_device_name(fd, dev_name, (sizeof(dev_name) - 1)) == -1)
+		return -1;
 
-		if (chipset & DRIVER_VC4 && is_vc4_device(fd))
-			return fd;
+	for (const struct module *m = modules; m->module; m++) {
+		if (strcmp(m->module, dev_name) == 0) {
+			chip = m->bit;
+			break;
+		}
+	}
+	if (chipset & chip)
+		return fd;
 
-		if (chipset & DRIVER_VGEM && is_vgem_device(fd))
-			return fd;
+	close(fd);
 
-		if (chipset & DRIVER_VIRTIO && is_virtio_device(fd))
-			return fd;
+	return -1;
+}
 
-		if (chipset & DRIVER_AMDGPU && is_amd_device(fd))
-			return fd;
+static int __search_and_open(const char *base, int offset, unsigned int chipset)
+{
+	for (int i = 0; i < 16; i++) {
+		char name[80];
+		int fd;
 
-		/* Only VGEM-specific tests should be run on VGEM */
-		if (chipset == DRIVER_ANY && !is_vgem_device(fd))
+		sprintf(name, "%s%u", base, i + offset);
+		fd = open_device(name, chipset);
+		if (fd == -1)
+			continue;
+		else
 			return fd;
-
-		close(fd);
 	}
 
 	return -1;
@@ -258,21 +259,9 @@ static int __open_device(const char *base, int offset, unsigned int chipset)
 static int __open_driver(const char *base, int offset, unsigned int chipset)
 {
 	static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
-	static const struct module {
-		unsigned int bit;
-		const char *module;
-		void (*modprobe)(const char *name);
-	} modules[] = {
-		{ DRIVER_AMDGPU, "amdgpu" },
-		{ DRIVER_INTEL, "i915", modprobe_i915 },
-		{ DRIVER_VC4, "vc4" },
-		{ DRIVER_VGEM, "vgem" },
-		{ DRIVER_VIRTIO, "virtio-gpu" },
-		{}
-	};
 	int fd;
 
-	fd = __open_device(base, offset, chipset);
+	fd = __search_and_open(base, offset, chipset);
 	if (fd != -1)
 		return fd;
 
@@ -287,7 +276,7 @@ static int __open_driver(const char *base, int offset, unsigned int chipset)
 	}
 	pthread_mutex_unlock(&mutex);
 
-	return __open_device(base, offset, chipset);
+	return __search_and_open(base, offset, chipset);
 }
 
 /**
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/drmtest: Move open device to separate function (rev2)

[Patchwork]

== Series Details ==

Series: lib/drmtest: Move open device to separate function (rev2)
URL   : https://patchwork.freedesktop.org/series/48929/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4748 -> IGTPW_1762 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1762 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1762, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48929/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1762:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_getparams_basic@basic-subslice-total:
      fi-snb-2600:        PASS -> FAIL +36
      fi-bdw-5557u:       PASS -> FAIL +26
      fi-bwr-2160:        PASS -> FAIL +31
      fi-kbl-7560u:       PASS -> FAIL +31
      fi-cfl-s3:          PASS -> FAIL +29

    igt@drv_module_reload@basic-reload:
      fi-skl-guc:         PASS -> FAIL +25
      fi-kbl-x1275:       PASS -> FAIL +17
      fi-bxt-dsi:         NOTRUN -> FAIL +7

    igt@gem_exec_store@basic-all:
      {fi-kbl-soraka}:    PASS -> FAIL +7

    igt@gem_exec_store@basic-blt:
      {fi-skl-caroline}:  PASS -> FAIL +7

    igt@gem_exec_store@basic-bsd:
      {fi-bdw-samus}:     PASS -> FAIL +26
      {fi-cfl-8109u}:     PASS -> FAIL +23
      fi-byt-n2820:       PASS -> FAIL +22

    igt@gem_exec_store@basic-bsd1:
      fi-kbl-r:           SKIP -> FAIL +1
      fi-whl-u:           SKIP -> FAIL +1
      fi-skl-6600u:       SKIP -> FAIL +1
      fi-cfl-s3:          SKIP -> FAIL +1
      {fi-kbl-soraka}:    SKIP -> FAIL +1
      {fi-skl-caroline}:  SKIP -> FAIL +1
      fi-cnl-psr:         SKIP -> FAIL +1

    igt@gem_exec_store@basic-bsd2:
      fi-hsw-4770:        SKIP -> FAIL +6
      fi-bxt-dsi:         SKIP -> FAIL +1
      fi-snb-2520m:       SKIP -> FAIL +17
      fi-cfl-8700k:       SKIP -> FAIL +5
      fi-kbl-7500u:       SKIP -> FAIL +5
      fi-skl-6700hq:      SKIP -> FAIL +1

    igt@gem_exec_store@basic-default:
      fi-bdw-gvtdvm:      PASS -> FAIL +23
      fi-ivb-3770:        PASS -> FAIL +24
      fi-skl-gvtdvm:      PASS -> FAIL +24

    igt@gem_exec_store@basic-vebox:
      fi-byt-j1900:       SKIP -> FAIL +13
      fi-snb-2600:        SKIP -> FAIL +17

    igt@gem_mmap_gtt@basic-small-bo:
      fi-kbl-7500u:       PASS -> FAIL +25
      fi-hsw-4770:        PASS -> FAIL +28

    igt@gem_mmap_gtt@basic-small-bo-tiledy:
      fi-kbl-7567u:       PASS -> FAIL +27
      fi-gdg-551:         SKIP -> FAIL +18
      fi-kbl-guc:         PASS -> FAIL +18

    igt@gem_mmap_gtt@basic-small-copy:
      fi-hsw-peppy:       PASS -> FAIL +23

    igt@gem_mmap_gtt@basic-small-copy-xy:
      fi-bxt-j4205:       PASS -> FAIL +25

    igt@gem_tiled_pread_basic:
      fi-cfl-8700k:       PASS -> FAIL +25
      fi-cnl-psr:         PASS -> FAIL +27

    igt@kms_addfb_basic@addfb25-y-tiled:
      fi-kbl-r:           PASS -> FAIL +29
      fi-whl-u:           PASS -> FAIL +29

    igt@kms_addfb_basic@addfb25-y-tiled-small:
      {fi-bdw-samus}:     SKIP -> FAIL +2
      fi-bdw-5557u:       SKIP -> FAIL +4
      fi-byt-n2820:       SKIP -> FAIL +7
      fi-ivb-3770:        SKIP -> FAIL +10
      fi-bsw-n3050:       SKIP -> FAIL +6

    igt@kms_addfb_basic@addfb25-yf-tiled:
      fi-gdg-551:         PASS -> FAIL +15
      {fi-kbl-8809g}:     PASS -> FAIL +18
      {fi-byt-clapper}:   PASS -> FAIL +22

    igt@kms_flip@basic-flip-vs-dpms:
      fi-ilk-650:         PASS -> FAIL +23
      fi-pnv-d510:        PASS -> FAIL +21
      fi-skl-6770hq:      PASS -> FAIL +27

    igt@kms_flip@basic-flip-vs-modeset:
      fi-kbl-x1275:       SKIP -> FAIL +11
      fi-blb-e6850:       PASS -> FAIL +21

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-icl-u:           PASS -> FAIL +21
      fi-skl-6260u:       PASS -> FAIL +27
      fi-hsw-4770r:       PASS -> FAIL +24

    igt@kms_flip@basic-plain-flip:
      fi-skl-6700k2:      PASS -> FAIL +25
      fi-cfl-guc:         PASS -> FAIL +25

    igt@kms_force_connector_basic@force-edid:
      fi-snb-2520m:       PASS -> FAIL +36

    igt@kms_frontbuffer_tracking@basic:
      fi-bsw-n3050:       PASS -> FAIL +23
      {fi-bsw-kefka}:     PASS -> FAIL +23
      fi-bxt-dsi:         PASS -> FAIL +21

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-ivb-3520m:       PASS -> FAIL +43

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
      fi-elk-e7500:       PASS -> FAIL +35

    igt@kms_pipe_crc_basic@read-crc-pipe-c:
      fi-bwr-2160:        SKIP -> FAIL +22

    {igt@kms_psr@cursor_plane_move}:
      fi-skl-6260u:       SKIP -> FAIL +3
      fi-hsw-4770r:       SKIP -> FAIL +6
      fi-glk-j4005:       SKIP -> FAIL +5
      fi-ivb-3520m:       SKIP -> FAIL +10
      fi-bxt-j4205:       SKIP -> FAIL +5

    {igt@kms_psr@primary_mmap_gtt}:
      fi-skl-guc:         SKIP -> FAIL +5
      fi-kbl-guc:         SKIP -> FAIL +11
      {fi-byt-clapper}:   SKIP -> FAIL +7
      fi-cfl-guc:         SKIP -> FAIL +5

    {igt@kms_psr@primary_page_flip}:
      fi-hsw-peppy:       SKIP -> FAIL +6
      fi-kbl-7567u:       SKIP -> FAIL +3
      {fi-skl-iommu}:     SKIP -> FAIL +5
      fi-skl-6700k2:      SKIP -> FAIL +5

    {igt@kms_psr@sprite_plane_onoff}:
      fi-skl-6700hq:      PASS -> FAIL +29
      {fi-bsw-kefka}:     SKIP -> FAIL +6
      fi-skl-6770hq:      SKIP -> FAIL +3

    igt@pm_rpm@basic-pci-d3-state:
      fi-skl-6600u:       PASS -> FAIL +29
      fi-pnv-d510:        SKIP -> FAIL +13
      fi-byt-j1900:       PASS -> FAIL +39
      {fi-kbl-8809g}:     SKIP -> FAIL +11

    igt@pm_rpm@basic-rte:
      {fi-skl-iommu}:     PASS -> FAIL +25
      fi-glk-j4005:       PASS -> FAIL +24
      fi-skl-gvtdvm:      SKIP -> FAIL +6
      fi-elk-e7500:       SKIP -> FAIL +18
      fi-ilk-650:         SKIP -> FAIL +11
      fi-bdw-gvtdvm:      SKIP -> FAIL +7
      fi-icl-u:           SKIP -> FAIL +5

    {igt@pm_rpm@module-reload}:
      fi-blb-e6850:       SKIP -> FAIL +13

    
    ==== Warnings ====

    {igt@amdgpu/amd_prime@i915-to-amd}:
      {fi-kbl-8809g}:     PASS -> SKIP

    {igt@pm_rpm@module-reload}:
      {fi-bsw-kefka}:     DMESG-WARN (fdo#107704) -> FAIL
      {fi-byt-clapper}:   WARN (fdo#107602, fdo#107708) -> FAIL
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> FAIL
      fi-hsw-peppy:       DMESG-WARN (fdo#107603) -> FAIL
      fi-kbl-x1275:       WARN (fdo#107602, fdo#107708) -> FAIL
      {fi-bdw-samus}:     DMESG-WARN (fdo#107603) -> FAIL
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> FAIL
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> FAIL
      fi-glk-j4005:       WARN (fdo#107602, fdo#107708) -> FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1762 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      {fi-cfl-8109u}:     PASS -> INCOMPLETE (fdo#106070)

    
    ==== Possible fixes ====

    {igt@amdgpu/amd_prime@amd-to-i915}:
      {fi-kbl-8809g}:     FAIL (fdo#107341) -> SKIP

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708


== Participating hosts (53 -> 48) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4613 -> IGTPW_1762

  CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1762: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1762/
  IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1762/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/drmtest: Move open device to separate function (rev3)

[Patchwork]

== Series Details ==

Series: lib/drmtest: Move open device to separate function (rev3)
URL   : https://patchwork.freedesktop.org/series/48929/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4748 -> IGTPW_1763 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1763 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1763, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48929/revisions/3/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1763:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_getparams_basic@basic-subslice-total:
      fi-snb-2600:        PASS -> FAIL +36
      fi-bdw-5557u:       PASS -> FAIL +26
      fi-bwr-2160:        PASS -> FAIL +31
      fi-kbl-7560u:       PASS -> FAIL +31
      fi-cfl-s3:          PASS -> FAIL +29

    igt@drv_module_reload@basic-reload:
      fi-skl-guc:         PASS -> FAIL +25
      fi-kbl-x1275:       PASS -> FAIL +17

    igt@gem_exec_store@basic-all:
      {fi-kbl-soraka}:    PASS -> FAIL +7

    igt@gem_exec_store@basic-blt:
      {fi-skl-caroline}:  PASS -> FAIL +7

    igt@gem_exec_store@basic-bsd:
      {fi-bdw-samus}:     PASS -> FAIL +26
      {fi-cfl-8109u}:     PASS -> FAIL +27
      fi-byt-n2820:       PASS -> FAIL +22

    igt@gem_exec_store@basic-bsd1:
      fi-kbl-r:           SKIP -> FAIL +1
      fi-whl-u:           SKIP -> FAIL +1
      fi-skl-6600u:       SKIP -> FAIL +1
      fi-cfl-s3:          SKIP -> FAIL +1
      {fi-kbl-soraka}:    SKIP -> FAIL +1
      {fi-skl-caroline}:  SKIP -> FAIL +1
      fi-cnl-psr:         SKIP -> FAIL +1

    igt@gem_exec_store@basic-bsd2:
      fi-hsw-4770:        SKIP -> FAIL +6
      fi-bxt-dsi:         SKIP -> FAIL +1
      fi-snb-2520m:       SKIP -> FAIL +17
      fi-cfl-8700k:       SKIP -> FAIL +5
      fi-kbl-7500u:       SKIP -> FAIL +5
      fi-skl-6700hq:      SKIP -> FAIL +1

    igt@gem_exec_store@basic-default:
      fi-bdw-gvtdvm:      PASS -> FAIL +23
      fi-ivb-3770:        PASS -> FAIL +24
      fi-skl-gvtdvm:      PASS -> FAIL +24

    igt@gem_exec_store@basic-vebox:
      fi-byt-j1900:       SKIP -> FAIL +13
      fi-snb-2600:        SKIP -> FAIL +17
      fi-blb-e6850:       SKIP -> FAIL +6

    igt@gem_mmap_gtt@basic-small-bo:
      fi-kbl-7500u:       PASS -> FAIL +25
      fi-hsw-4770:        PASS -> FAIL +28

    igt@gem_mmap_gtt@basic-small-bo-tiledy:
      fi-kbl-7567u:       PASS -> FAIL +27
      fi-gdg-551:         SKIP -> FAIL +18
      fi-kbl-guc:         PASS -> FAIL +18

    igt@gem_mmap_gtt@basic-small-copy:
      fi-hsw-peppy:       PASS -> FAIL +23

    igt@gem_mmap_gtt@basic-small-copy-xy:
      fi-bxt-j4205:       PASS -> FAIL +25

    igt@gem_tiled_pread_basic:
      fi-cfl-8700k:       PASS -> FAIL +25
      fi-cnl-psr:         PASS -> FAIL +27

    igt@kms_addfb_basic@addfb25-y-tiled:
      fi-kbl-r:           PASS -> FAIL +29
      fi-whl-u:           PASS -> FAIL +29

    igt@kms_addfb_basic@addfb25-y-tiled-small:
      {fi-bdw-samus}:     SKIP -> FAIL +2
      fi-bdw-5557u:       SKIP -> FAIL +4
      fi-byt-n2820:       SKIP -> FAIL +7
      fi-ivb-3770:        SKIP -> FAIL +10
      fi-bsw-n3050:       SKIP -> FAIL +6

    igt@kms_addfb_basic@addfb25-yf-tiled:
      fi-gdg-551:         PASS -> FAIL +15
      {fi-kbl-8809g}:     PASS -> FAIL +18
      {fi-byt-clapper}:   PASS -> FAIL +22

    igt@kms_flip@basic-flip-vs-dpms:
      fi-ilk-650:         PASS -> FAIL +23
      fi-pnv-d510:        PASS -> FAIL +21
      fi-skl-6770hq:      PASS -> FAIL +27

    igt@kms_flip@basic-flip-vs-modeset:
      fi-kbl-x1275:       SKIP -> FAIL +11
      fi-blb-e6850:       PASS -> FAIL +20

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-icl-u:           PASS -> FAIL +21
      fi-skl-6260u:       PASS -> FAIL +27
      fi-hsw-4770r:       PASS -> FAIL +24

    igt@kms_flip@basic-plain-flip:
      fi-skl-6700k2:      PASS -> FAIL +25
      fi-cfl-guc:         PASS -> FAIL +25

    igt@kms_force_connector_basic@force-edid:
      fi-snb-2520m:       PASS -> FAIL +36

    igt@kms_frontbuffer_tracking@basic:
      fi-bsw-n3050:       PASS -> FAIL +23
      {fi-bsw-kefka}:     PASS -> FAIL +23
      fi-bxt-dsi:         PASS -> FAIL +21

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-ivb-3520m:       PASS -> FAIL +43

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
      fi-elk-e7500:       PASS -> FAIL +35

    igt@kms_pipe_crc_basic@read-crc-pipe-c:
      fi-bwr-2160:        SKIP -> FAIL +22

    {igt@kms_psr@cursor_plane_move}:
      fi-skl-6260u:       SKIP -> FAIL +3
      fi-hsw-4770r:       SKIP -> FAIL +6
      fi-glk-j4005:       SKIP -> FAIL +5
      fi-ivb-3520m:       SKIP -> FAIL +10
      fi-bxt-j4205:       SKIP -> FAIL +5

    {igt@kms_psr@primary_mmap_gtt}:
      fi-skl-guc:         SKIP -> FAIL +5
      fi-kbl-guc:         SKIP -> FAIL +11
      {fi-cfl-8109u}:     SKIP -> FAIL +3
      {fi-byt-clapper}:   SKIP -> FAIL +7
      fi-cfl-guc:         SKIP -> FAIL +5

    {igt@kms_psr@primary_page_flip}:
      fi-hsw-peppy:       SKIP -> FAIL +6
      fi-kbl-7567u:       SKIP -> FAIL +3
      {fi-skl-iommu}:     SKIP -> FAIL +5
      fi-skl-6700k2:      SKIP -> FAIL +5

    {igt@kms_psr@sprite_plane_onoff}:
      fi-skl-6700hq:      PASS -> FAIL +29
      {fi-bsw-kefka}:     SKIP -> FAIL +6
      fi-skl-6770hq:      SKIP -> FAIL +3

    igt@pm_rpm@basic-pci-d3-state:
      fi-skl-6600u:       PASS -> FAIL +29
      fi-pnv-d510:        SKIP -> FAIL +13
      fi-byt-j1900:       PASS -> FAIL +39
      {fi-kbl-8809g}:     SKIP -> FAIL +11

    igt@pm_rpm@basic-rte:
      {fi-skl-iommu}:     PASS -> FAIL +25
      fi-glk-j4005:       PASS -> FAIL +24
      fi-skl-gvtdvm:      SKIP -> FAIL +6
      fi-elk-e7500:       SKIP -> FAIL +18
      fi-ilk-650:         SKIP -> FAIL +11
      fi-bdw-gvtdvm:      SKIP -> FAIL +7
      fi-icl-u:           SKIP -> FAIL +5

    
    ==== Warnings ====

    {igt@pm_rpm@module-reload}:
      {fi-bsw-kefka}:     DMESG-WARN (fdo#107704) -> FAIL
      {fi-byt-clapper}:   WARN (fdo#107708, fdo#107602) -> FAIL
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> FAIL
      fi-hsw-peppy:       DMESG-WARN (fdo#107603) -> FAIL
      fi-kbl-x1275:       WARN (fdo#107708, fdo#107602) -> FAIL
      {fi-bdw-samus}:     DMESG-WARN (fdo#107603) -> FAIL
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> FAIL
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> FAIL
      fi-glk-j4005:       WARN (fdo#107708, fdo#107602) -> FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1763 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    {igt@amdgpu/amd_basic@userptr}:
      {fi-kbl-8809g}:     PASS -> INCOMPLETE (fdo#107402)

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103191, fdo#107362)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (53 -> 48) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4613 -> IGTPW_1763

  CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1763: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1763/
  IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1763/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/drmtest: Move open device to separate function (rev4)

[Patchwork]

== Series Details ==

Series: lib/drmtest: Move open device to separate function (rev4)
URL   : https://patchwork.freedesktop.org/series/48929/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4748 -> IGTPW_1765 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1765 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1765, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48929/revisions/4/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1765:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_getparams_basic@basic-subslice-total:
      fi-snb-2600:        PASS -> FAIL +36
      fi-bdw-5557u:       PASS -> FAIL +26
      fi-bwr-2160:        PASS -> FAIL +31
      fi-kbl-7560u:       PASS -> FAIL +31
      fi-cfl-s3:          PASS -> FAIL +29

    igt@drv_module_reload@basic-reload:
      fi-skl-guc:         PASS -> FAIL +25
      fi-kbl-x1275:       PASS -> FAIL +17
      fi-bxt-dsi:         NOTRUN -> FAIL +7

    igt@gem_exec_store@basic-blt:
      {fi-skl-caroline}:  PASS -> FAIL +7

    igt@gem_exec_store@basic-bsd:
      {fi-bdw-samus}:     PASS -> FAIL +26
      {fi-cfl-8109u}:     PASS -> FAIL +27
      fi-byt-n2820:       PASS -> FAIL +22

    igt@gem_exec_store@basic-bsd1:
      fi-kbl-r:           SKIP -> FAIL +1
      fi-whl-u:           SKIP -> FAIL +1
      fi-skl-6600u:       SKIP -> FAIL +1
      fi-cfl-s3:          SKIP -> FAIL +1
      {fi-skl-caroline}:  SKIP -> FAIL +1
      fi-cnl-psr:         SKIP -> FAIL +1

    igt@gem_exec_store@basic-bsd2:
      fi-hsw-4770:        SKIP -> FAIL +6
      fi-bxt-dsi:         SKIP -> FAIL +1
      fi-snb-2520m:       SKIP -> FAIL +17
      fi-cfl-8700k:       SKIP -> FAIL +5
      fi-kbl-7500u:       SKIP -> FAIL +5
      fi-skl-6700hq:      SKIP -> FAIL +1

    igt@gem_exec_store@basic-default:
      fi-bdw-gvtdvm:      PASS -> FAIL +23
      fi-ivb-3770:        PASS -> FAIL +24
      fi-skl-gvtdvm:      PASS -> FAIL +24

    igt@gem_exec_store@basic-vebox:
      fi-byt-j1900:       SKIP -> FAIL +13
      fi-snb-2600:        SKIP -> FAIL +17

    igt@gem_mmap_gtt@basic-small-bo:
      fi-kbl-7500u:       PASS -> FAIL +25
      fi-hsw-4770:        PASS -> FAIL +28

    igt@gem_mmap_gtt@basic-small-bo-tiledy:
      fi-kbl-7567u:       PASS -> FAIL +27
      fi-gdg-551:         SKIP -> FAIL +18
      fi-kbl-guc:         PASS -> FAIL +18

    igt@gem_mmap_gtt@basic-small-copy:
      fi-hsw-peppy:       PASS -> FAIL +23

    igt@gem_mmap_gtt@basic-small-copy-xy:
      fi-bxt-j4205:       PASS -> FAIL +25

    igt@gem_tiled_pread_basic:
      fi-cfl-8700k:       PASS -> FAIL +25
      fi-cnl-psr:         PASS -> FAIL +27

    igt@kms_addfb_basic@addfb25-y-tiled:
      fi-kbl-r:           PASS -> FAIL +29
      fi-whl-u:           PASS -> FAIL +29

    igt@kms_addfb_basic@addfb25-y-tiled-small:
      {fi-bdw-samus}:     SKIP -> FAIL +2
      fi-bdw-5557u:       SKIP -> FAIL +4
      fi-byt-n2820:       SKIP -> FAIL +7
      fi-ivb-3770:        SKIP -> FAIL +10
      fi-bsw-n3050:       SKIP -> FAIL +6

    igt@kms_addfb_basic@addfb25-yf-tiled:
      fi-gdg-551:         PASS -> FAIL +15
      {fi-kbl-8809g}:     PASS -> FAIL +18
      {fi-byt-clapper}:   PASS -> FAIL +22

    igt@kms_flip@basic-flip-vs-dpms:
      fi-ilk-650:         PASS -> FAIL +23
      fi-pnv-d510:        PASS -> FAIL +21
      fi-skl-6770hq:      PASS -> FAIL +27

    igt@kms_flip@basic-flip-vs-modeset:
      fi-kbl-x1275:       SKIP -> FAIL +11
      fi-blb-e6850:       PASS -> FAIL +21

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-icl-u:           PASS -> FAIL +21
      fi-skl-6260u:       PASS -> FAIL +27
      fi-hsw-4770r:       PASS -> FAIL +24

    igt@kms_flip@basic-plain-flip:
      fi-skl-6700k2:      PASS -> FAIL +25
      fi-cfl-guc:         PASS -> FAIL +25

    igt@kms_force_connector_basic@force-edid:
      fi-snb-2520m:       PASS -> FAIL +36

    igt@kms_frontbuffer_tracking@basic:
      fi-bsw-n3050:       PASS -> FAIL +23
      {fi-bsw-kefka}:     PASS -> FAIL +23
      fi-bxt-dsi:         PASS -> FAIL +21

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-ivb-3520m:       PASS -> FAIL +43

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
      fi-elk-e7500:       PASS -> FAIL +35

    igt@kms_pipe_crc_basic@read-crc-pipe-c:
      fi-bwr-2160:        SKIP -> FAIL +22

    {igt@kms_psr@cursor_plane_move}:
      fi-skl-6260u:       SKIP -> FAIL +3
      fi-hsw-4770r:       SKIP -> FAIL +6
      fi-glk-j4005:       SKIP -> FAIL +5
      fi-ivb-3520m:       SKIP -> FAIL +10
      fi-bxt-j4205:       SKIP -> FAIL +5

    {igt@kms_psr@primary_mmap_gtt}:
      fi-skl-guc:         SKIP -> FAIL +5
      fi-kbl-guc:         SKIP -> FAIL +11
      {fi-cfl-8109u}:     SKIP -> FAIL +3
      {fi-byt-clapper}:   SKIP -> FAIL +7
      fi-cfl-guc:         SKIP -> FAIL +5

    {igt@kms_psr@primary_page_flip}:
      fi-hsw-peppy:       SKIP -> FAIL +6
      fi-kbl-7567u:       SKIP -> FAIL +3
      {fi-skl-iommu}:     SKIP -> FAIL +5
      fi-skl-6700k2:      SKIP -> FAIL +5

    {igt@kms_psr@sprite_plane_onoff}:
      fi-skl-6700hq:      PASS -> FAIL +29
      {fi-bsw-kefka}:     SKIP -> FAIL +6
      fi-skl-6770hq:      SKIP -> FAIL +3

    igt@pm_rpm@basic-pci-d3-state:
      fi-skl-6600u:       PASS -> FAIL +29
      fi-pnv-d510:        SKIP -> FAIL +13
      fi-byt-j1900:       PASS -> FAIL +39
      {fi-kbl-8809g}:     SKIP -> FAIL +11

    igt@pm_rpm@basic-rte:
      {fi-skl-iommu}:     PASS -> FAIL +25
      fi-glk-j4005:       PASS -> FAIL +24
      fi-skl-gvtdvm:      SKIP -> FAIL +6
      fi-elk-e7500:       SKIP -> FAIL +18
      fi-ilk-650:         SKIP -> FAIL +11
      fi-bdw-gvtdvm:      SKIP -> FAIL +7
      fi-icl-u:           SKIP -> FAIL +5

    {igt@pm_rpm@module-reload}:
      fi-blb-e6850:       SKIP -> FAIL +13

    
    ==== Warnings ====

    {igt@pm_rpm@module-reload}:
      {fi-bsw-kefka}:     DMESG-WARN (fdo#107704) -> FAIL
      {fi-byt-clapper}:   WARN (fdo#107708, fdo#107602) -> FAIL
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> FAIL
      fi-hsw-peppy:       DMESG-WARN (fdo#107603) -> FAIL
      fi-kbl-x1275:       WARN (fdo#107708, fdo#107602) -> FAIL
      {fi-bdw-samus}:     DMESG-WARN (fdo#107603) -> FAIL
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> FAIL
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> FAIL
      fi-glk-j4005:       WARN (fdo#107708, fdo#107602) -> FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1765 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103191, fdo#107362)

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#107362)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708


== Participating hosts (53 -> 47) ==

  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4613 -> IGTPW_1765

  CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1765: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1765/
  IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1765/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for lib/drmtest: Move open device to separate function (rev2)

[Patchwork]

== Series Details ==

Series: lib/drmtest: Move open device to separate function (rev2)
URL   : https://patchwork.freedesktop.org/series/48929/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4613_full -> IGTPW_1762_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1762_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1762_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48929/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1762_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_schedule@preempt-other-chain-blt:
      shard-snb:          SKIP -> FAIL +790

    igt@gem_exec_schedule@preempt-other-render:
      shard-glk:          NOTRUN -> FAIL +35

    igt@gem_exec_schedule@preempt-queue-contexts-render:
      shard-glk:          PASS -> FAIL +572

    igt@gem_exec_schedule@promotion-bsd2:
      shard-kbl:          NOTRUN -> FAIL +1

    igt@kms_chv_cursor_fail@pipe-b-256x256-top-edge:
      shard-hsw:          PASS -> FAIL +479

    igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled:
      shard-snb:          NOTRUN -> FAIL +1

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-apl:          SKIP -> FAIL +549

    igt@kms_flip@bo-too-big-interruptible:
      shard-snb:          PASS -> FAIL +276

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-kbl:          PASS -> FAIL +554

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
      shard-glk:          SKIP -> FAIL +435

    igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
      shard-kbl:          SKIP -> FAIL +510

    igt@kms_plane_lowres@pipe-b-tiling-yf:
      shard-hsw:          SKIP -> FAIL +600

    igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
      shard-apl:          PASS -> FAIL +528

    
    ==== Warnings ====

    igt@kms_mmap_write_crc:
      shard-snb:          PASS -> SKIP +1
      shard-apl:          PASS -> SKIP +1
      shard-hsw:          PASS -> SKIP

    igt@kms_pwrite_crc:
      shard-kbl:          PASS -> SKIP +1
      shard-glk:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1762_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_await@wide-contexts:
      shard-apl:          PASS -> FAIL (fdo#105900, fdo#106680)

    igt@gem_exec_big:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@rcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#107556) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4613 -> IGTPW_1762
    * Linux: CI_DRM_4746 -> CI_DRM_4748

  CI_DRM_4746: 4d881b165d4f1a75cc8ff09223f0501c26de814f @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1762: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1762/
  IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1762/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for lib/drmtest: Move open device to separate function (rev3)

[Patchwork]

== Series Details ==

Series: lib/drmtest: Move open device to separate function (rev3)
URL   : https://patchwork.freedesktop.org/series/48929/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4613_full -> IGTPW_1763_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1763_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1763_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48929/revisions/3/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1763_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_schedule@preempt-other-chain-blt:
      shard-snb:          SKIP -> FAIL +801

    igt@gem_exec_schedule@preempt-other-render:
      shard-glk:          NOTRUN -> FAIL +32

    igt@gem_exec_schedule@preempt-queue-contexts-render:
      shard-glk:          PASS -> FAIL +567

    igt@gem_exec_schedule@promotion-bsd2:
      shard-kbl:          NOTRUN -> FAIL +1

    igt@kms_chv_cursor_fail@pipe-b-256x256-top-edge:
      shard-hsw:          PASS -> FAIL +483

    igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled:
      shard-snb:          NOTRUN -> FAIL +1

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-apl:          SKIP -> FAIL +549

    igt@kms_flip@bo-too-big-interruptible:
      shard-snb:          PASS -> FAIL +278

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-kbl:          PASS -> FAIL +547

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
      shard-glk:          SKIP -> FAIL +429

    igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
      shard-kbl:          SKIP -> FAIL +507

    igt@kms_plane_lowres@pipe-b-tiling-yf:
      shard-hsw:          SKIP -> FAIL +606

    igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
      shard-apl:          PASS -> FAIL +528

    
    ==== Warnings ====

    igt@kms_mmap_write_crc:
      shard-glk:          PASS -> SKIP +1
      shard-snb:          PASS -> SKIP +1
      shard-apl:          PASS -> SKIP +1
      shard-hsw:          PASS -> SKIP +1

    igt@kms_pwrite_crc:
      shard-kbl:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in IGTPW_1763_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@debugfs-reader:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@drv_suspend@shrink:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106886)
      shard-glk:          PASS -> FAIL (fdo#106886)

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@rcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#107556) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-snb:          INCOMPLETE (fdo#106887, fdo#105411) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4613 -> IGTPW_1763
    * Linux: CI_DRM_4746 -> CI_DRM_4748

  CI_DRM_4746: 4d881b165d4f1a75cc8ff09223f0501c26de814f @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1763: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1763/
  IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1763/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for lib/drmtest: Move open device to separate function (rev4)

[Patchwork]

== Series Details ==

Series: lib/drmtest: Move open device to separate function (rev4)
URL   : https://patchwork.freedesktop.org/series/48929/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4613_full -> IGTPW_1765_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1765_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1765_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48929/revisions/4/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1765_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_schedule@preempt-other-chain-blt:
      shard-snb:          SKIP -> FAIL +800

    igt@gem_exec_schedule@preempt-other-render:
      shard-glk:          NOTRUN -> FAIL +34

    igt@gem_exec_schedule@preempt-queue-contexts-render:
      shard-glk:          PASS -> FAIL +562

    igt@gem_exec_schedule@promotion-bsd2:
      shard-kbl:          NOTRUN -> FAIL +1

    igt@kms_chv_cursor_fail@pipe-b-256x256-top-edge:
      shard-hsw:          PASS -> FAIL +479

    igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled:
      shard-snb:          NOTRUN -> FAIL +1

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-apl:          SKIP -> FAIL +549

    igt@kms_flip@bo-too-big-interruptible:
      shard-snb:          PASS -> FAIL +278

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-kbl:          PASS -> FAIL +558

    igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
      shard-glk:          SKIP -> FAIL +429

    igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
      shard-kbl:          SKIP -> FAIL +520

    igt@kms_plane_lowres@pipe-b-tiling-yf:
      shard-hsw:          SKIP -> FAIL +595

    igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
      shard-apl:          PASS -> FAIL +528

    
    ==== Warnings ====

    igt@kms_mmap_write_crc:
      shard-glk:          PASS -> SKIP +1
      shard-snb:          PASS -> SKIP +1
      shard-apl:          PASS -> SKIP +1
      shard-hsw:          PASS -> SKIP +1

    igt@kms_pwrite_crc:
      shard-kbl:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in IGTPW_1765_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540, fdo#106886)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    igt@perf_pmu@busy-hang-bcs0:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@rcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#107556, fdo#103665) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-snb:          INCOMPLETE (fdo#105411, fdo#106887) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4613 -> IGTPW_1765
    * Linux: CI_DRM_4746 -> CI_DRM_4748

  CI_DRM_4746: 4d881b165d4f1a75cc8ff09223f0501c26de814f @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1765: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1765/
  IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1765/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev