* [igt-dev] [PATCH i-g-t] tests/kms_vblank: Test if we have functional rpm before testing
@ 2018-08-31 13:08 Chris Wilson
2018-08-31 13:30 ` Imre Deak
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2018-08-31 13:08 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
We want to test that provoking a vblank interrupt works correctly after
waking up from runtime-pm. First though, we must wait for the device to
enter runtime-suspend. If the device cannot, e.g. we haven't enabled the
DMC firmware, the test should skip because our external requirements are
not met.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107768
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
tests/kms_vblank.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index 508c0fa03..b3cd2d93c 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -352,7 +352,7 @@ static void vblank_ts_cont(data_t *data, int fd, int nchildren)
}
if (data->flags & RPM)
- igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+ igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
if (data->flags & SUSPEND)
igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
--
2.19.0.rc1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [igt-dev] [PATCH i-g-t] tests/kms_vblank: Test if we have functional rpm before testing
2018-08-31 13:08 [igt-dev] [PATCH i-g-t] tests/kms_vblank: Test if we have functional rpm before testing Chris Wilson
@ 2018-08-31 13:30 ` Imre Deak
2018-08-31 13:32 ` Imre Deak
2018-08-31 13:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-31 18:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2018-08-31 13:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Fri, Aug 31, 2018 at 02:08:13PM +0100, Chris Wilson wrote:
> We want to test that provoking a vblank interrupt works correctly after
> waking up from runtime-pm. First though, we must wait for the device to
> enter runtime-suspend. If the device cannot, e.g. we haven't enabled the
> DMC firmware, the test should skip because our external requirements are
> not met.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107768
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> tests/kms_vblank.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 508c0fa03..b3cd2d93c 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -352,7 +352,7 @@ static void vblank_ts_cont(data_t *data, int fd, int nchildren)
> }
>
> if (data->flags & RPM)
> - igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> + igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
>
> if (data->flags & SUSPEND)
> igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> --
> 2.19.0.rc1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_vblank: Test if we have functional rpm before testing
2018-08-31 13:30 ` Imre Deak
@ 2018-08-31 13:32 ` Imre Deak
0 siblings, 0 replies; 5+ messages in thread
From: Imre Deak @ 2018-08-31 13:32 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev, intel-gfx
On Fri, Aug 31, 2018 at 04:30:31PM +0300, Imre Deak wrote:
> On Fri, Aug 31, 2018 at 02:08:13PM +0100, Chris Wilson wrote:
> > We want to test that provoking a vblank interrupt works correctly after
> > waking up from runtime-pm. First though, we must wait for the device to
> > enter runtime-suspend. If the device cannot, e.g. we haven't enabled the
> > DMC firmware, the test should skip because our external requirements are
> > not met.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107768
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@intel.com>
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
I mean
Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> > ---
> > tests/kms_vblank.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> > index 508c0fa03..b3cd2d93c 100644
> > --- a/tests/kms_vblank.c
> > +++ b/tests/kms_vblank.c
> > @@ -352,7 +352,7 @@ static void vblank_ts_cont(data_t *data, int fd, int nchildren)
> > }
> >
> > if (data->flags & RPM)
> > - igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> > + igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> >
> > if (data->flags & SUSPEND)
> > igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> > --
> > 2.19.0.rc1
> >
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_vblank: Test if we have functional rpm before testing
2018-08-31 13:08 [igt-dev] [PATCH i-g-t] tests/kms_vblank: Test if we have functional rpm before testing Chris Wilson
2018-08-31 13:30 ` Imre Deak
@ 2018-08-31 13:36 ` Patchwork
2018-08-31 18:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-08-31 13:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: tests/kms_vblank: Test if we have functional rpm before testing
URL : https://patchwork.freedesktop.org/series/49008/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4748 -> IGTPW_1766 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49008/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1766 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
{fi-byt-clapper}: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-cnl-psr: PASS -> DMESG-WARN (fdo#104951)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ilk-650: PASS -> DMESG-WARN (fdo#106387)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: FAIL (fdo#107336) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
== Participating hosts (53 -> 48) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* IGT: IGT_4613 -> IGTPW_1766
CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1766: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1766/
IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1766/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_vblank: Test if we have functional rpm before testing
2018-08-31 13:08 [igt-dev] [PATCH i-g-t] tests/kms_vblank: Test if we have functional rpm before testing Chris Wilson
2018-08-31 13:30 ` Imre Deak
2018-08-31 13:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-08-31 18:49 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-08-31 18:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: tests/kms_vblank: Test if we have functional rpm before testing
URL : https://patchwork.freedesktop.org/series/49008/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4613_full -> IGTPW_1766_full =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1766_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1766_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49008/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1766_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled:
shard-glk: PASS -> FAIL
==== Warnings ====
igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1766_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: PASS -> FAIL (fdo#103355)
igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +18
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-b-ts-continuation-suspend:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@perf_pmu@init-sema-rcs0:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
==== Possible fixes ====
igt@gem_ctx_isolation@rcs0-s3:
shard-kbl: INCOMPLETE (fdo#107556, fdo#103665) -> PASS
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-snb: INCOMPLETE (fdo#105411, fdo#106887) -> PASS
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106887 https://bugs.freedesktop.org/show_bug.cgi?id=106887
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4613 -> IGTPW_1766
* Linux: CI_DRM_4746 -> CI_DRM_4748
CI_DRM_4746: 4d881b165d4f1a75cc8ff09223f0501c26de814f @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1766: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1766/
IGT_4613: 3f89d7b02dcf662e994c7135b13d52bc8e09a4ea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1766/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-31 18:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-31 13:08 [igt-dev] [PATCH i-g-t] tests/kms_vblank: Test if we have functional rpm before testing Chris Wilson
2018-08-31 13:30 ` Imre Deak
2018-08-31 13:32 ` Imre Deak
2018-08-31 13:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-31 18:49 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).