[igt-dev] [PATCH i-g-t] lib: Squelch warning for failing to enable audio powermanagement

[igt-dev] [PATCH i-g-t] lib: Squelch warning for failing to enable audio powermanagement

[Chris Wilson]

It doesn't seem to be preventing rpm (see the pm_rpm tests) if we fail
to enable runtime-powermanagement for audio, so reduce the warning to a
debug. It will still be visible if it fails, but only if it fails.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 lib/igt_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 339a51e6f..b1f359d8b 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -260,7 +260,7 @@ void igt_pm_enable_audio_runtime_pm(void)
 
 	err = __igt_pm_enable_audio_runtime_pm();
 	if (err)
-		igt_warn("Failed to enable audio runtime PM! (%d)\n", -err);
+		igt_debug("Failed to enable audio runtime PM! (%d)\n", -err);
 }
 
 /**
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib: Squelch warning for failing to enable audio powermanagement

[Patchwork]

== Series Details ==

Series: lib: Squelch warning for failing to enable audio powermanagement
URL   : https://patchwork.freedesktop.org/series/49012/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4749 -> IGTPW_1768 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49012/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1768 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-icl-u:           PASS -> DMESG-FAIL (fdo#107411)

    igt@gem_exec_reloc@basic-gtt-read-noreloc:
      fi-icl-u:           PASS -> DMESG-WARN (fdo#107411) +77

    igt@gem_exec_suspend@basic-s3:
      {fi-kbl-soraka}:    NOTRUN -> INCOMPLETE (fdo#107774, fdo#107556)
      fi-icl-u:           PASS -> DMESG-WARN (fdo#107716)

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-hsw-4770:        PASS -> INCOMPLETE (fdo#103540)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
    ==== Possible fixes ====

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         FAIL (fdo#107336) -> PASS

    {igt@pm_rpm@module-reload}:
      {fi-byt-clapper}:   WARN (fdo#107708, fdo#107602) -> PASS
      fi-kbl-x1275:       WARN (fdo#107708, fdo#107602) -> PASS
      fi-glk-j4005:       WARN (fdo#107708, fdo#107602) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107411 https://bugs.freedesktop.org/show_bug.cgi?id=107411
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708
  fdo#107716 https://bugs.freedesktop.org/show_bug.cgi?id=107716
  fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774


== Participating hosts (52 -> 48) ==

  Additional (1): fi-kbl-soraka 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4616 -> IGTPW_1768

  CI_DRM_4749: 4a46c18fad0de38a78b4b0c848892de494324a17 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1768: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1768/
  IGT_4616: 5800e46c6f851c370c944a7cb169e99657239f8d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1768/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for lib: Squelch warning for failing to enable audio powermanagement

[Patchwork]

== Series Details ==

Series: lib: Squelch warning for failing to enable audio powermanagement
URL   : https://patchwork.freedesktop.org/series/49012/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4616_full -> IGTPW_1768_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1768_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1768_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49012/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1768_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          PASS -> FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1768_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@fence-restore-untiled:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@gem_exec_schedule@pi-ringfull-blt:
      shard-glk:          NOTRUN -> FAIL (fdo#103158)

    igt@gem_exec_schedule@pi-ringfull-bsd1:
      shard-kbl:          NOTRUN -> FAIL (fdo#103158)

    igt@gem_userptr_blits@sync-unmap:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_flip@flip-vs-wf_vblank-interruptible:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558) +25

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-kbl:          NOTRUN -> DMESG-WARN (fdo#105602, fdo#103558) +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558, fdo#105604)

    igt@perf@blocking:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    igt@perf_pmu@rc6-runtime-pm:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#105602, fdo#103558)

    igt@pm_rpm@system-suspend-execbuf:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#107556)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-snb:          INCOMPLETE (fdo#106886, fdo#105411) -> PASS
      shard-kbl:          INCOMPLETE (fdo#106886, fdo#103665) -> PASS

    igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
      shard-glk:          FAIL (fdo#104873) -> PASS

    igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105604 https://bugs.freedesktop.org/show_bug.cgi?id=105604
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4616 -> IGTPW_1768
    * Linux: CI_DRM_4748 -> CI_DRM_4749

  CI_DRM_4748: 6caeb081ceb9282503439565e7093c1032758289 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4749: 4a46c18fad0de38a78b4b0c848892de494324a17 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1768: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1768/
  IGT_4616: 5800e46c6f851c370c944a7cb169e99657239f8d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1768/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Squelch warning for failing to enable audio powermanagement

[Imre Deak]

On Fri, Aug 31, 2018 at 02:58:28PM +0100, Chris Wilson wrote:
> It doesn't seem to be preventing rpm (see the pm_rpm tests)

Yep, in this case, due to disable_display=1 and so no audio power
domain reference held by snd_hda_intel (no HDMI capable outputs
enumerated by snd_hda_intel). The error itself is due to the
audio init (already after component binding completes, but before
registering the audio device) taking more than our 5 sec polling
time.

Btw, too bad IGT debug log is not shown on the CI results page, even
though there was an error.

> if we fail to enable runtime-powermanagement for audio, so reduce the
> warning to a debug. It will still be visible if it fails, but only if
> it fails.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  lib/igt_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 339a51e6f..b1f359d8b 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -260,7 +260,7 @@ void igt_pm_enable_audio_runtime_pm(void)
>  
>  	err = __igt_pm_enable_audio_runtime_pm();
>  	if (err)
> -		igt_warn("Failed to enable audio runtime PM! (%d)\n", -err);
> +		igt_debug("Failed to enable audio runtime PM! (%d)\n", -err);
>  }
>  
>  /**
> -- 
> 2.19.0.rc1
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Squelch warning for failing to enable audio powermanagement

[Chris Wilson]

Quoting Imre Deak (2018-09-04 10:39:50)
> On Fri, Aug 31, 2018 at 02:58:28PM +0100, Chris Wilson wrote:
> > It doesn't seem to be preventing rpm (see the pm_rpm tests)
> 
> Yep, in this case, due to disable_display=1 and so no audio power
> domain reference held by snd_hda_intel (no HDMI capable outputs
> enumerated by snd_hda_intel). The error itself is due to the
> audio init (already after component binding completes, but before
> registering the audio device) taking more than our 5 sec polling
> time.

Bump to 10s? More than is getting on the silly side ;)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Squelch warning for failing to enable audio powermanagement

[Chris Wilson]

Quoting Chris Wilson (2018-09-04 10:43:54)
> Quoting Imre Deak (2018-09-04 10:39:50)
> > On Fri, Aug 31, 2018 at 02:58:28PM +0100, Chris Wilson wrote:
> > > It doesn't seem to be preventing rpm (see the pm_rpm tests)
> > 
> > Yep, in this case, due to disable_display=1 and so no audio power
> > domain reference held by snd_hda_intel (no HDMI capable outputs
> > enumerated by snd_hda_intel). The error itself is due to the
> > audio init (already after component binding completes, but before
> > registering the audio device) taking more than our 5 sec polling
> > time.
> 
> Bump to 10s? More than is getting on the silly side ;)

We have plenty of genuine errors to be getting on with though. :|
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Squelch warning for failing to enable audio powermanagement

[Imre Deak]

On Tue, Sep 04, 2018 at 10:45:28AM +0100, Chris Wilson wrote:
> Quoting Chris Wilson (2018-09-04 10:43:54)
> > Quoting Imre Deak (2018-09-04 10:39:50)
> > > On Fri, Aug 31, 2018 at 02:58:28PM +0100, Chris Wilson wrote:
> > > > It doesn't seem to be preventing rpm (see the pm_rpm tests)
> > > 
> > > Yep, in this case, due to disable_display=1 and so no audio power
> > > domain reference held by snd_hda_intel (no HDMI capable outputs
> > > enumerated by snd_hda_intel). The error itself is due to the
> > > audio init (already after component binding completes, but before
> > > registering the audio device) taking more than our 5 sec polling
> > > time.
> > 
> > Bump to 10s? More than is getting on the silly side ;)

Yes, sounds ok.

> 
> We have plenty of genuine errors to be getting on with though. :|

azx_rirb_get_response() at least is on that probe path with an up to
3 sec polling, haven't looked further where the rest of 7 sec we see
can come from.

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev