From: Katarzyna Dec <katarzyna.dec@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] igt/pm_rps: Clear previous high load on high->low transition
Date: Tue, 4 Sep 2018 15:50:14 +0200 [thread overview]
Message-ID: <20180904135014.GJ18600@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20180904124956.29993-1-chris@chris-wilson.co.uk>
On Tue, Sep 04, 2018 at 01:49:56PM +0100, Chris Wilson wrote:
> Make sure we do flush out the previous spinner and delay signaling
> transition completion until we do.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102250
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Katarzyna Dec <katarzyna.dec@intel.com>
> ---
> tests/pm_rps.c | 26 +++++++++++++++++++++-----
> 1 file changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/tests/pm_rps.c b/tests/pm_rps.c
> index 84e71fa8a..23b33f41b 100644
> --- a/tests/pm_rps.c
> +++ b/tests/pm_rps.c
> @@ -218,6 +218,7 @@ static void load_helper_set_load(enum load load)
>
> static void load_helper_run(enum load load)
> {
> + bool dummy;
> int link[2];
>
> /*
> @@ -233,13 +234,14 @@ static void load_helper_run(enum load load)
>
> lh.exit = false;
> lh.load = load;
> - lh.signal = false;
> + lh.signal = true;
>
> pipe(link);
> lh.link = link[1];
>
> igt_fork_helper(&lh.igt_proc) {
> igt_spin_t *spin[2] = {};
> + bool prev_load;
> uint32_t handle;
>
> signal(SIGUSR1, load_helper_signal_handler);
> @@ -247,10 +249,14 @@ static void load_helper_run(enum load load)
>
> igt_debug("Applying %s load...\n", lh.load ? "high" : "low");
>
> + prev_load = lh.load == HIGH;
I would add parenthesis to improve clarity:
prev_load = (lh.load == HIGH);
Despite this:
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-09-04 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 12:49 [igt-dev] [PATCH i-g-t] igt/pm_rps: Clear previous high load on high->low transition Chris Wilson
2018-09-04 13:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-04 13:50 ` Katarzyna Dec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904135014.GJ18600@kdec5-desk.ger.corp.intel.com \
--to=katarzyna.dec@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox