public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] igt/pm_backlight: Require a connected output for the backlight
Date: Tue,  4 Sep 2018 22:34:48 +0100	[thread overview]
Message-ID: <20180904213448.20196-1-chris@chris-wilson.co.uk> (raw)

We cannot control the backlight if its attached output is not connected.
Don't assert, but require.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/pm_backlight.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/pm_backlight.c b/tests/pm_backlight.c
index 33614e969..e94340a2b 100644
--- a/tests/pm_backlight.c
+++ b/tests/pm_backlight.c
@@ -225,7 +225,9 @@ igt_main
 			break;
 		}
 
-		igt_assert_f(found, "Could not map \"%s\" to output (%s?)\n", name, name + 6);
+		igt_require_f(found,
+			      "Could not map backlight for \"%s\" to connected output\n",
+			      name);
 
 		igt_output_set_pipe(output, pipe);
 		mode = igt_output_get_mode(output);
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2018-09-04 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 21:34 Chris Wilson [this message]
2018-09-04 22:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for igt/pm_backlight: Require a connected output for the backlight Patchwork
2018-09-05  1:52 ` [igt-dev] [PATCH i-g-t] " Dhinakaran Pandiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904213448.20196-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox