Re: [igt-dev] [PATCH i-g-t] igt/kms_vblank: Exercise some EINVAL

Chris Wilson
2018-09-04T22:00:29Z

Quoting Daniel Vetter (2018-09-04 22:52:20)
> On Tue, Sep 04, 2018 at 07:51:59PM +0100, Chris Wilson wrote:
> > + /* check the maximum pipe, nobody should have that many pipes! */
> > + memset(&vbl, 0, sizeof(vbl));
> > + vbl.request.type = _DRM_VBLANK_RELATIVE;
> > + vbl.request.type |= _DRM_VBLANK_SECONDARY;
> > + vbl.request.type |= _DRM_VBLANK_FLAGS_MASK;
> > + igt_assert_eq(wait_vblank(fd, &vbl), -EINVAL);
>
> Hm just realized that the kernel lets _DRM_VBLANK_SECONDARY and
> _DRM_VBLANK_HIGH_CRTC_MASK through at the same time. Not really an issue,
> just a bit silly. But for another day.

I forgot to mention that. Yes, that did look a bit silly. I felt like
writing a test to say use one or the other, but definitely not both, but
meh.
-Chris