From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
eben@raspberrypi.org, igt-dev@lists.freedesktop.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH v6 05/13] fb: Fix ARGB8888 color depth
Date: Wed, 5 Sep 2018 13:14:34 +0300 [thread overview]
Message-ID: <20180905101434.GL5565@intel.com> (raw)
In-Reply-To: <20180905093549.2sv3ggjp5j6yiihz@flea>
On Wed, Sep 05, 2018 at 11:35:49AM +0200, Maxime Ripard wrote:
> On Fri, Aug 31, 2018 at 04:42:18PM +0300, Ville Syrjälä wrote:
> > On Fri, Aug 31, 2018 at 03:12:14PM +0200, Maxime Ripard wrote:
> > > The ARGB8888 has been listed as having a 32 bits depth, while it actually
> > > is a 24 bits format. Fix this.
> >
> > I think 32 is the more usual definition for this.
>
> Isn't color depth about the color itself? I guess alpha wouldn't apply
> in this case.
Not according to X at least.
visual:
visual id: 0x6d
class: TrueColor
depth: 32 planes
available colormap entries: 256 per subfield
red, green, blue masks: 0xff0000, 0xff00, 0xff
significant bits in color specification: 8 bits
Same for eg. drm_mode_legacy_fb_format().
>
> In the same format list:
> - RGB565 has a depth of 16
> - XRGB8888 has a depth of 24
> - XRGB2101010 has a depth of 30
> - ARGB8888 has a depth of 32
>
> Which seems to indicate that the list indeed meant that the color
> depth is about the color, and that ARGB8888 is wrong.
None of those other things have alpha, so they are still
consistent with the depth==32 definition for ARGB888.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-05 10:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 13:12 [igt-dev] [PATCH v6 00/13] chamelium: Test the plane formats Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 01/13] fb: Add buffer map/unmap functions Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 02/13] fb: convert: Remove swizzle from the arguments Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 03/13] fb: Create common function to convert frame formats Maxime Ripard
2018-08-31 13:41 ` Ville Syrjälä
2018-09-05 13:16 ` Maxime Ripard
2018-09-06 11:41 ` Maxime Ripard
2018-09-06 12:11 ` Ville Syrjälä
2018-09-06 12:49 ` Maxime Ripard
2018-09-06 13:30 ` Ville Syrjälä
2018-08-31 13:12 ` [igt-dev] [PATCH v6 04/13] fb: Add format conversion routine Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 05/13] fb: Fix ARGB8888 color depth Maxime Ripard
2018-08-31 13:42 ` Ville Syrjälä
2018-09-05 9:35 ` Maxime Ripard
2018-09-05 10:14 ` Ville Syrjälä [this message]
2018-09-05 13:19 ` Maxime Ripard
2018-09-05 13:37 ` Ville Syrjälä
2018-09-06 7:22 ` Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 06/13] fb: Add support for conversions through pixman Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 07/13] fb: Add depth lookup function Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 08/13] fb: Add more formats Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 09/13] chamelium: Split CRC test function in two Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 10/13] chamelium: Change our pattern for a custom one if needed Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 11/13] chamelium: Add format support Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 12/13] chamelium: Add format subtests Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 13/13] tests: Add chamelium formats subtests to vc4 test lists Maxime Ripard
2018-09-03 8:33 ` [igt-dev] ✓ Fi.CI.BAT: success for chamelium: Test the plane formats (rev5) Patchwork
2018-09-03 9:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905101434.GL5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=eben@raspberrypi.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=maxime.ripard@bootlin.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).