From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATH i-g-t 04/13] gem_wsim: Check sleep times
Date: Wed, 5 Sep 2018 14:49:30 +0100 [thread overview]
Message-ID: <20180905134939.2942-5-tvrtko.ursulin@linux.intel.com> (raw)
In-Reply-To: <20180905134939.2942-1-tvrtko.ursulin@linux.intel.com>
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Notice in more places if we are running behind.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
benchmarks/gem_wsim.c | 52 ++++++++++++++++++++++++++++++++++++++-----
1 file changed, 46 insertions(+), 6 deletions(-)
diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index 25af4d678ba4..b05e9760f419 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -1718,6 +1718,21 @@ static bool sync_deps(struct workload *wrk, struct w_step *w)
return synced;
}
+static unsigned int measured_usleep(unsigned int usec)
+{
+ struct timespec ts = { };
+ unsigned int slept;
+
+ slept = igt_nsec_elapsed(&ts);
+ igt_assert(slept == 0);
+ do {
+ usleep(usec - slept);
+ slept = igt_nsec_elapsed(&ts) / 1000;
+ } while (slept < usec);
+
+ return igt_nsec_elapsed(&ts);
+}
+
static void *run_workload(void *data)
{
struct workload *wrk = (struct workload *)data;
@@ -1739,7 +1754,7 @@ static void *run_workload(void *data)
count++) {
unsigned int cur_seqno = wrk->sync_seqno;
- clock_gettime(CLOCK_MONOTONIC, &wrk->repeat_start);
+ igt_gettime(&wrk->repeat_start);
for (i = 0, w = wrk->steps; wrk->run && (i < wrk->nr_steps);
i++, w++) {
@@ -1751,13 +1766,14 @@ static void *run_workload(void *data)
} else if (w->type == PERIOD) {
struct timespec now;
- clock_gettime(CLOCK_MONOTONIC, &now);
+ igt_gettime(&now);
do_sleep = w->period -
elapsed_us(&wrk->repeat_start, &now);
if (do_sleep < 0) {
- if (verbose > 1)
- printf("%u: Dropped period @ %u/%u (%dus late)!\n",
- wrk->id, count, i, do_sleep);
+ if (verbose > 1 &&
+ -do_sleep > 10 * w->period / 100)
+ printf("%u: Missed period @ %u/%u (%dus late)!\n",
+ wrk->id, count, i, -do_sleep);
continue;
}
} else if (w->type == SYNC) {
@@ -1793,7 +1809,31 @@ static void *run_workload(void *data)
}
if (do_sleep || w->type == PERIOD) {
- usleep(do_sleep);
+ long slept = measured_usleep(do_sleep) / 1000;
+
+ if ( w->type == PERIOD) {
+ struct timespec now;
+
+ igt_gettime(&now);
+
+ slept = elapsed_us(&wrk->repeat_start,
+ &now);
+
+ if (verbose > 1 &&
+ slept > (110 * w->period / 100))
+ printf("%u: Overslept period by %ldus @ %u/%u! (%uus)\n",
+ wrk->id,
+ -slept, count,
+ i, w->period);
+ } else {
+ if (verbose > 1 &&
+ slept > (110 * do_sleep / 100))
+ printf("%u: Overslept by %ldus @ %u/%u! (%uus)\n",
+ wrk->id,
+ slept - do_sleep, count,
+ i, do_sleep);
+ }
+
continue;
}
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-05 13:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:49 [Intel-gfx] [PATH i-g-t 00/13] Tracing & workload simulation misc patches Tvrtko Ursulin
2018-09-05 13:49 ` [Intel-gfx] [PATH i-g-t 01/13] trace.pl: Fix frequency timeline Tvrtko Ursulin
2018-09-05 13:49 ` [Intel-gfx] [PATH i-g-t 02/13] trace.pl: Use undocumented -o to perf record to allow tee Tvrtko Ursulin
2018-09-05 13:49 ` [Intel-gfx] [PATH i-g-t 03/13] gem_wsim: Fix BCS usage under VCS2 remap warning Tvrtko Ursulin
2018-09-05 13:49 ` Tvrtko Ursulin [this message]
2018-09-05 14:09 ` [igt-dev] [PATH i-g-t 04/13] gem_wsim: Check sleep times Ville Syrjälä
2018-09-07 8:37 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2018-09-07 8:45 ` Chris Wilson
2018-09-07 14:13 ` [Intel-gfx] [igt-dev] " Ville Syrjälä
2018-09-07 16:00 ` Tvrtko Ursulin
2018-09-05 13:49 ` [Intel-gfx] [PATH i-g-t 05/13] gem_wsim: Make workload commands case sensitive Tvrtko Ursulin
2018-09-05 13:49 ` [igt-dev] [PATH i-g-t 06/13] gem_wsim: Context priority support Tvrtko Ursulin
2018-09-05 13:49 ` [igt-dev] [PATH i-g-t 07/13] gem_wsim: Make batches preemptable by default Tvrtko Ursulin
2018-09-07 8:48 ` Chris Wilson
2018-09-05 13:49 ` [igt-dev] [PATH i-g-t 08/13] gem_wsim: Per context preemption point control Tvrtko Ursulin
2018-09-07 8:49 ` Chris Wilson
2018-09-07 8:51 ` [Intel-gfx] " Chris Wilson
2018-09-05 13:49 ` [Intel-gfx] [PATH i-g-t 09/13] media-bench: Update for engine=class:instance tracepoints Tvrtko Ursulin
2018-09-05 13:49 ` [Intel-gfx] [PATH i-g-t 10/13] media-bench: Protect against incorrect -b syntax Tvrtko Ursulin
2018-09-05 13:49 ` [igt-dev] [PATH i-g-t 11/13] media-bench: Fix tracing of direct workloads Tvrtko Ursulin
2018-09-05 13:49 ` [igt-dev] [PATH i-g-t 12/13] media-bench: Write out trace files directly Tvrtko Ursulin
2018-09-05 13:49 ` [igt-dev] [PATH i-g-t 13/13] media-bench: Add mixed mode evaluation Tvrtko Ursulin
2018-09-05 15:24 ` [igt-dev] ✓ Fi.CI.BAT: success for Tracing & workload simulation misc patches Patchwork
2018-09-05 20:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905134939.2942-5-tvrtko.ursulin@linux.intel.com \
--to=tursulin@ursulin.net \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).