From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com
 [IPv6:2a00:1450:4864:20::541])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A28AB89AB9
 for <igt-dev@lists.freedesktop.org>; Wed,  5 Sep 2018 14:33:26 +0000 (UTC)
Received: by mail-ed1-x541.google.com with SMTP id u1-v6so6276105eds.1
 for <igt-dev@lists.freedesktop.org>; Wed, 05 Sep 2018 07:33:26 -0700 (PDT)
Date: Wed, 5 Sep 2018 16:33:22 +0200
From: Daniel Vetter <daniel@ffwll.ch>
Message-ID: <20180905143322.GF4929@phenom.ffwll.local>
References: <20180905100522.19207-1-chris@chris-wilson.co.uk>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20180905100522.19207-1-chris@chris-wilson.co.uk>
Subject: Re: [igt-dev] [PATCH i-g-t] igt/kms_addfb_basic: Exercise legacy
 interface to addfb2
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMTE6MDU6MjJBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFRoZSBsZWdhY3kgaW50ZXJmYWNlIHBhc3NlcyBpbiBhIHNpbmdsZSBoYW5kbGUsIGFu
ZCBpbnN0ZWFkIG9mIHByb3ZpZGluZwo+IHRoZSBwaXhlbF9mb3JtYXQgZm91cmNjLCBwYXNzZXMg
aW4gYSBicHAvZGVwdGggY29tYmluYXRpb24gdGhhdCB0aGUKPiBrZXJuZWwgdHJhbnNsYXRlcyBp
bnRvIGEgZm91cmNjLiBJZiB0aGF0IGlzIGFuIGlsbGVnYWwgY29tYmluYXRpb24sIHRoZQo+IGtl
cm5lbCBzaG91bGQgYmUgcmVwb3J0aW5nIEVJTlZBTCByYXRoZXIgdGhhbiBwYXNzIGFuIHVua25v
d24KPiBmcmFtZWJ1ZmZlciB0byB0aGUgZHJpdmVycy4KPiAKPiBBcyB0aGUgbnVtYmVyIG9mIHBv
c3NpYmxlIHBlcm11dGF0aW9ucyBvZiBicHAvZGVwdGggKGJvdGggYXJlIHN0cmljdGx5Cj4gdTMy
IHBhcmFtZXRlcnMpIGlzIGh1Z2UsIHdlIHNpbXBseSBmdXp6IHRoZSBpbnRlcmZhY2UgZm9yIDFz
Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv
LnVrPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBW
aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICB0
ZXN0cy9rbXNfYWRkZmJfYmFzaWMuYyB8IDEwMyArKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMDMgaW5zZXJ0aW9ucygrKQo+IAo+IGRp
ZmYgLS1naXQgYS90ZXN0cy9rbXNfYWRkZmJfYmFzaWMuYyBiL3Rlc3RzL2ttc19hZGRmYl9iYXNp
Yy5jCj4gaW5kZXggN2Q4ODUyZjAyLi5iMWIxNDNmMTIgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21z
X2FkZGZiX2Jhc2ljLmMKPiArKysgYi90ZXN0cy9rbXNfYWRkZmJfYmFzaWMuYwo+IEBAIC0zOCw5
ICszOCwzNSBAQAo+ICAjaW5jbHVkZSAiZHJtLmgiCj4gICNpbmNsdWRlICJkcm1fZm91cmNjLmgi
Cj4gIAo+ICsjaW5jbHVkZSAiaWd0X3JhbmQuaCIKPiArCj4gIHVpbnQzMl90IGdlbV9ibzsKPiAg
dWludDMyX3QgZ2VtX2JvX3NtYWxsOwo+ICAKPiArc3RhdGljIGludCBsZWdhY3lfYWRkZmIoaW50
IGZkLCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kICphcmcpCj4gK3sKPiArCWludCBlcnI7Cj4gKwo+
ICsJZXJyID0gMDsKPiArCWlmIChpZ3RfaW9jdGwoZmQsIERSTV9JT0NUTF9NT0RFX0FEREZCLCBh
cmcpKQo+ICsJCWVyciA9IC1lcnJubzsKPiArCj4gKwllcnJubyA9IDA7Cj4gKwlyZXR1cm4gZXJy
Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHJtZmIoaW50IGZkLCB1aW50MzJfdCBpZCkKPiArewo+
ICsJaW50IGVycjsKPiArCj4gKwllcnIgPSAwOwo+ICsJaWYgKGlndF9pb2N0bChmZCwgRFJNX0lP
Q1RMX01PREVfUk1GQiwgJmlkKSkKPiArCQllcnIgPSAtZXJybm87Cj4gKwo+ICsJZXJybm8gPSAw
Owo+ICsJcmV0dXJuIGVycjsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgaW52YWxpZF90ZXN0cyhp
bnQgZmQpCj4gIHsKPiAgCXN0cnVjdCBsb2NhbF9kcm1fbW9kZV9mYl9jbWQyIGYgPSB7fTsKPiBA
QCAtMTEzLDYgKzEzOSw4MyBAQCBzdGF0aWMgdm9pZCBpbnZhbGlkX3Rlc3RzKGludCBmZCkKPiAg
CQlpZ3RfYXNzZXJ0KGYubW9kaWZpZXJbMF0gPT0gMCk7Cj4gIAl9Cj4gIAo+ICsJaWd0X3N1YnRl
c3QoImxlZ2FjeS1mb3JtYXQiKSB7Cj4gKwkJc3RydWN0IHsKPiArCQkJLyogZHJtX21vZGVfbGVn
YWN5X2ZiX2Zvcm1hdCgpICovCj4gKwkJCWludCBicHAsIGRlcHRoOwo+ICsJCQlpbnQgZXhwZWN0
Owo+ICsJCX0ga25vd25fZm9ybWF0c1tdID0gewo+ICsJCQl7IDgsIDAgfSwgICAvKiBwYWxldHRl
ICovCgpBcHBhcmVudGx5IDgvOAo+ICsJCQl7IDE2LCAxNSB9LCAvKiB4MXI1ZzViNSAqLwo+ICsJ
CQl7IDE2LCAxNiB9LCAvKiByNWc2YjUgKi8KPiArCQkJeyAyNCwgMjQgfSwgLyogcjhnOGI4ICov
Cj4gKwkJCXsgMzIsIDI0IH0sIC8qIHg4cjhnOGI4ICovCj4gKwkJCXsgMzIsIDMwIH0sIC8qIHgy
cjEwZzEwYjEwICovCj4gKwkJCXsgMzIsIDMyIH0sIC8qIGEycjEwZzEwYjEwICovCj4gKwkJfTsK
PiArCQlzdHJ1Y3QgZHJtX21vZGVfZmJfY21kIGFyZyA9IHsKPiArCQkJLndpZHRoID0gZi53aWR0
aCwKPiArCQkJLmhlaWdodCA9IGYuaGVpZ2h0LAo+ICsJCQkucGl0Y2ggPSBmLnBpdGNoZXNbMF0s
Cj4gKwkJCS5oYW5kbGUgPSBmLmhhbmRsZXNbMF0sCj4gKwkJfTsKPiArCQl1aW50MzJfdCBwcm5n
ID0gMHgxMjM0NTY3ODsKPiArCj4gKwkJLyoKPiArCQkgKiBGaXJzdCBjb25maXJtIHRoZSBrZXJu
ZWwgcmVjb2duaXNlcyBvdXIga25vd25fZm9ybWF0czsKPiArCQkgKiBzb21lIG1heSBiZSBpbnZh
bGlkIGZvciBkaWZmZXJlbnQgZGV2aWNlcy4KPiArCQkgKi8KPiArCQlmb3IgKGludCBpID0gMDsg
aSA8IEFSUkFZX1NJWkUoa25vd25fZm9ybWF0cyk7IGkrKykgewo+ICsJCQlhcmcuYnBwID0ga25v
d25fZm9ybWF0c1tpXS5icHA7Cj4gKwkJCWFyZy5kZXB0aCA9IGtub3duX2Zvcm1hdHNbaV0uZGVw
dGg7Cj4gKwkJCWtub3duX2Zvcm1hdHNbaV0uZXhwZWN0ID0gbGVnYWN5X2FkZGZiKGZkLCAmYXJn
KTsKPiArCQkJaWd0X2RlYnVnKCIoYnBwOiVkLCBkZXB0aDolZCkgLT4gZXhwZWN0OiVkXG4iLAo+
ICsJCQkJICBhcmcuYnBwLCBhcmcuZGVwdGgsIGtub3duX2Zvcm1hdHNbaV0uZXhwZWN0KTsKPiAr
CQkJaWYgKGFyZy5mYl9pZCkgewo+ICsJCQkJaWd0X2Fzc2VydF9lcShybWZiKGZkLCBhcmcuZmJf
aWQpLCAwKTsKPiArCQkJCWFyZy5mYl9pZCA9IDA7Cj4gKwkJCX0KPiArCQl9Cj4gKwo+ICsJCWln
dF91bnRpbF90aW1lb3V0KDEpIHsKPiArCQkJaW50IGV4cGVjdCA9IC1FSU5WQUw7Cj4gKwkJCWlu
dCBlcnI7Cj4gKwo+ICsJCQlhcmcuYnBwID0gaGFyc19wZXRydXNrYV9mNTRfMV9yYW5kb20oJnBy
bmcpOwo+ICsJCQlhcmcuZGVwdGggPSBoYXJzX3BldHJ1c2thX2Y1NF8xX3JhbmRvbSgmcHJuZyk7
Cj4gKwkJCWZvciAoaW50IHN0YXJ0ID0gMCwgZW5kID0gQVJSQVlfU0laRShrbm93bl9mb3JtYXRz
KTsKPiArCQkJICAgICBzdGFydCA8IGVuZDsgKSB7CgpUaGUgYi1zZWFyY2ggaXMgbWF5YmUgYSBi
aXQgb3ZlcmtpbGwgZm9yIGFuIGFycmF5IHdpdGggNyBlbnRyaWVzIDotKSBJJ2QKc2ltcGxpZnkg
dG8gYSBicnV0ZS1mb3JjZSBtYXRjaC4KCj4gKwkJCQlpbnQgbWlkID0gc3RhcnQgKyAoZW5kIC0g
c3RhcnQpIC8gMjsKPiArCQkJCXR5cGVvZigqa25vd25fZm9ybWF0cykgKnRibCA9ICZrbm93bl9m
b3JtYXRzW21pZF07Cj4gKwo+ICsJCQkJaWYgKGFyZy5icHAgPCB0YmwtPmJwcCkgewo+ICsJCQkJ
CWVuZCA9IG1pZDsKPiArCQkJCX0gZWxzZSBpZiAoYXJnLmJwcCA+IHRibC0+YnBwKSB7Cj4gKwkJ
CQkJc3RhcnQgPSBtaWQgKyAxOwo+ICsJCQkJfSBlbHNlIHsKPiArCQkJCQlpZiAoYXJnLmRlcHRo
IDwgdGJsLT5kZXB0aCkgewo+ICsJCQkJCQllbmQgPSBtaWQ7Cj4gKwkJCQkJfSBlbHNlIGlmIChh
cmcuZGVwdGggPiB0YmwtPmRlcHRoKSB7Cj4gKwkJCQkJCXN0YXJ0ID0gbWlkICsgMTsKPiArCQkJ
CQl9IGVsc2Ugewo+ICsJCQkJCQlleHBlY3QgPSB0YmwtPmV4cGVjdDsKPiArCQkJCQkJYnJlYWs7
Cj4gKwkJCQkJfQo+ICsJCQkJfQo+ICsJCQl9Cj4gKwo+ICsKPiArCQkJZXJyID0gbGVnYWN5X2Fk
ZGZiKGZkLCAmYXJnKTsKPiArCQkJaWd0X2Fzc2VydF9mKGVyciA9PSBleHBlY3QsCj4gKwkJCQkg
ICAgICJFeHBlY3RlZCAlZCB3aXRoIChicHA6JWQsIGRlcHRoOiVkKSwgZ290ICVkIGluc3RlYWRc
biIsCj4gKwkJCQkgICAgIGV4cGVjdCwgYXJnLmJwcCwgYXJnLmRlcHRoLCBlcnIpOwo+ICsJCQlp
ZiAoYXJnLmZiX2lkKSB7Cj4gKwkJCQlpZ3RfYXNzZXJ0X2VxKHJtZmIoZmQsIGFyZy5mYl9pZCks
IDApOwo+ICsJCQkJYXJnLmZiX2lkID0gMDsKPiArCQkJfQo+ICsJCX0KPiArCX0KClJldmlld2Vk
LWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiArCj4gIAlpZ3Rf
Zml4dHVyZSB7Cj4gIAkJZ2VtX2Nsb3NlKGZkLCBnZW1fYm8pOwo+ICAJCWdlbV9jbG9zZShmZCwg
Z2VtX2JvX3NtYWxsKTsKPiAtLSAKPiAyLjE5LjAucmMxCj4gCgotLSAKRGFuaWVsIFZldHRlcgpT
b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt
YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==