From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id B17316E533 for ; Wed, 5 Sep 2018 18:18:00 +0000 (UTC) Date: Wed, 5 Sep 2018 11:17:59 -0700 From: Rodrigo Vivi Message-ID: <20180905181759.GA586@intel.com> References: <20180901041806.2627-1-rodrigo.vivi@intel.com> <20180901041806.2627-3-rodrigo.vivi@intel.com> <2469463c5fa78109ae302d79f3fedd8470700f54.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2469463c5fa78109ae302d79f3fedd8470700f54.camel@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 3/6] tools/dpcd_reg: Unify file handling. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Dhinakaran Pandiyan Cc: igt-dev@lists.freedesktop.org List-ID: T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDU6NTY6MDFQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBPbiBGcmksIDIwMTgtMDgtMzEgYXQgMjE6MTggLTA3MDAsIFJvZHJpZ28g Vml2aSB3cm90ZToKPiA+IEJlc2lkZXMgcmVtb3ZpbmcgZmV3IGNvZGUgZHVwbGljYXRpb24gdGhp cyB3aWxsCj4gPiBhbGxvdyB1cyB0byByZWFkIG11bHRpcGxlIHJlZ3Mgd2l0aG91dCBoYXZpbmcK PiA+IHRvIGtlZXAgY2xvc2luZyBhbmQgb3BlbmluZyB0aGUgZmlsZSBmb3IgZXZlcnkKPiA+IHJl YWQuCj4gPiAKPiA+IENjOiBUYXJ1biBWeWFzIDx0YXJ1bi52eWFzQGludGVsLmNvbT4KPiA+IENj OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiA+ IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ IC0tLQo+ID4gIHRvb2xzL2RwY2RfcmVnLmMgfCA5OCArKysrKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiAtLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1NSBpbnNl cnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL3Rvb2xzL2Rw Y2RfcmVnLmMgYi90b29scy9kcGNkX3JlZy5jCj4gPiBpbmRleCBkMTM5MDA3Yy4uMDlkYTQxMDkg MTAwNjQ0Cj4gPiAtLS0gYS90b29scy9kcGNkX3JlZy5jCj4gPiArKysgYi90b29scy9kcGNkX3Jl Zy5jCj4gPiBAQCAtNTMsNjEgKzUzLDU2IEBAIHN0YXRpYyB2b2lkIHByaW50X3VzYWdlKGNoYXIg KnRvb2wsIGludCBoZWxwKQo+ID4gIAlleGl0KChoZWxwID09IDEpPyBFWElUX1NVQ0NFU1MgOiBF WElUX0ZBSUxVUkUpOwo+ID4gIH0KPiA+ICAKPiA+IC1zdGF0aWMgaW50IGRwY2RfcmVhZChjaGFy ICpkZXZpY2UsIGNvbnN0IHVpbnQzMl90IG9mZnNldCwgc2l6ZV90Cj4gPiBjb3VudCkKPiA+ICtz dGF0aWMgaW50IGRwY2RfcmVhZChpbnQgZmQsIGNvbnN0IHVpbnQzMl90IG9mZnNldCwgc2l6ZV90 IGNvdW50KQo+ID4gIHsKPiA+IC0JaW50IGZkLCByZXQsIGk7Cj4gPiArCWludCByZXQsIGk7Cj4g PiAgCXZvaWQgKmJ1ZiA9IG1hbGxvYyhzaXplb2YodWludDhfdCkgKiBjb3VudCk7Cj4gPiAgCj4g PiArCXJldCA9IGxzZWVrKGZkLCBvZmZzZXQsIFNFRUtfU0VUKTsKPiBEb2VzIHRoaXMgb2ZmZXIg YW55IGJlbmVmaXQgb3ZlciBwcmVhZCgpL3B3cml0ZSgpPwoKSSdtIGhvbmVzdGx5IG5vdCBzdXJl LiBDYW4gd2UgdHJ1c3QgcHJlYWQvcHdyaXRlIHRoYXQgb2Zmc2V0cyBhcmUgYWx3YXlzCnJlbGF0 aXZlIHRvIHRoZSBiZWdpbiBvZiB0aGUgZmlsZSBvciByZWxhdGl2ZSB0byB3aGVyZSB0aGUgcG9p bnRlcgp3YXMgbGVmdCBhZnRlciBsYXN0IHJlYWQvd3JpdGUgb3BlcmF0aW9uIGJ1dCBmaWxlIG5v dCBjbG9zZWQ/Cgpsb29raW5nIHRvIHRoZSBkb2NzIGxzZWVrIHNlZW1lZCBtb3JlIGNyaXNweSBv biB0aGUgZGVmaW5pdGlvbgpvZiBpdHMgbmF2aWdhdGlvbiBhbmQgc2luY2UgSSBjYW5ub3QgZ3Vh cmFudGVlIG9yZGVyIG9uIGRwY2RfbGlzdApJIHByZWZlcnJlZCBsc2Vlay4KCmJ1dCBpZiB5b3Ug YXJlIHN1cmUgcHJlYWQvcHdyaXRlIGlzIHJlbGlhYmxlIGFuZCBub3QgcmVsYXRpdmUgcG9zaXRp b24KYW5kIHlvdSBoYXZlIHN0cm9uZyBwcmVmZXJlbmNlIG9uIHRoYXQgSSBjYW4gY2hhbmdlIGJh Y2suCgpUaGFua3MsClJvZHJpZ28uCgo+IAo+ID4gKwlpZiAocmV0IDwgMCkgewo+ID4gKwkJaWd0 X3dhcm4oImxzZWVrIHRvICUwNHggZmFpbGVkIVxuIiwgb2Zmc2V0KTsKPiA+ICsJCXJldHVybiBy ZXQ7Cj4gPiArCX0KPiA+ICsKPiA+ICAJaWYgKE5VTEwgIT0gYnVmKQo+ID4gIAkJbWVtc2V0KGJ1 ZiwgMCwgc2l6ZW9mKHVpbnQ4X3QpICogY291bnQpOwo+ID4gIAllbHNlIHsKPiA+ICAJCWlndF93 YXJuKCJDYW4ndCBhbGxvY2F0ZSByZWFkIGJ1ZmZlclxuIik7Cj4gPiAtCQlyZXR1cm4gRVhJVF9G QUlMVVJFOwo+ID4gKwkJcmV0dXJuIC0xOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCWZkID0gb3Blbihk ZXZpY2UsIE9fUkRPTkxZKTsKPiA+IC0JaWYgKGZkID4gMCkgewo+ID4gLQkJcmV0ID0gcHJlYWQo ZmQsIGJ1ZiwgY291bnQsIG9mZnNldCk7Cj4gPiAtCQljbG9zZShmZCk7Cj4gPiAtCQlpZiAocmV0 ICE9IGNvdW50KSB7Cj4gPiAtCQkJaWd0X3dhcm4oIkZhaWxlZCB0byByZWFkIGZyb20gJXMgYXV4 IGRldmljZQo+ID4gLSBlcnJvciAlc1xuIiwgZGV2aWNlLCBzdHJlcnJvcihlcnJubykpOwo+ID4g LQkJCXJldCA9IEVYSVRfRkFJTFVSRTsKPiA+IC0JCQlnb3RvIG91dDsKPiA+IC0JCX0KPiA+IC0K PiA+IC0JCWlndF9pbmZvKCIlMDR4OiIsIG9mZnNldCk7Cj4gPiAtCQlmb3IgKGkgPSAwOyBpIDwg Y291bnQ7IGkrKykKPiA+IC0JCQlpZ3RfaW5mbygiICUwMngiLCAqKCgodWludDhfdCAqKShidWYp KSArCj4gPiBpKSk7Cj4gPiAtCQlpZ3RfaW5mbygiXG4iKTsKPiA+IC0JfQo+ID4gLQllbHNlIHsK PiA+IC0JCWlndF93YXJuKCJGYWlsZWQgdG8gb3BlbiAlcyBhdXggZGV2aWNlIC0gZXJyb3I6Cj4g PiAlc1xuIiwgZGV2aWNlLCBzdHJlcnJvcihlcnJubykpOwo+ID4gLQkJcmV0ID0gRVhJVF9GQUlM VVJFOwo+ID4gKwlyZXQgPSByZWFkKGZkLCBidWYsIGNvdW50KTsKPiA+ICsJaWYgKHJldCAhPSBj b3VudCkgewo+ID4gKwkJaWd0X3dhcm4oIkZhaWxlZCB0byByZWFkIC0gZXJyb3IgJXNcbiIsCj4g PiBzdHJlcnJvcihlcnJubykpOwo+ID4gKwkJZ290byBvdXQ7Cj4gPiAgCX0KPiA+ICsKPiA+ICsJ aWd0X2luZm8oIiUwNHg6Iiwgb2Zmc2V0KTsKPiA+ICsJZm9yIChpID0gMDsgaSA8IGNvdW50OyBp KyspCj4gPiArCQlpZ3RfaW5mbygiICUwMngiLCAqKCgodWludDhfdCAqKShidWYpKSArIGkpKTsK PiA+ICsJaWd0X2luZm8oIlxuIik7Cj4gPiArCj4gPiAgb3V0Ogo+ID4gIAlmcmVlKGJ1Zik7Cj4g PiAgCXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyBpbnQgZHBjZF93cml0ZShj aGFyICpkZXZpY2UsIGNvbnN0IHVpbnQzMl90IG9mZnNldCwgY29uc3QKPiA+IHVpbnQ4X3QgKnZh bCkKPiA+ICtzdGF0aWMgaW50IGRwY2Rfd3JpdGUoaW50IGZkLCBjb25zdCB1aW50MzJfdCBvZmZz ZXQsIGNvbnN0IHVpbnQ4X3QKPiA+ICp2YWwpCj4gPiAgewo+ID4gLQlpbnQgZmQsIHJldDsKPiA+ IC0KPiA+IC0JZmQgPSBvcGVuKGRldmljZSwgT19SRFdSKTsKPiA+IC0JaWYgKGZkID4gMCkgewo+ ID4gLQkJcmV0ID0gcHdyaXRlKGZkLCAoY29uc3Qgdm9pZCAqKXZhbCwgc2l6ZW9mKHVpbnQ4X3Qp LAo+ID4gb2Zmc2V0KTsKPiA+IC0JCWNsb3NlKGZkKTsKPiA+IC0JCWlmIChyZXQgPCAwKSB7Cj4g PiAtCQkJaWd0X3dhcm4oIkZhaWxlZCB0byB3cml0ZSB0byAlcyBhdXggZGV2aWNlIC0KPiA+IGVy cm9yICVzXG4iLCBkZXZpY2UsIHN0cmVycm9yKGVycm5vKSk7Cj4gPiAtCQkJcmV0ID0gRVhJVF9G QUlMVVJFOwo+ID4gLQkJCWdvdG8gb3V0Owo+ID4gLQkJfQo+ID4gLQkJcmV0ID0gZHBjZF9yZWFk KGRldmljZSwgb2Zmc2V0LCBzaXplb2YodWludDhfdCkpOwo+ID4gKwlpbnQgcmV0Owo+ID4gKwo+ ID4gKwlyZXQgPSBsc2VlayhmZCwgb2Zmc2V0LCBTRUVLX1NFVCk7Cj4gPiArCWlmIChyZXQgPCAw KSB7Cj4gPiArCQlpZ3Rfd2FybigibHNlZWsgdG8gJTA0eCBmYWlsZWQhXG4iLCBvZmZzZXQpOwo+ ID4gKwkJcmV0dXJuIHJldDsKPiA+ICAJfQo+ID4gLQllbHNlIHsKPiA+IC0JCWlndF93YXJuKCJG YWlsZWQgdG8gb3BlbiAlcyBhdXggZGV2aWNlIC0gZXJyb3I6Cj4gPiAlc1xuIiwgZGV2aWNlLCBz dHJlcnJvcihlcnJubykpOwo+ID4gLQkJcmV0ID0gRVhJVF9GQUlMVVJFOwo+ID4gKwo+ID4gKwly ZXQgPSB3cml0ZShmZCwgKGNvbnN0IHZvaWQgKil2YWwsIHNpemVvZih1aW50OF90KSk7Cj4gPiAr CWlmIChyZXQgPCAwKSB7Cj4gPiArCQlpZ3Rfd2FybigiRmFpbGVkIHRvIHdyaXRlIC0gZXJyb3Ig JXNcbiIsCj4gPiBzdHJlcnJvcihlcnJubykpOwo+ID4gKwkJZ290byBvdXQ7Cj4gPiAgCX0KPiA+ ICsJcmV0ID0gZHBjZF9yZWFkKGZkLCBvZmZzZXQsIHNpemVvZih1aW50OF90KSk7Cj4gPiAgb3V0 Ogo+ID4gIAlyZXR1cm4gcmV0Owo+ID4gIH0KPiA+IEBAIC0xMTUsMTAgKzExMCwxMSBAQCBvdXQ6 Cj4gPiAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ID4gIHsKPiA+ICAJY2hhciBk ZXZfbmFtZVsyMF07Cj4gPiAtCWludCByZXQsIGRldmlkLCBoZWxwX2ZsZzsKPiA+ICsJaW50IGZk LCByZXQsIGRldmlkLCBoZWxwX2ZsZzsKPiA+ICAJdWludDMyX3Qgb2Zmc2V0Owo+ID4gIAl1aW50 OF90IHZhbDsKPiA+ICAJc2l6ZV90IGNvdW50Owo+ID4gKwlpbnQgZmlsZV9vcCA9IE9fUkRPTkxZ Owo+ID4gIAo+ID4gIAllbnVtIGNvbW1hbmQgewo+ID4gIAkJSU5WID0gLTEsCj4gPiBAQCAtMTU3 LDExICsxNTMsMTIgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ID4gIAkJCWJy ZWFrOwo+ID4gIAkJLyogQ29tbWFuZCBwYXJzaW5nICovCj4gPiAgCQljYXNlIDE6Cj4gPiAtCQkJ aWYgKHN0cmNtcChvcHRhcmcsICJyZWFkIikgPT0gMCkKPiA+ICsJCQlpZiAoc3RyY21wKG9wdGFy ZywgInJlYWQiKSA9PSAwKSB7Cj4gPiAgCQkJCWNtZCA9IFJFQUQ7Cj4gPiAtCQkJZWxzZSBpZiAo c3RyY21wKG9wdGFyZywgIndyaXRlIikgPT0gMCkKPiA+ICsJCQl9IGVsc2UgaWYgKHN0cmNtcChv cHRhcmcsICJ3cml0ZSIpID09IDApIHsKPiA+ICAJCQkJY21kID0gV1JJVEU7Cj4gPiAtCQkJYnJl YWs7Cj4gPiArCQkJCWZpbGVfb3AgPSBPX1JEV1I7Cj4gPiArCQkJfSBicmVhazsKPiA+ICAJCWNh c2UgJzonOgo+ID4gIAkJCWlndF93YXJuKCJUaGUgLSVjIG9wdGlvbiBvZiAlcyByZXF1aXJlcyBh bgo+ID4gYXJndW1lbnRcbiIsCj4gPiAgCQkJCSBvcHRvcHQsIGFyZ3ZbMF0pOwo+ID4gQEAgLTE4 NSwyMCArMTgyLDMzIEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiA+ICAJbWVt c2V0KGRldl9uYW1lLCAnXDAnLCAyMCk7Cj4gPiAgCXNucHJpbnRmKGRldl9uYW1lLCBzaXplb2Yo YXV4X2RldikgKyAyLCAiJXMlZCIsIGF1eF9kZXYsCj4gPiBkZXZpZCk7Cj4gPiAgCj4gPiArCWZk ID0gb3BlbihkZXZfbmFtZSwgZmlsZV9vcCk7Cj4gPiArCWlmIChmZCA8IDApIHsKPiA+ICsJCWln dF93YXJuKCJGYWlsZWQgdG8gb3BlbiAlcyBhdXggZGV2aWNlIC0gZXJyb3I6Cj4gPiAlc1xuIiwg ZGV2X25hbWUsCj4gPiArCQkJIHN0cmVycm9yKGVycm5vKSk7Cj4gPiArCQlyZXR1cm4gRVhJVF9G QUlMVVJFOwo+ID4gKwl9Cj4gPiArCj4gPiAgCXN3aXRjaCAoY21kKSB7Cj4gPiAgCWNhc2UgUkVB RDoKPiA+ICAJCWlmIChjb3VudCA9PSBJTlZBTElEKSB7Cj4gPiAgCQkJaWd0X3dhcm4oIlBsZWFz ZSBzcGVjaWZ5IHRoZSBjb3VudCBpbgo+ID4gYnl0ZXNcbiIpOwo+ID4gIAkJCXByaW50X3VzYWdl KGFyZ3ZbMF0sIDApOwo+ID4gIAkJfQo+ID4gLQkJcmV0ID0gZHBjZF9yZWFkKGRldl9uYW1lLCBv ZmZzZXQsIGNvdW50KTsKPiA+ICsJCXJldCA9IGRwY2RfcmVhZChmZCwgb2Zmc2V0LCBjb3VudCk7 Cj4gPiArCQlpZiAocmV0ICE9IGNvdW50KQo+ID4gKwkJCWlndF93YXJuKCJGYWlsZWQgdG8gcmVh ZCBmcm9tICVzIGF1eAo+ID4gZGV2aWNlXG4iLAo+ID4gKwkJCQkgZGV2X25hbWUpOwo+ID4gIAkJ YnJlYWs7Cj4gPiAgCWNhc2UgV1JJVEU6Cj4gPiAgCQlpZiAodmFsID09IElOVkFMSUQpIHsKPiA+ ICAJCQlpZ3Rfd2FybigiV3JpdGUgdmFsdWUgaXMgbWlzc2luZ1xuIik7Cj4gPiAgCQkJcHJpbnRf dXNhZ2UoYXJndlswXSwgMCk7Cj4gPiAgCQl9Cj4gPiAtCQlyZXQgPSBkcGNkX3dyaXRlKGRldl9u YW1lLCBvZmZzZXQsICZ2YWwpOwo+ID4gKwkJcmV0ID0gZHBjZF93cml0ZShmZCwgb2Zmc2V0LCAm dmFsKTsKPiA+ICsJCWlmIChyZXQgPCAwKQo+ID4gKwkJCWlndF93YXJuKCJGYWlsZWQgdG8gd3Jp dGUgdG8gJXMgYXV4Cj4gPiBkZXZpY2VcbiIsCj4gPiArCQkJCSBkZXZfbmFtZSk7Cj4gPiAgCQli cmVhazsKPiA+ICAJY2FzZSBJTlY6Cj4gPiAgCWRlZmF1bHQ6Cj4gPiBAQCAtMjA2LDUgKzIxNiw3 IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiA+ICAJCXByaW50X3VzYWdlKGFy Z3ZbMF0sIDApOwo+ID4gIAl9Cj4gPiAgCj4gPiArCWNsb3NlKGZkKTsKPiA+ICsKPiA+ICAJcmV0 dXJuIHJldDsKPiA+ICB9Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBpZ3QtZGV2IG1haWxpbmcgbGlzdAo+IGlndC1kZXZAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p Z3QtZGV2Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmln dC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=