[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Remove dead code

[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Remove dead code

[Antonio Argenziano]

Probably just leftover code that escaped review.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_ctx_isolation.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
index 4325e1c2..6b4e9260 100644
--- a/tests/gem_ctx_isolation.c
+++ b/tests/gem_ctx_isolation.c
@@ -700,7 +700,6 @@ igt_main
 		igt_require(has_context_isolation);
 
 		gen = intel_gen(intel_get_drm_devid(fd));
-		//igt_ci_fail_on(gen > LAST_KNOWN_GEN);
 		igt_skip_on(gen > LAST_KNOWN_GEN);
 	}
 
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Remove dead code

[Chris Wilson]

Quoting Antonio Argenziano (2018-09-06 17:51:56)
> Probably just leftover code that escaped review.

The '//' indicates a wish that igt_ci_fail_on() existed. The problem as
it currently stands is that we don't get a big warning to update this
test for future gen. iirc the intent was to try and reinforce that this
was a test limitation for CI and shouldn't alarm any other user.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Remove dead code

[Antonio Argenziano]

On 06/09/18 09:58, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-09-06 17:51:56)
>> Probably just leftover code that escaped review.
> 
> The '//' indicates a wish that igt_ci_fail_on() existed. The problem as
> it currently stands is that we don't get a big warning to update this
> test for future gen. iirc the intent was to try and reinforce that this
> was a test limitation for CI and shouldn't alarm any other user.

Change it to an igt_warn()? Not sure how CI deals with those but maybe 
we can ask to mark them in a special way.

Antonio

> -Chris
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/gem_ctx_isoation: Remove dead code

[Patchwork]

== Series Details ==

Series: tests/gem_ctx_isoation: Remove dead code
URL   : https://patchwork.freedesktop.org/series/49287/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4782 -> IGTPW_1803 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1803 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1803, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49287/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1803:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rpm@basic-pci-d3-state:
      fi-glk-j4005:       PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1803 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106725, fdo#106248)

    igt@gem_exec_suspend@basic-s3:
      fi-cfl-8109u:       PASS -> DMESG-WARN (fdo#107345)
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_flip@basic-flip-vs-dpms:
      fi-cfl-8109u:       PASS -> INCOMPLETE (fdo#106070)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000)

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106238) +1

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    igt@kms_psr@primary_page_flip:
      fi-kbl-r:           PASS -> FAIL (fdo#107336)

    igt@pm_rpm@module-reload:
      fi-glk-j4005:       PASS -> FAIL (fdo#107708, fdo#104767)

    
    ==== Possible fixes ====

    igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
      fi-kbl-8809g:       DMESG-WARN (fdo#107762) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-kbl-7560u:       FAIL (fdo#107336) -> PASS

    
    ==== Warnings ====

    igt@amdgpu/amd_prime@amd-to-i915:
      fi-kbl-8809g:       DMESG-FAIL (fdo#107762) -> FAIL (fdo#107341)

    
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104767 https://bugs.freedesktop.org/show_bug.cgi?id=104767
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
  fdo#106238 https://bugs.freedesktop.org/show_bug.cgi?id=106238
  fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
  fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107762 https://bugs.freedesktop.org/show_bug.cgi?id=107762


== Participating hosts (52 -> 49) ==

  Additional (2): fi-byt-j1900 fi-gdg-551 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4632 -> IGTPW_1803

  CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1803: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1803/
  IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1803/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Remove dead code

[Chris Wilson]

Quoting Antonio Argenziano (2018-09-06 18:05:48)
> 
> 
> On 06/09/18 09:58, Chris Wilson wrote:
> > Quoting Antonio Argenziano (2018-09-06 17:51:56)
> >> Probably just leftover code that escaped review.
> > 
> > The '//' indicates a wish that igt_ci_fail_on() existed. The problem as
> > it currently stands is that we don't get a big warning to update this
> > test for future gen. iirc the intent was to try and reinforce that this
> > was a test limitation for CI and shouldn't alarm any other user.
> 
> Change it to an igt_warn()? Not sure how CI deals with those but maybe 
> we can ask to mark them in a special way.

Seems reasonable. I can't remember if igt_warn + SKIP == orange flag in
CI. If it does, yes that seems fine. It doesn't really matter that much,
I just don't like indicating a fail in the case test hasn't been run
because it is out of date. (But that's probably too much hairsplitting
on my part.)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Remove dead code

[Petri Latvala]

On Thu, Sep 06, 2018 at 06:19:20PM +0100, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-09-06 18:05:48)
> > 
> > 
> > On 06/09/18 09:58, Chris Wilson wrote:
> > > Quoting Antonio Argenziano (2018-09-06 17:51:56)
> > >> Probably just leftover code that escaped review.
> > > 
> > > The '//' indicates a wish that igt_ci_fail_on() existed. The problem as
> > > it currently stands is that we don't get a big warning to update this
> > > test for future gen. iirc the intent was to try and reinforce that this
> > > was a test limitation for CI and shouldn't alarm any other user.
> > 
> > Change it to an igt_warn()? Not sure how CI deals with those but maybe 
> > we can ask to mark them in a special way.
> 
> Seems reasonable. I can't remember if igt_warn + SKIP == orange flag in
> CI. If it does, yes that seems fine. It doesn't really matter that much,
> I just don't like indicating a fail in the case test hasn't been run
> because it is out of date. (But that's probably too much hairsplitting
> on my part.)

For the record: Currently, no, igt_warn + SKIP == SKIP == grey.

Good news is that it's changeable easily as soon as igt_runner is used
in CI.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/gem_ctx_isoation: Remove dead code

[Patchwork]

== Series Details ==

Series: tests/gem_ctx_isoation: Remove dead code
URL   : https://patchwork.freedesktop.org/series/49287/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4632_full -> IGTPW_1803_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1803_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1803_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49287/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1803_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1803_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_busy@extended-pageflip-hang-oldfb-render-c:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_sysfs_edid_timing:
      shard-glk:          NOTRUN -> WARN (fdo#100047)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          FAIL (fdo#103355) -> PASS +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4632 -> IGTPW_1803
    * Linux: CI_DRM_4775 -> CI_DRM_4782

  CI_DRM_4775: 1a2bb6c061217718b972b3f4a74b96b61cf19d0c @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1803: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1803/
  IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1803/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Remove dead code

[Joonas Lahtinen]

Quoting Chris Wilson (2018-09-06 20:19:20)
> Quoting Antonio Argenziano (2018-09-06 18:05:48)
> > 
> > 
> > On 06/09/18 09:58, Chris Wilson wrote:
> > > Quoting Antonio Argenziano (2018-09-06 17:51:56)
> > >> Probably just leftover code that escaped review.
> > > 
> > > The '//' indicates a wish that igt_ci_fail_on() existed. The problem as
> > > it currently stands is that we don't get a big warning to update this
> > > test for future gen. iirc the intent was to try and reinforce that this
> > > was a test limitation for CI and shouldn't alarm any other user.
> > 
> > Change it to an igt_warn()? Not sure how CI deals with those but maybe 
> > we can ask to mark them in a special way.
> 
> Seems reasonable. I can't remember if igt_warn + SKIP == orange flag in
> CI. If it does, yes that seems fine. It doesn't really matter that much,
> I just don't like indicating a fail in the case test hasn't been run
> because it is out of date. (But that's probably too much hairsplitting
> on my part.)

There's a typo in the patch title s/isoation/isolation/.

Regards, Joonas
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev