igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Double check that the CRC collection is stable
@ 2018-09-07 10:19 Chris Wilson
  2018-09-07 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Chris Wilson @ 2018-09-07 10:19 UTC (permalink / raw)
  To: igt-dev

Read the target CRCs a second and require that they do not change, as
otherwise we know that the collection of CRCs is unreliable.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/kms_frontbuffer_tracking.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index e9abceb66..8ef07e3ae 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1193,6 +1193,7 @@ static void collect_crc(igt_crc_t *crc)
 static void init_blue_crc(enum pixel_format format)
 {
 	struct igt_fb blue;
+	igt_crc_t check;
 
 	if (blue_crcs[format].initialized)
 		return;
@@ -1214,11 +1215,13 @@ static void init_blue_crc(enum pixel_format format)
 	}
 
 	collect_crc(&blue_crcs[format].crc);
-
 	print_crc("Blue CRC:  ", &blue_crcs[format].crc);
 
-	igt_display_reset(&drm.display);
+	/* Check the CRC collection HW is stable */
+	collect_crc(&check);
+	igt_require(igt_check_crc_equal(&blue_crcs[format].crc, &check));
 
+	igt_display_reset(&drm.display);
 	igt_remove_fb(drm.fd, &blue);
 
 	blue_crcs[format].initialized = true;
-- 
2.19.0.rc2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-09-11  9:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-07 10:19 [igt-dev] [PATCH i-g-t] igt/kms_frontbuffer_tracking: Double check that the CRC collection is stable Chris Wilson
2018-09-07 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-09-07 11:01   ` Chris Wilson
2018-09-07 19:19 ` Patchwork
2018-09-07 20:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-09-11  8:40 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2018-09-11  9:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).