From: Daniel Vetter <daniel@ffwll.ch>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tests: Remove tools_test
Date: Fri, 14 Sep 2018 11:28:14 +0200 [thread overview]
Message-ID: <20180914092814.GN11082@phenom.ffwll.local> (raw)
In-Reply-To: <20180912065624.voyt2tffpbwhrvwk@ahiler-desk1.fi.intel.com>
On Wed, Sep 12, 2018 at 09:56:24AM +0300, Arkadiusz Hiler wrote:
> On Wed, Sep 12, 2018 at 09:51:24AM +0300, Petri Latvala wrote:
> > The test is basically just testing if the tools work properly with
> > little relevance to testing if the kernel works properly. If the
> > purpose was to test the kernel (or hardware), actual tests will be
> > better suited for the purpose. If the purpose was to test if the tools
> > work, sanity checks somewhere else for all tools instead of just two
> > is better suited for the purpose.
> >
> > In a nutshell, tools_test as such is fairly useless and has thus far
> > only revealed problems in testing setups (incorrect paths etc) instead
> > of problems in kernel or hardware.
> >
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Hm, not terribly happy about this. We have blown up the tools in trivial
ways before, that's why I wrote these. And yes it's incomplete coverage.
But we're also not going around deleting other igt tests, just because
they're not yet fully covering a given area.
So maybe add a FIXME here instead that there's work to do?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-14 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 6:51 [igt-dev] [PATCH i-g-t 1/1] tests: Remove tools_test Petri Latvala
2018-09-12 6:56 ` Arkadiusz Hiler
2018-09-14 9:28 ` Daniel Vetter [this message]
2018-09-14 13:27 ` Jani Nikula
2018-09-14 15:26 ` Daniel Vetter
2018-09-12 8:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-09-12 10:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914092814.GN11082@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox