igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] igt/gen3_*_blits: Add memory requirement checks
@ 2018-09-14 13:35 Chris Wilson
  2018-09-14 13:45 ` Ville Syrjälä
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-09-14 13:35 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev

Check we have sufficient memory to run the tests before getting trapped
in the swap of despair.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107935
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gen3_mixed_blits.c         | 1 +
 tests/gen3_render_linear_blits.c | 1 +
 tests/gen3_render_mixed_blits.c  | 1 +
 tests/gen3_render_tiledx_blits.c | 1 +
 tests/gen3_render_tiledy_blits.c | 1 +
 5 files changed, 5 insertions(+)

diff --git a/tests/gen3_mixed_blits.c b/tests/gen3_mixed_blits.c
index fa64598a6..948f4e6a7 100644
--- a/tests/gen3_mixed_blits.c
+++ b/tests/gen3_mixed_blits.c
@@ -458,6 +458,7 @@ int main(int argc, char **argv)
 	if (count == 0)
 		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
 	igt_info("Using %d 1MiB buffers\n", count);
+	intel_require_memory(count, 1024*1024, CHECK_RAM);
 
 	handle = malloc(sizeof(uint32_t)*count*3);
 	tiling = handle + count;
diff --git a/tests/gen3_render_linear_blits.c b/tests/gen3_render_linear_blits.c
index a03d7fc06..9d1499a59 100644
--- a/tests/gen3_render_linear_blits.c
+++ b/tests/gen3_render_linear_blits.c
@@ -333,6 +333,7 @@ int main(int argc, char **argv)
 	if (count == 0)
 		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
 	igt_info("Using %d 1MiB buffers\n", count);
+	intel_require_memory(count, 1024*1024, CHECK_RAM);
 
 	handle = malloc(sizeof(uint32_t)*count*2);
 	start_val = handle + count;
diff --git a/tests/gen3_render_mixed_blits.c b/tests/gen3_render_mixed_blits.c
index 2f127d993..afb53a598 100644
--- a/tests/gen3_render_mixed_blits.c
+++ b/tests/gen3_render_mixed_blits.c
@@ -352,6 +352,7 @@ int main(int argc, char **argv)
 	if (count == 0)
 		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
 	igt_info("Using %d 1MiB buffers\n", count);
+	intel_require_memory(count, 1024*1024, CHECK_RAM);
 
 	handle = malloc(sizeof(uint32_t)*count*3);
 	tiling = handle + count;
diff --git a/tests/gen3_render_tiledx_blits.c b/tests/gen3_render_tiledx_blits.c
index 06cdda382..e6246f2b0 100644
--- a/tests/gen3_render_tiledx_blits.c
+++ b/tests/gen3_render_tiledx_blits.c
@@ -339,6 +339,7 @@ int main(int argc, char **argv)
 	if (count == 0)
 		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
 	igt_info("Using %d 1MiB buffers\n", count);
+	intel_require_memory(count, 1024*1024, CHECK_RAM);
 
 	handle = malloc(sizeof(uint32_t)*count*2);
 	start_val = handle + count;
diff --git a/tests/gen3_render_tiledy_blits.c b/tests/gen3_render_tiledy_blits.c
index 9e4f4b77b..17502ccb7 100644
--- a/tests/gen3_render_tiledy_blits.c
+++ b/tests/gen3_render_tiledy_blits.c
@@ -339,6 +339,7 @@ int main(int argc, char **argv)
 	if (count == 0)
 		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
 	igt_info("Using %d 1MiB buffers\n", count);
+	intel_require_memory(count, 1024*1024, CHECK_RAM);
 
 	handle = malloc(sizeof(uint32_t)*count*2);
 	start_val = handle + count;
-- 
2.19.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gen3_*_blits: Add memory requirement checks
  2018-09-14 13:35 [igt-dev] [PATCH i-g-t] igt/gen3_*_blits: Add memory requirement checks Chris Wilson
@ 2018-09-14 13:45 ` Ville Syrjälä
  2018-09-14 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-09-14 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2018-09-14 13:45 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev, intel-gfx

On Fri, Sep 14, 2018 at 02:35:38PM +0100, Chris Wilson wrote:
> Check we have sufficient memory to run the tests before getting trapped
> in the swap of despair.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107935
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Looks consistent with the igt_info().

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/gen3_mixed_blits.c         | 1 +
>  tests/gen3_render_linear_blits.c | 1 +
>  tests/gen3_render_mixed_blits.c  | 1 +
>  tests/gen3_render_tiledx_blits.c | 1 +
>  tests/gen3_render_tiledy_blits.c | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/tests/gen3_mixed_blits.c b/tests/gen3_mixed_blits.c
> index fa64598a6..948f4e6a7 100644
> --- a/tests/gen3_mixed_blits.c
> +++ b/tests/gen3_mixed_blits.c
> @@ -458,6 +458,7 @@ int main(int argc, char **argv)
>  	if (count == 0)
>  		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
>  	igt_info("Using %d 1MiB buffers\n", count);
> +	intel_require_memory(count, 1024*1024, CHECK_RAM);
>  
>  	handle = malloc(sizeof(uint32_t)*count*3);
>  	tiling = handle + count;
> diff --git a/tests/gen3_render_linear_blits.c b/tests/gen3_render_linear_blits.c
> index a03d7fc06..9d1499a59 100644
> --- a/tests/gen3_render_linear_blits.c
> +++ b/tests/gen3_render_linear_blits.c
> @@ -333,6 +333,7 @@ int main(int argc, char **argv)
>  	if (count == 0)
>  		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
>  	igt_info("Using %d 1MiB buffers\n", count);
> +	intel_require_memory(count, 1024*1024, CHECK_RAM);
>  
>  	handle = malloc(sizeof(uint32_t)*count*2);
>  	start_val = handle + count;
> diff --git a/tests/gen3_render_mixed_blits.c b/tests/gen3_render_mixed_blits.c
> index 2f127d993..afb53a598 100644
> --- a/tests/gen3_render_mixed_blits.c
> +++ b/tests/gen3_render_mixed_blits.c
> @@ -352,6 +352,7 @@ int main(int argc, char **argv)
>  	if (count == 0)
>  		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
>  	igt_info("Using %d 1MiB buffers\n", count);
> +	intel_require_memory(count, 1024*1024, CHECK_RAM);
>  
>  	handle = malloc(sizeof(uint32_t)*count*3);
>  	tiling = handle + count;
> diff --git a/tests/gen3_render_tiledx_blits.c b/tests/gen3_render_tiledx_blits.c
> index 06cdda382..e6246f2b0 100644
> --- a/tests/gen3_render_tiledx_blits.c
> +++ b/tests/gen3_render_tiledx_blits.c
> @@ -339,6 +339,7 @@ int main(int argc, char **argv)
>  	if (count == 0)
>  		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
>  	igt_info("Using %d 1MiB buffers\n", count);
> +	intel_require_memory(count, 1024*1024, CHECK_RAM);
>  
>  	handle = malloc(sizeof(uint32_t)*count*2);
>  	start_val = handle + count;
> diff --git a/tests/gen3_render_tiledy_blits.c b/tests/gen3_render_tiledy_blits.c
> index 9e4f4b77b..17502ccb7 100644
> --- a/tests/gen3_render_tiledy_blits.c
> +++ b/tests/gen3_render_tiledy_blits.c
> @@ -339,6 +339,7 @@ int main(int argc, char **argv)
>  	if (count == 0)
>  		count = 3 * gem_aperture_size(fd) / (1024*1024) / 2;
>  	igt_info("Using %d 1MiB buffers\n", count);
> +	intel_require_memory(count, 1024*1024, CHECK_RAM);
>  
>  	handle = malloc(sizeof(uint32_t)*count*2);
>  	start_val = handle + count;
> -- 
> 2.19.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/gen3_*_blits: Add memory requirement checks
  2018-09-14 13:35 [igt-dev] [PATCH i-g-t] igt/gen3_*_blits: Add memory requirement checks Chris Wilson
  2018-09-14 13:45 ` Ville Syrjälä
@ 2018-09-14 15:46 ` Patchwork
  2018-09-14 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-09-14 15:46 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gen3_*_blits: Add memory requirement checks
URL   : https://patchwork.freedesktop.org/series/49714/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4825 -> IGTPW_1844 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49714/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1844 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-kbl-7560u:       FAIL (fdo#107336) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362


== Participating hosts (47 -> 44) ==

  Additional (1): fi-hsw-4770r 
  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4641 -> IGTPW_1844

  CI_DRM_4825: b42528aaa961c0d469f381b4a5c3830fe46aedfa @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1844: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1844/
  IGT_4641: 468febc4c746f168e885e0d662ec3adb0cca60f6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1844/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/gen3_*_blits: Add memory requirement checks
  2018-09-14 13:35 [igt-dev] [PATCH i-g-t] igt/gen3_*_blits: Add memory requirement checks Chris Wilson
  2018-09-14 13:45 ` Ville Syrjälä
  2018-09-14 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-09-14 20:14 ` Patchwork
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-09-14 20:14 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gen3_*_blits: Add memory requirement checks
URL   : https://patchwork.freedesktop.org/series/49714/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4641_full -> IGTPW_1844_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49714/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1844_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ctx_isolation@bcs0-s3:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    igt@kms_flip@2x-flip-vs-dpms:
      shard-glk:          PASS -> INCOMPLETE (fdo#103359, k.org#198133)

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#102887, fdo#105363)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@syncobj_basic@bad-pad-handle-to-fd:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106886) -> PASS

    igt@gem_softpin@noreloc-s3:
      shard-snb:          DMESG-WARN (fdo#102365) -> PASS

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS +1

    igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
      shard-glk:          DMESG-WARN (fdo#106538, fdo#105763) -> PASS

    igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled:
      shard-glk:          FAIL -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#103166, fdo#107749) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@prime_busy@wait-hang-blt:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    
  fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4641 -> IGTPW_1844
    * Linux: CI_DRM_4824 -> CI_DRM_4825

  CI_DRM_4824: 110556c298bfe6ce81b453869e60dedbd4f0f182 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4825: b42528aaa961c0d469f381b4a5c3830fe46aedfa @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1844: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1844/
  IGT_4641: 468febc4c746f168e885e0d662ec3adb0cca60f6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1844/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-14 20:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-14 13:35 [igt-dev] [PATCH i-g-t] igt/gen3_*_blits: Add memory requirement checks Chris Wilson
2018-09-14 13:45 ` Ville Syrjälä
2018-09-14 15:46 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-09-14 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).