Re: [igt-dev] [PATCH i-g-t 1/1] tests: Remove tools_test

Daniel Vetter
2018-09-14T09:28:18Z

On Wed, Sep 12, 2018 at 09:56:24AM +0300, Arkadiusz Hiler wrote:
> On Wed, Sep 12, 2018 at 09:51:24AM +0300, Petri Latvala wrote:
> > The test is basically just testing if the tools work properly with
> > little relevance to testing if the kernel works properly. If the
> > purpose was to test the kernel (or hardware), actual tests will be
> > better suited for the purpose. If the purpose was to test if the tools
> > work, sanity checks somewhere else for all tools instead of just two
> > is better suited for the purpose.
> >
> > In a nutshell, tools_test as such is fairly useless and has thus far
> > only revealed problems in testing setups (incorrect paths etc) instead
> > of problems in kernel or hardware.
> >
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>

Hm, not terribly happy about this. We have blown up the tools in trivial
ways before, that's why I wrote these. And yes it's incomplete coverage.
But we're also not going around deleting other igt tests, just because
they're not yet fully covering a given area.

So maybe add a FIXME here instead that there's work to do?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation