From: Chris Wilson <chris@chris-wilson.co.uk>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 4/5] lib/kms: Skip no-op display updates
Date: Fri, 14 Sep 2018 21:13:09 +0100 [thread overview]
Message-ID: <20180914201310.19527-4-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20180914201310.19527-1-chris@chris-wilson.co.uk>
If the display is disabled (e.g. the driver has disabled the KMS
interface) there is nothing to do so avoid failing.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/igt_kms.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 9710bcae1..dedc81344 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -3271,6 +3271,9 @@ static int do_display_commit(igt_display_t *display,
enum pipe pipe;
LOG_INDENT(display, "commit");
+ if (!display->n_pipes || !display->n_outputs)
+ return 0; /* nothing to do */
+
igt_display_refresh(display);
if (s == COMMIT_ATOMIC) {
@@ -3321,6 +3324,9 @@ int igt_display_try_commit_atomic(igt_display_t *display, uint32_t flags, void *
{
int ret;
+ if (!display->n_pipes || !display->n_outputs)
+ return 0; /* nothing to do */
+
LOG_INDENT(display, "commit");
igt_display_refresh(display);
--
2.19.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-14 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 20:13 [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use Chris Wilson
2018-09-14 20:13 ` [Intel-gfx] [PATCH i-g-t 2/5] igt/prime_vgem: Skip flip if no display Chris Wilson
2018-10-01 8:49 ` [igt-dev] " Daniel Vetter
2018-10-01 9:57 ` Chris Wilson
2018-09-14 20:13 ` [igt-dev] [PATCH i-g-t 3/5] lib: Report if kms is enabled on the display Chris Wilson
2018-10-01 8:46 ` [Intel-gfx] " Daniel Vetter
2018-09-14 20:13 ` Chris Wilson [this message]
2018-10-01 8:47 ` [igt-dev] [PATCH i-g-t 4/5] lib/kms: Skip no-op display updates Daniel Vetter
2018-09-14 20:13 ` [igt-dev] [PATCH i-g-t 5/5] igt: Require a display (KMS enabled) for KMS tests Chris Wilson
2018-09-14 20:48 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] igt/kms_getfb: Check the iface exists before use Patchwork
2018-09-15 1:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-09-28 10:19 [igt-dev] [PATCH i-g-t 1/5] " Chris Wilson
2018-09-28 10:20 ` [igt-dev] [PATCH i-g-t 4/5] lib/kms: Skip no-op display updates Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914201310.19527-4-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).