From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56A4B8930B for ; Sat, 15 Sep 2018 00:06:19 +0000 (UTC) Date: Fri, 14 Sep 2018 17:06:18 -0700 From: Tarun Vyas Message-ID: <20180915000618.GB65070@otc-chromeosbuild-5> References: <20180901041806.2627-1-rodrigo.vivi@intel.com> <20180901041806.2627-3-rodrigo.vivi@intel.com> <2469463c5fa78109ae302d79f3fedd8470700f54.camel@intel.com> <20180905181759.GA586@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180905181759.GA586@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 3/6] tools/dpcd_reg: Unify file handling. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Vivi Cc: igt-dev@lists.freedesktop.org, Dhinakaran Pandiyan List-ID: T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMTE6MTc6NTlBTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFR1ZSwgU2VwIDA0LCAyMDE4IGF0IDA1OjU2OjAxUE0gLTA3MDAsIERoaW5ha2Fy YW4gUGFuZGl5YW4gd3JvdGU6Cj4gPiBPbiBGcmksIDIwMTgtMDgtMzEgYXQgMjE6MTggLTA3MDAs IFJvZHJpZ28gVml2aSB3cm90ZToKPiA+ID4gQmVzaWRlcyByZW1vdmluZyBmZXcgY29kZSBkdXBs aWNhdGlvbiB0aGlzIHdpbGwKPiA+ID4gYWxsb3cgdXMgdG8gcmVhZCBtdWx0aXBsZSByZWdzIHdp dGhvdXQgaGF2aW5nCj4gPiA+IHRvIGtlZXAgY2xvc2luZyBhbmQgb3BlbmluZyB0aGUgZmlsZSBm b3IgZXZlcnkKPiA+ID4gcmVhZC4KPiA+ID4gCj4gPiA+IENjOiBUYXJ1biBWeWFzIDx0YXJ1bi52 eWFzQGludGVsLmNvbT4KPiA+ID4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4u cGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJv ZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgdG9vbHMvZHBjZF9yZWcuYyB8 IDk4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ID4g LS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1NSBpbnNlcnRpb25zKCspLCA0MyBkZWxldGlvbnMo LSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS90b29scy9kcGNkX3JlZy5jIGIvdG9vbHMvZHBj ZF9yZWcuYwo+ID4gPiBpbmRleCBkMTM5MDA3Yy4uMDlkYTQxMDkgMTAwNjQ0Cj4gPiA+IC0tLSBh L3Rvb2xzL2RwY2RfcmVnLmMKPiA+ID4gKysrIGIvdG9vbHMvZHBjZF9yZWcuYwo+ID4gPiBAQCAt NTMsNjEgKzUzLDU2IEBAIHN0YXRpYyB2b2lkIHByaW50X3VzYWdlKGNoYXIgKnRvb2wsIGludCBo ZWxwKQo+ID4gPiAgCWV4aXQoKGhlbHAgPT0gMSk/IEVYSVRfU1VDQ0VTUyA6IEVYSVRfRkFJTFVS RSk7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gLXN0YXRpYyBpbnQgZHBjZF9yZWFkKGNoYXIgKmRl dmljZSwgY29uc3QgdWludDMyX3Qgb2Zmc2V0LCBzaXplX3QKPiA+ID4gY291bnQpCj4gPiA+ICtz dGF0aWMgaW50IGRwY2RfcmVhZChpbnQgZmQsIGNvbnN0IHVpbnQzMl90IG9mZnNldCwgc2l6ZV90 IGNvdW50KQo+ID4gPiAgewo+ID4gPiAtCWludCBmZCwgcmV0LCBpOwo+ID4gPiArCWludCByZXQs IGk7Cj4gPiA+ICAJdm9pZCAqYnVmID0gbWFsbG9jKHNpemVvZih1aW50OF90KSAqIGNvdW50KTsK PiA+ID4gIAo+ID4gPiArCXJldCA9IGxzZWVrKGZkLCBvZmZzZXQsIFNFRUtfU0VUKTsKPiA+IERv ZXMgdGhpcyBvZmZlciBhbnkgYmVuZWZpdCBvdmVyIHByZWFkKCkvcHdyaXRlKCk/Cj4gCj4gSSdt IGhvbmVzdGx5IG5vdCBzdXJlLiBDYW4gd2UgdHJ1c3QgcHJlYWQvcHdyaXRlIHRoYXQgb2Zmc2V0 cyBhcmUgYWx3YXlzCj4gcmVsYXRpdmUgdG8gdGhlIGJlZ2luIG9mIHRoZSBmaWxlIG9yIHJlbGF0 aXZlIHRvIHdoZXJlIHRoZSBwb2ludGVyCj4gd2FzIGxlZnQgYWZ0ZXIgbGFzdCByZWFkL3dyaXRl IG9wZXJhdGlvbiBidXQgZmlsZSBub3QgY2xvc2VkPwo+IAo+IGxvb2tpbmcgdG8gdGhlIGRvY3Mg bHNlZWsgc2VlbWVkIG1vcmUgY3Jpc3B5IG9uIHRoZSBkZWZpbml0aW9uCj4gb2YgaXRzIG5hdmln YXRpb24gYW5kIHNpbmNlIEkgY2Fubm90IGd1YXJhbnRlZSBvcmRlciBvbiBkcGNkX2xpc3QKPiBJ IHByZWZlcnJlZCBsc2Vlay4KPiAKPiBidXQgaWYgeW91IGFyZSBzdXJlIHByZWFkL3B3cml0ZSBp cyByZWxpYWJsZSBhbmQgbm90IHJlbGF0aXZlIHBvc2l0aW9uCj4gYW5kIHlvdSBoYXZlIHN0cm9u ZyBwcmVmZXJlbmNlIG9uIHRoYXQgSSBjYW4gY2hhbmdlIGJhY2suCj4gCj4gVGhhbmtzLAo+IFJv ZHJpZ28uCj4gCj4gPgpJIHRyaWVkIG11bHRpcGxlIHJlYWRzIHdpdGggcHJlYWQoKSBhbmQgaXQg d29ya3MgT0suIFRoZSBkb2MgbWVudGlvbnMgdGhhdCB0aGUgZmlsZSBvZmZzZXQgd2lsbCBub3Qg YmUgY2hhbmdlZCBieSBwcmVhZCgpIHNvIGFsbCB0aGUgb2Zmc2V0cyBwYXNzZWQgdG8gaXQgd2ls bCBiZSByZWxhdGl2ZSB0byB0aGUgYmVnaW5pbmcgb2YgdGhlIGZpbGUuCj4gPiA+ICsJaWYgKHJl dCA8IDApIHsKPiA+ID4gKwkJaWd0X3dhcm4oImxzZWVrIHRvICUwNHggZmFpbGVkIVxuIiwgb2Zm c2V0KTsKPiA+ID4gKwkJcmV0dXJuIHJldDsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gIAlpZiAo TlVMTCAhPSBidWYpCj4gPiA+ICAJCW1lbXNldChidWYsIDAsIHNpemVvZih1aW50OF90KSAqIGNv dW50KTsKPiA+ID4gIAllbHNlIHsKPiA+ID4gIAkJaWd0X3dhcm4oIkNhbid0IGFsbG9jYXRlIHJl YWQgYnVmZmVyXG4iKTsKPiA+ID4gLQkJcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiA+ID4gKwkJcmV0 dXJuIC0xOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAtCWZkID0gb3BlbihkZXZpY2UsIE9fUkRP TkxZKTsKPiA+ID4gLQlpZiAoZmQgPiAwKSB7Cj4gPiA+IC0JCXJldCA9IHByZWFkKGZkLCBidWYs IGNvdW50LCBvZmZzZXQpOwo+ID4gPiAtCQljbG9zZShmZCk7Cj4gPiA+IC0JCWlmIChyZXQgIT0g Y291bnQpIHsKPiA+ID4gLQkJCWlndF93YXJuKCJGYWlsZWQgdG8gcmVhZCBmcm9tICVzIGF1eCBk ZXZpY2UKPiA+ID4gLSBlcnJvciAlc1xuIiwgZGV2aWNlLCBzdHJlcnJvcihlcnJubykpOwo+ID4g PiAtCQkJcmV0ID0gRVhJVF9GQUlMVVJFOwo+ID4gPiAtCQkJZ290byBvdXQ7Cj4gPiA+IC0JCX0K PiA+ID4gLQo+ID4gPiAtCQlpZ3RfaW5mbygiJTA0eDoiLCBvZmZzZXQpOwo+ID4gPiAtCQlmb3Ig KGkgPSAwOyBpIDwgY291bnQ7IGkrKykKPiA+ID4gLQkJCWlndF9pbmZvKCIgJTAyeCIsICooKCh1 aW50OF90ICopKGJ1ZikpICsKPiA+ID4gaSkpOwo+ID4gPiAtCQlpZ3RfaW5mbygiXG4iKTsKPiA+ ID4gLQl9Cj4gPiA+IC0JZWxzZSB7Cj4gPiA+IC0JCWlndF93YXJuKCJGYWlsZWQgdG8gb3BlbiAl cyBhdXggZGV2aWNlIC0gZXJyb3I6Cj4gPiA+ICVzXG4iLCBkZXZpY2UsIHN0cmVycm9yKGVycm5v KSk7Cj4gPiA+IC0JCXJldCA9IEVYSVRfRkFJTFVSRTsKPiA+ID4gKwlyZXQgPSByZWFkKGZkLCBi dWYsIGNvdW50KTsKPiA+ID4gKwlpZiAocmV0ICE9IGNvdW50KSB7Cj4gPiA+ICsJCWlndF93YXJu KCJGYWlsZWQgdG8gcmVhZCAtIGVycm9yICVzXG4iLAo+ID4gPiBzdHJlcnJvcihlcnJubykpOwo+ ID4gPiArCQlnb3RvIG91dDsKPiA+ID4gIAl9Cj4gPiA+ICsKPiA+ID4gKwlpZ3RfaW5mbygiJTA0 eDoiLCBvZmZzZXQpOwo+ID4gPiArCWZvciAoaSA9IDA7IGkgPCBjb3VudDsgaSsrKQo+ID4gPiAr CQlpZ3RfaW5mbygiICUwMngiLCAqKCgodWludDhfdCAqKShidWYpKSArIGkpKTsKPiA+ID4gKwlp Z3RfaW5mbygiXG4iKTsKPiA+ID4gKwo+ID4gPiAgb3V0Ogo+ID4gPiAgCWZyZWUoYnVmKTsKPiA+ ID4gIAlyZXR1cm4gcmV0Owo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+IC1zdGF0aWMgaW50IGRwY2Rf d3JpdGUoY2hhciAqZGV2aWNlLCBjb25zdCB1aW50MzJfdCBvZmZzZXQsIGNvbnN0Cj4gPiA+IHVp bnQ4X3QgKnZhbCkKPiA+ID4gK3N0YXRpYyBpbnQgZHBjZF93cml0ZShpbnQgZmQsIGNvbnN0IHVp bnQzMl90IG9mZnNldCwgY29uc3QgdWludDhfdAo+ID4gPiAqdmFsKQo+ID4gPiAgewo+ID4gPiAt CWludCBmZCwgcmV0Owo+ID4gPiAtCj4gPiA+IC0JZmQgPSBvcGVuKGRldmljZSwgT19SRFdSKTsK PiA+ID4gLQlpZiAoZmQgPiAwKSB7Cj4gPiA+IC0JCXJldCA9IHB3cml0ZShmZCwgKGNvbnN0IHZv aWQgKil2YWwsIHNpemVvZih1aW50OF90KSwKPiA+ID4gb2Zmc2V0KTsKPiA+ID4gLQkJY2xvc2Uo ZmQpOwo+ID4gPiAtCQlpZiAocmV0IDwgMCkgewo+ID4gPiAtCQkJaWd0X3dhcm4oIkZhaWxlZCB0 byB3cml0ZSB0byAlcyBhdXggZGV2aWNlIC0KPiA+ID4gZXJyb3IgJXNcbiIsIGRldmljZSwgc3Ry ZXJyb3IoZXJybm8pKTsKPiA+ID4gLQkJCXJldCA9IEVYSVRfRkFJTFVSRTsKPiA+ID4gLQkJCWdv dG8gb3V0Owo+ID4gPiAtCQl9Cj4gPiA+IC0JCXJldCA9IGRwY2RfcmVhZChkZXZpY2UsIG9mZnNl dCwgc2l6ZW9mKHVpbnQ4X3QpKTsKPiA+ID4gKwlpbnQgcmV0Owo+ID4gPiArCj4gPiA+ICsJcmV0 ID0gbHNlZWsoZmQsIG9mZnNldCwgU0VFS19TRVQpOwo+ID4gPiArCWlmIChyZXQgPCAwKSB7Cj4g PiA+ICsJCWlndF93YXJuKCJsc2VlayB0byAlMDR4IGZhaWxlZCFcbiIsIG9mZnNldCk7Cj4gPiA+ ICsJCXJldHVybiByZXQ7Cj4gPiA+ICAJfQo+ID4gPiAtCWVsc2Ugewo+ID4gPiAtCQlpZ3Rfd2Fy bigiRmFpbGVkIHRvIG9wZW4gJXMgYXV4IGRldmljZSAtIGVycm9yOgo+ID4gPiAlc1xuIiwgZGV2 aWNlLCBzdHJlcnJvcihlcnJubykpOwo+ID4gPiAtCQlyZXQgPSBFWElUX0ZBSUxVUkU7Cj4gPiA+ ICsKPiA+ID4gKwlyZXQgPSB3cml0ZShmZCwgKGNvbnN0IHZvaWQgKil2YWwsIHNpemVvZih1aW50 OF90KSk7Cj4gPiA+ICsJaWYgKHJldCA8IDApIHsKPiA+ID4gKwkJaWd0X3dhcm4oIkZhaWxlZCB0 byB3cml0ZSAtIGVycm9yICVzXG4iLAo+ID4gPiBzdHJlcnJvcihlcnJubykpOwo+ID4gPiArCQln b3RvIG91dDsKPiA+ID4gIAl9Cj4gPiA+ICsJcmV0ID0gZHBjZF9yZWFkKGZkLCBvZmZzZXQsIHNp emVvZih1aW50OF90KSk7Cj4gPiA+ICBvdXQ6Cj4gPiA+ICAJcmV0dXJuIHJldDsKPiA+ID4gIH0K PiA+ID4gQEAgLTExNSwxMCArMTEwLDExIEBAIG91dDoKPiA+ID4gIGludCBtYWluKGludCBhcmdj LCBjaGFyICoqYXJndikKPiA+ID4gIHsKPiA+ID4gIAljaGFyIGRldl9uYW1lWzIwXTsKPiA+ID4g LQlpbnQgcmV0LCBkZXZpZCwgaGVscF9mbGc7Cj4gPiA+ICsJaW50IGZkLCByZXQsIGRldmlkLCBo ZWxwX2ZsZzsKPiA+ID4gIAl1aW50MzJfdCBvZmZzZXQ7Cj4gPiA+ICAJdWludDhfdCB2YWw7Cj4g PiA+ICAJc2l6ZV90IGNvdW50Owo+ID4gPiArCWludCBmaWxlX29wID0gT19SRE9OTFk7Cj4gPiA+ ICAKPiA+ID4gIAllbnVtIGNvbW1hbmQgewo+ID4gPiAgCQlJTlYgPSAtMSwKPiA+ID4gQEAgLTE1 NywxMSArMTUzLDEyIEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiA+ID4gIAkJ CWJyZWFrOwo+ID4gPiAgCQkvKiBDb21tYW5kIHBhcnNpbmcgKi8KPiA+ID4gIAkJY2FzZSAxOgo+ ID4gPiAtCQkJaWYgKHN0cmNtcChvcHRhcmcsICJyZWFkIikgPT0gMCkKPiA+ID4gKwkJCWlmIChz dHJjbXAob3B0YXJnLCAicmVhZCIpID09IDApIHsKPiA+ID4gIAkJCQljbWQgPSBSRUFEOwo+ID4g PiAtCQkJZWxzZSBpZiAoc3RyY21wKG9wdGFyZywgIndyaXRlIikgPT0gMCkKPiA+ID4gKwkJCX0g ZWxzZSBpZiAoc3RyY21wKG9wdGFyZywgIndyaXRlIikgPT0gMCkgewo+ID4gPiAgCQkJCWNtZCA9 IFdSSVRFOwo+ID4gPiAtCQkJYnJlYWs7Cj4gPiA+ICsJCQkJZmlsZV9vcCA9IE9fUkRXUjsKPiA+ ID4gKwkJCX0gYnJlYWs7Cj4gPiA+ICAJCWNhc2UgJzonOgo+ID4gPiAgCQkJaWd0X3dhcm4oIlRo ZSAtJWMgb3B0aW9uIG9mICVzIHJlcXVpcmVzIGFuCj4gPiA+IGFyZ3VtZW50XG4iLAo+ID4gPiAg CQkJCSBvcHRvcHQsIGFyZ3ZbMF0pOwo+ID4gPiBAQCAtMTg1LDIwICsxODIsMzMgQEAgaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ID4gPiAgCW1lbXNldChkZXZfbmFtZSwgJ1wwJywg MjApOwo+ID4gPiAgCXNucHJpbnRmKGRldl9uYW1lLCBzaXplb2YoYXV4X2RldikgKyAyLCAiJXMl ZCIsIGF1eF9kZXYsCj4gPiA+IGRldmlkKTsKPiA+ID4gIAo+ID4gPiArCWZkID0gb3BlbihkZXZf bmFtZSwgZmlsZV9vcCk7Cj4gPiA+ICsJaWYgKGZkIDwgMCkgewo+ID4gPiArCQlpZ3Rfd2Fybigi RmFpbGVkIHRvIG9wZW4gJXMgYXV4IGRldmljZSAtIGVycm9yOgo+ID4gPiAlc1xuIiwgZGV2X25h bWUsCj4gPiA+ICsJCQkgc3RyZXJyb3IoZXJybm8pKTsKPiA+ID4gKwkJcmV0dXJuIEVYSVRfRkFJ TFVSRTsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gIAlzd2l0Y2ggKGNtZCkgewo+ID4gPiAgCWNh c2UgUkVBRDoKPiA+ID4gIAkJaWYgKGNvdW50ID09IElOVkFMSUQpIHsKPiA+ID4gIAkJCWlndF93 YXJuKCJQbGVhc2Ugc3BlY2lmeSB0aGUgY291bnQgaW4KPiA+ID4gYnl0ZXNcbiIpOwo+ID4gPiAg CQkJcHJpbnRfdXNhZ2UoYXJndlswXSwgMCk7Cj4gPiA+ICAJCX0KPiA+ID4gLQkJcmV0ID0gZHBj ZF9yZWFkKGRldl9uYW1lLCBvZmZzZXQsIGNvdW50KTsKPiA+ID4gKwkJcmV0ID0gZHBjZF9yZWFk KGZkLCBvZmZzZXQsIGNvdW50KTsKPiA+ID4gKwkJaWYgKHJldCAhPSBjb3VudCkKPiA+ID4gKwkJ CWlndF93YXJuKCJGYWlsZWQgdG8gcmVhZCBmcm9tICVzIGF1eAo+ID4gPiBkZXZpY2VcbiIsCj4g PiA+ICsJCQkJIGRldl9uYW1lKTsKPiA+ID4gIAkJYnJlYWs7Cj4gPiA+ICAJY2FzZSBXUklURToK PiA+ID4gIAkJaWYgKHZhbCA9PSBJTlZBTElEKSB7Cj4gPiA+ICAJCQlpZ3Rfd2FybigiV3JpdGUg dmFsdWUgaXMgbWlzc2luZ1xuIik7Cj4gPiA+ICAJCQlwcmludF91c2FnZShhcmd2WzBdLCAwKTsK PiA+ID4gIAkJfQo+ID4gPiAtCQlyZXQgPSBkcGNkX3dyaXRlKGRldl9uYW1lLCBvZmZzZXQsICZ2 YWwpOwo+ID4gPiArCQlyZXQgPSBkcGNkX3dyaXRlKGZkLCBvZmZzZXQsICZ2YWwpOwo+ID4gPiAr CQlpZiAocmV0IDwgMCkKPiA+ID4gKwkJCWlndF93YXJuKCJGYWlsZWQgdG8gd3JpdGUgdG8gJXMg YXV4Cj4gPiA+IGRldmljZVxuIiwKPiA+ID4gKwkJCQkgZGV2X25hbWUpOwo+ID4gPiAgCQlicmVh azsKPiA+ID4gIAljYXNlIElOVjoKPiA+ID4gIAlkZWZhdWx0Ogo+ID4gPiBAQCAtMjA2LDUgKzIx Niw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiA+ID4gIAkJcHJpbnRfdXNh Z2UoYXJndlswXSwgMCk7Cj4gPiA+ICAJfQo+ID4gPiAgCj4gPiA+ICsJY2xvc2UoZmQpOwo+ID4g PiArCj4gPiA+ICAJcmV0dXJuIHJldDsKPiA+ID4gIH0KPiA+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBpZ3QtZGV2IG1haWxpbmcgbGlzdAo+ID4g aWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gaWd0LWRldiBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaWd0LWRldgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ln dC1kZXYK