igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v2 1/3] tests/kms_frontbuffer_tracking: Pass the debugfs fd to psr_wait_entry()
@ 2018-09-20 17:59 José Roberto de Souza
  2018-09-20 17:59 ` [igt-dev] [PATCH i-g-t v2 2/3] lib/igt_psr: Give a explicit parameter name to functions that expect debugfs fd José Roberto de Souza
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: José Roberto de Souza @ 2018-09-20 17:59 UTC (permalink / raw)
  To: igt-dev

psr_wait_entry() uses the fd to the debugfs directory not the fd
the drm device.

This fix some kms_frontbuffers_tracking tests:
...
(kms_frontbuffer_tracking:1353) DEBUG: Calculated CRC: pipe:[94a0476d 00000000 00000000 00000000 00000000]
(kms_frontbuffer_tracking:1353) DEBUG: Test requirement passed: !fbc_not_enough_stolen()
(kms_frontbuffer_tracking:1353) DEBUG: Test requirement passed: !fbc_stride_not_supported()
(kms_frontbuffer_tracking:1353) DEBUG: Test requirement passed: !fbc_mode_too_large()
(kms_frontbuffer_tracking:1353) DEBUG: fbc_is_enabled()?
FBC enabled
Compressing: yes
(kms_frontbuffer_tracking:1353) DEBUG: fbc_is_enabled(IGT_LOG_DEBUG) took 0ms
(kms_frontbuffer_tracking:1353) DEBUG: fbc_is_compressing() took 0ms
(kms_frontbuffer_tracking:1353) CRITICAL: Test assertion failure function do_status_assertions, file ../tests/kms_frontbuffer_tracking.c:1634:
(kms_frontbuffer_tracking:1353) CRITICAL: Failed assertion: psr_wait_entry(drm.fd)
(kms_frontbuffer_tracking:1353) CRITICAL: Last errno: 20, Not a directory
(kms_frontbuffer_tracking:1353) CRITICAL: PSR still disabled
(kms_frontbuffer_tracking:1353) igt_core-INFO: Stack trace:
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #0 ../lib/igt_core.c:1467 __igt_fail_assert()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #1 ../tests/kms_frontbuffer_tracking.c:1635 do_status_assertions()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #2 ../tests/kms_frontbuffer_tracking.c:1663 __do_assertions()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #3 ../tests/kms_frontbuffer_tracking.c:1687 enable_prim_screen_and_wait()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #4 ../tests/kms_frontbuffer_tracking.c:1847 prepare_subtest_screens()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #5 ../tests/kms_frontbuffer_tracking.c:1867 prepare_subtest()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #6 ../tests/kms_frontbuffer_tracking.c:2987 tilingchange_subtest()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #7 ../tests/kms_frontbuffer_tracking.c:3474 main()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #8 ../csu/libc-start.c:344 __libc_start_main()
(kms_frontbuffer_tracking:1353) igt_core-INFO:   #9 [_start+0x2a]

v2: Fixing code style

Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/kms_frontbuffer_tracking.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index b33f3128..1bce6760 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1631,7 +1631,8 @@ static void do_status_assertions(int flags)
 	}
 
 	if (flags & ASSERT_PSR_ENABLED)
-		igt_assert_f(psr_wait_entry(drm.fd), "PSR still disabled\n");
+		igt_assert_f(psr_wait_entry(drm.debugfs),
+			     "PSR still disabled\n");
 	else if (flags & ASSERT_PSR_DISABLED)
 		igt_assert_f(psr_active(drm.debugfs, false),
 			     "PSR still enabled\n");
-- 
2.19.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-09-21  3:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 17:59 [igt-dev] [PATCH i-g-t v2 1/3] tests/kms_frontbuffer_tracking: Pass the debugfs fd to psr_wait_entry() José Roberto de Souza
2018-09-20 17:59 ` [igt-dev] [PATCH i-g-t v2 2/3] lib/igt_psr: Give a explicit parameter name to functions that expect debugfs fd José Roberto de Souza
2018-09-20 17:59 ` [igt-dev] [PATCH i-g-t v2 3/3] test/kms_fbcon_fbt: " José Roberto de Souza
2018-09-20 18:26 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/3] tests/kms_frontbuffer_tracking: Pass the debugfs fd to psr_wait_entry() Patchwork
2018-09-20 21:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-09-20 23:05 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2018-09-21  3:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).