From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format.
Date: Mon, 24 Sep 2018 15:41:06 +0300 [thread overview]
Message-ID: <20180924124106.GM5565@intel.com> (raw)
In-Reply-To: <20180924064449.25013-1-maarten.lankhorst@linux.intel.com>
On Mon, Sep 24, 2018 at 08:44:49AM +0200, Maarten Lankhorst wrote:
> Creating a YUV FB in a high resolution takes too long, and we end up with:
> [drm:drm_crtc_add_crc_entry] *ERROR* Overflow of CRC buffer, userspace reads too slow.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106885
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> tests/kms_plane.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index aa36ddeba31a..d00baeaff72d 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -419,7 +419,7 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
> igt_plane_set_fb(plane, fb);
>
> igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> - igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
> + igt_pipe_crc_collect_crc(data->pipe_crc, crc);
That's going to slow the test down even more :(
>
> igt_remove_fb(data->drm_fd, &old_fb);
> }
> @@ -466,7 +466,6 @@ static void test_format_plane(data_t *data, enum pipe pipe,
> set_legacy_lut(data, pipe, 0xfc00);
>
> test_init(data, pipe);
> - igt_pipe_crc_start(data->pipe_crc);
_stop() needs removing too.
>
> igt_info("Testing format " IGT_FORMAT_FMT " on %s.%u\n",
> IGT_FORMAT_ARGS(format),
> --
> 2.19.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-09-24 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 6:44 [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format Maarten Lankhorst
2018-09-24 7:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-09-24 7:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-09-24 12:41 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924124106.GM5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).