From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A5656E11C for ; Thu, 27 Sep 2018 12:21:36 +0000 (UTC) Date: Thu, 27 Sep 2018 15:21:28 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20180927122128.GX9144@intel.com> References: <20180925145357.7918-1-ville.syrjala@linux.intel.com> <1a23fddd-f1ec-1bfd-ebdf-5b7a662496df@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1a23fddd-f1ec-1bfd-ebdf-5b7a662496df@gmail.com> Subject: Re: [igt-dev] [PATCH i-g-t] lib/debugfs: Use a blocking read in igt_pipe_crc_get_single() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Juha-Pekka =?iso-8859-1?Q?Heikkil=E4?= Cc: igt-dev@lists.freedesktop.org List-ID: T24gV2VkLCBTZXAgMjYsIDIwMTggYXQgMDk6NTY6NDdQTSArMDMwMCwgSnVoYS1QZWtrYSBIZWlr a2lsw6Qgd3JvdGU6Cj4gTG9va3MgZ29vZC4gSSBzdXNwZWN0IHRoaXMgd2lsbCByZWR1Y2UgdGhv c2UgcmFuZG9tIGNyYyBlcnJvcnMgc2VlbiBpbiBDSS4KPiAKPiBSZXZpZXdlZC1ieTogSnVoYS1Q ZWtrYSBIZWlra2lsYSA8anVoYXBla2thLmhlaWtraWxhQGdtYWlsLmNvbT4KPiAKPiBWaWxsZSBT eXJqYWxhIGtpcmpvaXR0aSAyNS45LjIwMTgga2xvIDE3LjUzOgo+ID4gRnJvbTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gQWxsIHVzZXJz IG9mIGlndF9waXBlX2NyY19nZXRfc2luZ2xlKCkgd2FudCBhIGJsb2NraW5nIHJlYWQgZXZlbiBp Zgo+ID4gdGhlIGZkIHdhcyBvcGVuZWQgaW4gbm9uYmxvY2tpbmcgbW9kZS4gTWFrZSBpdCBzby4K PiA+IAo+ID4gQ2M6IEp1aGEtUGVra2EgSGVpa2tpbGEgPGp1aGFwZWtrYS5oZWlra2lsYUBnbWFp bC5jb20+Cj4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4 LmludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICAgbGliL2lndF9kZWJ1Z2ZzLmMgICAg ICAgICAgIHwgMzUgKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAgbGli L2lndF9kZWJ1Z2ZzLmggICAgICAgICAgIHwgIDIgKy0KPiA+ICAgdGVzdHMva21zX2Nodl9jdXJz b3JfZmFpbC5jIHwgIDIgKy0KPiA+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCsp LCAyNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZGVidWdmcy5j IGIvbGliL2lndF9kZWJ1Z2ZzLmMKPiA+IGluZGV4IGJhZWRjMjI1NWFjOS4uZDE1MWQ5YjIzZWQ0 IDEwMDY0NAo+ID4gLS0tIGEvbGliL2lndF9kZWJ1Z2ZzLmMKPiA+ICsrKyBiL2xpYi9pZ3RfZGVi dWdmcy5jCj4gPiBAQCAtNzU3LDggKzc1NywxMyBAQCBzdGF0aWMgdm9pZCByZWFkX29uZV9jcmMo aWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjLCBpZ3RfY3JjX3QgKm91dCkKPiA+ICAgewo+ID4gICAJ aW50IHJldDsKPiA+ICAgCj4gPiAtCXdoaWxlICgocmV0ID0gcmVhZF9jcmMocGlwZV9jcmMsIG91 dCkpIDw9IDAgJiYgcmV0ICE9IC1FSU5WQUwpCj4gPiAtCQl1c2xlZXAoMTAwMCk7Cj4gPiArCWZj bnRsKHBpcGVfY3JjLT5jcmNfZmQsIEZfU0VURkwsIHBpcGVfY3JjLT5mbGFncyAmIH5PX05PTkJM T0NLKTsKPiA+ICsKPiA+ICsJZG8gewo+ID4gKwkJcmV0ID0gcmVhZF9jcmMocGlwZV9jcmMsIG91 dCk7Cj4gPiArCX0gd2hpbGUgKHJldCA9PSAtRUlOVFIpOwo+ID4gKwo+ID4gKwlmY250bChwaXBl X2NyYy0+Y3JjX2ZkLCBGX1NFVEZMLCBwaXBlX2NyYy0+ZmxhZ3MpOwo+ID4gICB9Cj4gPiAgIAo+ ID4gICAvKioKPiA+IEBAIC05MjYsMTIgKzkzMSw4IEBAIHZvaWQgaWd0X3BpcGVfY3JjX2RyYWlu KGlndF9waXBlX2NyY190ICpwaXBlX2NyYykKPiA+ICAgICogQHBpcGVfY3JjOiBwaXBlIENSQyBv YmplY3QKPiA+ICAgICogQGNyYzogYnVmZmVyIHBvaW50ZXIgZm9yIHRoZSBjYXB0dXJlZCBDUkMg dmFsdWUKPiA+ICAgICoKPiA+IC0gKiBSZWFkIGEgc2luZ2xlIEBjcmMgZnJvbSBAcGlwZV9jcmMu IFRoaXMgZnVuY3Rpb24gZG9lcyBub3QgYmxvY2sKPiA+IC0gKiB3aGVuIG5vbmJsb2NraW5nIENS QyBpcyByZXF1ZXN0ZWQsIGFuZCB3aWxsIHJldHVybiBmYWxzZSBpZiBubyBDUkMKPiA+IC0gKiBj YW4gYmUgY2FwdHVyZWQuCj4gPiAtICoKPiA+IC0gKiBJZiBvcGVuZWQgaW4gYmxvY2tpbmcgbW9k ZSBpdCB3aWxsIGFsd2F5cyBibG9jayB1bnRpbCBhIG5ldyBDUkMgaXMgcmVhZCwgbGlrZQo+ID4g LSAqIGlndF9waXBlX2NyY19jb2xsZWN0X2NyYygpLgo+ID4gKyAqIFJlYWQgYSBzaW5nbGUgQGNy YyBmcm9tIEBwaXBlX2NyYy4gVGhpcyBmdW5jdGlvbiBibG9ja3MgZXZlbgo+ID4gKyAqIHdoZW4g bm9uYmxvY2tpbmcgQ1JDIGlzIHJlcXVlc3RlZC4KPiA+ICAgICoKPiA+ICAgICogQ2FsbGVycyBt dXN0IHN0YXJ0IGFuZCBzdG9wIHRoZSBjYXB0dXJpbmcgdGhlbXNlbHZlcyBieSBjYWxsaW5nCj4g PiAgICAqIGlndF9waXBlX2NyY19zdGFydCgpIGFuZCBpZ3RfcGlwZV9jcmNfc3RvcCgpLiBGb3Ig b25lLXNob3QgQ1JDIGNvbGxlY3RpbmcKPiA+IEBAIC05NDMsMjIgKzk0NCwxMSBAQCB2b2lkIGln dF9waXBlX2NyY19kcmFpbihpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMpCj4gPiAgICAqIFJldHVy bnM6Cj4gPiAgICAqIFdoZXRoZXIgYSBjcmMgaXMgY2FwdHVyZWQsIG9ubHkgZmFsc2UgaW4gbm9u LWJsb2NraW5nIG1vZGUuCgpJIGp1c3Qgbm90aWNlZCB0aGF0IEkgZmFpbGVkIHRvIHJlbW92ZSB0 aGlzICJSZXR1cm5zOiAuLi4iIHN0dWZmIGhlcmUuCkZpeGVkIHdoaWxlIHB1c2hpbmcuIFRoYW5r cyBmb3IgdGhlIHJldmlldy4KCj4gPiAgICAqLwo+ID4gLWJvb2wKPiA+IC1pZ3RfcGlwZV9jcmNf Z2V0X3NpbmdsZShpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqY3JjKQo+ID4g K3ZvaWQgaWd0X3BpcGVfY3JjX2dldF9zaW5nbGUoaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjLCBp Z3RfY3JjX3QgKmNyYykKPiA+ICAgewo+ID4gLQlib29sIGZvdW5kID0gdHJ1ZTsKPiA+ICsJcmVh ZF9vbmVfY3JjKHBpcGVfY3JjLCBjcmMpOwo+ID4gICAKPiA+IC0JaWYgKHBpcGVfY3JjLT5mbGFn cyAmIE9fTk9OQkxPQ0spIHsKPiA+IC0JCWludCByZXQgPSByZWFkX2NyYyhwaXBlX2NyYywgY3Jj KTsKPiA+IC0KPiA+IC0JCWZvdW5kID0gcmV0ID4gMDsKPiA+IC0JfSBlbHNlCj4gPiAtCQlyZWFk X29uZV9jcmMocGlwZV9jcmMsIGNyYyk7Cj4gPiAtCj4gPiAtCWlmIChmb3VuZCkKPiA+IC0JCWNy Y19zYW5pdHlfY2hlY2tzKGNyYyk7Cj4gPiAtCj4gPiAtCXJldHVybiBmb3VuZDsKPiA+ICsJY3Jj X3Nhbml0eV9jaGVja3MoY3JjKTsKPiA+ICAgfQo+ID4gICAKPiA+ICAgLyoqCj4gPiBAQCAtOTc2 LDcgKzk2Niw2IEBAIGlndF9waXBlX2NyY19nZXRfY3VycmVudChpbnQgZHJtX2ZkLCBpZ3RfcGlw ZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqY3JjKQo+ID4gICB7Cj4gPiAgIAl1bnNpZ25l ZCB2YmxhbmsgPSBrbXN0ZXN0X2dldF92YmxhbmsoZHJtX2ZkLCBwaXBlX2NyYy0+cGlwZSwgMCk7 Cj4gPiAgIAo+ID4gLQlpZ3RfYXNzZXJ0KCEocGlwZV9jcmMtPmZsYWdzICYgT19OT05CTE9DSykp Owo+ID4gICAJZG8gewo+ID4gICAJCXJlYWRfb25lX2NyYyhwaXBlX2NyYywgY3JjKTsKPiA+ICAg Cj4gPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9kZWJ1Z2ZzLmggYi9saWIvaWd0X2RlYnVnZnMuaAo+ ID4gaW5kZXggOWY4MWJlMGEyNGRlLi41OGNhMDdmNWMxNWQgMTAwNjQ0Cj4gPiAtLS0gYS9saWIv aWd0X2RlYnVnZnMuaAo+ID4gKysrIGIvbGliL2lndF9kZWJ1Z2ZzLmgKPiA+IEBAIC0xMzIsNyAr MTMyLDcgQEAgX19hdHRyaWJ1dGVfXygod2Fybl91bnVzZWRfcmVzdWx0KSkKPiA+ICAgaW50IGln dF9waXBlX2NyY19nZXRfY3JjcyhpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGludCBuX2NyY3Ms Cj4gPiAgIAkJCSAgaWd0X2NyY190ICoqb3V0X2NyY3MpOwo+ID4gICB2b2lkIGlndF9waXBlX2Ny Y19kcmFpbihpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMpOwo+ID4gLWJvb2wgaWd0X3BpcGVfY3Jj X2dldF9zaW5nbGUoaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjLCBpZ3RfY3JjX3QgKm91dF9jcmMp Owo+ID4gK3ZvaWQgaWd0X3BpcGVfY3JjX2dldF9zaW5nbGUoaWd0X3BpcGVfY3JjX3QgKnBpcGVf Y3JjLCBpZ3RfY3JjX3QgKm91dF9jcmMpOwo+ID4gICB2b2lkIGlndF9waXBlX2NyY19nZXRfY3Vy cmVudChpbnQgZHJtX2ZkLCBpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAqY3Jj KTsKPiA+ICAgCj4gPiAgIHZvaWQgaWd0X3BpcGVfY3JjX2NvbGxlY3RfY3JjKGlndF9waXBlX2Ny Y190ICpwaXBlX2NyYywgaWd0X2NyY190ICpvdXRfY3JjKTsKPiA+IGRpZmYgLS1naXQgYS90ZXN0 cy9rbXNfY2h2X2N1cnNvcl9mYWlsLmMgYi90ZXN0cy9rbXNfY2h2X2N1cnNvcl9mYWlsLmMKPiA+ IGluZGV4IDcxMzhlNTQ5YWViNy4uOGU1MDk3OGQwYmUxIDEwMDY0NAo+ID4gLS0tIGEvdGVzdHMv a21zX2Nodl9jdXJzb3JfZmFpbC5jCj4gPiArKysgYi90ZXN0cy9rbXNfY2h2X2N1cnNvcl9mYWls LmMKPiA+IEBAIC0yNTgsNyArMjU4LDcgQEAgc3RhdGljIHZvaWQgcHJlcGFyZV9jcnRjKGRhdGFf dCAqZGF0YSkKPiA+ICAgCj4gPiAgIAkvKiBnZXQgcmVmZXJlbmNlIGNyYyB3L28gY3Vyc29yICov Cj4gPiAgIAlpZ3RfcGlwZV9jcmNfc3RhcnQoZGF0YS0+cGlwZV9jcmMpOwo+ID4gLQlpZ3RfYXNz ZXJ0KGlndF9waXBlX2NyY19nZXRfc2luZ2xlKGRhdGEtPnBpcGVfY3JjLCAmZGF0YS0+cmVmX2Ny YykpOwo+ID4gKwlpZ3RfcGlwZV9jcmNfZ2V0X3NpbmdsZShkYXRhLT5waXBlX2NyYywgJmRhdGEt PnJlZl9jcmMpOwo+ID4gICB9Cj4gPiAgIAo+ID4gICBzdGF0aWMgdm9pZCB0ZXN0X2NydGMoZGF0 YV90ICpkYXRhLCB1bnNpZ25lZCBpbnQgZWRnZXMpCj4gPiAKCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0 LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==