Re: [igt-dev] [PATCH v7 07/14] fb: Add support for conversions through pixman

From: Maxime Ripard <maxime.ripard@bootlin.com>
To: igt-dev@lists.freedesktop.org,
	"Boris Brezillon" <boris.brezillon@bootlin.com>,
	"Eric Anholt" <eric@anholt.net>,
	eben@raspberrypi.org,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [igt-dev] [PATCH v7 07/14] fb: Add support for conversions through pixman
Date: Tue, 2 Oct 2018 16:57:44 +0200	[thread overview]
Message-ID: <20181002145744.jt2ko5vhu7k77c2o@flea> (raw)
In-Reply-To: <20181001092658.GB17124@platvala-desk.ger.corp.intel.com>

[-- Attachment #1.1: Type: text/plain, Size: 1240 bytes --]

Hi Petri,

On Mon, Oct 01, 2018 at 12:26:58PM +0300, Petri Latvala wrote:
> On Tue, Sep 11, 2018 at 10:47:34AM +0200, Maxime Ripard wrote:
> > Pixman allows for much more conversions than cairo, and we don't want to
> > open code conversions routine for the common formats.
> > 
> > Let's plug pixman in our conversion function so that we can benefit from it
> > when possible.
> > 
> > Reviewed-by: Eric Anholt <eric@anholt.net>
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> >  lib/igt_fb.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 53 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> > index 624fddbd465b..64370e01c1d6 100644
> > --- a/lib/igt_fb.c
> > +++ b/lib/igt_fb.c
> > @@ -29,6 +29,7 @@
> >  #include <math.h>
> >  #include <wchar.h>
> >  #include <inttypes.h>
> > +#include <pixman.h>
> >  
> 
> Currently pixman is only there if you enable chamelium. Doing this
> requires making it mandatory, doing some refactoring on meson.build
> and configure.ac. And README.

Ah, right. I'll fix that.

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev