From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 2 Oct 2018 19:28:39 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20181002162839.GD9144@intel.com> References: <20181002153607.12073-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181002153607.12073-1-chris@chris-wilson.co.uk> Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Handle no-KMS gracefully List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-ID: T24gVHVlLCBPY3QgMDIsIDIwMTggYXQgMDQ6MzY6MDdQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IElmIEtNUyBpcyBub3Qgc3VwcG9ydGVkLCBkcm1HZXRSZXNvdXJjZXMoKSB3aWxsIHJl dHVybiBOVUxMIHNvIGJlCj4gY2FyZWZ1bCBub3QgdG8gZGVyZWZlcmVuY2UgaXQuIEhvd2V2ZXIs IHdlIHN0aWxsIGluc2lzdCB0aGF0IHJ1bnRpbWUgcG0KPiB3b3Jrcywgc28ga2VlcCBvbiB0ZXN0 aW5nLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u LmNvLnVrPgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICB0ZXN0cy9wbV9ycG0uYyB8IDcxICsrKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 NCBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvdGVzdHMv cG1fcnBtLmMgYi90ZXN0cy9wbV9ycG0uYwo+IGluZGV4IDJkNmM1YjQ5Yy4uNzQ4OGVmZDc0IDEw MDY0NAo+IC0tLSBhL3Rlc3RzL3BtX3JwbS5jCj4gKysrIGIvdGVzdHMvcG1fcnBtLmMKPiBAQCAt MjIwLDkgKzIyMCwxMCBAQCBzdGF0aWMgYm9vbCB3YWl0X2Zvcl9hY3RpdmUodm9pZCkKPiAgCj4g IHN0YXRpYyB2b2lkIGRpc2FibGVfYWxsX3NjcmVlbnNfZHBtcyhzdHJ1Y3QgbW9kZV9zZXRfZGF0 YSAqZGF0YSkKPiAgewo+IC0JaW50IGk7Cj4gKwlpZiAoIWRhdGEtPnJlcykKPiArCQlyZXR1cm47 Cj4gIAo+IC0JZm9yIChpID0gMDsgaSA8IGRhdGEtPnJlcy0+Y291bnRfY29ubmVjdG9yczsgaSsr KSB7Cj4gKwlmb3IgKGludCBpID0gMDsgaSA8IGRhdGEtPnJlcy0+Y291bnRfY29ubmVjdG9yczsg aSsrKSB7Cj4gIAkJZHJtTW9kZUNvbm5lY3RvclB0ciBjID0gZGF0YS0+Y29ubmVjdG9yc1tpXTsK PiAgCj4gIAkJa21zdGVzdF9zZXRfY29ubmVjdG9yX2RwbXMoZHJtX2ZkLCBjLCBEUk1fTU9ERV9E UE1TX09GRik7Cj4gQEAgLTIzMSw3ICsyMzIsOCBAQCBzdGF0aWMgdm9pZCBkaXNhYmxlX2FsbF9z Y3JlZW5zX2RwbXMoc3RydWN0IG1vZGVfc2V0X2RhdGEgKmRhdGEpCj4gIAo+ICBzdGF0aWMgdm9p ZCBkaXNhYmxlX2FsbF9zY3JlZW5zKHN0cnVjdCBtb2RlX3NldF9kYXRhICpkYXRhKQo+ICB7Cj4g LQlrbXN0ZXN0X3Vuc2V0X2FsbF9jcnRjcyhkcm1fZmQsIGRhdGEtPnJlcyk7Cj4gKwlpZiAoZGF0 YS0+cmVzKQo+ICsJCWttc3Rlc3RfdW5zZXRfYWxsX2NydGNzKGRybV9mZCwgZGF0YS0+cmVzKTsK PiAgfQo+ICAKPiAgI2RlZmluZSBkaXNhYmxlX2FsbF9zY3JlZW5zX2FuZF93YWl0KGRhdGEpIGRv IHsgXAo+IEBAIC0yNTYsMTEgKzI1OCwxMyBAQCBzdGF0aWMgYm9vbCBpbml0X21vZGVzZXRfcGFy YW1zX2Zvcl90eXBlKHN0cnVjdCBtb2RlX3NldF9kYXRhICpkYXRhLAo+ICAJCQkJCSBzdHJ1Y3Qg bW9kZXNldF9wYXJhbXMgKnBhcmFtcywKPiAgCQkJCQkgZW51bSBzY3JlZW5fdHlwZSB0eXBlKQo+ ICB7Cj4gLQlpbnQgaTsKPiAgCWRybU1vZGVDb25uZWN0b3JQdHIgY29ubmVjdG9yID0gTlVMTDsK PiAgCWRybU1vZGVNb2RlSW5mb1B0ciBtb2RlID0gTlVMTDsKPiAgCj4gLQlmb3IgKGkgPSAwOyBp IDwgZGF0YS0+cmVzLT5jb3VudF9jb25uZWN0b3JzOyBpKyspIHsKPiArCWlmICghZGF0YS0+cmVz KQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlmb3IgKGludCBpID0gMDsgaSA8IGRhdGEtPnJl cy0+Y291bnRfY29ubmVjdG9yczsgaSsrKSB7Cj4gIAkJZHJtTW9kZUNvbm5lY3RvclB0ciBjID0g ZGF0YS0+Y29ubmVjdG9yc1tpXTsKPiAgCj4gIAkJaWYgKHR5cGUgPT0gU0NSRUVOX1RZUEVfTFBT UCAmJgo+IEBAIC0zODYsMzQgKzM5MCwzMSBAQCBzdGF0aWMgZHJtTW9kZVByb3BlcnR5QmxvYlB0 ciBnZXRfY29ubmVjdG9yX2VkaWQoZHJtTW9kZUNvbm5lY3RvclB0ciBjb25uZWN0b3IsCj4gIAo+ ICBzdGF0aWMgdm9pZCBpbml0X21vZGVfc2V0X2RhdGEoc3RydWN0IG1vZGVfc2V0X2RhdGEgKmRh dGEpCj4gIHsKPiAtCWludCBpOwo+IC0KPiAgCWRhdGEtPnJlcyA9IGRybU1vZGVHZXRSZXNvdXJj ZXMoZHJtX2ZkKTsKPiAtCWlndF9hc3NlcnQoZGF0YS0+cmVzKTsKPiAtCWlndF9hc3NlcnQoZGF0 YS0+cmVzLT5jb3VudF9jb25uZWN0b3JzIDw9IE1BWF9DT05ORUNUT1JTKTsKPiArCWlmIChkYXRh LT5yZXMpIHsKPiArCQlpZ3RfYXNzZXJ0KGRhdGEtPnJlcy0+Y291bnRfY29ubmVjdG9ycyA8PSBN QVhfQ09OTkVDVE9SUyk7Cj4gKwkJZm9yIChpbnQgaSA9IDA7IGkgPCBkYXRhLT5yZXMtPmNvdW50 X2Nvbm5lY3RvcnM7IGkrKykgewo+ICsJCQlkYXRhLT5jb25uZWN0b3JzW2ldID0gZHJtTW9kZUdl dENvbm5lY3RvckN1cnJlbnQoZHJtX2ZkLAo+ICsJCQkJCQkJCQkgZGF0YS0+cmVzLT5jb25uZWN0 b3JzW2ldKTsKPiArCQkJZGF0YS0+ZWRpZHNbaV0gPSBnZXRfY29ubmVjdG9yX2VkaWQoZGF0YS0+ Y29ubmVjdG9yc1tpXSwgaSk7Cj4gKwkJfQo+ICAKPiAtCWZvciAoaSA9IDA7IGkgPCBkYXRhLT5y ZXMtPmNvdW50X2Nvbm5lY3RvcnM7IGkrKykgewo+IC0JCWRhdGEtPmNvbm5lY3RvcnNbaV0gPSBk cm1Nb2RlR2V0Q29ubmVjdG9yQ3VycmVudChkcm1fZmQsCj4gLQkJCQkJCWRhdGEtPnJlcy0+Y29u bmVjdG9yc1tpXSk7Cj4gLQkJZGF0YS0+ZWRpZHNbaV0gPSBnZXRfY29ubmVjdG9yX2VkaWQoZGF0 YS0+Y29ubmVjdG9yc1tpXSwgaSk7Cj4gKwkJa21zdGVzdF9zZXRfdnRfZ3JhcGhpY3NfbW9kZSgp Owo+ICAJfQo+ICAKPiAgCWRhdGEtPmRldmlkID0gaW50ZWxfZ2V0X2RybV9kZXZpZChkcm1fZmQp Owo+IC0KPiAtCWttc3Rlc3Rfc2V0X3Z0X2dyYXBoaWNzX21vZGUoKTsKPiAtCj4gIAlpbml0X21v ZGVzZXRfY2FjaGVkX3BhcmFtcygmbXNfZGF0YSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGZp bmlfbW9kZV9zZXRfZGF0YShzdHJ1Y3QgbW9kZV9zZXRfZGF0YSAqZGF0YSkKPiAgewo+IC0JaW50 IGk7Cj4gLQo+IC0JZm9yIChpID0gMDsgaSA8IGRhdGEtPnJlcy0+Y291bnRfY29ubmVjdG9yczsg aSsrKSB7Cj4gLQkJZHJtTW9kZUZyZWVDb25uZWN0b3IoZGF0YS0+Y29ubmVjdG9yc1tpXSk7Cj4g LQkJZHJtTW9kZUZyZWVQcm9wZXJ0eUJsb2IoZGF0YS0+ZWRpZHNbaV0pOwo+ICsJaWYgKGRhdGEt PnJlcykgewo+ICsJCWZvciAoaW50IGkgPSAwOyBpIDwgZGF0YS0+cmVzLT5jb3VudF9jb25uZWN0 b3JzOyBpKyspIHsKPiArCQkJZHJtTW9kZUZyZWVDb25uZWN0b3IoZGF0YS0+Y29ubmVjdG9yc1tp XSk7Cj4gKwkJCWRybU1vZGVGcmVlUHJvcGVydHlCbG9iKGRhdGEtPmVkaWRzW2ldKTsKPiArCQl9 Cj4gKwkJZHJtTW9kZUZyZWVSZXNvdXJjZXMoZGF0YS0+cmVzKTsKPiAgCX0KPiAtCWRybU1vZGVG cmVlUmVzb3VyY2VzKGRhdGEtPnJlcyk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIGdldF9kcm1f aW5mbyhzdHJ1Y3QgY29tcGFyZV9kYXRhICpkYXRhKQo+IEBAIC00MjEsNyArNDIyLDggQEAgc3Rh dGljIHZvaWQgZ2V0X2RybV9pbmZvKHN0cnVjdCBjb21wYXJlX2RhdGEgKmRhdGEpCj4gIAlpbnQg aTsKPiAgCj4gIAlkYXRhLT5yZXMgPSBkcm1Nb2RlR2V0UmVzb3VyY2VzKGRybV9mZCk7Cj4gLQlp Z3RfYXNzZXJ0KGRhdGEtPnJlcyk7Cj4gKwlpZiAoIWRhdGEtPnJlcykKPiArCQlyZXR1cm47Cj4g IAo+ICAJaWd0X2Fzc2VydChkYXRhLT5yZXMtPmNvdW50X2Nvbm5lY3RvcnMgPD0gTUFYX0NPTk5F Q1RPUlMpOwo+ICAJaWd0X2Fzc2VydChkYXRhLT5yZXMtPmNvdW50X2VuY29kZXJzIDw9IE1BWF9F TkNPREVSUyk7Cj4gQEAgLTQ0NSw2ICs0NDcsOSBAQCBzdGF0aWMgdm9pZCBmcmVlX2RybV9pbmZv KHN0cnVjdCBjb21wYXJlX2RhdGEgKmRhdGEpCj4gIHsKPiAgCWludCBpOwo+ICAKPiArCWlmICgh ZGF0YS0+cmVzKQo+ICsJCXJldHVybjsKPiArCj4gIAlmb3IgKGkgPSAwOyBpIDwgZGF0YS0+cmVz LT5jb3VudF9jb25uZWN0b3JzOyBpKyspIHsKPiAgCQlkcm1Nb2RlRnJlZUNvbm5lY3RvcihkYXRh LT5jb25uZWN0b3JzW2ldKTsKPiAgCQlkcm1Nb2RlRnJlZVByb3BlcnR5QmxvYihkYXRhLT5lZGlk c1tpXSk7Cj4gQEAgLTU0NSw2ICs1NTAsMTIgQEAgc3RhdGljIHZvaWQgYXNzZXJ0X2RybV9pbmZv c19lcXVhbChzdHJ1Y3QgY29tcGFyZV9kYXRhICpkMSwKPiAgewo+ICAJaW50IGk7Cj4gIAo+ICsJ aWYgKGQxLT5yZXMgPT0gZDItPnJlcykKPiArCQlyZXR1cm47Cj4gKwo+ICsJaWd0X2Fzc2VydChk MS0+cmVzKTsKPiArCWlndF9hc3NlcnQoZDItPnJlcyk7Cj4gKwo+ICAJYXNzZXJ0X2RybV9yZXNv dXJjZXNfZXF1YWwoZDEsIGQyKTsKPiAgCj4gIAlmb3IgKGkgPSAwOyBpIDwgZDEtPnJlcy0+Y291 bnRfY29ubmVjdG9yczsgaSsrKSB7Cj4gQEAgLTU3Miw5ICs1ODMsMTIgQEAgc3RhdGljIGJvb2wg ZWRpZF9pc192YWxpZChjb25zdCB1bnNpZ25lZCBjaGFyICplZGlkKQo+ICAKPiAgc3RhdGljIGlu dCBjb3VudF9kcm1fdmFsaWRfZWRpZHMoc3RydWN0IG1vZGVfc2V0X2RhdGEgKmRhdGEpCj4gIHsK PiAtCWludCBpLCByZXQgPSAwOwo+ICsJaW50IHJldCA9IDA7Cj4gIAo+IC0JZm9yIChpID0gMDsg aSA8IGRhdGEtPnJlcy0+Y291bnRfY29ubmVjdG9yczsgaSsrKQo+ICsJaWYgKCFkYXRhLT5yZXMp Cj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJZm9yIChpbnQgaSA9IDA7IGkgPCBkYXRhLT5yZXMtPmNv dW50X2Nvbm5lY3RvcnM7IGkrKykKPiAgCQlpZiAoZGF0YS0+ZWRpZHNbaV0gJiYgZWRpZF9pc192 YWxpZChkYXRhLT5lZGlkc1tpXS0+ZGF0YSkpCj4gIAkJCXJldCsrOwo+ICAJcmV0dXJuIHJldDsK PiBAQCAtNjM1LDkgKzY0OSwxMiBAQCBzdGF0aWMgaW50IGNvdW50X2kyY192YWxpZF9lZGlkcyh2 b2lkKQo+ICAKPiAgc3RhdGljIGludCBjb3VudF92Z2Ffb3V0cHV0cyhzdHJ1Y3QgbW9kZV9zZXRf ZGF0YSAqZGF0YSkKPiAgewo+IC0JaW50IGksIGNvdW50ID0gMDsKPiArCWludCBjb3VudCA9IDA7 Cj4gKwo+ICsJaWYgKCFkYXRhLT5yZXMpCj4gKwkJcmV0dXJuIDA7Cj4gIAo+IC0JZm9yIChpID0g MDsgaSA8IGRhdGEtPnJlcy0+Y291bnRfY29ubmVjdG9yczsgaSsrKQo+ICsJZm9yIChpbnQgaSA9 IDA7IGkgPCBkYXRhLT5yZXMtPmNvdW50X2Nvbm5lY3RvcnM7IGkrKykKPiAgCQlpZiAoZGF0YS0+ Y29ubmVjdG9yc1tpXS0+Y29ubmVjdG9yX3R5cGUgPT0KPiAgCQkgICAgRFJNX01PREVfQ09OTkVD VE9SX1ZHQSkKPiAgCQkJY291bnQrKzsKPiAtLSAKPiAyLjE5LjAKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGlndC1kZXYgbWFpbGluZyBsaXN0 Cj4gaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50 ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==