Re: [igt-dev] [PATCH i-g-t v1 4/6] [intel-gfx][intel-dev] tests/pm_dc : This patch adds test to validate DC6 on SKL. DC6 on SKL is achieved with RPM enabled and DPMS OFF sequence.

[Imre Deak <imre.deak@intel.com>]

On Wed, Oct 03, 2018 at 10:07:27AM +0530, Yadav, Jyoti R wrote:
> > > [...]
> > > @@ -193,6 +206,14 @@ int main(int argc, char *argv[])
> > >   				"DC6 State is not achieved\n");
> > >   		cleanup(&data);
> > >   	}
> > > +	igt_subtest("DC6_state_on_gen9") {
> > This isn't GEN9 specific, so could be called dc6-dpms-off. I suppose you
> > also want a dc5-dpms-off test.
>
> AS on Gen9,  (I am sure about SKL, not sure about other Gen9
> platforms), on SKL, DC6 is achieved with DPMS off. but on Gen 11, DC6
> is achieved with PSR.

It must be also achieved with DPMS off everywhere where DC6 is
available.

> That's why i named test like "Dc6_state_on_gen9" and
> "Dc6_state_on_gen11".

No need to have the platform name in the subtest name, let's just do the
tests everywhere where the corresponding DC counter is available and
skip it elsewhere.

> Also on Gen9, DC5 is mainly achieved with PSR, on DPMS off directly we
> can enter into DC6.

Still, it makes sense to have a separate test for DC5, so we have a
better clue what goes wrong in case of failures.

> So in case of DPMS off scenario, i was mainly checking Dc6 counter,
> instead of checking DC5 and Dc6 counters both.

I still think we should have the following subtests:

dc5-psr
dc6-psr
dc5-dpms-off
dc6-dpms-off

And run each of these where the counter is available, skip them
otherwise.

> > 
> > > +		dc5_dc6_counter_before_suspend = read_dc5_dc6_counter(data.devid);
> > > +		dpms_off_on(&data);
> > > +		dc5_dc6_counter_after_resume = read_dc5_dc6_counter(data.devid);
> > > +		igt_require_f(dc5_dc6_counter_after_resume > dc5_dc6_counter_before_suspend,
> > > +				"DC6 State is not achieved\n");
> > > +		cleanup(&data);
> > > +	}
> > >   	igt_fixture {
> > >   		psr_disable(data.debugfs_fd);
> > >   		close(data.debugfs_fd);
> > > -- 
> > > 2.7.4
> > > 
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev