From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3240A6E846 for ; Fri, 5 Oct 2018 15:07:44 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id y19-v6so11955801edd.2 for ; Fri, 05 Oct 2018 08:07:44 -0700 (PDT) Date: Fri, 5 Oct 2018 17:07:38 +0200 From: Daniel Vetter Message-ID: <20181005150738.GI31561@phenom.ffwll.local> References: <20181004132128.6412-1-daniel.vetter@ffwll.ch> <20181004132128.6412-4-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181004132128.6412-4-daniel.vetter@ffwll.ch> Subject: Re: [igt-dev] [PATCH i-g-t 4/4] lib/kms: warn if we commit without outputs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: IGT development Cc: Daniel Vetter List-ID: T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDM6MjE6MjhQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBXaXRoIHRoZSBoaWdoLWxldmVsIGhlbHBlcnMgcmVxdWlyaW5nIG91dHB1dHMgdGhl cmUncyBub3QgcG9pbnQKPiBpbiBzaWxlbnRseSBpZ25vcmluZyBpc3N1ZXMgYW55bW9yZS4gQ29t cGxhaW4gYWJvdXQgdGhhdCBpZiBpdAo+IGV2ZXIgaGFwcGVucy4KPiAKPiBDYzogQW50b25pbyBB cmdlbnppYW5vIDxhbnRvbmlvLmFyZ2Vuemlhbm9AaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxz b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0 dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KCkkgZ3Vlc3MgbXkgbW90aXZhdGlvbiB3aXRo IGZ1bWJsaW5nIGFyb3VuZCB3aXRoIHRoZSBpZ3RfZGlzcGxheV8qIGFwaQp3YXNuJ3QgZW50aXJl bHkgY2xlYXI6IEl0J3MgdGhpcyBwYXRjaCBoZXJlLCByZXNwZWN0aXZlbHkgQ2hyaXMnIHBhdGNo CndoaWNoIGFkZGVkIHRoZSBzaWxlbnQgc2hvcnQgY2lyY3VpdC4KCkltbyB0aGF0J3MgdmVyeSBi cml0dGxlIGFwaSwgYXNraW5nIGZvciB0cm91YmxlLCBhbmQgbWUgbm90IHJlY29nbml6aW5nCnJp Z2h0IGF3YXkgd2hhdCdzIGhhcHBlbmluZyBpbiB0aGUgZGVidWdmcyBpcyBraW5kYSBwcm92aW5n IHRoZSBwb2ludC4KU2lsZW50bHkgdGhyb3dpbmcgYSByZXF1ZXN0IGF3YXkgZnJvbSB0aGUgdGVz dGNhc2UgaXMgYXQgbGVhc3QgdmVyeQpzdXJwcmlzaW5nLiBBbmQgaW5jb25zaXN0ZW50IHdpdGgg Ym90aCBtb3JlIGV4cGxpY2l0IGlndF9yZXF1aXJlL2Fzc2VydApjaGVja3MgaW4gZHJpdmVycywg YW5kICh0aGUgc3R5bGUgSSBmYXZvdXIgcGVyc29uYWxseSwgYnV0IHJlYWxseSBub3QgdGhlCmlz c3VlIGhlcmUpIHB1dHRpbmcgaWd0X3JlcXVpcmUvYXNzZXJ0IGludG8gdGhlIGhlbHBlciBsaWJy YXJ5LgoKTm93IG15IHByb3Bvc2FsIHRvIGdldCB1cyBiYWNrIHNvbWUgcm9idXN0bmVzcyBzZWVt cyBub3QgbWV0IHdpdGggaHVnZQplbnRodXNpYW1zLCBzbyB3aGF0J3MgaXQgZ29pbmcgdG8gYmU/ IEknZCBiZSBvayB3aXRoIHNwcmlua2xpbmcgbW9yZQpleHBsaWNpdCBjaGVja3Mgb3ZlciB0ZXN0 cyAoYW5kIHByb2JhYmx5IG1vcmUgZXhwbGljaXQgY29udHJvbCBmbG93KSwgcGx1cwpwcm9wZXIg ZG9jdW1lbnRhdGlvbiBmb3IgaWd0X2Rpc3BsYXlfcmVxdWlyZSwgdG9vLiBCdXQgdGhpcyBoZXJl IGRvZXNuJ3QKbG9vayBsaWtlIGEgZ29vZCBpZGVhIGxvbmctdGVybSwgYW5kIHRoYXQncyB3aHkg SSdtIG5vdCBoYXBweSB3aXRoIGhvdwp0aGF0IGJ1Z2ZpeGluZyB3YXMgcnVzaGVkIGluLiBGaXhp bmcgZGlzYWJsZV9kaXNwbGF5PTEgaXNuJ3QgX3RoYXRfIGhpZ2gKb2YgYSBwcmlvcml0eSB0aGF0 IHdlIGNhbid0IHRha2UgdGhlIHRpbWUgdG8gZ2V0IHRoZSBpZ3QgbGlicmFyeSBhcGkKc29tZXdo YXQgcmlnaHQuCgpDaGVlcnMsIERhbmllbAoKPiAtLS0KPiAgbGliL2lndF9rbXMuYyB8IDQgKyst LQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9saWIvaWd0X2ttcy5jIGIvbGliL2lndF9rbXMuYwo+IGluZGV4IDQ1NGFi NzQ4MWNkZS4uODY3ZWFhN2E5NzFjIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3Rfa21zLmMKPiArKysg Yi9saWIvaWd0X2ttcy5jCj4gQEAgLTMyNjksNyArMzI2OSw3IEBAIHN0YXRpYyBpbnQgZG9fZGlz cGxheV9jb21taXQoaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSwKPiAgCWVudW0gcGlwZSBwaXBlOwo+ ICAJTE9HX0lOREVOVChkaXNwbGF5LCAiY29tbWl0Iik7Cj4gIAo+IC0JaWYgKCFkaXNwbGF5LT5u X3BpcGVzIHx8ICFkaXNwbGF5LT5uX291dHB1dHMpCj4gKwlpZiAoaWd0X3dhcm5fb24oIWRpc3Bs YXktPm5fcGlwZXMgfHwgIWRpc3BsYXktPm5fb3V0cHV0cykpCj4gIAkJcmV0dXJuIDA7IC8qIG5v dGhpbmcgdG8gZG8gKi8KPiAgCj4gIAlpZ3RfZGlzcGxheV9yZWZyZXNoKGRpc3BsYXkpOwo+IEBA IC0zMzIyLDcgKzMzMjIsNyBAQCBpbnQgaWd0X2Rpc3BsYXlfdHJ5X2NvbW1pdF9hdG9taWMoaWd0 X2Rpc3BsYXlfdCAqZGlzcGxheSwgdWludDMyX3QgZmxhZ3MsIHZvaWQgKgo+ICB7Cj4gIAlpbnQg cmV0Owo+ICAKPiAtCWlmICghZGlzcGxheS0+bl9waXBlcyB8fCAhZGlzcGxheS0+bl9vdXRwdXRz KQo+ICsJaWYgKGlndF93YXJuX29uKCFkaXNwbGF5LT5uX3BpcGVzIHx8ICFkaXNwbGF5LT5uX291 dHB1dHMpKQo+ICAJCXJldHVybiAwOyAvKiBub3RoaW5nIHRvIGRvICovCj4gIAo+ICAJTE9HX0lO REVOVChkaXNwbGF5LCAiY29tbWl0Iik7Cj4gLS0gCj4gMi4xOS4wLnJjMgo+IAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=