From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AEF86E8B1 for ; Fri, 5 Oct 2018 18:48:46 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id c1-v6so12498682ede.5 for ; Fri, 05 Oct 2018 11:48:46 -0700 (PDT) Date: Fri, 5 Oct 2018 20:48:40 +0200 From: Daniel Vetter Message-ID: <20181005184840.GM31561@phenom.ffwll.local> References: <20181004132128.6412-1-daniel.vetter@ffwll.ch> <20181004132128.6412-4-daniel.vetter@ffwll.ch> <20181005150738.GI31561@phenom.ffwll.local> <153875401480.5379.4296070102922494534@skylake-alporthouse-com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <153875401480.5379.4296070102922494534@skylake-alporthouse-com> Subject: Re: [igt-dev] [PATCH i-g-t 4/4] lib/kms: warn if we commit without outputs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson Cc: IGT development , Daniel Vetter , Daniel Vetter List-ID: T24gRnJpLCBPY3QgMDUsIDIwMTggYXQgMDQ6NDA6MTRQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgRGFuaWVsIFZldHRlciAoMjAxOC0xMC0wNSAxNjowNzozOCkKPiA+IE9u IFRodSwgT2N0IDA0LCAyMDE4IGF0IDAzOjIxOjI4UE0gKzAyMDAsIERhbmllbCBWZXR0ZXIgd3Jv dGU6Cj4gPiA+IFdpdGggdGhlIGhpZ2gtbGV2ZWwgaGVscGVycyByZXF1aXJpbmcgb3V0cHV0cyB0 aGVyZSdzIG5vdCBwb2ludAo+ID4gPiBpbiBzaWxlbnRseSBpZ25vcmluZyBpc3N1ZXMgYW55bW9y ZS4gQ29tcGxhaW4gYWJvdXQgdGhhdCBpZiBpdAo+ID4gPiBldmVyIGhhcHBlbnMuCj4gPiA+IAo+ ID4gPiBDYzogQW50b25pbyBBcmdlbnppYW5vIDxhbnRvbmlvLmFyZ2Vuemlhbm9AaW50ZWwuY29t Pgo+ID4gPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiA+ IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ ID4gCj4gPiBJIGd1ZXNzIG15IG1vdGl2YXRpb24gd2l0aCBmdW1ibGluZyBhcm91bmQgd2l0aCB0 aGUgaWd0X2Rpc3BsYXlfKiBhcGkKPiA+IHdhc24ndCBlbnRpcmVseSBjbGVhcjogSXQncyB0aGlz IHBhdGNoIGhlcmUsIHJlc3BlY3RpdmVseSBDaHJpcycgcGF0Y2gKPiA+IHdoaWNoIGFkZGVkIHRo ZSBzaWxlbnQgc2hvcnQgY2lyY3VpdC4KPiA+IAo+ID4gSW1vIHRoYXQncyB2ZXJ5IGJyaXR0bGUg YXBpLCBhc2tpbmcgZm9yIHRyb3VibGUsIGFuZCBtZSBub3QgcmVjb2duaXppbmcKPiA+IHJpZ2h0 IGF3YXkgd2hhdCdzIGhhcHBlbmluZyBpbiB0aGUgZGVidWdmcyBpcyBraW5kYSBwcm92aW5nIHRo ZSBwb2ludC4KPiA+IFNpbGVudGx5IHRocm93aW5nIGEgcmVxdWVzdCBhd2F5IGZyb20gdGhlIHRl c3RjYXNlIGlzIGF0IGxlYXN0IHZlcnkKPiA+IHN1cnByaXNpbmcuIEFuZCBpbmNvbnNpc3RlbnQg d2l0aCBib3RoIG1vcmUgZXhwbGljaXQgaWd0X3JlcXVpcmUvYXNzZXJ0Cj4gPiBjaGVja3MgaW4g ZHJpdmVycywgYW5kICh0aGUgc3R5bGUgSSBmYXZvdXIgcGVyc29uYWxseSwgYnV0IHJlYWxseSBu b3QgdGhlCj4gPiBpc3N1ZSBoZXJlKSBwdXR0aW5nIGlndF9yZXF1aXJlL2Fzc2VydCBpbnRvIHRo ZSBoZWxwZXIgbGlicmFyeS4KPiAKPiBJJ2QgYXJndWUgdGhlIG9wcG9zaXRlLiBUaGUgdGVzdCBj YXNlIHJlcXVlc3RlZCB1cyB0byBjb25maWd1cmUgMAo+IG91dHB1dHMgYWNyb3NzIDAgcGlwZXMs IGFuZCB3ZSBhcmUgb2JleWluZyBpdC4gTm90IHNlY29uZCBndWVzc2luZyB3aGF0Cj4gdGhlIHRl c3QgY2FzZSBpbnRlbmRlZC4KCldlIGhhdmUgOCBjYXNlcyBvZiBpZ3RfZGlzcGxheV9pbml0IG5v dywgYW5kIHNsaWdodGx5IHNoeSBvZiA3MCBmb3IKaWd0X2Rpc3BsYXlfcmVxdWlyZS4gVGhlcmUn cyBhbG1vc3QgMTB4IHRlc3RjYXNlcyB5b3UgY2FuIHNpbGVudGx5IGJyZWFrCmZvciB0aGUgaGFu ZGZ1bCB0aGF0IGRvbid0IGJyZWFrIHdpdGggdGhpcy4KCkZ1cnRoZXJtb3JlLCB0aGVyZSBzZWVt cyBleGFjdGx5IDEgdGVzdGNhc2Ugd2hpY2ggYWN0dWFsbHkgYXNrZWQgZm9yIHRoaXMsCmFuZCBJ J20gYXJndWVpbmcgdGhhdCB0aGF0IHRlc3RjYXNlIGlzIG11Y2ggY2xlYW5lciBpZiB3ZSdkIHNw bGl0IHRoZQpuby1kaXNwbGF5IHRlc3QgZnJvbSB0aGUgYWxsLWRpc3BsYXlzLW9mZiB0ZXN0LgoK U28gd2UgaGF2ZSAxIHZzLiB+NzAgdGVzdGNhc2VzLiBJZiB5b3VyIGFwaSBtYWtlcyB0aGUgZXhj ZWVkaW5nbHkgY29tbW9uCmNhc2UgYnJpdHRsZSwgdGhlbiBJIHJlYWxseSBkb24ndCBzZWUgd2h5 IHRoYXQncyBnb29kIGFwaSBkZXNpZ24uCgpBbmQgdGhlcmUncyB0b25zIG90aGVyIG9wdGlvbnMs IHdpdGhvdXQgYW55IGJyaXR0bGVuZXNzLiBFLmcuIHdlIGNvdWxkIGFkZAp0aGlzIGlndF93YXJu X29uIGhlcmUsIGJ1dCBhZGQgZXhwbGljaXQgY29udHJvbCBmbG93IHRvIHRoZSBkZWJ1Z2ZzIHRl c3QuClRoYXQ6Ci0gS2VlcHMgYWxsIHRoZSBpZ3QgcmVxdWlyZSBjaGVja3MgZXhhY3RseSB3aGVy ZSB5b3Ugd2FudCB0aGVtLgotIEdpdmVzIHVzIGEgbm9uLWJyaXR0bGUgYXBpIHRoYXQgZG9lc24n dCBoaWRlIHN1cnByaXNlcy4KClRoZXJlJ3MgcHJvYmFibHkgbWV0cmljIHBpbGVzIG9mIG90aGVy IGFwcHJvYWNoZXMsIHdpdGggdmFyeWluZyBzaGFkZXMgb2YKcGFpbnQgYXBwbGllZC4gSSBkb24n dCBzZWUgYW55IHJlYXNvbiB3aHkgdGhlIGFwaSBzaG91bGQgc2lsZW50bHkgZWF0CmVycm9ycyAt IGFuZCBlcnJvcnMgZG9lcyBpdCBlYXQsIHNpbmNlIHRoYXQncyB3aHkgeW91IHB1c2hlZCB0aGUg cGF0Y2guCgpBbGwgSSdtIGFyZ3VpbmcgZm9yIGlzIHRvIG1ha2UgdGhhdCBtb3JlIGV4cGxpY2l0 LgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2lndC1kZXYK