public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/perf: adapt report timing delta acceptance for ICL
Date: Wed, 10 Oct 2018 18:49:12 +0100	[thread overview]
Message-ID: <20181010174912.25600-1-lionel.g.landwerlin@intel.com> (raw)

The behavior of the OA unit is a tiny bit different on ICL. It appears
to be a bit sloppier on the timings of its OA reports (missing the
deadline by one period quite often). Let's add an acceptance delta.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/perf.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tests/perf.c b/tests/perf.c
index 6a6001d5..a92de221 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -1674,6 +1674,16 @@ static void load_helper_fini(void)
 		drm_intel_bufmgr_destroy(lh.bufmgr);
 }
 
+static bool expected_report_timing_delta(uint32_t delta, uint32_t expected_delta)
+{
+	/*
+	 * On ICL, the OA unit appears to be a bit more relaxed about
+	 * its timing for emitting OA reports (often missing the
+	 * deadline by 1 timestamp).
+	 */
+	return delta <= (expected_delta + 3);
+}
+
 static void
 test_oa_exponents(void)
 {
@@ -1774,9 +1784,9 @@ test_oa_exponents(void)
 			igt_debug("report%04i ts=%08x hw_id=0x%08x delta=%u %s\n", i,
 				  timer_reports[i].report[1],
 				  oa_report_get_ctx_id(timer_reports[i].report),
-				  delta, delta == expected_timestamp_delta ? "" : "******");
+				  delta, expected_report_timing_delta(delta,expected_timestamp_delta) ? "" : "******");
 
-			matches += expected_timestamp_delta <= delta;
+			matches += expected_report_timing_delta(delta,expected_timestamp_delta);
 		}
 
 		igt_debug("matches=%u/%u\n", matches, n_timer_reports - 1);
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2018-10-10 17:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 17:49 Lionel Landwerlin [this message]
2018-10-10 18:15 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf: adapt report timing delta acceptance for ICL Patchwork
2018-10-11  1:26 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-12 23:32 ` [igt-dev] [PATCH i-g-t] " Souza, Jose
2018-10-15 10:23   ` Lionel Landwerlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181010174912.25600-1-lionel.g.landwerlin@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox