From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 1/2] tests/kms_properties: Add additional prperty test infrastructure
Date: Wed, 10 Oct 2018 17:14:15 -0700 [thread overview]
Message-ID: <20181011001416.19450-1-radhakrishna.sripada@intel.com> (raw)
We currently test the existimg properties by setting them with default value.
Add infrastructure to perform additional test on a desired property.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
tests/kms_properties.c | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index 9548cf44017a..bd3e82761f6e 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -29,6 +29,13 @@
#include <string.h>
#include <time.h>
+struct additional_test {
+ char *name;
+ uint32_t obj_type;
+ void (*prop_test)(int fd, uint32_t id, uint32_t type, drmModePropertyPtr prop,
+ uint32_t prop_id, uint64_t prop_value, bool atomic);
+};
+
static void prepare_pipe(igt_display_t *display, enum pipe pipe, igt_output_t *output, struct igt_fb *fb)
{
drmModeModeInfo *mode = igt_output_get_mode(output);
@@ -75,11 +82,27 @@ static bool ignore_property(uint32_t obj_type, uint32_t prop_flags,
return false;
}
+static const struct additional_test property_functional_test[] = {};
+
+static bool has_additional_test_lookup(uint32_t obj_type, const char *name,
+ bool atomic, int *index)
+{
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(property_functional_test); i++)
+ if (property_functional_test[i].obj_type == obj_type &&
+ strcmp(name, property_functional_test[i].name)) {
+ *index = i;
+ return true;
+ }
+
+ return false;
+}
static void test_properties(int fd, uint32_t type, uint32_t id, bool atomic)
{
drmModeObjectPropertiesPtr props =
drmModeObjectGetProperties(fd, id, type);
- int i, ret;
+ int i, j, ret;
drmModeAtomicReqPtr req = NULL;
igt_assert(props);
@@ -114,6 +137,9 @@ static void test_properties(int fd, uint32_t type, uint32_t id, bool atomic)
igt_assert_eq(ret, 0);
}
+ if (has_additional_test_lookup(type, prop->name, atomic, &j))
+ property_functional_test[j].prop_test(fd, id, type, prop, prop_id, prop_value, atomic);
+
drmModeFreeProperty(prop);
}
--
2.9.3
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2018-10-11 0:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 0:14 Radhakrishna Sripada [this message]
2018-10-11 0:14 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_properties: Add functional test for "max bpc" property Radhakrishna Sripada
2018-10-11 1:28 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_properties: Add additional prperty test infrastructure Patchwork
2018-10-11 11:03 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011001416.19450-1-radhakrishna.sripada@intel.com \
--to=radhakrishna.sripada@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox