From: Katarzyna Dec <katarzyna.dec@intel.com>
To: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2] libs: Adding rendercopy support for gen11
Date: Thu, 11 Oct 2018 10:33:14 +0200 [thread overview]
Message-ID: <20181011083314.GA27486@kdec5-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20181010104837.14069-1-lukasz.kalamarz@intel.com>
On Wed, Oct 10, 2018 at 12:48:37PM +0200, Lukasz Kalamarz wrote:
> From: "Kalamarz, Lukasz" <lukasz.kalamarz@intel.com>
>
> In Gen11 there were EU changes which was causing gem_render_copy test
> failing. Shader used in gen9 is no longer applicable for those change
and it had to be aligned to gen11 changes. Only/s/main/?? difference is
shader, /* I have */ created a wrapper for gen9 function.
>
> v2: Added gen11 shader source path next to it binary form
>
> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
I would have change commit msg a little bit (see above), but it is not
blocking patch from merging. LGTM :)
Reviewed-by: Katarzyna Dec <katarzyna.dec@intel.com>
Kasia :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-11 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 14:45 [igt-dev] [PATCH i-g-t] libs: Adding rendercopy support for gen11 Lukasz Kalamarz
2018-10-09 15:16 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-09 17:32 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-10-10 9:23 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2018-10-10 10:48 ` [igt-dev] [PATCH i-g-t v2] " Lukasz Kalamarz
2018-10-11 8:33 ` Katarzyna Dec [this message]
2018-10-10 11:45 ` [igt-dev] ✓ Fi.CI.BAT: success for libs: Adding rendercopy support for gen11 (rev2) Patchwork
2018-10-10 15:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011083314.GA27486@kdec5-desk.ger.corp.intel.com \
--to=katarzyna.dec@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lukasz.kalamarz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox