From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 459016E478 for ; Fri, 12 Oct 2018 12:17:27 +0000 (UTC) Date: Fri, 12 Oct 2018 15:17:23 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20181012121723.GO9144@intel.com> References: <1539296256-16598-1-git-send-email-sunpeng.li@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1539296256-16598-1-git-send-email-sunpeng.li@amd.com> Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Require FB modifiers only when needed List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: sunpeng.li@amd.com Cc: igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMDY6MTc6MzZQTSAtMDQwMCwgc3VucGVuZy5saUBhbWQu Y29tIHdyb3RlOgo+IEZyb206IExlbyBMaSA8c3VucGVuZy5saUBhbWQuY29tPgo+IAo+IEFNREdQ VSBkb2Vzbid0IGhhdmUgbW9kaWZpZXIgc3VwcG9ydC4gSG93ZXZlciwgX19rbXNfYWRkZmIgcmVx dWVzdHMKPiBtb2RpZmllciBzdXBwb3J0IG9uIGFsbCBjYWxscyB0byBpZ3RfY3JlYXRlX2ZiX3dp dGhfYm9fc2l6ZS4KPiAKPiBUaGVyZWZvcmUsIGRvbid0IHJlcXVlc3QgbW9kaWZpZXIgc3VwcG9y dCBpZiBub3QgbmVlZGVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IExlbyBMaSA8c3VucGVuZy5saUBh bWQuY29tPgo+IC0tLQo+ICBsaWIvaWd0X2ZiLmMgICAgICAgICB8IDggKysrKysrKy0KPiAgbGli L2lvY3RsX3dyYXBwZXJzLmMgfCAzICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGli L2lndF9mYi5jCj4gaW5kZXggMzViZTJlOC4uMzI1MzIzNiAxMDA2NDQKPiAtLS0gYS9saWIvaWd0 X2ZiLmMKPiArKysgYi9saWIvaWd0X2ZiLmMKPiBAQCAtOTEzLDYgKzkxMywxMiBAQCBpZ3RfY3Jl YXRlX2ZiX3dpdGhfYm9fc2l6ZShpbnQgZmQsIGludCB3aWR0aCwgaW50IGhlaWdodCwKPiAgCS8q IEZJWE1FIGFsbG93IHRoZSBjYWxsZXIgdG8gcGFzcyB0aGVzZSBpbiAqLwo+ICAJZW51bSBpZ3Rf Y29sb3JfZW5jb2RpbmcgY29sb3JfZW5jb2RpbmcgPSBJR1RfQ09MT1JfWUNCQ1JfQlQ3MDk7Cj4g IAllbnVtIGlndF9jb2xvcl9yYW5nZSBjb2xvcl9yYW5nZSA9IElHVF9DT0xPUl9ZQ0JDUl9MSU1J VEVEX1JBTkdFOwo+ICsJdWludDMyX3QgZmxhZ3MgPSAwOwo+ICsKPiArCWlmICh0aWxpbmcgIT0g TE9DQUxfRFJNX0ZPUk1BVF9NT0RfTk9ORSAmJgo+ICsJICAgIHRpbGluZyAhPSBMT0NBTF9JOTE1 X0ZPUk1BVF9NT0RfWF9USUxFRCkKPiArCQlmbGFncyA9IExPQ0FMX0RSTV9NT0RFX0ZCX01PRElG SUVSUzsKPiArCgpDaGVjayBvdXQgdGhlIGRpc2N1c3Npb24gYXQKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvYXJjaGl2ZXMvaWd0LWRldi8yMDE4LU9jdG9iZXIvMDA2MjgyLmh0bWwKCkF0 IGxlYXN0IEkgbGlrZSBEYW5pZWwncyBzdWdnZXN0aW9uIHRoZXJlLgoKPiAgCj4gIAlmYl9pbml0 KGZiLCBmZCwgd2lkdGgsIGhlaWdodCwgZm9ybWF0LCB0aWxpbmcsCj4gIAkJY29sb3JfZW5jb2Rp bmcsIGNvbG9yX3JhbmdlKTsKPiBAQCAtOTM1LDcgKzk0MSw3IEBAIGlndF9jcmVhdGVfZmJfd2l0 aF9ib19zaXplKGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LAo+ICAJCQkgICAgICBmYi0+ d2lkdGgsIGZiLT5oZWlnaHQsCj4gIAkJCSAgICAgIGZiLT5kcm1fZm9ybWF0LCBmYi0+dGlsaW5n LAo+ICAJCQkgICAgICBmYi0+c3RyaWRlcywgZmItPm9mZnNldHMsIGZiLT5udW1fcGxhbmVzLAo+ IC0JCQkgICAgICBMT0NBTF9EUk1fTU9ERV9GQl9NT0RJRklFUlMsCj4gKwkJCSAgICAgIGZsYWdz LAo+ICAJCQkgICAgICAmZmItPmZiX2lkKSk7Cj4gIAo+ICAJcmV0dXJuIGZiLT5mYl9pZDsKPiBk aWZmIC0tZ2l0IGEvbGliL2lvY3RsX3dyYXBwZXJzLmMgYi9saWIvaW9jdGxfd3JhcHBlcnMuYwo+ IGluZGV4IDA5MjljNDMuLjAxNzMxNGEgMTAwNjQ0Cj4gLS0tIGEvbGliL2lvY3RsX3dyYXBwZXJz LmMKPiArKysgYi9saWIvaW9jdGxfd3JhcHBlcnMuYwo+IEBAIC0xNjc4LDcgKzE2NzgsOCBAQCBp bnQgX19rbXNfYWRkZmIoaW50IGZkLCB1aW50MzJfdCBoYW5kbGUsCj4gIAlzdHJ1Y3QgZHJtX21v ZGVfZmJfY21kMiBmOwo+ICAJaW50IHJldCwgaTsKPiAgCj4gLQlpZ3RfcmVxdWlyZV9mYl9tb2Rp ZmllcnMoZmQpOwo+ICsJaWYgKG1vZGlmaWVyKQo+ICsJCWlndF9yZXF1aXJlX2ZiX21vZGlmaWVy cyhmZCk7Cj4gIAo+ICAJbWVtc2V0KCZmLCAwLCBzaXplb2YoZikpOwo+ICAKPiAtLSAKPiAyLjcu NAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g aWd0LWRldiBtYWlsaW5nIGxpc3QKPiBpZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ln dC1kZXYK