From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16E3B891D2 for ; Wed, 17 Oct 2018 00:24:08 +0000 (UTC) Date: Tue, 16 Oct 2018 17:23:59 -0700 From: Rodrigo Vivi Message-ID: <20181017002359.GN3694@intel.com> References: <20181010064418.2711-1-tarun.vyas@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181010064418.2711-1-tarun.vyas@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] tools/dpcd_reg: Introduce dump as the default operation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tarun Vyas Cc: igt-dev@lists.freedesktop.org, dhinakaran.pandiyan@intel.com List-ID: T24gVHVlLCBPY3QgMDksIDIwMTggYXQgMTE6NDQ6MThQTSAtMDcwMCwgVGFydW4gVnlhcyB3cm90 ZToKPiBGcm9tOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gCj4gRm9y IG5vdyB0aGlzIG9ubHkgaW1wb3J0cyB0aGUgcmVnaXN0ZXJzIHRoYXQgd2VyZSB1c2VkIG9uCj4g aTkxNSdzIGRlYnVnZnMgZHBjZCBkdW1wLiBMYXRlciB0aGlzIGNvdWxkIGJlIGV4dGVuZGVkLgo+ IAo+IFdpdGggdGhpcywgd2Ugc2hvdWxkIGJlIGFibGUgdG8ga2lsbCBpOTE1X2RwY2QgZnJvbSB0 aGUKPiBrZXJuZWwgZGVidWdmcyBhbmQgcmVseSBzb2xlbHkgb24gZHBjZF9yZWcgZm9yIGRwY2Qg ZHVtcHMuCj4gCj4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5A aW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGlu dGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBUYXJ1biBWeWFzIDx0YXJ1bi52eWFzQGludGVsLmNv bT4KClRoaXMgbG9va3MgZ29vZCB0byBtZSBhbmQgSSBiZWxpZXZlIEkgY291bGQganVzdApnbyB0 aGVyZSBhbmQgbWVyZ2Ugc2luY2Ugd2UgaGF2ZSAyIHBlb3BsZSB3b3JraW5nIHRvZ2V0aGVyCmFu ZCBhZ3JlZWluZyBoZXJlIHJpZ2h0PwoKREssIGNvbW1lbnRzPwoKVGFydW4sIGRvIHlvdSBoYXZl IHBsYW5zIHRvIG1ha2UgdGhpcyBkdW1wIHdpdGhvdXQgLS1kZXZpY2UKb3B0aW9uIHRvIHByaW50 IGFsbCBvZiBhdmFpbGFibGUgZHBjZCBsaWtlIG15IG9sZCBzZXJpZXMgd2FzCmRvaW5nPwoKPiAt LS0KPiAgdG9vbHMvZHBjZF9yZWcuYyB8IDg2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2NiBpbnNlcnRp b25zKCspLCAyMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvdG9vbHMvZHBjZF9yZWcu YyBiL3Rvb2xzL2RwY2RfcmVnLmMKPiBpbmRleCBkNTc3YWE1NS4uMjc2MTE2OGQgMTAwNjQ0Cj4g LS0tIGEvdG9vbHMvZHBjZF9yZWcuYwo+ICsrKyBiL3Rvb2xzL2RwY2RfcmVnLmMKPiBAQCAtNDEs MTkgKzQxLDUwIEBACj4gIAo+ICBjb25zdCBjaGFyIGF1eF9kZXZbXSA9ICIvZGV2L2RybV9kcF9h dXgiOwo+ICAKPiArc3RydWN0IGRwY2RfYmxvY2sgewo+ICsJLyogRFBDRCBkdW1wIHN0YXJ0IGFk ZHJlc3MuICovCj4gKwl1aW50MzJfdCBvZmZzZXQ7Cj4gKwkvKiBEUENEIG51bWJlciBvZiBieXRl cyB0byByZWFkLiBJZiB1bnNldCwgZGVmYXVsdHMgdG8gMS4gKi8KPiArCXNpemVfdCBjb3VudDsK PiArfTsKPiArCj4gIHN0cnVjdCBkcGNkX2RhdGEgewo+ICAJaW50IGRldmlkOwo+ICAJaW50IGZp bGVfb3A7Cj4gLQl1aW50MzJfdCBvZmZzZXQ7Cj4gKwlzdHJ1Y3QgZHBjZF9ibG9jayBydzsKPiAg CWVudW0gY29tbWFuZCB7Cj4gLQkJSU5WQUxJRCA9IC0xLAo+IC0JCVJFQUQgPSAyLAo+ICsJCURV TVAsCj4gKwkJUkVBRCwKPiAgCQlXUklURSwKPiAgCX0gY21kOwo+IC0Jc2l6ZV90IGNvdW50Owo+ ICAJdWludDhfdCB2YWw7Cj4gIH07Cj4gIAo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRwY2RfYmxv Y2sgZHVtcF9saXN0W10gPSB7Cj4gKwkvKiBEUF9EUENEX1JFViAqLwo+ICsJeyAub2Zmc2V0ID0g MCwgLmNvdW50ID0gMTUgfSwKPiArCS8qIERQX1BTUl9TVVBQT1JUIHRvIERQX1BTUl9DQVBTKi8K PiArCXsgLm9mZnNldCA9ICAweDcwLCAuY291bnQgPSAyIH0sCj4gKwkvKiBEUF9ET1dOU1RSRUFN X1BPUlRfMCAqLwo+ICsJeyAub2Zmc2V0ID0gIDB4ODAsIC5jb3VudCA9IDE2IH0sCj4gKwkvKiBE UF9MSU5LX0JXX1NFVCB0byBEUF9FRFBfQ09ORklHVVJBVElPTl9TRVQgKi8KPiArCXsgLm9mZnNl dCA9IDB4MTAwLCAuY291bnQgPSAxMSB9LAo+ICsJLyogRFBfU0lOS19DT1VOVCB0byBEUF9BREpV U1RfUkVRVUVTVF9MQU5FMl8zICovCj4gKwl7IC5vZmZzZXQgPSAweDIwMCwgLmNvdW50ID0gOCB9 LAo+ICsJLyogRFBfU0VUX1BPV0VSICovCj4gKwl7IC5vZmZzZXQgPSAweDYwMCB9LAo+ICsJLyog RFBfRURQX0RQQ0RfUkVWICovCj4gKwl7IC5vZmZzZXQgPSAgMHg3MDAgfSwKPiArCS8qIERQX0VE UF9HRU5FUkFMX0NBUF8xIHRvIERQX0VEUF9HRU5FUkFMX0NBUF8zICovCj4gKwl7IC5vZmZzZXQg PSAweDcwMSwgLmNvdW50ID0gNCB9LAo+ICsJLyogRFBfRURQX0RJU1BMQVlfQ09OVFJPTF9SRUdJ U1RFUiB0byBEUF9FRFBfQkFDS0xJR0hUX0ZSRVFfQ0FQX01BWF9MU0IgKi8KPiArCXsgLm9mZnNl dCA9IDB4NzIwLCAuY291bnQgPSAxNn0sCj4gKwkvKiBEUF9FRFBfREJDX01JTklNVU1fQlJJR0hU TkVTU19TRVQgdG8gRFBfRURQX0RCQ19NQVhJTVVNX0JSSUdIVE5FU1NfU0VUICovCj4gKwl7IC5v ZmZzZXQgPSAgMHg3MzIsIC5jb3VudCA9IDIgfSwKPiArCS8qIERQX1BTUl9TVEFUVVMgdG8gRFBf UFNSX1NUQVRVUyAqLwo+ICsJeyAub2Zmc2V0ID0gMHgyMDA4LCAuY291bnQgPSAxIH0sCj4gK307 Cj4gKwo+ICBzdGF0aWMgdm9pZCBwcmludF91c2FnZSh2b2lkKQo+ICB7Cj4gIAlwcmludGYoIlVz YWdlOiBkcGNkX3JlZyBbT1BUSU9OIC4uLl0gQ09NTUFORFxuXG4iKTsKPiBAQCAtMTAzLDcgKzEz NCw3IEBAIHN0YXRpYyBpbnQgcGFyc2Vfb3B0cyhzdHJ1Y3QgZHBjZF9kYXRhICpkcGNkLCBpbnQg YXJnYywgY2hhciAqKmFyZ3YpCj4gIAkJCQlwcmludF91c2FnZSgpOwo+ICAJCQkJcmV0dXJuIEVY SVRfRkFJTFVSRTsKPiAgCQkJfQo+IC0JCQlkcGNkLT5jb3VudCA9IHRlbXA7Cj4gKwkJCWRwY2Qt PnJ3LmNvdW50ID0gdGVtcDsKPiAgCQkJYnJlYWs7Cj4gIAkJY2FzZSAnZCc6Cj4gIAkJCXRlbXAg PSBzdHJ0b2wob3B0YXJnLCAmZW5kcHRyLCAxMCk7Cj4gQEAgLTEzMSw3ICsxNjIsNyBAQCBzdGF0 aWMgaW50IHBhcnNlX29wdHMoc3RydWN0IGRwY2RfZGF0YSAqZHBjZCwgaW50IGFyZ2MsIGNoYXIg Kiphcmd2KQo+ICAJCQkJcHJpbnRfdXNhZ2UoKTsKPiAgCQkJCXJldHVybiBFUkFOR0U7Cj4gIAkJ CX0KPiAtCQkJZHBjZC0+b2Zmc2V0ID0gdGVtcDsKPiArCQkJZHBjZC0+cncub2Zmc2V0ID0gdGVt cDsKPiAgCQkJYnJlYWs7Cj4gIAkJY2FzZSAndic6Cj4gIAkJCXZmbGFnID0gJ3YnOwo+IEBAIC0x NDcsMTYgKzE3OCwxNSBAQCBzdGF0aWMgaW50IHBhcnNlX29wdHMoc3RydWN0IGRwY2RfZGF0YSAq ZHBjZCwgaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ICAJCS8qIENvbW1hbmQgcGFyc2luZyAqLwo+ ICAJCWNhc2UgMToKPiAgCQkJaWYgKHN0cmNtcChvcHRhcmcsICJyZWFkIikgPT0gMCkgewo+IC0J CQkJdGVtcCA9IFJFQUQ7Cj4gKwkJCQlkcGNkLT5jbWQgPSBSRUFEOwo+ICAJCQl9IGVsc2UgaWYg KHN0cmNtcChvcHRhcmcsICJ3cml0ZSIpID09IDApIHsKPiAtCQkJCXRlbXAgPSBXUklURTsKPiAr CQkJCWRwY2QtPmNtZCA9IFdSSVRFOwo+ICAJCQkJZHBjZC0+ZmlsZV9vcCA9IE9fV1JPTkxZOwo+ IC0JCQl9IGVsc2Ugewo+ICsJCQl9IGVsc2UgaWYgKHN0cmNtcChvcHRhcmcsICJkdW1wIikgIT0g MCkgewo+ICAJCQkJZnByaW50ZihzdGRlcnIsICJVbnJlY29nbml6ZWQgY29tbWFuZFxuIik7Cj4g IAkJCQlwcmludF91c2FnZSgpOwo+ICAJCQkJcmV0dXJuIEVYSVRfRkFJTFVSRTsKPiAgCQkJfQo+ IC0JCQlkcGNkLT5jbWQgPSB0ZW1wOwo+ICAJCQlicmVhazsKPiAgCQljYXNlICc6JzoKPiAgCQkJ ZnByaW50ZihzdGRlcnIsICJPcHRpb24gLSVjIHJlcXVpcmVzIGFuIGFyZ3VtZW50XG4iLAo+IEBA IC0xNzAsNyArMjAwLDcgQEAgc3RhdGljIGludCBwYXJzZV9vcHRzKHN0cnVjdCBkcGNkX2RhdGEg KmRwY2QsIGludCBhcmdjLCBjaGFyICoqYXJndikKPiAgCQl9Cj4gIAl9Cj4gIAo+IC0JaWYgKChk cGNkLT5jb3VudCArIGRwY2QtPm9mZnNldCkgPiAoTUFYX0RQX09GRlNFVCArIDEpKSB7Cj4gKwlp ZiAoKGRwY2QtPnJ3LmNvdW50ICsgZHBjZC0+cncub2Zmc2V0KSA+IChNQVhfRFBfT0ZGU0VUICsg MSkpIHsKPiAgCQlmcHJpbnRmKHN0ZGVyciwgIk91dCBvZiBib3VuZHMuIENvdW50ICsgT2Zmc2V0 IDw9IDB4MTAwMDAwXG4iKTsKPiAgCQlyZXR1cm4gRVJBTkdFOwo+ICAJfQo+IEBAIC0yMDcsNyAr MjM3LDcgQEAgc3RhdGljIGludCBkcGNkX3JlYWQoaW50IGZkLCB1aW50MzJfdCBvZmZzZXQsIHNp emVfdCBjb3VudCkKPiAgCQlyZXQgPSBFWElUX0ZBSUxVUkU7Cj4gIAl9Cj4gIAo+IC0JcHJpbnRm KCIweCUwMng6ICIsIG9mZnNldCk7Cj4gKwlwcmludGYoIjB4JTA0eDogIiwgb2Zmc2V0KTsKPiAg CWZvciAoaSA9IDA7IGkgPCBwcmV0OyBpKyspCj4gIAkJcHJpbnRmKCIgJTAyeCIsICooYnVmICsg aSkpOwo+ICAJcHJpbnRmKCJcbiIpOwo+IEBAIC0yMzMsNiArMjYzLDIzIEBAIHN0YXRpYyBpbnQg ZHBjZF93cml0ZShpbnQgZmQsIHVpbnQzMl90IG9mZnNldCwgdWludDhfdCB2YWwpCj4gIAlyZXR1 cm4gcmV0Owo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGRwY2RfZHVtcChpbnQgZmQpCj4gK3sKPiAr CXNpemVfdCBjb3VudDsKPiArCWludCByZXQsIGk7Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IHNp emVvZihkdW1wX2xpc3QpIC8gc2l6ZW9mKGR1bXBfbGlzdFswXSk7IGkrKykgewo+ICsJCWNvdW50 ID0gZHVtcF9saXN0W2ldLmNvdW50ID8gZHVtcF9saXN0W2ldLmNvdW50OiAxOwo+ICsJCXJldCA9 IGRwY2RfcmVhZChmZCwgZHVtcF9saXN0W2ldLm9mZnNldCwgY291bnQpOwo+ICsJCWlmIChyZXQg IT0gRVhJVF9TVUNDRVNTKSB7Cj4gKwkJCWZwcmludGYoc3RkZXJyLCAiRHVtcCBmYWlsZWQgd2hp bGUgcmVhZGluZyAlMDR4XG4iLAo+ICsJCQkJIGR1bXBfbGlzdFtpXS5vZmZzZXQpOwo+ICsJCQly ZXR1cm4gcmV0Owo+ICsJCX0KPiArCX0KPiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gIGludCBt YWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiAgewo+ICAJY2hhciBkZXZfbmFtZVsyMF07Cj4g QEAgLTI0MSw5ICsyODgsOSBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCj4gIAlz dHJ1Y3QgZHBjZF9kYXRhIGRwY2QgPSB7Cj4gIAkJLmRldmlkID0gMCwKPiAgCQkuZmlsZV9vcCA9 IE9fUkRPTkxZLAo+IC0JCS5vZmZzZXQgPSAweDAsCj4gLQkJLmNtZCA9IElOVkFMSUQsCj4gLQkJ LmNvdW50ID0gMSwKPiArCQkucncub2Zmc2V0ID0gMHgwLAo+ICsJCS5ydy5jb3VudCA9IDEsCj4g KwkJLmNtZCA9IERVTVAsCj4gIAl9Owo+ICAKPiAgCXJldCA9IHBhcnNlX29wdHMoJmRwY2QsIGFy Z2MsIGFyZ3YpOwo+IEBAIC0yNjIsMTUgKzMwOSwxNCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hh ciAqKmFyZ3YpCj4gIAo+ICAJc3dpdGNoIChkcGNkLmNtZCkgewo+ICAJY2FzZSBSRUFEOgo+IC0J CXJldCA9IGRwY2RfcmVhZChmZCwgZHBjZC5vZmZzZXQsIGRwY2QuY291bnQpOwo+ICsJCXJldCA9 IGRwY2RfcmVhZChmZCwgZHBjZC5ydy5vZmZzZXQsIGRwY2QucncuY291bnQpOwo+ICAJCWJyZWFr Owo+ICAJY2FzZSBXUklURToKPiAtCQlyZXQgPSBkcGNkX3dyaXRlKGZkLCBkcGNkLm9mZnNldCwg ZHBjZC52YWwpOwo+ICsJCXJldCA9IGRwY2Rfd3JpdGUoZmQsIGRwY2Qucncub2Zmc2V0LCBkcGNk LnZhbCk7Cj4gIAkJYnJlYWs7Cj4gKwljYXNlIERVTVA6Cj4gIAlkZWZhdWx0Ogo+IC0JCWZwcmlu dGYoc3RkZXJyLCAiUGxlYXNlIHNwZWNpZnkgYSBjb21tYW5kOiByZWFkL3dyaXRlLlxuIik7Cj4g LQkJcHJpbnRfdXNhZ2UoKTsKPiAtCQlyZXQgPSBFWElUX0ZBSUxVUkU7Cj4gKwkJcmV0ID0gZHBj ZF9kdW1wKGZkKTsKPiAgCQlicmVhazsKPiAgCX0KPiAgCj4gLS0gCj4gMi4xNC4xCj4gCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGlu ZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=