From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42C046E087 for ; Thu, 18 Oct 2018 17:59:24 +0000 (UTC) Date: Thu, 18 Oct 2018 13:30:03 +0000 From: Tarun Vyas Message-ID: <20181018133003.GA15363@otc-arch-ivb-06> References: <20181010064418.2711-1-tarun.vyas@intel.com> <20181017002359.GN3694@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181017002359.GN3694@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] tools/dpcd_reg: Introduce dump as the default operation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Vivi Cc: igt-dev@lists.freedesktop.org, dhinakaran.pandiyan@intel.com List-ID: T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMDU6MjM6NTlQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFR1ZSwgT2N0IDA5LCAyMDE4IGF0IDExOjQ0OjE4UE0gLTA3MDAsIFRhcnVuIFZ5 YXMgd3JvdGU6Cj4gPiBGcm9tOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+ Cj4gPiAKPiA+IEZvciBub3cgdGhpcyBvbmx5IGltcG9ydHMgdGhlIHJlZ2lzdGVycyB0aGF0IHdl cmUgdXNlZCBvbgo+ID4gaTkxNSdzIGRlYnVnZnMgZHBjZCBkdW1wLiBMYXRlciB0aGlzIGNvdWxk IGJlIGV4dGVuZGVkLgo+ID4gCj4gPiBXaXRoIHRoaXMsIHdlIHNob3VsZCBiZSBhYmxlIHRvIGtp bGwgaTkxNV9kcGNkIGZyb20gdGhlCj4gPiBrZXJuZWwgZGVidWdmcyBhbmQgcmVseSBzb2xlbHkg b24gZHBjZF9yZWcgZm9yIGRwY2QgZHVtcHMuCj4gPiAKPiA+IENjOiBEaGluYWthcmFuIFBhbmRp eWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFJv ZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFRh cnVuIFZ5YXMgPHRhcnVuLnZ5YXNAaW50ZWwuY29tPgo+IAo+IFRoaXMgbG9va3MgZ29vZCB0byBt ZSBhbmQgSSBiZWxpZXZlIEkgY291bGQganVzdAo+IGdvIHRoZXJlIGFuZCBtZXJnZSBzaW5jZSB3 ZSBoYXZlIDIgcGVvcGxlIHdvcmtpbmcgdG9nZXRoZXIKPiBhbmQgYWdyZWVpbmcgaGVyZSByaWdo dD8KPiAKPiBESywgY29tbWVudHM/Cj4gCj4gVGFydW4sIGRvIHlvdSBoYXZlIHBsYW5zIHRvIG1h a2UgdGhpcyBkdW1wIHdpdGhvdXQgLS1kZXZpY2UKPiBvcHRpb24gdG8gcHJpbnQgYWxsIG9mIGF2 YWlsYWJsZSBkcGNkIGxpa2UgbXkgb2xkIHNlcmllcyB3YXMKPiBkb2luZz8KPgpUaGFua3MgUm9k cmlnby4gREsgYW5kIEkgZGlzY3Vzc2VkIGR1bXBpbmcgZHBjZHMgZm9yIGFsbCB0aGUgZGV2aWNl cywgYnV0IHdlIHdlcmVuJ3Qgc3VyZSBpZiB3ZSB3YW50IHRvIG9wZW4gZXZlcnkgZGV2aWNlIHRo YXQgbWF5IG9yIG1heSBub3QgYmUgY29ubmVjdGVkIGFuZCBoZW5jZSB0aW1lb3V0IG9uIGEgcmVh ZC4gU28sIGJ5IGRlZmF1bHQgd2UgZHVtcCBkZXZpY2UgMCwgZXZlbiBpZiB0aGUgdXNlciBkb2Vz bnQgc3BlY2lmaWVzIGFueXRoaW5nLiBGb3Igb3RoZXIgZGV2aWNlcyB0aGV5IGNhbiBzcGVjaWZ5 IHRoZSBkZXZpY2UgaWRzLgo+ID4gLS0tCj4gPiAgdG9vbHMvZHBjZF9yZWcuYyB8IDg2ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDY2IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvdG9vbHMvZHBjZF9yZWcuYyBiL3Rvb2xzL2RwY2RfcmVnLmMKPiA+IGlu ZGV4IGQ1NzdhYTU1Li4yNzYxMTY4ZCAxMDA2NDQKPiA+IC0tLSBhL3Rvb2xzL2RwY2RfcmVnLmMK PiA+ICsrKyBiL3Rvb2xzL2RwY2RfcmVnLmMKPiA+IEBAIC00MSwxOSArNDEsNTAgQEAKPiA+ICAK PiA+ICBjb25zdCBjaGFyIGF1eF9kZXZbXSA9ICIvZGV2L2RybV9kcF9hdXgiOwo+ID4gIAo+ID4g K3N0cnVjdCBkcGNkX2Jsb2NrIHsKPiA+ICsJLyogRFBDRCBkdW1wIHN0YXJ0IGFkZHJlc3MuICov Cj4gPiArCXVpbnQzMl90IG9mZnNldDsKPiA+ICsJLyogRFBDRCBudW1iZXIgb2YgYnl0ZXMgdG8g cmVhZC4gSWYgdW5zZXQsIGRlZmF1bHRzIHRvIDEuICovCj4gPiArCXNpemVfdCBjb3VudDsKPiA+ ICt9Owo+ID4gKwo+ID4gIHN0cnVjdCBkcGNkX2RhdGEgewo+ID4gIAlpbnQgZGV2aWQ7Cj4gPiAg CWludCBmaWxlX29wOwo+ID4gLQl1aW50MzJfdCBvZmZzZXQ7Cj4gPiArCXN0cnVjdCBkcGNkX2Js b2NrIHJ3Owo+ID4gIAllbnVtIGNvbW1hbmQgewo+ID4gLQkJSU5WQUxJRCA9IC0xLAo+ID4gLQkJ UkVBRCA9IDIsCj4gPiArCQlEVU1QLAo+ID4gKwkJUkVBRCwKPiA+ICAJCVdSSVRFLAo+ID4gIAl9 IGNtZDsKPiA+IC0Jc2l6ZV90IGNvdW50Owo+ID4gIAl1aW50OF90IHZhbDsKPiA+ICB9Owo+ID4g IAo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHBjZF9ibG9jayBkdW1wX2xpc3RbXSA9IHsKPiA+ ICsJLyogRFBfRFBDRF9SRVYgKi8KPiA+ICsJeyAub2Zmc2V0ID0gMCwgLmNvdW50ID0gMTUgfSwK PiA+ICsJLyogRFBfUFNSX1NVUFBPUlQgdG8gRFBfUFNSX0NBUFMqLwo+ID4gKwl7IC5vZmZzZXQg PSAgMHg3MCwgLmNvdW50ID0gMiB9LAo+ID4gKwkvKiBEUF9ET1dOU1RSRUFNX1BPUlRfMCAqLwo+ ID4gKwl7IC5vZmZzZXQgPSAgMHg4MCwgLmNvdW50ID0gMTYgfSwKPiA+ICsJLyogRFBfTElOS19C V19TRVQgdG8gRFBfRURQX0NPTkZJR1VSQVRJT05fU0VUICovCj4gPiArCXsgLm9mZnNldCA9IDB4 MTAwLCAuY291bnQgPSAxMSB9LAo+ID4gKwkvKiBEUF9TSU5LX0NPVU5UIHRvIERQX0FESlVTVF9S RVFVRVNUX0xBTkUyXzMgKi8KPiA+ICsJeyAub2Zmc2V0ID0gMHgyMDAsIC5jb3VudCA9IDggfSwK PiA+ICsJLyogRFBfU0VUX1BPV0VSICovCj4gPiArCXsgLm9mZnNldCA9IDB4NjAwIH0sCj4gPiAr CS8qIERQX0VEUF9EUENEX1JFViAqLwo+ID4gKwl7IC5vZmZzZXQgPSAgMHg3MDAgfSwKPiA+ICsJ LyogRFBfRURQX0dFTkVSQUxfQ0FQXzEgdG8gRFBfRURQX0dFTkVSQUxfQ0FQXzMgKi8KPiA+ICsJ eyAub2Zmc2V0ID0gMHg3MDEsIC5jb3VudCA9IDQgfSwKPiA+ICsJLyogRFBfRURQX0RJU1BMQVlf Q09OVFJPTF9SRUdJU1RFUiB0byBEUF9FRFBfQkFDS0xJR0hUX0ZSRVFfQ0FQX01BWF9MU0IgKi8K PiA+ICsJeyAub2Zmc2V0ID0gMHg3MjAsIC5jb3VudCA9IDE2fSwKPiA+ICsJLyogRFBfRURQX0RC Q19NSU5JTVVNX0JSSUdIVE5FU1NfU0VUIHRvIERQX0VEUF9EQkNfTUFYSU1VTV9CUklHSFRORVNT X1NFVCAqLwo+ID4gKwl7IC5vZmZzZXQgPSAgMHg3MzIsIC5jb3VudCA9IDIgfSwKPiA+ICsJLyog RFBfUFNSX1NUQVRVUyB0byBEUF9QU1JfU1RBVFVTICovCj4gPiArCXsgLm9mZnNldCA9IDB4MjAw OCwgLmNvdW50ID0gMSB9LAo+ID4gK307Cj4gPiArCj4gPiAgc3RhdGljIHZvaWQgcHJpbnRfdXNh Z2Uodm9pZCkKPiA+ICB7Cj4gPiAgCXByaW50ZigiVXNhZ2U6IGRwY2RfcmVnIFtPUFRJT04gLi4u XSBDT01NQU5EXG5cbiIpOwo+ID4gQEAgLTEwMyw3ICsxMzQsNyBAQCBzdGF0aWMgaW50IHBhcnNl X29wdHMoc3RydWN0IGRwY2RfZGF0YSAqZHBjZCwgaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ID4g IAkJCQlwcmludF91c2FnZSgpOwo+ID4gIAkJCQlyZXR1cm4gRVhJVF9GQUlMVVJFOwo+ID4gIAkJ CX0KPiA+IC0JCQlkcGNkLT5jb3VudCA9IHRlbXA7Cj4gPiArCQkJZHBjZC0+cncuY291bnQgPSB0 ZW1wOwo+ID4gIAkJCWJyZWFrOwo+ID4gIAkJY2FzZSAnZCc6Cj4gPiAgCQkJdGVtcCA9IHN0cnRv bChvcHRhcmcsICZlbmRwdHIsIDEwKTsKPiA+IEBAIC0xMzEsNyArMTYyLDcgQEAgc3RhdGljIGlu dCBwYXJzZV9vcHRzKHN0cnVjdCBkcGNkX2RhdGEgKmRwY2QsIGludCBhcmdjLCBjaGFyICoqYXJn dikKPiA+ICAJCQkJcHJpbnRfdXNhZ2UoKTsKPiA+ICAJCQkJcmV0dXJuIEVSQU5HRTsKPiA+ICAJ CQl9Cj4gPiAtCQkJZHBjZC0+b2Zmc2V0ID0gdGVtcDsKPiA+ICsJCQlkcGNkLT5ydy5vZmZzZXQg PSB0ZW1wOwo+ID4gIAkJCWJyZWFrOwo+ID4gIAkJY2FzZSAndic6Cj4gPiAgCQkJdmZsYWcgPSAn dic7Cj4gPiBAQCAtMTQ3LDE2ICsxNzgsMTUgQEAgc3RhdGljIGludCBwYXJzZV9vcHRzKHN0cnVj dCBkcGNkX2RhdGEgKmRwY2QsIGludCBhcmdjLCBjaGFyICoqYXJndikKPiA+ICAJCS8qIENvbW1h bmQgcGFyc2luZyAqLwo+ID4gIAkJY2FzZSAxOgo+ID4gIAkJCWlmIChzdHJjbXAob3B0YXJnLCAi cmVhZCIpID09IDApIHsKPiA+IC0JCQkJdGVtcCA9IFJFQUQ7Cj4gPiArCQkJCWRwY2QtPmNtZCA9 IFJFQUQ7Cj4gPiAgCQkJfSBlbHNlIGlmIChzdHJjbXAob3B0YXJnLCAid3JpdGUiKSA9PSAwKSB7 Cj4gPiAtCQkJCXRlbXAgPSBXUklURTsKPiA+ICsJCQkJZHBjZC0+Y21kID0gV1JJVEU7Cj4gPiAg CQkJCWRwY2QtPmZpbGVfb3AgPSBPX1dST05MWTsKPiA+IC0JCQl9IGVsc2Ugewo+ID4gKwkJCX0g ZWxzZSBpZiAoc3RyY21wKG9wdGFyZywgImR1bXAiKSAhPSAwKSB7Cj4gPiAgCQkJCWZwcmludGYo c3RkZXJyLCAiVW5yZWNvZ25pemVkIGNvbW1hbmRcbiIpOwo+ID4gIAkJCQlwcmludF91c2FnZSgp Owo+ID4gIAkJCQlyZXR1cm4gRVhJVF9GQUlMVVJFOwo+ID4gIAkJCX0KPiA+IC0JCQlkcGNkLT5j bWQgPSB0ZW1wOwo+ID4gIAkJCWJyZWFrOwo+ID4gIAkJY2FzZSAnOic6Cj4gPiAgCQkJZnByaW50 ZihzdGRlcnIsICJPcHRpb24gLSVjIHJlcXVpcmVzIGFuIGFyZ3VtZW50XG4iLAo+ID4gQEAgLTE3 MCw3ICsyMDAsNyBAQCBzdGF0aWMgaW50IHBhcnNlX29wdHMoc3RydWN0IGRwY2RfZGF0YSAqZHBj ZCwgaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ID4gIAkJfQo+ID4gIAl9Cj4gPiAgCj4gPiAtCWlm ICgoZHBjZC0+Y291bnQgKyBkcGNkLT5vZmZzZXQpID4gKE1BWF9EUF9PRkZTRVQgKyAxKSkgewo+ ID4gKwlpZiAoKGRwY2QtPnJ3LmNvdW50ICsgZHBjZC0+cncub2Zmc2V0KSA+IChNQVhfRFBfT0ZG U0VUICsgMSkpIHsKPiA+ICAJCWZwcmludGYoc3RkZXJyLCAiT3V0IG9mIGJvdW5kcy4gQ291bnQg KyBPZmZzZXQgPD0gMHgxMDAwMDBcbiIpOwo+ID4gIAkJcmV0dXJuIEVSQU5HRTsKPiA+ICAJfQo+ ID4gQEAgLTIwNyw3ICsyMzcsNyBAQCBzdGF0aWMgaW50IGRwY2RfcmVhZChpbnQgZmQsIHVpbnQz Ml90IG9mZnNldCwgc2l6ZV90IGNvdW50KQo+ID4gIAkJcmV0ID0gRVhJVF9GQUlMVVJFOwo+ID4g IAl9Cj4gPiAgCj4gPiAtCXByaW50ZigiMHglMDJ4OiAiLCBvZmZzZXQpOwo+ID4gKwlwcmludGYo IjB4JTA0eDogIiwgb2Zmc2V0KTsKPiA+ICAJZm9yIChpID0gMDsgaSA8IHByZXQ7IGkrKykKPiA+ ICAJCXByaW50ZigiICUwMngiLCAqKGJ1ZiArIGkpKTsKPiA+ICAJcHJpbnRmKCJcbiIpOwo+ID4g QEAgLTIzMyw2ICsyNjMsMjMgQEAgc3RhdGljIGludCBkcGNkX3dyaXRlKGludCBmZCwgdWludDMy X3Qgb2Zmc2V0LCB1aW50OF90IHZhbCkKPiA+ICAJcmV0dXJuIHJldDsKPiA+ICB9Cj4gPiAgCj4g PiArc3RhdGljIGludCBkcGNkX2R1bXAoaW50IGZkKQo+ID4gK3sKPiA+ICsJc2l6ZV90IGNvdW50 Owo+ID4gKwlpbnQgcmV0LCBpOwo+ID4gKwo+ID4gKwlmb3IgKGkgPSAwOyBpIDwgc2l6ZW9mKGR1 bXBfbGlzdCkgLyBzaXplb2YoZHVtcF9saXN0WzBdKTsgaSsrKSB7Cj4gPiArCQljb3VudCA9IGR1 bXBfbGlzdFtpXS5jb3VudCA/IGR1bXBfbGlzdFtpXS5jb3VudDogMTsKPiA+ICsJCXJldCA9IGRw Y2RfcmVhZChmZCwgZHVtcF9saXN0W2ldLm9mZnNldCwgY291bnQpOwo+ID4gKwkJaWYgKHJldCAh PSBFWElUX1NVQ0NFU1MpIHsKPiA+ICsJCQlmcHJpbnRmKHN0ZGVyciwgIkR1bXAgZmFpbGVkIHdo aWxlIHJlYWRpbmcgJTA0eFxuIiwKPiA+ICsJCQkJIGR1bXBfbGlzdFtpXS5vZmZzZXQpOwo+ID4g KwkJCXJldHVybiByZXQ7Cj4gPiArCQl9Cj4gPiArCX0KPiA+ICsJcmV0dXJuIHJldDsKPiA+ICt9 Cj4gPiArCj4gPiAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ID4gIHsKPiA+ICAJ Y2hhciBkZXZfbmFtZVsyMF07Cj4gPiBAQCAtMjQxLDkgKzI4OCw5IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyICoqYXJndikKPiA+ICAJc3RydWN0IGRwY2RfZGF0YSBkcGNkID0gewo+ID4gIAkJ LmRldmlkID0gMCwKPiA+ICAJCS5maWxlX29wID0gT19SRE9OTFksCj4gPiAtCQkub2Zmc2V0ID0g MHgwLAo+ID4gLQkJLmNtZCA9IElOVkFMSUQsCj4gPiAtCQkuY291bnQgPSAxLAo+ID4gKwkJLnJ3 Lm9mZnNldCA9IDB4MCwKPiA+ICsJCS5ydy5jb3VudCA9IDEsCj4gPiArCQkuY21kID0gRFVNUCwK PiA+ICAJfTsKPiA+ICAKPiA+ICAJcmV0ID0gcGFyc2Vfb3B0cygmZHBjZCwgYXJnYywgYXJndik7 Cj4gPiBAQCAtMjYyLDE1ICszMDksMTQgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2 KQo+ID4gIAo+ID4gIAlzd2l0Y2ggKGRwY2QuY21kKSB7Cj4gPiAgCWNhc2UgUkVBRDoKPiA+IC0J CXJldCA9IGRwY2RfcmVhZChmZCwgZHBjZC5vZmZzZXQsIGRwY2QuY291bnQpOwo+ID4gKwkJcmV0 ID0gZHBjZF9yZWFkKGZkLCBkcGNkLnJ3Lm9mZnNldCwgZHBjZC5ydy5jb3VudCk7Cj4gPiAgCQli cmVhazsKPiA+ICAJY2FzZSBXUklURToKPiA+IC0JCXJldCA9IGRwY2Rfd3JpdGUoZmQsIGRwY2Qu b2Zmc2V0LCBkcGNkLnZhbCk7Cj4gPiArCQlyZXQgPSBkcGNkX3dyaXRlKGZkLCBkcGNkLnJ3Lm9m ZnNldCwgZHBjZC52YWwpOwo+ID4gIAkJYnJlYWs7Cj4gPiArCWNhc2UgRFVNUDoKPiA+ICAJZGVm YXVsdDoKPiA+IC0JCWZwcmludGYoc3RkZXJyLCAiUGxlYXNlIHNwZWNpZnkgYSBjb21tYW5kOiBy ZWFkL3dyaXRlLlxuIik7Cj4gPiAtCQlwcmludF91c2FnZSgpOwo+ID4gLQkJcmV0ID0gRVhJVF9G QUlMVVJFOwo+ID4gKwkJcmV0ID0gZHBjZF9kdW1wKGZkKTsKPiA+ICAJCWJyZWFrOwo+ID4gIAl9 Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTQuMQo+ID4gCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaWd0LWRldgo=