Re: [igt-dev] [PATCH i-g-t v2] tests: Introduce i915 directory

Petri Latvala
2018-10-19T10:25:47Z

On Fri, Oct 19, 2018 at 11:12:29AM +0100, Chris Wilson wrote:
> Quoting Petri Latvala (2018-10-19 11:02:18)
> > On Fri, Oct 19, 2018 at 11:48:54AM +0300, Arkadiusz Hiler wrote:
> > > We can already move all the tests with distinct prefixes: gem_, gen3_
> > > and i915_.
> > >
> > > pm_ and drv_ tests will follow in batches, so we can do the
> > > adjustments in the reporting/filtering layer of the CI system.
> > >
> > > v2: Fix test-list.txt generation with meson
> > >
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Petri Latvala <petri.latvala@intel.com>
> > > Cc: Martin Peres <martin.peres@linux.intel.com>
> > > Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> >
> > Worth stating out loud why there's such a load of bovine excrement
> > needed for the autotools parts:
> >
> > Test binaries all need to be in the same directory. After installing
> > it's easy to achieve but we also support running stuff from the build
> > directory directly. Ergo, we can't just make the tests/i915 directory
> > self-contained.
>
> What are you talking about? Maybe explaining how amdgpu/ doesn't work,
> but we haven't given it any special treatment and you can run the
> compile binaries and it installs into the same targetdir as we haven't
> told it otherwise.

Yeah I wasn't quite clear on that one:

The test binary needs to be relative to the location of test-list.txt,
and for amdgpu the binary is amdgpu/amd_foobar. So to elaborate: The
reason is that we need to build the binaries into the tests directory
instead of tests/i915 or all tests will rename to i915/stuff@subtests
and 1) we avoid renaming tests when possible, to keep some resemblence
of test history and comparison capability 2) having / in the test name
is icky already with amdgpu. Quite soon we might be able to churn the
amdgpu tests to not have the /.

--
Petri Latvala