From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tools/intel_watermark: Recognize cnl+
Date: Wed, 24 Oct 2018 10:00:16 -0700 [thread overview]
Message-ID: <20181024170016.GA3942@intel.com> (raw)
In-Reply-To: <20181024162740.28425-1-ville.syrjala@linux.intel.com>
On Wed, Oct 24, 2018 at 07:27:40PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Pick the skl+ code path for cnl+. And since this tool has
> nothing to do with pch let's also replace the has_pch_split
> check with gen>=5 check.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tools/intel_watermark.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
> index 03da68b6ff69..3fd37441cba7 100644
> --- a/tools/intel_watermark.c
> +++ b/tools/intel_watermark.c
> @@ -1142,12 +1142,12 @@ int main(int argc, char *argv[])
> {
> devid = intel_get_pci_device()->device_id;
>
> - if (IS_GEN9(devid)) {
> + if (intel_gen(devid) >= 9) {
> skl_wm_dump();
> } else if (IS_VALLEYVIEW(devid) || IS_CHERRYVIEW(devid)) {
> display_base = 0x180000;
> vlv_wm_dump();
> - } else if (HAS_PCH_SPLIT(devid)) {
> + } else if (intel_gen(devid) >= 5) {
> ilk_wm_dump();
> } else if (IS_G4X(devid)) {
> g4x_wm_dump();
> --
> 2.18.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-24 17:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 16:27 [igt-dev] [PATCH i-g-t] tools/intel_watermark: Recognize cnl+ Ville Syrjala
2018-10-24 17:00 ` Rodrigo Vivi [this message]
2018-10-24 19:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-25 2:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024170016.GA3942@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox