public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/kmod: Unload snd_hdmi_lpe_audio
Date: Thu, 25 Oct 2018 12:32:50 +0200	[thread overview]
Message-ID: <20181025103250.GD21967@phenom.ffwll.local> (raw)
In-Reply-To: <20181025102146.24258-1-ville.syrjala@linux.intel.com>

On Thu, Oct 25, 2018 at 01:21:46PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Unload the snd_hdmi_lpe_audio module. Otherwise i915 can't be unloaded.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  lib/igt_kmod.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index b2f4f884b137..22c260210e3d 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -333,6 +333,17 @@ igt_i915_driver_unload(void)
>  		}
>  	}
>  
> +	if (igt_kmod_is_loaded("snd_hdmi_lpe_audio")) {
> +		igt_terminate_process(SIGTERM, "alsactl");
> +
> +		if (igt_kmod_unload("snd_hdmi_lpe_audio", 0)) {
> +			igt_warn("Could not unload snd_hdmi_lpe_audio\n");
> +			igt_kmod_list_loaded();
> +			igt_lsof("/dev/snd");
> +			return IGT_EXIT_FAILURE;
> +		}
> +	}
> +
>  	/* gen5 */
>  	if (igt_kmod_is_loaded("intel_ips"))
>  		igt_kmod_unload("intel_ips", 0);
> -- 
> 2.18.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-10-25 10:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 10:21 [igt-dev] [PATCH i-g-t] lib/kmod: Unload snd_hdmi_lpe_audio Ville Syrjala
2018-10-25 10:32 ` Daniel Vetter [this message]
2018-10-26 14:57   ` Ville Syrjälä
2018-10-25 11:19 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-25 15:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025103250.GD21967@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox